From nobody Fri Apr 10 22:21:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F0FC25B0E for ; Thu, 18 Aug 2022 21:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346838AbiHRVLo (ORCPT ); Thu, 18 Aug 2022 17:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346692AbiHRVKM (ORCPT ); Thu, 18 Aug 2022 17:10:12 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D844D86F5 for ; Thu, 18 Aug 2022 14:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=k1; bh=m4VbsoCrgcEsS3vm6DJoOd+gg8S rpIZvIbWf4GW7DUk=; b=aN64llEKE8D3b5qIWAWyIeQxsLa9QyUcKwc30ZVi+Rp Z8QBUKvhnwJrzL7LWkgryrEVj4kq4PWFq3lByvHeAQNZHa56X1IhM+OiILgIO9od l9OCruSl81iozXmHM3xz+3W4E3nXk7y5qsRpmwJV7n8Rndg1SjM6Bnhmu+Q+tzN4 = Received: (qmail 3962269 invoked from network); 18 Aug 2022 23:01:41 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 18 Aug 2022 23:01:41 +0200 X-UD-Smtp-Session: l3s3148p1@x8DBSYrms+8ucref From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: Wolfram Sang , Luis de Bethencourt , Salah Triki Subject: [PATCH] befs: move from strlcpy with unused retval to strscpy Date: Thu, 18 Aug 2022 23:01:40 +0200 Message-Id: <20220818210140.7843-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=3DwgfRnXz0W3D37d01q3JFkr_i_uTL=3DV6A6= G1oUZcprmknw@mail.gmail.com/ Signed-off-by: Wolfram Sang --- fs/befs/btree.c | 2 +- fs/befs/linuxvfs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/befs/btree.c b/fs/befs/btree.c index 1b7e0f7128d6..53b36aa29978 100644 --- a/fs/befs/btree.c +++ b/fs/befs/btree.c @@ -500,7 +500,7 @@ befs_btree_read(struct super_block *sb, const befs_data= _stream *ds, goto error_alloc; } =20 - strlcpy(keybuf, keystart, keylen + 1); + strscpy(keybuf, keystart, keylen + 1); *value =3D fs64_to_cpu(sb, valarray[cur_key]); *keysize =3D keylen; =20 diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 32749fcee090..eee9237386e2 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c @@ -374,7 +374,7 @@ static struct inode *befs_iget(struct super_block *sb, = unsigned long ino) if (S_ISLNK(inode->i_mode) && !(befs_ino->i_flags & BEFS_LONG_SYMLINK)){ inode->i_size =3D 0; inode->i_blocks =3D befs_sb->block_size / VFS_BLOCK_SIZE; - strlcpy(befs_ino->i_data.symlink, raw_inode->data.symlink, + strscpy(befs_ino->i_data.symlink, raw_inode->data.symlink, BEFS_SYMLINK_LEN); } else { int num_blks; --=20 2.35.1