From nobody Fri Apr 10 23:23:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F3AC28B2B for ; Thu, 18 Aug 2022 03:51:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242797AbiHRDvQ (ORCPT ); Wed, 17 Aug 2022 23:51:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240247AbiHRDvN (ORCPT ); Wed, 17 Aug 2022 23:51:13 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1936D60FF for ; Wed, 17 Aug 2022 20:51:12 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id p128so368990oif.9 for ; Wed, 17 Aug 2022 20:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=z/kt4xsiqT5uh1tSKfd39tJzduEkjiNNtsPz4ODYScQ=; b=hUsX8rTlrvTeQvHroIs2XSAw7rftVr3j4T1DMDpJAOhE75zyhypDjS8nZn2dJ1PAtV PyyiE9zWnK4AdZgnzKyYo5SaIU4lzFOnMQhymG4K/BunYWpJmPqfh2ayCKiRVtyMXUSa qWJ/8Kn31W0eviW63LQ0bNlJd7r6XSayEsgXrpJrTkzbtn676A0CSZlXget+ct41QgUJ 6pnc/4akLOnoonrqqS59n0HN3I+svs8h75IiIISyBFN+rKSSBroei3IQKCB+ACuprsL1 ysf9YPNasyRTNxgNyKrZrBFrU7rRsKPFfAWfn2JKWrr+VV6hdcFI5VeL8KpweMamYNQs J9Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=z/kt4xsiqT5uh1tSKfd39tJzduEkjiNNtsPz4ODYScQ=; b=Ihnlp6tXHfR0DimR60OumVpiaDVoBefXLur0U5vkJFzbSxEq4mY3blsh9j92FNkg32 8z/Stu1yGvagFEzWq3QZkEKOzRbxBiswEf+jNRzrX58wp2aayU2Hi7qZIUVLrtR6N82D qz1AaXLZJBM3r+Jv7FzNfG74ANvP8v1qQdZ3xW3csuiEjha9DSAippCSoHXeRb7WyXnD InkuJ2RvlmdGI9Z24p6bwt8ziS/HxwyDMYANUuJ6rHWVT8sRCemu0i4BHBQovuOgKBEH zgHsXmt+8eSwNtLyVHMTvf1A6h0+2gQEFLP3YBtYu1wQ+syDuESP1eGRrLFwYFaDrRGP Wmdw== X-Gm-Message-State: ACgBeo0VqU1zl+C3FM+iFpFZ0DJUxTxzhTj+g14ItQulZUVP8AyPpWGa 3z8JGhUG7dnmHk6LbEuJX3af0A== X-Google-Smtp-Source: AA6agR5nK0pO97s1k3xUg01xcKqTwc3MTVG/hu97TQDzw0VbKl4p+cqjklTjMetgLlKH5V34+pGaOA== X-Received: by 2002:a05:6808:200f:b0:343:470a:cd22 with SMTP id q15-20020a056808200f00b00343470acd22mr2776801oiw.52.1660794671410; Wed, 17 Aug 2022 20:51:11 -0700 (PDT) Received: from localhost (cpe-173-173-107-246.satx.res.rr.com. [173.173.107.246]) by smtp.gmail.com with ESMTPSA id b6-20020a9d5d06000000b0063695ad0cbesm142984oti.66.2022.08.17.20.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 20:51:10 -0700 (PDT) From: Steev Klimaszewski To: Steev Klimaszewski Cc: Amit Pundir , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Philipp Zabel , Srinivasa Rao Mandadapu , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] soundwire: qcom: remove unneeded check Date: Wed, 17 Aug 2022 22:51:05 -0500 Message-Id: <20220818035105.5510-1-steev@kali.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" commit 1fd0d85affe4d6 ("soundwire: qcom: Add flag for software clock gating= check")=20 added a flag for software clock gating check, however in commit 33ba01788889666 ("soundwire: qcom: Add support for controlling audio CGCR f= rom HLOS") the same check was added without the flag, so we would still end up failing the software clock gating check. Originally reported by Amit Pundir on DB845c, I also saw it on the Lenovo Yoga C630, right before the splat, we would see qcom-soundwire wcd934x-soundwire.6.auto: Failed to get audio_cgcr reset req= uired for soundwire-v1.6.0 however, SDM845 has a soundwire-v1.3.0 Since the flag was added in 1fd0d85affe, lets just remove this one. Fixes: 33ba01788889 ("soundwire: qcom: Add support for controlling audio CG= CR from HLOS") Signed-off-by: Steev Klimaszewski Reported-by: Amit Pundir --- drivers/soundwire/qcom.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 709a7c1e0704..b621f7fb866f 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1355,10 +1355,6 @@ static int qcom_swrm_probe(struct platform_device *p= dev) ctrl->bus.compute_params =3D &qcom_swrm_compute_params; ctrl->bus.clk_stop_timeout =3D 300; =20 - ctrl->audio_cgcr =3D devm_reset_control_get_exclusive(dev, "swr_audio_cgc= r"); - if (IS_ERR(ctrl->audio_cgcr)) - dev_err(dev, "Failed to get audio_cgcr reset required for soundwire-v1.6= .0\n"); - ret =3D qcom_swrm_get_port_config(ctrl); if (ret) goto err_clk; --=20 2.35.1