From nobody Mon Apr 13 12:01:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 762CCC32772 for ; Wed, 17 Aug 2022 21:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241875AbiHQVOI (ORCPT ); Wed, 17 Aug 2022 17:14:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241740AbiHQVOF (ORCPT ); Wed, 17 Aug 2022 17:14:05 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 594A42A438 for ; Wed, 17 Aug 2022 14:14:01 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-3359a55dcb6so32637427b3.21 for ; Wed, 17 Aug 2022 14:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc; bh=URg+UMQZgJAJZD19p4gwvvadtL6QiS5A6GMenmjwJgY=; b=SRObGBGBG2sRxe2+tGmXszzXIzti/OIGxkLLhYH/K9EzOKWGAOSbFZcnNiSbSrfEH1 IS03Ciz5Y5XLkip4EtQzvRPLpihmjrh/kzWkFvimmx1y/IMQfU8uz8sSVeXI70UajTdv VEPUBCb/EaS6GLIE9GpsLB+ouvqg5iovDF9cmXOrKm9tsHMfQ1Jfued6B9TLqONuxlcz 5jswcGo+LoYU8w3wK6e6vvrXw1U2Oher3+46zQDHkwPj5fzemLZ+5CSQF5b46ZC9+djo UXjXOpcwSjExip49HwmqLqdjoPKWC+gXaUHyhunxTTeeKEN9pJGOodbr+X2YitB8bnA2 k7EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc; bh=URg+UMQZgJAJZD19p4gwvvadtL6QiS5A6GMenmjwJgY=; b=aX/iIy/oJbsw4FOz5bR83T8ndU1L9AYrbZaF1aixgqJPyJs6v0FF1aexZAul1yCE2o xaXNELMZkhsRdrHav2hzBbBPuNBZ7wR/0t7DJZElBNkYgmedke6D2IzYjVg09kyBy398 EY5G+L3sI0CcHwKW7O1Wx88ORGoo4156uBa+SUISCpJOn/DoxsH+kGAzVuR3BSJDglVs SgoacjUNvcqBS3M51PafMltFgAKy/H2mC9ZiCt3NUKzH7e9OzRqdoqf+ihtlJ/ln0XE+ 0qe7kOM2W78qgDMOBxD7Sf9UGc43j61+JCIYJqlBTrNIMET3AyoeXVOszFt8cW1r0U9M xAcg== X-Gm-Message-State: ACgBeo2itMkIvCCbtAAyRXoCPAzDBhFC7Sey5m/pgzAFUHtzLJotnbeq yqayvnrLBoEWgI/PsBiie7D78fwe7/lAjNmiEwWL X-Google-Smtp-Source: AA6agR6WBtTNLco5wa8t9uk8XSJjuDXXNwRdbOpIyGssHp2EbU6D8jDQ4yBgt9G5ppX7ffVKK3xkGU+G4y+8VrFU7KYb X-Received: from ajr0.svl.corp.google.com ([2620:15c:2d4:203:2f41:f176:4bac:b729]) (user=axelrasmussen job=sendgmr) by 2002:a81:ad58:0:b0:329:5b1:106e with SMTP id l24-20020a81ad58000000b0032905b1106emr10097ywk.371.1660770840476; Wed, 17 Aug 2022 14:14:00 -0700 (PDT) Date: Wed, 17 Aug 2022 14:13:56 -0700 Message-Id: <20220817211356.273019-1-axelrasmussen@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog Subject: [PATCH] selftests/vm: fix inability to build any vm tests From: Axel Rasmussen To: Andrew Morton , Shuah Khan , Guillaume Tucker Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Axel Rasmussen Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When we stopped using KSFT_KHDR_INSTALL, a side effect is we also changed the value of `top_srcdir`. This can be seen by looking at the code removed by: 49de12ba06ef ("selftests: drop KSFT_KHDR_INSTALL make target"): (Note though that this commit didn't break this, technically the one before it did since that's the one that stopped KSFT_KHDR_INSTALL from being used, even though the code was still there.) Previously lib.mk reconfigured `top_srcdir` when KSFT_KHDR_INSTALL was being used. Now, that's no longer the case. As a result, the path to gup_test.h in vm/Makefile was wrong, and since it's a dependency of all of the vm binaries none of them could be built. Instead, we'd get an "error" like: make[1]: *** No rule to make target '/[...]/tools/testing/selftests/vm/= compaction_test', needed by 'all'. Stop. If we specify the path of gup_test.h relatively using selfdir instead, now it is found correctly, and things work again. Fixes: f2745dc0ba3d ("selftests: stop using KSFT_KHDR_INSTALL") Signed-off-by: Axel Rasmussen Reviewed-by: John Hubbard --- tools/testing/selftests/vm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/= vm/Makefile index d9fa6a9ea584..f2a12494f2d8 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 # Makefile for vm selftests =20 -LOCAL_HDRS +=3D $(selfdir)/vm/local_config.h $(top_srcdir)/mm/gup_test.h +LOCAL_HDRS +=3D $(selfdir)/vm/local_config.h $(selfdir)/../../../mm/gup_te= st.h =20 include local_config.mk =20 --=20 2.37.1.595.g718a3a8f04-goog