From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E831C25B08 for ; Wed, 17 Aug 2022 13:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239771AbiHQNOj (ORCPT ); Wed, 17 Aug 2022 09:14:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239583AbiHQNO1 (ORCPT ); Wed, 17 Aug 2022 09:14:27 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F5604BD01 for ; Wed, 17 Aug 2022 06:14:24 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id a9so18928259lfm.12 for ; Wed, 17 Aug 2022 06:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=ylRikkO/bjiVr6cfpMQukwsajH9gmB7MCgQxpA3FZjg=; b=PlW7Mtcl47MpdE/4X+zlMXjbRlUXpGWW9lYJlFzAkyhQ6HaAUQuNhxHKHBZATug0fV qWWX0jOXCVp+nAnrGjjF7KUBOemnJGrR02np5S78KK79cjImAtHquy9edBoPFqJ1zp5T sxPsNlena2Y/2n9nF2P6+V51h8teL+21UMhJNmrqGofHl8pDvNYByk7pnsQSIaPyKLr4 2LzUPkeLxCO/3TpJnod9YLGzhENtwtomzyI4wdvNDWiqh7rDVci2w1728KL/JHXN9d0k OOV1Hd63+mI08bZZDt1S+FdV6Dtz68N3ZL/czhDm4NXBFmrPYnbwWb0K5GgrPluFd5hl JFpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=ylRikkO/bjiVr6cfpMQukwsajH9gmB7MCgQxpA3FZjg=; b=DpEQmp/JFDkJv+7lSGAcoi0ihvhnqFUCj0BOaNy7uD/wZySy2QFxoSEVX2Ysp7900L 4vuhKBLwPpMP96Enu7XaGr4tl/N+X3DzCdQWw9YH/eOrc/BNHN+H0rKNqu1yox3UkpmZ tn+dVCIAe9n5Z9hF/cu9l1US906N5W4+BHfGf/W7li/2apJCm7M74fq27vUPX3w3fYa4 d2N/1Lp7q/kOLSMtqEOeCOfz+9gjkdJeG8TmOoGZNpH3GWqjS6nkuaM8i8egkOhve64k 6UJyIytqqPHZq4toKTZSmFKBR6FW0LM6lKlx5Ltp0iegmMok0FPUomafc7NxQ3uhm1vD P6QA== X-Gm-Message-State: ACgBeo3OfH+dFvkY/EzVB4yaMyLS28pi4lmMaSgvTqa1CpiNpPSRc7bC V+QWK6ASqJzsnJRJ9AQNQNwNmg== X-Google-Smtp-Source: AA6agR7hK/LtVDTNcW/FOB3ZBLh9ErM5S9vA8oOiKLvSKbz5Ptv+gx5OFqdfNPZpxNBEgxnzgv8Lag== X-Received: by 2002:a05:6512:4c7:b0:48b:29bb:8195 with SMTP id w7-20020a05651204c700b0048b29bb8195mr8347371lfq.386.1660742062364; Wed, 17 Aug 2022 06:14:22 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:21 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 01/12] dt-bindings: hwlock: qcom-hwspinlock: add support for MMIO on older SoCs Date: Wed, 17 Aug 2022 16:14:04 +0300 Message-Id: <20220817131415.714340-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Older Qualcomm SoCs have TCSR mutex registers with 0x80 stride, instead of 0x1000. Add dedicated compatibles for such case. Unfortunately the binding started using a generic "qcom,tcsr-mutex" compatible without specifying the SoC part, thus it looks now quite inconsistent. Signed-off-by: Krzysztof Kozlowski --- If anyone ever says "I want a generic compatible because I am sure all devices are compatible", that's one more argument they are wrong. :) --- .../bindings/hwlock/qcom-hwspinlock.yaml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml = b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml index 1c7149f7d171..de98b961fb38 100644 --- a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml +++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml @@ -15,9 +15,18 @@ description: =20 properties: compatible: - enum: - - qcom,sfpb-mutex - - qcom,tcsr-mutex + oneOf: + - enum: + - qcom,sfpb-mutex + - qcom,tcsr-mutex + - items: + - enum: + - qcom,apq8084-tcsr-mutex + - qcom,ipq6018-tcsr-mutex + - qcom,msm8226-tcsr-mutex + - qcom,msm8974-tcsr-mutex + - qcom,msm8994-tcsr-mutex + - const: qcom,tcsr-mutex =20 reg: maxItems: 1 --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464D4C28B2B for ; Wed, 17 Aug 2022 13:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239754AbiHQNOm (ORCPT ); Wed, 17 Aug 2022 09:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237015AbiHQNOb (ORCPT ); Wed, 17 Aug 2022 09:14:31 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81E974BD30 for ; Wed, 17 Aug 2022 06:14:25 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id y23so13489527ljh.12 for ; Wed, 17 Aug 2022 06:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=CEQ6kD7E3x3cGbQZ0xWqW+Ktcext0aENc2Q7rleIIpo=; b=ZLW1S4NiQU/zIX4dyxR1JbzzCb9w3pYh1ElEDkry2G49gQQwdoV4ZbBEqfMgLxvwk3 qn+U7LlGYMMHtOuupRnX8wo5BaXQZ/2ZwVjnVyzLnIEYucldFUClvsxpWRN+iETeLROc 3cDiMgCF/bt9aMWhEKVS/XdpDnVf3PlchWidgj0aheh6UxqdZNGDEthcLtIMhjOy+kIR e7b7pEC56l7+71GHun2fdcULFqQ1kKpR6UTQP+eE1SPSEp+UjB0ZTuCl8BMBLmHkGfIB B3kS5jZR+NQJvCcCVOQ1NLmZagOGE+A7fVI2sHna6YocLY8uTFyo+GSzeX70G6nxCuNx 2ZJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=CEQ6kD7E3x3cGbQZ0xWqW+Ktcext0aENc2Q7rleIIpo=; b=aEPREO1M9/Yb6CRreCdCpGg1a/aba4S0SQyTnHn4JVrkLmRxBS8QqCWJYF9tu0vjyL 3/DsN2sGFXepUkRMR+yaCDlu0xJovsAiv8Y0cr65hstYDrkBxkjD3qGTY1zdSDSq3eVJ xNt3fCsmiVXUYlatf9o17p43IJCPS5x35I9lHbqO3lQ9dC7EoM7uz/lOvEMtbFINP51/ mEQSRVOt2G21jiFrjYCA6MFrp9tfw7bWwdVlMwoD5jkwgOo4qwKBI2l8IqnFqxuY7ajW eCCBbQo0uFB6hrwo7JdF+mLbWHZV8MyyC+luCUP1bUBR13YmwbYjYJVFqAiobE7BSC70 QLwg== X-Gm-Message-State: ACgBeo0u1EVgMgCiH35ab0/HVLs8sMkfLiRHK+5amPe34XIZxqacvCID BPW+3UHN7qoABXfzdBfVf3HDcA== X-Google-Smtp-Source: AA6agR7KrrzN7b/lcEy++KQc/DJ9TjbfJCRkrrA6FmPSFUqMwZ0dAq5BtJWI5XRcsnwJW3AfxaUL6g== X-Received: by 2002:a05:651c:14e:b0:25f:dbf7:8636 with SMTP id c14-20020a05651c014e00b0025fdbf78636mr8007233ljd.51.1660742063840; Wed, 17 Aug 2022 06:14:23 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:23 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 02/12] dt-bindings: hwlock: qcom-hwspinlock: correct example indentation Date: Wed, 17 Aug 2022 16:14:05 +0300 Message-Id: <20220817131415.714340-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use some consistent indentation (4-space) for DTS example. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/hwlock/qcom-hwspinlock.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml = b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml index de98b961fb38..1a3adf75934b 100644 --- a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml +++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml @@ -43,9 +43,9 @@ additionalProperties: false =20 examples: - | - tcsr_mutex: hwlock@1f40000 { - compatible =3D "qcom,tcsr-mutex"; - reg =3D <0x01f40000 0x40000>; - #hwlock-cells =3D <1>; - }; + hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; + reg =3D <0x01f40000 0x40000>; + #hwlock-cells =3D <1>; + }; ... --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 143AFC25B08 for ; Wed, 17 Aug 2022 13:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbiHQNOr (ORCPT ); Wed, 17 Aug 2022 09:14:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239746AbiHQNOe (ORCPT ); Wed, 17 Aug 2022 09:14:34 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5221D4C612 for ; Wed, 17 Aug 2022 06:14:27 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id x10so13527276ljq.4 for ; Wed, 17 Aug 2022 06:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Yg02g9RCBzELEXyS88kfi01jTvYemBxzwaKsyEKanCE=; b=wrxaq7kIOpkPNFTiLpjulwCD7pviXkUQGvHL9K/EVHN5XsO7SN2JLubqS+u9PCcp5v q0vOZVwTtxD1x5mYS+/y7aa68SIKuzE8DZuOm4+sRD0zzLTLLwk488pBr5EicLQAly/1 jQWEu7D26Z+pT4ShEDmBxsziUSiTd288fmynPp/5uP9gitFdW75iasYactInEaasMu40 Nta7yv0NpCMRYB/Mn7lcN2dyUvFyfiPl3H6JMjDbs1ffzgvgDB3K0WXit+xgqIowB3vc QWrwxpvvsgXv9CiWC1iIiMdTEq0DnmfAI4Lee40+6ZyUzN/V8OJ92T9vc5cpgGVP/H+i kYhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Yg02g9RCBzELEXyS88kfi01jTvYemBxzwaKsyEKanCE=; b=LLSDlwu8v876kBoMGbIv312MXDADyXo+N1Kk2ErcCKBisaZ31yRIE5JBzhjQGsXUNs HhVYhkhTh9aSE7hhlpMRCRakjgtipy6WP1LgPBW2Xtt6N9U/1S5lCwTghQ3CUPfKspdw fX0wnjyBYq4rMndOdIFC2M5AlTT/UTzzHywlXFrYQLahoa6/QVBX5YrmU4LWbmRaWC+n ba9Lth30GXGWSK1Qst2QkUQCMj0GsRFQJkqchwJ9dRrk4XTGzmNqE5qRymHRE7n0jlop +wDi2DyVTqjBJT7xJkY+oNjAXRodnMlpedtVzV4wnHBr+lf8QbjmwcOZblM3If8XtHks wZ7g== X-Gm-Message-State: ACgBeo114t8f/jtbt9wMLwkTeVFPvcP0YKxE+u4H9PFi5ZTF+LRYK3Oy NzIoWk7bAEi9YENKra2YzX9Gig== X-Google-Smtp-Source: AA6agR5uzwpyakQr42iVyz1uBf4J8T2NX3T081uUgaSAx0+liX43Wz9QFyk9NN8TtSGeujw5eecP3A== X-Received: by 2002:a05:651c:555:b0:25f:f134:de3a with SMTP id q21-20020a05651c055500b0025ff134de3amr8354626ljp.376.1660742065551; Wed, 17 Aug 2022 06:14:25 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:25 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 03/12] dt-bindings: mfd: qcom,tcsr: add MSM8974 Date: Wed, 17 Aug 2022 16:14:06 +0300 Message-Id: <20220817131415.714340-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Document new MSM8974 TCSR compatible. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documen= tation/devicetree/bindings/mfd/qcom,tcsr.yaml index e1c4936a0352..e7383dcad83b 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml @@ -18,6 +18,7 @@ properties: oneOf: - items: - enum: + - qcom,msm8974-tcsr - qcom,msm8998-tcsr - qcom,sc7180-tcsr - qcom,sc7280-tcsr --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E12EC32772 for ; Wed, 17 Aug 2022 13:14:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239823AbiHQNOw (ORCPT ); Wed, 17 Aug 2022 09:14:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239764AbiHQNOi (ORCPT ); Wed, 17 Aug 2022 09:14:38 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C97C4C614 for ; Wed, 17 Aug 2022 06:14:27 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id v2so18957604lfi.6 for ; Wed, 17 Aug 2022 06:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=G7nHz7460NiblDwkfaLZP3QC942cYsdIM8XAFA/ajO4=; b=Ux60q81hVODEZ/9jXK6w497/gC2vI3P1tZbdFxdC7xZz26+r69kF7Ay82VhNZborZk L/TqTpH907LPYU7oDzCO2WHPks/3Nt5X5SXUJt65mFu8kNFDwxa2RgNQENDyIenqsVji KO4CkIbSeSKX6cthFiFYToS+bSBV0y1bDXlXjNNZhsJRiAG35W3hnRUoprjD3PZyujeA /w0blmU9lUw5MSxHa/bbaVsvGmEwGq6tl6LuFQgr6OkeFyryD2WmIW+V5OaMkW0rnjGE vWHe0c/ZBQit5GGf5CKS04xciRk1+vWigIp5+kxAiPRRZJNyegN/DGfWEj23co0DWa7J igLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=G7nHz7460NiblDwkfaLZP3QC942cYsdIM8XAFA/ajO4=; b=a7ZxVvBQF6pt8w+gGvvFDzB7pfVg1rFfCmlLT3da2QHDSzBNoUpd6va98Rmw75StAF GHYHZKBq/bbQUicAvmGKVwy4ZPE2aFSpNmGPedNC51uIosA93XFi6I+athC4oRDcVyWd sYmTWPqX7voonnLN5RlAEaNkIPF2fAnyUCglvIJTyl5N4fpbpT1jB9cRF98W5GRGQfIt rYyEgyggWnvXb35msYvmJYoka7Za+fwan6onY+oA1NwfAYCX2rM2DCNSSDMB9lASJXyo JIJ1RpIFfgXvsWvUtdFcWt8GJQoDmqG+e+5vt7v/Ur61fCHhLbQshrj+jn63kzGZIHrV zwtQ== X-Gm-Message-State: ACgBeo025WK56h6N/URY0oFEiLuFAu1X3YLsOMLqKwMwwTkpAgy3FQCO eVHMiG4n5Q1ACxwoPvGLIdBRWQ== X-Google-Smtp-Source: AA6agR7VvZ0QXXkcR5lT43JZl+4AdD8B89Fw1v6q71SdS7UPGz75Z3tQMAGOjjFa6BZ9G5qRomKT6w== X-Received: by 2002:a05:6512:3e0f:b0:491:313d:5b6a with SMTP id i15-20020a0565123e0f00b00491313d5b6amr6822082lfv.223.1660742067199; Wed, 17 Aug 2022 06:14:27 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:26 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 04/12] hwspinlock: qcom: correct MMIO max register for newer SoCs Date: Wed, 17 Aug 2022 16:14:07 +0300 Message-Id: <20220817131415.714340-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Newer ARMv8 Qualcomm SoCs using 0x1000 register stride have maximum register 0x20000 (32 mutexes * 0x1000). Fixes: 7a1e6fb1c606 ("hwspinlock: qcom: Allow mmio usage in addition to sys= con") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- drivers/hwspinlock/qcom_hwspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom= _hwspinlock.c index 80ea45b3a815..9734e149d981 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++ b/drivers/hwspinlock/qcom_hwspinlock.c @@ -121,7 +121,7 @@ static const struct regmap_config tcsr_mutex_config =3D= { .reg_bits =3D 32, .reg_stride =3D 4, .val_bits =3D 32, - .max_register =3D 0x40000, + .max_register =3D 0x20000, .fast_io =3D true, }; =20 --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBE2C32771 for ; Wed, 17 Aug 2022 13:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239764AbiHQNO5 (ORCPT ); Wed, 17 Aug 2022 09:14:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233846AbiHQNOj (ORCPT ); Wed, 17 Aug 2022 09:14:39 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 502014CA1C for ; Wed, 17 Aug 2022 06:14:29 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id bx38so13501150ljb.10 for ; Wed, 17 Aug 2022 06:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=NUd8YryzxRUKn1lcURqTFfrnvxH9vHeWn1VsvKW9iig=; b=j8crz0TGC0TwfsN5OrJTRjy9ExfL2boMNIiIoZ1GY8DY2Wi8+8b5X5/lv2gqmY7V6o aG0tfYcAOL6OX55fn2TtvZjNbo4cbB98QqLI6hmhHXa0sJFp+4Pd3hGETSYGKooGCm69 i+J0aZOHrU0Gm+Avl9S6OpiDSVZGKzhpbo2W8t4jSJjmP6wfesLIgEK84+vqfZ6B559+ X0gwLCno8PNjo0efY5DtGg0dRn0mtlx988H4zpYMPU3XV3OB7Z1rpjE0ToYiWrO8C3EF 6h4nSwl1PdoWkcuKcYIzDm8rBZdZhVBCMF1EautAoqjbAWO147MRzL1Mp8x0z6ZxSZik H8xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=NUd8YryzxRUKn1lcURqTFfrnvxH9vHeWn1VsvKW9iig=; b=f313td/dOrpIDdvunEUWFWBUs+e60zxQwMYWXx6iYTvQyfG6WRLrTmzjpvpimGmlsO Tq1wrqBhoaL9xRbD2LllxW60UhzYdWuAvJclGvfRStOd/bfQy+EkLs0BMWI9xHaBYStM FH2Wc5joUnvKR4xTIXMVsMl1E7wb5URr7EMF7xSApWxrNTFKVlCw/LX26ZXfN3VQcKvR r4grecddpW66MrYpmMoMvPTE7j6JrnV7gE5+DgnoiUQOXgNObDTHwDlvGxaUvgtm1mTG Ti5lGvLCc6tZT6NlTsddBDC4EbARwrWWysdb3ZUG9kd3R/tfQ/dc94DqeNmnqk7vvkSy UTHQ== X-Gm-Message-State: ACgBeo2/Cjto/F5VCMFAn4m0CzT2pXLbAYdKlZg1eg0D2gwUfxh423jC gD9hRJqOFVXb6SmJVeYUbROy9g== X-Google-Smtp-Source: AA6agR4ODr7SKicA1GAKwnAKK/adpoZpki8+XPbXTk8r1Ll36pXGE75J4H1rXOx4tDjMzSsB4QzPbA== X-Received: by 2002:a05:651c:154a:b0:25e:7b43:133f with SMTP id y10-20020a05651c154a00b0025e7b43133fmr8631623ljp.137.1660742068771; Wed, 17 Aug 2022 06:14:28 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:28 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 05/12] hwspinlock: qcom: add support for MMIO on older SoCs Date: Wed, 17 Aug 2022 16:14:08 +0300 Message-Id: <20220817131415.714340-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Older Qualcomm SoCs have TCSR mutex registers with 0x80 stride, instead of 0x1000. Add dedicated compatibles and regmap for such case. Signed-off-by: Krzysztof Kozlowski --- drivers/hwspinlock/qcom_hwspinlock.c | 42 +++++++++++++++++++++------- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom= _hwspinlock.c index 9734e149d981..9cf186362ae2 100644 --- a/drivers/hwspinlock/qcom_hwspinlock.c +++ b/drivers/hwspinlock/qcom_hwspinlock.c @@ -22,6 +22,7 @@ struct qcom_hwspinlock_of_data { u32 offset; u32 stride; + const struct regmap_config *regmap_config; }; =20 static int qcom_hwspinlock_trylock(struct hwspinlock *lock) @@ -73,15 +74,42 @@ static const struct qcom_hwspinlock_of_data of_sfpb_mut= ex =3D { .stride =3D 0x4, }; =20 -/* All modern platform has offset 0 and stride of 4k */ +static const struct regmap_config tcsr_msm8226_mutex_config =3D { + .reg_bits =3D 32, + .reg_stride =3D 4, + .val_bits =3D 32, + .max_register =3D 0x1000, + .fast_io =3D true, +}; + +static const struct qcom_hwspinlock_of_data of_msm8226_tcsr_mutex =3D { + .offset =3D 0, + .stride =3D 0x80, + .regmap_config =3D &tcsr_msm8226_mutex_config, +}; + +static const struct regmap_config tcsr_mutex_config =3D { + .reg_bits =3D 32, + .reg_stride =3D 4, + .val_bits =3D 32, + .max_register =3D 0x20000, + .fast_io =3D true, +}; + static const struct qcom_hwspinlock_of_data of_tcsr_mutex =3D { .offset =3D 0, .stride =3D 0x1000, + .regmap_config =3D &tcsr_mutex_config, }; =20 static const struct of_device_id qcom_hwspinlock_of_match[] =3D { { .compatible =3D "qcom,sfpb-mutex", .data =3D &of_sfpb_mutex }, { .compatible =3D "qcom,tcsr-mutex", .data =3D &of_tcsr_mutex }, + { .compatible =3D "qcom,apq8084-tcsr-mutex", .data =3D &of_msm8226_tcsr_m= utex }, + { .compatible =3D "qcom,ipq6018-tcsr-mutex", .data =3D &of_msm8226_tcsr_m= utex }, + { .compatible =3D "qcom,msm8226-tcsr-mutex", .data =3D &of_msm8226_tcsr_m= utex }, + { .compatible =3D "qcom,msm8974-tcsr-mutex", .data =3D &of_msm8226_tcsr_m= utex }, + { .compatible =3D "qcom,msm8994-tcsr-mutex", .data =3D &of_msm8226_tcsr_m= utex }, { } }; MODULE_DEVICE_TABLE(of, qcom_hwspinlock_of_match); @@ -117,14 +145,6 @@ static struct regmap *qcom_hwspinlock_probe_syscon(str= uct platform_device *pdev, return regmap; } =20 -static const struct regmap_config tcsr_mutex_config =3D { - .reg_bits =3D 32, - .reg_stride =3D 4, - .val_bits =3D 32, - .max_register =3D 0x20000, - .fast_io =3D true, -}; - static struct regmap *qcom_hwspinlock_probe_mmio(struct platform_device *p= dev, u32 *offset, u32 *stride) { @@ -133,6 +153,8 @@ static struct regmap *qcom_hwspinlock_probe_mmio(struct= platform_device *pdev, void __iomem *base; =20 data =3D of_device_get_match_data(dev); + if (!data->regmap_config) + return ERR_PTR(-EINVAL); =20 *offset =3D data->offset; *stride =3D data->stride; @@ -141,7 +163,7 @@ static struct regmap *qcom_hwspinlock_probe_mmio(struct= platform_device *pdev, if (IS_ERR(base)) return ERR_CAST(base); =20 - return devm_regmap_init_mmio(dev, base, &tcsr_mutex_config); + return devm_regmap_init_mmio(dev, base, data->regmap_config); } =20 static int qcom_hwspinlock_probe(struct platform_device *pdev) --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E322BC25B08 for ; Wed, 17 Aug 2022 13:15:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239826AbiHQNPG (ORCPT ); Wed, 17 Aug 2022 09:15:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239785AbiHQNOk (ORCPT ); Wed, 17 Aug 2022 09:14:40 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3F104D82F for ; Wed, 17 Aug 2022 06:14:31 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id z6so18949215lfu.9 for ; Wed, 17 Aug 2022 06:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Ye4bqmRVQU/UtyZrgiLeA6KXU6bvQ0m892CxJrKhdQ4=; b=ed6cpMDb8WI+kpHuNPDw3tEHtLzGoeIM7/DhxZ8qY1spbgm2GgkLKM2vYL41UwjWTW Jr9TR0jKQQ5WmNC/Ebsaac+0rh0uwoGkYKo3oiCmJN6xlqoF2bO2Ltl+ci+4TMMgchCU FjSnDVVPFsVUXiiCcbt9tO1SmhcoEjt1SW0ez7B++yxaAZw7dskA50tLPmv+EVyh2vg7 MltuQedxRcmvs4pBtnEZ8xEHWm/RYJHmvWfyR+i2TopkLd8TfOeeCbZGXGYJh7wu+1Hs /1WVWpH11/l7UHlZ+uMA4g/d/7NfcdEaXD97rSId0OpsKfyf+3LM6T3bHvGt1t3I+lzk Whvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Ye4bqmRVQU/UtyZrgiLeA6KXU6bvQ0m892CxJrKhdQ4=; b=eCVg9a/UiQzJmJ9yUrC8C6Xy2s184zKKMvlMNm1SzZ48mxqQ8GCQSQOQNVlXNaI1X8 YWrcimZG/is/pGG4a72SHNqopZ6uJRn1S0jQsVg+/JyFyYwFW1fVFS/ysNhtAJpSFwzJ cesUqUklDClpn0peLc3wPS4wLLAxCCRtxY+D4ND/U7ZaloUjyTNIbdWCF08O1qSdNmR5 m/JzI5yxcaMsLHqQ6LGXvrr6osgi/4hDnaluIW0zbcQnRbJfGSeQro0pCMhrh+Xnaf/y LZUbgCHYnlij/5CTGdGYmPCxu3jxQIODpkYUGScDXigxrT1zJwXwclLSlHKB70HwiKbC jPLA== X-Gm-Message-State: ACgBeo3wulxouwv9OrCL3cIeCPJOahYWqZPuQT/NmH0Spoj2xoHLYjyj eRtdrTCKAtZY/m5pASN1Ckbjvw== X-Google-Smtp-Source: AA6agR40LiTC3alpKQxZw8Z8Ahc4i1D+Q9jCLV9rHVJrjn5TH84JSJC2mmd4LlwEX2Gei2nrCKh5+Q== X-Received: by 2002:a05:6512:3047:b0:491:4104:cf93 with SMTP id b7-20020a056512304700b004914104cf93mr6591392lfb.546.1660742070296; Wed, 17 Aug 2022 06:14:30 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:29 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 06/12] arm64: dts: qcom: ipq6018: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:09 +0300 Message-Id: <20220817131415.714340-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/ipq6018-cp01-c1.dtb: hwlock: 'reg' is a required property qcom/ipq6018-cp01-c1.dtb: hwlock: 'syscon' does not match any of the rege= xes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qc= om/ipq6018.dtsi index aaad7d9059f6..ae56fccebe21 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -129,12 +129,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x80>; - #hwlock-cells =3D <1>; - }; - pmuv8: pmu { compatible =3D "arm,cortex-a53-pmu"; interrupts =3D ; }; =20 - tcsr_mutex_regs: syscon@1905000 { - compatible =3D "syscon"; - reg =3D <0x0 0x01905000 0x0 0x8000>; + tcsr_mutex: hwlock@1905000 { + compatible =3D "qcom,ipq6018-tcsr-mutex", "qcom,tcsr-mutex"; + reg =3D <0x0 0x01905000 0x0 0x1000>; + #hwlock-cells =3D <1>; }; =20 tcsr: syscon@1937000 { --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896BCC32789 for ; Wed, 17 Aug 2022 13:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239809AbiHQNPC (ORCPT ); Wed, 17 Aug 2022 09:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239786AbiHQNOk (ORCPT ); Wed, 17 Aug 2022 09:14:40 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3601E4DB04 for ; Wed, 17 Aug 2022 06:14:32 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id by6so13503065ljb.11 for ; Wed, 17 Aug 2022 06:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=pqtLuKgHuRzFaU11WfzhWYMqklF7F2EiVQK9EioMBZA=; b=b1fRqbAJMcp7MUX2FEM9tYc3wbUwUDEQG6V91K9FJXB6NCYbi8D9eNXaJrQ6acEsTz 4FYHfDxLG1IWsEYf27Ra+q3ewylMGr6Xlt5s6AwP0ZZARxJx1qenfuOhtsEvPZIBfhLN JXf9eBsveGFDNDonbR6vec/7MYpWHTOl1UKTNt2VhfOYkmYa0INSFHB9UDbcjsbHepRQ 2Kh4eja2X9Ifz34Yf1mUydYTe5ohxUbtDHiLypPq6+uYugreCR2vA1Exbhin+QsWpAKc 9ddmxkO0Dga2GL8S+R/Zh2FGXM1M+K/W4GEi1n3f5ysqo4If32H3SIPosvL7T+nDU8TX YyTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=pqtLuKgHuRzFaU11WfzhWYMqklF7F2EiVQK9EioMBZA=; b=fvZhcA0amZtYgn5rnYuqunbQVndF3TStQ32CnZeC11Jq4nKrD8Fz8kl9JmghsLNC8u hiHoYmQ0UtP+4WjnXQbnvH8tSNDXiD/8/ywiDh5m8BvyFSynsfr9jPEC6ayoTYePfxUb tE3vQu6NBkMd5Teft7e86z6DXp7OYAiqGq6CgxKhmTaQECopdNzt7uCBD0aCrI7ump6r p/zOpqu438BAa6+oT+4p0xw3o7r+o+xv8sOoXcpp2c8fuEwmIADETdlkkwiT6Ix6Hm/8 tW9E7UvzF8uxN8myvvcfDMZnMZDgXNvTcBGSj+jtfirf6I1AtGXXdkxxKJCH/3ImxC0p lpMA== X-Gm-Message-State: ACgBeo1MeMZQxv24RSNodpbP3upkmJLOm5ONGGACiR6VM7LSxg93W77w 567E1H1ssGsv+vRyACG/7OOpjw== X-Google-Smtp-Source: AA6agR48PdRddyjQg7Y2vLx7jqebiR+4tCUBl5bItx/oMtFmrBED6xdwL9PgJoF15SElq6AQmcJWLw== X-Received: by 2002:a2e:9e56:0:b0:261:7544:d79d with SMTP id g22-20020a2e9e56000000b002617544d79dmr1742755ljk.296.1660742071792; Wed, 17 Aug 2022 06:14:31 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:31 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 07/12] arm64: dts: qcom: msm8994: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:10 +0300 Message-Id: <20220817131415.714340-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8994-sony-xperia-kitakami-suzuran.dtb: hwlock: 'reg' is a require= d property qcom/msm8994-sony-xperia-kitakami-suzuran.dtb: hwlock: 'syscon' does not = match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8994.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8994.dtsi b/arch/arm64/boot/dts/qc= om/msm8994.dtsi index 8bc6c070e306..6a9bca6c2c5f 100644 --- a/arch/arm64/boot/dts/qcom/msm8994.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8994.dtsi @@ -164,12 +164,6 @@ memory@80000000 { reg =3D <0 0x80000000 0 0>; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x80>; - #hwlock-cells =3D <1>; - }; - pmu { compatible =3D "arm,cortex-a53-pmu"; interrupts =3D ; @@ -762,9 +756,10 @@ spmi_bus: spmi@fc4c0000 { #interrupt-cells =3D <4>; }; =20 - tcsr_mutex_regs: syscon@fd484000 { - compatible =3D "syscon"; - reg =3D <0xfd484000 0x2000>; + tcsr_mutex: hwlock@fd484000 { + compatible =3D "qcom,msm8994-tcsr-mutex", "qcom,tcsr-mutex"; + reg =3D <0xfd484000 0x1000>; + #hwlock-cells =3D <1>; }; =20 tlmm: pinctrl@fd510000 { --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D38A2C25B08 for ; Wed, 17 Aug 2022 13:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239847AbiHQNPP (ORCPT ); Wed, 17 Aug 2022 09:15:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239695AbiHQNOk (ORCPT ); Wed, 17 Aug 2022 09:14:40 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8BF84F646 for ; Wed, 17 Aug 2022 06:14:34 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id x19so18963015lfq.7 for ; Wed, 17 Aug 2022 06:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=6hkmj/RZGZV2ubSm7Y6EYAIQdJcarVin5p0NjjE8aKM=; b=LuJ/DuHx4XaFQtsZbUlL5O+XQwKTuYuMk1wiqb2amgN7AammjIOHIC0tBnk4Wys2Ea PIFR30NaUfWwcbUKlW0Cn7JUiQILZXgSb7N4S0M5y3CYgFbmVj4IekoVv4rMmnPUp8++ VFOvVJV8pSa+Kf+lKGjc03HE62HpnYzTeAtq4Ukp4tfcgpqYBsV18zQSHSJ9vBbCov0z uxEM/UwcXaIYlLxJLzFXFZTC08y5t45MuJkCHEHxHzu/W07vV0jqz5S4Zo748TYDibyz HhjwhTQxCCw8Jry2oJUV3JALsJMo2em/tfd7Wf+qy+4kWqQe7czpjwF3Y3W2bbD8SgKM 3DTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=6hkmj/RZGZV2ubSm7Y6EYAIQdJcarVin5p0NjjE8aKM=; b=7vgEKKVArLD+tEYvdEsW6VGznYTvAhVmeVVyo3/EYba51QUyq9J6UPJuBDdBySBMIK 2/7FlDa5RACOUKwU95GP62ZxpcfAC1wpTEZc/qObmd0Ob6LDcjla6HX9ldZnYnAXu6xc p/ptCPGXZ2QCBNBc1RpwfSrTglxwiQzBIxDCcmDk+YhvrmEsYCM5W98PddaqXNRG/HsS d98+o3cvTM/37JMnIzQPISyFv7UqyrQ8wDtdD/+eGiQHH75GVNIw5YYbcUtFWheCc6dD pgpEoTszU7B+U98gqpFnWPn0JRf3Vk4dDhB1qQV7+BvzMkm7Hbi8z4+ZVbnlCZwZEFBA xgxA== X-Gm-Message-State: ACgBeo2URjjvra5xmhFy+EJkwn5xdGyiHDUKA1kgNW6d0aJq/HbPtD3A MYXGxZR6A4Co7i/GlSgQ85U+Dw== X-Google-Smtp-Source: AA6agR6uz6PgHJJgHSkUYGIHiHszn0Dz+54GDEd24Jx76kQfPHB9W+lxiMZ+hmy/E2YYJ90MXmVbyg== X-Received: by 2002:a05:6512:3e1b:b0:48b:6ae:ce4d with SMTP id i27-20020a0565123e1b00b0048b06aece4dmr8496799lfv.142.1660742073304; Wed, 17 Aug 2022 06:14:33 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:32 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 08/12] ARM: dts: qcom: msm8974: add missing TCSR syscon compatible Date: Wed, 17 Aug 2022 16:14:11 +0300 Message-Id: <20220817131415.714340-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" TCSR syscon node should come with dedicated compatible. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-m= sm8974.dtsi index 8baca2a77717..0a9f252c88a7 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi @@ -1234,7 +1234,7 @@ tcsr_mutex_block: syscon@fd484000 { }; =20 tcsr: syscon@fd4a0000 { - compatible =3D "syscon"; + compatible =3D "qcom,msm8974-tcsr", "syscon"; reg =3D <0xfd4a0000 0x10000>; }; =20 --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D158C25B08 for ; Wed, 17 Aug 2022 13:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239855AbiHQNP0 (ORCPT ); Wed, 17 Aug 2022 09:15:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239061AbiHQNOm (ORCPT ); Wed, 17 Aug 2022 09:14:42 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9A064F693 for ; Wed, 17 Aug 2022 06:14:36 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id z6so18949485lfu.9 for ; Wed, 17 Aug 2022 06:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=xXYhGBIEDADNPaF7FntsO5+CaYiCK5EMt2dAgswIP/E=; b=rfesmkR/Z2XkW9U5Ai2BIS8LVP73UN+425tKrx0cDTW1zqLqT2gXDM078/lW9QV2yI sQG6qAJgYSZUG457LxgdNYYIuMkNQq2Za3JQy/YETZEYWpLvm37fPk9RtQlnG4X0V0dK TW066pA7XnpEPtQ1VV1538t+W8+9k4l5WpTNDQpglqG1FRuGBVvBFp43qjaB5IH8sBf7 /JQ9csPnIN4J6v5N5ljLmSk3hCycOvauDqM6gBbkoyOqFswbH9BgtcKwiiWVJ1VwyGT3 KUGbmquXwocSJD4TjlGNAOvzw4v7tG5i7B5vjjJoCY+NAtYpaFy0pSVR5FvRuRxWlByI tFiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=xXYhGBIEDADNPaF7FntsO5+CaYiCK5EMt2dAgswIP/E=; b=LaaGZ9zpj62xUqABPfBr6HNRUQaM6pFgBOXC6+P4fa0xnqndpmCzbWl4DIO+kZYP/x /WMNV8lXcu6gepAriktjL8KRLZ9nx7j5a6ifrgcTCEHzSC/johd4GslUTDwArsTlXjBc XLC87wfRPWvSoeeQFCLp5xTiCvKQkV7XRpT8F5lMANCGEzSZSDI4/YuxWSTWVpBsmC8I sNzmHKbcoTzrMo+5qf9Lx2NzK0XlP8JHRIeBxkiL8VlRoRQG+U7Urjj4qB8uQxwYG09X U+MZudKSo3AJ2f6VjlKhwXToIBAr+q7EeZQMjkmlYSKawRwUD8uLiCp5P7xI0ZYthhVH HXOg== X-Gm-Message-State: ACgBeo2l+MYtezPizbNQLG5GdtGfXLz+HUSHlwpHwei3sEjKs9E/l9yY fY/tvLG0misqbe2Mw+lzLeUodg== X-Google-Smtp-Source: AA6agR6PDcGKSl5yiOIktlWZ0jUH6eEYd3ChNN0RAz7S7jfXE61WPqYwgJ808qhJjFJUkBaxmtwcow== X-Received: by 2002:a05:6512:2611:b0:478:da8f:e2d8 with SMTP id bt17-20020a056512261100b00478da8fe2d8mr8444745lfb.460.1660742074843; Wed, 17 Aug 2022 06:14:34 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:34 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 09/12] ARM: dts: qcom: msm8974: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:14:12 +0300 Message-Id: <20220817131415.714340-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 2 +- .../boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +- arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 2 +- arch/arm/boot/dts/qcom-msm8974.dtsi | 11 ++++++++--- arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts | 2 +- arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 2 +- .../qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +- 7 files changed, 14 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot= /dts/qcom-apq8074-dragonboard.dts index 3051a861ff0c..2709a99e5c4c 100644 --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts @@ -38,7 +38,7 @@ &otg { status =3D "okay"; =20 phys =3D <&usb_hs2_phy>; - phy-select =3D <&tcsr 0xb000 1>; + phy-select =3D <&tcsr_2 0xb000 1>; extcon =3D <&smbb>, <&usb_id>; vbus-supply =3D <&chg_otg>; hnp-disable; diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arc= h/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts index ec5d340562b6..5fd94dd6a427 100644 --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts @@ -251,7 +251,7 @@ &otg { status =3D "okay"; =20 phys =3D <&usb_hs1_phy>; - phy-select =3D <&tcsr 0xb000 0>; + phy-select =3D <&tcsr_2 0xb000 0>; =20 extcon =3D <&charger>, <&usb_id>; vbus-supply =3D <&usb_otg_vbus>; diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/a= rm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi index 5a70683d9103..118b231f3137 100644 --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi @@ -136,7 +136,7 @@ &otg { status =3D "okay"; =20 phys =3D <&usb_hs1_phy>; - phy-select =3D <&tcsr 0xb000 0>; + phy-select =3D <&tcsr_2 0xb000 0>; extcon =3D <&smbb>, <&usb_id>; vbus-supply =3D <&chg_otg>; =20 diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-m= sm8974.dtsi index 0a9f252c88a7..4b602410d72a 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi @@ -1189,7 +1189,7 @@ remoteproc_mss: remoteproc@fc880000 { resets =3D <&gcc GCC_MSS_RESTART>; reset-names =3D "mss_restart"; =20 - qcom,halt-regs =3D <&tcsr_mutex_block 0x1180 0x1200 0x1280>; + qcom,halt-regs =3D <&tcsr_1 0x180 0x200 0x280>; =20 qcom,smem-states =3D <&modem_smp2p_out 0>; qcom,smem-state-names =3D "stop"; @@ -1230,10 +1230,15 @@ smd-edge { =20 tcsr_mutex_block: syscon@fd484000 { compatible =3D "syscon"; - reg =3D <0xfd484000 0x2000>; + reg =3D <0xfd484000 0x1000>; }; =20 - tcsr: syscon@fd4a0000 { + tcsr_1: syscon@fd485000 { + compatible =3D "qcom,msm8974-tcsr", "syscon"; + reg =3D <0xfd485000 0x1000>; + }; + + tcsr_2: syscon@fd4a0000 { compatible =3D "qcom,msm8974-tcsr", "syscon"; reg =3D <0xfd4a0000 0x10000>; }; diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm= /boot/dts/qcom-msm8974pro-fairphone-fp2.dts index ff6e0066768b..c264d17e0953 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts @@ -89,7 +89,7 @@ &otg { status =3D "okay"; =20 phys =3D <&usb_hs1_phy>; - phy-select =3D <&tcsr 0xb000 0>; + phy-select =3D <&tcsr_2 0xb000 0>; extcon =3D <&smbb>, <&usb_id>; vbus-supply =3D <&chg_otg>; =20 diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/= boot/dts/qcom-msm8974pro-samsung-klte.dts index 983e10c3d863..2691a6dbbb8b 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts @@ -379,7 +379,7 @@ &otg { status =3D "okay"; =20 phys =3D <&usb_hs1_phy>; - phy-select =3D <&tcsr 0xb000 0>; + phy-select =3D <&tcsr_2 0xb000 0>; =20 hnp-disable; srp-disable; diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.d= ts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts index 3f45f5c5d37b..d2bef3896c82 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts @@ -216,7 +216,7 @@ &otg { status =3D "okay"; =20 phys =3D <&usb_hs1_phy>; - phy-select =3D <&tcsr 0xb000 0>; + phy-select =3D <&tcsr_2 0xb000 0>; extcon =3D <&smbb>, <&usb_id>; vbus-supply =3D <&chg_otg>; =20 --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33FA4C28B2B for ; Wed, 17 Aug 2022 13:15:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236565AbiHQNPX (ORCPT ); Wed, 17 Aug 2022 09:15:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239799AbiHQNOq (ORCPT ); Wed, 17 Aug 2022 09:14:46 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1E914F6B3 for ; Wed, 17 Aug 2022 06:14:36 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id x19so18963181lfq.7 for ; Wed, 17 Aug 2022 06:14:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=zKHY3dCKJ9MBQUb1nFG5BJ8dnmo7NmfzmU7KoX4k/sc=; b=I7ZGQFpT7TyHMGcPOTq3gyDtAPS8zEGPd42TBrWTkjoqhrt3akPHiIf+w4B76q3aiU 3XI+IhkIVY2r3Iln2cKulCNu3xUaNftz1cSQrvJOifhtA316/9klkiyve6BFAPV1d6VY 7IU70Xb7QNLpKjEkw0Nwv2vr5dKAB23qe8xhrOtM2iIFHG8JPHF0X382o+ioejbk7DZe VPknovP886k8IVr78GTWmL/eyPg7VtoMZjCn9JTn9iGnbCgPfwiGaZlMQqHoTFGdyKMM 9sE2tpSW5DcEJvjaVVBPzOadXu6W0EVGWoaIjpd26RlNBHHvh1EM8vjudDsaBcJ7XFrF YHWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=zKHY3dCKJ9MBQUb1nFG5BJ8dnmo7NmfzmU7KoX4k/sc=; b=uyJZM/uXVS35RcoYLZOz1FExl1szdpAygRrjjKQfB+D/BtsYwuKCTRKZhYII4CVSel vgKCD4lBCmUtn9DlwRGVR71x1PvDfHPTtP9Ekhc7v9rRXlIqIpcEEbI7uiobftGNAUaF 4OftBuTsXipvhsf+oSezc/PpePFck+1PGimghPR064Zd5XU12bU+cP4S9khsz9v6AC0k TwqsW3WJwxFpsKK4mt3IjvMpAw5TovpcDH9NSsPBkB5dPICEDdByI7OL51wK5WhAm6Jy SAWDskhpgNGNvuwsC1ngn0wzkmsxyyLYjyIb1eYkoNMU/Oe/fzC57xJULTJG1V5pVwei ElDQ== X-Gm-Message-State: ACgBeo3fav6KvBYXLCeivAW8+mhbRuEcsuZFw1UM9+ZUoIxdJztcC+MY E3DdZiIBf+2hoak3uaz0ATvU4g== X-Google-Smtp-Source: AA6agR5XGF47v4qdgMgUliUXwW/xR14w/+9RDtpKsUFcdZ7p+r7vapl4D4EGIFCR+LZwwiSCgS0Epg== X-Received: by 2002:a05:6512:32c5:b0:48b:969a:9c24 with SMTP id f5-20020a05651232c500b0048b969a9c24mr8389425lfg.300.1660742076344; Wed, 17 Aug 2022 06:14:36 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:35 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 10/12] ARM: dts: qcom: msm8974: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:13 +0300 Message-Id: <20220817131415.714340-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom-msm8974-sony-xperia-rhine-amami.dtb: tcsr-mutex: 'reg' is a required= property qcom-msm8974-sony-xperia-rhine-amami.dtb: tcsr-mutex: 'syscon' does not m= atch any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-msm8974.dtsi | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-m= sm8974.dtsi index 4b602410d72a..5f674aa819ae 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi @@ -1228,9 +1228,10 @@ smd-edge { }; }; =20 - tcsr_mutex_block: syscon@fd484000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@fd484000 { + compatible =3D "qcom,msm8974-tcsr-mutex", "qcom,tcsr-mutex"; reg =3D <0xfd484000 0x1000>; + #hwlock-cells =3D <1>; }; =20 tcsr_1: syscon@fd485000 { @@ -1719,13 +1720,6 @@ reboot-mode { }; }; =20 - tcsr_mutex: tcsr-mutex { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_block 0 0x80>; - - #hwlock-cells =3D <1>; - }; - thermal-zones { cpu0-thermal { polling-delay-passive =3D <250>; --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1671C32771 for ; Wed, 17 Aug 2022 13:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239873AbiHQNPa (ORCPT ); Wed, 17 Aug 2022 09:15:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239781AbiHQNOu (ORCPT ); Wed, 17 Aug 2022 09:14:50 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98C3A51A0C for ; Wed, 17 Aug 2022 06:14:38 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id bx38so13501538ljb.10 for ; Wed, 17 Aug 2022 06:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=uXLJl3ZPkfkVvmcRHOHOBnFdkGCya/Ew5ljctJGYsvo=; b=LThxqa07rs/MPV48N0w8kXoiodIcyMBUsQNqxCs/gH3PFDrVGh4PWvL+NXQ+nCb57O wAz+p0MPwvBqAaSenCoapEcgKSxAK4WxYxuOY8y7fN5OQ/on66T8Pn0htKijnE8VlOGk t92RgTzAKkzFe9Mf7ynXFlzG8NlkoNhFLWb3mtkbw3jK4KQiqRiC2bbnWGiHNXGgZ1UV hy3cRXR3fILbUgxgXio6ZFXJz/lf3m6FYOqW9wHLkTA5PON0V19ZEyj1HIomI5hx0vpT 7af9bPe3+VsZ6kxSFqSUmdDjv9Ive3oZ1ezAvw9PSQkJNqngxlD3PEvXXkMTgq5WGR7y Sd6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=uXLJl3ZPkfkVvmcRHOHOBnFdkGCya/Ew5ljctJGYsvo=; b=dj+HDbw7ajQeybR7bbfSW4GEMZSf4KK1tJf5yOANpbFSiAahmUlhRUKAaWoS86loP5 DMxhniAQnezN0lTd+If0QZVJgUgR3mttgNevg7sOFi2j14VBysUliE647e6sI77Op/14 gIE8wEnARlqT0qAXahAkcHsISmEJ5GhOP/THz9HAf2lVZJgonTA+xqstXNnv2QC7kOO1 bMNTRTQ+tUa9xBhbBibd1mPGUUgrULq7PYEtJ1uPrlKArI7aET6QwIXBiXe3SYcSHxWm RRFnyBorkeGJNMBa/s16+AFFnEUKyj2Yz/DEzaJUh/8QsS8uxufUogQwKHYUheonqYt9 eW2w== X-Gm-Message-State: ACgBeo0XRZ+Dd/XfJAXTDyy9UkuTFieXy/XFlxf0DgqhoLhW12rPmYs3 UETftIY6PYQ5SZ8io+WILBnNXg== X-Google-Smtp-Source: AA6agR4jh/QK3ONB9rVZSBJuYOsHWZBBWf+scOCDnCRRh0UN+NM4NdTkZ2qEXGMavvmupaishF7GOw== X-Received: by 2002:a05:651c:2212:b0:25e:cc38:a1dc with SMTP id y18-20020a05651c221200b0025ecc38a1dcmr8545043ljq.359.1660742077891; Wed, 17 Aug 2022 06:14:37 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:37 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 11/12] ARM: dts: qcom: apq8084: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:14 +0300 Message-Id: <20220817131415.714340-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom-apq8084-mtp.dtb: hwlock: 'reg' is a required property qcom-apq8084-mtp.dtb: hwlock: 'syscon' does not match any of the regexes:= 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-apq8084.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-a= pq8084.dtsi index 72f9255855a1..5e07255fe5ea 100644 --- a/arch/arm/boot/dts/qcom-apq8084.dtsi +++ b/arch/arm/boot/dts/qcom-apq8084.dtsi @@ -383,14 +383,9 @@ gcc: clock-controller@fc400000 { reg =3D <0xfc400000 0x4000>; }; =20 - tcsr_mutex_regs: syscon@fd484000 { - compatible =3D "syscon"; - reg =3D <0xfd484000 0x2000>; - }; - - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x80>; + tcsr_mutex: hwlock@fd484000 { + compatible =3D "qcom,apq8084-tcsr-mutex", "qcom,tcsr-mutex"; + reg =3D <0xfd484000 0x1000>; #hwlock-cells =3D <1>; }; =20 --=20 2.34.1 From nobody Sat Apr 11 00:45:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C842C28B2B for ; Wed, 17 Aug 2022 13:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239919AbiHQNPc (ORCPT ); Wed, 17 Aug 2022 09:15:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239811AbiHQNOs (ORCPT ); Wed, 17 Aug 2022 09:14:48 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2D0A4E856 for ; Wed, 17 Aug 2022 06:14:40 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id w15so13542905ljw.1 for ; Wed, 17 Aug 2022 06:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Yb2tg6NLcz0SjyT+zhbpZCCAWG7Bnyw4PloKDdxoVAU=; b=StgnaHhGCg7OOpqTG13+gQqRFOCLdTRA/VCywEDqg9kMIxRkqhIjEL6/unZNraETkB OY78slefTO6VmDzp97WDvD8kTArUqhb1NLsuK7dpIINzEiwMK1YWNK9g8TqUfbVweYMm FIgJ0b+KVQtMsadPvgTAwA26rnWXysiwVIdai5xvQ4DdVGOA3ClgjDb5I0IEcgQ+Gv1U pyhxFEJkeL2O6+cfBaxxXSVEhe4+VnOd7U8+etGNUDTddXn7jHg1/sKyJW5B3MseCKzD NP8IjoOxxroQY3Y1ne8qNUgojmtamVj7SkkIGcdYG36ye/FMasRKQE/ytP2+enkQueNs RdtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Yb2tg6NLcz0SjyT+zhbpZCCAWG7Bnyw4PloKDdxoVAU=; b=cS/vyQnf9T+MvY5dV736iaBwFBS1zSf/VvE9enSQFNm6hLhuPPBppHvyybl0N+tkzM 1X9kVTBVgw4sEBpLyzVQXfB1Fhmwg2fGEnK4Jo/yq+pYbVFqqEZmREUhwgTwCHG9WMI3 P31AiWiId2y0hMmBHSDNIl4QJp8WIzrEnuMNtKk5ZeUssgjmhfpnrlDccotyvFzRJDB+ iVREW4ypgqZa8oLkeNnQ7bP/9OB4CwUk6YswIgub75xhhg04ppdCuvVmLV1Nd2j5oYay cR9g/haeE3beLfzzri/hWoNFke2PLBQv2eU2ZIzGakoDpA/100Qm7nI/0APudk6uQhL8 NZ4g== X-Gm-Message-State: ACgBeo0swgXTnIUDHHb6VzzaJHjjLaWvFFpfyFilLzPi702zZI2hLXSI C75H1gTlezk3ucfcGsqYx+Rhtg== X-Google-Smtp-Source: AA6agR4Jr9dVJN0cBFc7EFaxXfsdQSVgqEaGe2HDLtNEJ6H2epeCLVj35rKOvxNYeo5RnnOoO2U2wg== X-Received: by 2002:a05:651c:10d2:b0:25e:5a65:9026 with SMTP id l18-20020a05651c10d200b0025e5a659026mr8217403ljn.193.1660742079394; Wed, 17 Aug 2022 06:14:39 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id k1-20020a2ea261000000b0026182f31aa0sm1411307ljm.1.2022.08.17.06.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:14:38 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Ohad Ben-Cohen , Baolin Wang , Rob Herring , Krzysztof Kozlowski , Lee Jones , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 12/12] ARM: dts: qcom: msm8226: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:14:15 +0300 Message-Id: <20220817131415.714340-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> References: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom-msm8226-samsung-s3ve3g.dtb: hwlock: 'reg' is a required property qcom-msm8226-samsung-s3ve3g.dtb: hwlock: 'syscon' does not match any of t= he regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/qcom-msm8226.dtsi | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-m= sm8226.dtsi index 0b5effdb269a..efb5d1edc3a8 100644 --- a/arch/arm/boot/dts/qcom-msm8226.dtsi +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi @@ -44,13 +44,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_block 0 0x80>; - - #hwlock-cells =3D <1>; - }; - reserved-memory { #address-cells =3D <1>; #size-cells =3D <1>; @@ -508,9 +501,10 @@ rpm_msg_ram: memory@fc428000 { reg =3D <0xfc428000 0x4000>; }; =20 - tcsr_mutex_block: syscon@fd484000 { - compatible =3D "syscon"; - reg =3D <0xfd484000 0x2000>; + tcsr_mutex: hwlock@fd484000 { + compatible =3D "qcom,msm8226-tcsr-mutex", "qcom,tcsr-mutex"; + reg =3D <0xfd484000 0x1000>; + #hwlock-cells =3D <1>; }; }; =20 --=20 2.34.1