From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3848FC25B08 for ; Wed, 17 Aug 2022 13:04:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231629AbiHQNEP (ORCPT ); Wed, 17 Aug 2022 09:04:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239534AbiHQNEH (ORCPT ); Wed, 17 Aug 2022 09:04:07 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D9633136F for ; Wed, 17 Aug 2022 06:03:54 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id i19so618252lfr.10 for ; Wed, 17 Aug 2022 06:03:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Fu31UHcZ2LXLoLqG8lQtW1W1v+mxTPYhVi9HdleMdto=; b=Al0HfpTRNiVmLf1Ltv8H0kEaWM7RlsrinxpJ/BmAgcypfuG50URpD03yiHWeC6n7q0 0/RXgYGGpwDEvcW3gNu1qhAcdV10k8HQ/lt62yZQafuNb5766KLrU+p2+Y4cRktx/OFj so4P5dgfGKHJhagKPR0s+kmuFFP4P11CCWE3pnO57irtvZ5t/BbGx4tEVk24PSbDl24A 1Ghil/Vj3TKnPtdxIpegAJjo+/EbAdD/aVN05TIT40PX1nRyTU++UvuHZwifYcOTkY35 lXy07XAL+UJ/AqM1Y+tPCjzrZdf9RgnY8z5tocPvLqtRHtdmQWaMYymeQvDyHQzn3Lzu +9+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Fu31UHcZ2LXLoLqG8lQtW1W1v+mxTPYhVi9HdleMdto=; b=nz4huvWTJTs8d04aagT+r4Qgd0VzRQu3ERlzGb1u2wWtzBxff8eVful6DBQZ8ZiPJU LKHUz2YzdfcuYwFavB/lM36HqrQ5D1tPTZbZ+mcjs0tZbxWsPQhcOIB2Vbm8VltZssz3 bXGeYCRAUTJfb3tCHjqxDvFghO61azJX5q7lNgmZHCfOXgV2L4azYRR0U0qHr9rm/aoP D1pHzNrsLqwS9bVawm7+REIqRfRkNjXOPjtS5jCgRe/meL2tQl2E5wWIAxaqO+dqWoO7 vQLJqfMLKkxqDaG+p6PE2ER+UqpsqAjJXye3kXq4kqfLthphVku8ZNyMBf42hOLQTUWm Iq8A== X-Gm-Message-State: ACgBeo1XjIj/VQmBSakHNk0tpxqG0BxhBNPqFWEQTAN0CPbypdh5PLNV S8rxXrz1YrEfIxuJiZKvo+ugDA== X-Google-Smtp-Source: AA6agR4hselVCr5xeWZ6GrhELl9ZY9rOaufFtQoKburwlVDxbLqKVXqrVxlc9YkN1yPuXZkskihE7g== X-Received: by 2002:a05:6512:2243:b0:48b:2746:314d with SMTP id i3-20020a056512224300b0048b2746314dmr9429439lfu.392.1660741432396; Wed, 17 Aug 2022 06:03:52 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:51 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 01/14] dt-bindings: mfd: qcom,tcsr: add SC7x80, SDM845 and MSM8996/8 Date: Wed, 17 Aug 2022 16:03:29 +0300 Message-Id: <20220817130342.568396-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Document existing (MSM8996, SC7280) and new compatibles for TCSR syscon registers. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Correct order of compatibles. --- Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documen= tation/devicetree/bindings/mfd/qcom,tcsr.yaml index 2f816fd0c9ec..e1c4936a0352 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml @@ -18,6 +18,10 @@ properties: oneOf: - items: - enum: + - qcom,msm8998-tcsr + - qcom,sc7180-tcsr + - qcom,sc7280-tcsr + - qcom,sdm845-tcsr - qcom,tcsr-apq8064 - qcom,tcsr-apq8084 - qcom,tcsr-ipq8064 @@ -27,6 +31,7 @@ properties: - qcom,tcsr-msm8953 - qcom,tcsr-msm8960 - qcom,tcsr-msm8974 + - qcom,tcsr-msm8996 - const: syscon - items: - const: qcom,tcsr-ipq6018 --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C24AC32771 for ; Wed, 17 Aug 2022 13:04:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239108AbiHQNEU (ORCPT ); Wed, 17 Aug 2022 09:04:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239562AbiHQNEH (ORCPT ); Wed, 17 Aug 2022 09:04:07 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C81432DA2 for ; Wed, 17 Aug 2022 06:03:56 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id d14so18895363lfl.13 for ; Wed, 17 Aug 2022 06:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=7xLpyvjcjxtFjBdq2TnMTpFX2axCPt8X9rBvt8vK73g=; b=PjUVTMLZrPosGW6XmepHlPO6eBG33wbigvyDIhLQxGCe0t0HNYb7qqhQRzDUb6WSUd 8Ix9XRC/u8xSK0VB2AfHrZNUZHgAdte+McfWQyJ+xGlUDAbzhIJqfxQgAOoDufNrsvGG lo3x89xgK1BBxmfSYHfrCNe/byq3/pfDGz3MH5mG2jHsd/zD6vMbeg6ljVZnzE23unAa 67DtmM3ZT+/PA7L/5Y5fXlcsT9JWh28VvfIwpSGdJm1/iUlX+mW0PidIsjXTl1pZV7Ys vLNq56vARazX3rlDUN3+hf4VqRjQV2kFkRKG09tIQrjmB4ag9j/J9rj/E6M03fUzbvee K0Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=7xLpyvjcjxtFjBdq2TnMTpFX2axCPt8X9rBvt8vK73g=; b=py1fSGaX0phNL8VJ16ykzbJxqRzAfldVti+eA050HENEtl7FtYX3IgZ7ygTgmyhYZO qIkE95k9d8RIOOqw75Zsj5eiJIkEq7t89dJDWbQuF7QniUuN22V6Pgh0mcMVMYdYRYfJ RsgI7QVloQ0dbuQPr5vysYT64M5iU/4KEjSIkdwItzoM8INxhwsMreEG4J4k0Qx15oaN BU2d+UtNpD6PhEy1d5nVxpWLfwTawFIseT4Sj/CKlF5v+Rr9Z1/qElDXnOhn9BWOMHwj uXJOVsRsSSVwrOVjSTe3bPiAnJmhHPPa8r5D1zS9luZCt6EBDsafxqLYzYBzWWeZqkeZ p4Zw== X-Gm-Message-State: ACgBeo2/7fipAT4sOwOkPqw+buLb0YvVIOveA7efbXoTqRUvUysiWlpX oq+kxwx2wVW8wR/06U5p18W3nw== X-Google-Smtp-Source: AA6agR7Zzblj4Xlxub0k83AuZvMCqpVVbNxPphlAI3oTNPmKajhVKPj/RJ1GaeWLs5yQwv1ptA1tfA== X-Received: by 2002:a05:6512:1392:b0:48d:a6b7:caff with SMTP id p18-20020a056512139200b0048da6b7caffmr9229978lfa.154.1660741433664; Wed, 17 Aug 2022 06:03:53 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:53 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 02/14] arm64: dts: qcom: msm8996: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:30 +0300 Message-Id: <20220817130342.568396-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qc= om/msm8996.dtsi index 742eac4ce9b3..3411ced96db6 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -359,7 +359,7 @@ opp-2150400000 { firmware { scm { compatible =3D "qcom,scm-msm8996", "qcom,scm"; - qcom,dload-mode =3D <&tcsr 0x13000>; + qcom,dload-mode =3D <&tcsr_2 0x13000>; }; }; =20 @@ -840,10 +840,15 @@ pnoc: interconnect@5c0000 { =20 tcsr_mutex_regs: syscon@740000 { compatible =3D "syscon"; - reg =3D <0x00740000 0x40000>; + reg =3D <0x00740000 0x20000>; }; =20 - tcsr: syscon@7a0000 { + tcsr_1: sycon@760000 { + compatible =3D "qcom,tcsr-msm8996", "syscon"; + reg =3D <0x00760000 0x20000>; + }; + + tcsr_2: syscon@7a0000 { compatible =3D "qcom,tcsr-msm8996", "syscon"; reg =3D <0x007a0000 0x18000>; }; @@ -2413,7 +2418,7 @@ mss_pil: remoteproc@2080000 { qcom,smem-states =3D <&mpss_smp2p_out 0>; qcom,smem-state-names =3D "stop"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs =3D <&tcsr_1 0x3000 0x5000 0x4000>; =20 status =3D "disabled"; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 691DEC32772 for ; Wed, 17 Aug 2022 13:04:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239594AbiHQNEZ (ORCPT ); Wed, 17 Aug 2022 09:04:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239567AbiHQNEH (ORCPT ); Wed, 17 Aug 2022 09:04:07 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D87130555 for ; Wed, 17 Aug 2022 06:03:57 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id a9so18891671lfm.12 for ; Wed, 17 Aug 2022 06:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DmgjoU3ZwmShD+iuLbm/N6H6WPhywoNwmKzID5e5568=; b=dOoNqvye8xquk0IPEbhQhqui+Qtl+FwGe6xO/9UzbcZeyzno5z0sjyTEDevwNPNzZI LxmTr+GSKl1380Nz1jq42Qouq+iXDy1mDR+N3uPjd0W7UCAgLQN985quLi+FE7hVk+GE jIOzlHwbLSvijTeh7RfHxO8wXCvrMeaUH0cSa2DTcQM3FToaO4IQGyySLej/+PqUnekK z3KGXi8UOxo7kxFjMnJDvEHVn1MzXQKy0Tjd5tizb1D+yQb3y43/Id+I2AtklPjn3em3 2YbAQ2xzosOaW+DZHq4Y+HSSmZHaOwRL9vwIfsTzbjRJFJqWCB0X0cgYrHX9voJqMhqz OMVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DmgjoU3ZwmShD+iuLbm/N6H6WPhywoNwmKzID5e5568=; b=boQI4gZtgqWTXY2DQY8jwbbfdMsU9AQx6xaCQuzwMYrlYAaRKVaIOe4/MEtGLeQVh1 bwllvK+HTG+JVw3NSfG1XCSgMHP1e60b3N/uExX4em6Md0t2enWL61a11/9Mze6QmDV/ AUcguhQZ1OWTd+7dmPsXTw4FnpsKriZXrmoZQKtCGLVEPs5oOxjyZXEFzoqv6Yuvn6NT hPRa5JjlpMN0x+KPN0OyYmXUbsqhPkNHmbzbaQ19D/OlWdvIpL3Y4IiPZbxCEdbEb5FR 9Fou2b3cV/1eC6zaPEb2+WeB7Nsa+Co9RaMZ+KFcbdScoj51U3+sCb8QUzgcuzdtb0Ub Clrw== X-Gm-Message-State: ACgBeo13W8u3sykT5re25Y3Kr7csFHpiI6M6HetRHH1KuZ8V2T2Chlz9 Pq/aqoy1n1w2ZfZ2wbJcxdA5Lg== X-Google-Smtp-Source: AA6agR6lqDxgMK9JFImwUaoMuhNueyu4AJdfFEi+SBN7qOkfEFKxa/ji1nEoI+8vSCoCDkGlSQ3nRw== X-Received: by 2002:a05:6512:b89:b0:490:34f9:d1c6 with SMTP id b9-20020a0565120b8900b0049034f9d1c6mr8336696lfv.637.1660741434903; Wed, 17 Aug 2022 06:03:54 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:54 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 03/14] arm64: dts: qcom: msm8996: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:31 +0300 Message-Id: <20220817130342.568396-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'reg' is a required property qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'syscon' does not match any of t= he regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qc= om/msm8996.dtsi index 3411ced96db6..166374566a49 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -363,12 +363,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - memory@80000000 { device_type =3D "memory"; /* We expect the bootloader to fill in the reg */ @@ -838,9 +832,10 @@ pnoc: interconnect@5c0000 { <&rpmcc RPM_SMD_PCNOC_A_CLK>; }; =20 - tcsr_mutex_regs: syscon@740000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@740000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x00740000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_1: sycon@760000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3668EC32771 for ; Wed, 17 Aug 2022 13:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239580AbiHQNEK (ORCPT ); Wed, 17 Aug 2022 09:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239545AbiHQNEC (ORCPT ); Wed, 17 Aug 2022 09:04:02 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3773933436 for ; Wed, 17 Aug 2022 06:03:58 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id a9so18891741lfm.12 for ; Wed, 17 Aug 2022 06:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=d81NAUVI3O6mHh9rRCLTkzFGlVQOgUX55hJVWZukNlg=; b=GIFpL+ATcIDKagtSP6rDHeoCcOFWWr/pW8xkg67OgOzuXkmqjQa8TAsgP6d8MPQ7jj qqJg+WFqfoF+EwMmJsCVZ1wXIL63HQvJYQmoIZn7t1jBMG+cTbuPHPOJ0a8Bf2UVJGzD P5FoLeWgBjexMccdTDJuh25nyvBuLT1QXHSP7X/h0SuDotdAC8jOh6Di97NbFpclUJVV eOUj3TyiIrOTofGk3sreML2YYY2+FPy4vDkZFPCARSTHOPYU9qtFFP3LkYk7cm0PBzv4 Qh4wFSS3FtUEZr8xfTPHbwtEgb07HMGEZC6I88DQVM9f1zSED1+cWnM0w54Cza6uW+TQ +/3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=d81NAUVI3O6mHh9rRCLTkzFGlVQOgUX55hJVWZukNlg=; b=IR/D3X1Y3MUEa/75aEZ8IWob9Nk1AwF8sx+bZbHEiBIqAkxEobUq8Cteyy7MMORv1C YtW+jlf2ICqFJnchE3YqsKjJ1FW0qnuQV5aboj+nD56i7yPWL6RvxmvoPbEG20jJLkDB VrMaE0t5AJyQuqh1aTMYgI4DVm5zzsWLxnwYVdtz/oSrBdahke8fqpW6JYepsKkRGEwp untJpuwnOVgCE4ER48FBhmGq9UGkdHpksXd54/zzrHlicW2E2Xj+nPW+9bcpRA+uUh2W fRI/91bObwjVLbPCGJpxzvaKC4zBdYVKUGUwKpxN5EkZkET1OJGYWr6QdoLxqsfeSgDC SXFg== X-Gm-Message-State: ACgBeo1bc+Si7KrqmseZyso5+T69OQT8y5rWBlYTflOWK1Ggt9yzG/lt 3aPda0YHloephjyoGTlnzaLNYg== X-Google-Smtp-Source: AA6agR6s5ElWmktazefBCvNFDDnaenAXi9o0z1jq4dXZQKKmJoPORPpgt5EBridafrYMiKy9WM5w0A== X-Received: by 2002:a05:6512:ac7:b0:491:571c:3ef5 with SMTP id n7-20020a0565120ac700b00491571c3ef5mr7149067lfu.2.1660741436156; Wed, 17 Aug 2022 06:03:56 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:55 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 04/14] arm64: dts: qcom: msm8998: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:32 +0300 Message-Id: <20220817130342.568396-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qc= om/msm8998.dtsi index 02d21bff2198..f0806ed103f1 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1049,7 +1049,12 @@ ufsphy_lanes: phy@1da7400 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0x01f40000 0x40000>; + reg =3D <0x01f40000 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,msm8998-tcsr", "syscon"; + reg =3D <0x01f60000 0x20000>; }; =20 tlmm: pinctrl@3400000 { @@ -1340,7 +1345,7 @@ remoteproc_mss: remoteproc@4080000 { resets =3D <&gcc GCC_MSS_RESTART>; reset-names =3D "mss_restart"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs =3D <&tcsr_regs_1 0x3000 0x5000 0x4000>; =20 power-domains =3D <&rpmpd MSM8998_VDDCX>, <&rpmpd MSM8998_VDDMX>; --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 064ADC3F6B0 for ; Wed, 17 Aug 2022 13:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239639AbiHQNEn (ORCPT ); Wed, 17 Aug 2022 09:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239557AbiHQNEK (ORCPT ); Wed, 17 Aug 2022 09:04:10 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5637356DF for ; Wed, 17 Aug 2022 06:03:59 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id d14so18895593lfl.13 for ; Wed, 17 Aug 2022 06:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Oc1vz9/DWeA4ULM94yDKxE44YQvZ9a9JuzHX3olMNuY=; b=Fc9cabtFx1GJRo4qrTB1EhBZ7hgujc16iVvpb3ePFvG7T1vcX0scRoIps3RRq8NtN+ DL6+dWYcEg3ceKPL2PyTfkrMrW1SnWrgfKi3fyBxqQjjZzjSS/31qwzITB7Df7Dhf6V1 jIO9+VNh21NxuM8sc/hm5JRWUda/hlXtfMpr9CR4EDsrV9pG3PNHnMx9KWtGtZW46dbh ofza/0xET9r3x2cneAdfuR9tA7Q0UMH93VnLod/yHIxs4Imeb62+0unZImweenPvGxxh wIVPnk+/pg495RSGZVTs83+E4KUJnlf5RgrpmMRt6eHsW5C48azxrN/PtQHpd82+WvyS lnhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Oc1vz9/DWeA4ULM94yDKxE44YQvZ9a9JuzHX3olMNuY=; b=M79bQYMSX2/nFLUYfcEhdnlhEbe9e7E0jKsMb4EjHfY1GwG/Opo7jQlBDMocCNT7Nr D0WuKgleI+MvlHphP+M6X2rSH90Mfw7mWzHvMUuB796mj15ZW4NuBx4qdWNWIAl98q7B BuKwoBuBZxs9pUzk6eX9EAw9IPMAYXWeM4Amf4UtUREDrHc3DHxVb7rxhDQrWOlzFojY qEzh6vHuMt/4HzfWD2CHfpmJf4HaEoTZx/RpTYmJzEFPd37TNkL/fsDv/7xugX9ltk32 O5BZshIJjRotg4pWH6kuOgFv55ud5oQkE4W7Be5TkU2zqKVBrGwHIK9hMuu9J/r+SXO2 +Cjw== X-Gm-Message-State: ACgBeo3z9cbHYimZ6k7pluLaG4WGPdORYka9bD0ca7N+/cqbWtrT3bRq gzxdbcMJhrQnPC0ut366IJRSGA== X-Google-Smtp-Source: AA6agR6S9efhZzy0qbQxF1CplVeckdK+xn7G3qkjrDJjItBPaU5fJX7F/Rpvq3DguQqr5p/Ke3w0Fw== X-Received: by 2002:ac2:4c42:0:b0:482:cb18:25ac with SMTP id o2-20020ac24c42000000b00482cb1825acmr9289923lfk.643.1660741437470; Wed, 17 Aug 2022 06:03:57 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:57 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 05/14] arm64: dts: qcom: msm8998: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:33 +0300 Message-Id: <20220817130342.568396-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'reg' is a required property qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'syscon' does not match any= of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qc= om/msm8998.dtsi index f0806ed103f1..22b2da74d105 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -308,12 +308,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - psci { compatible =3D "arm,psci-1.0"; method =3D "smc"; @@ -1047,9 +1041,10 @@ ufsphy_lanes: phy@1da7400 { }; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x01f40000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D62FC25B08 for ; Wed, 17 Aug 2022 13:04:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239570AbiHQNE3 (ORCPT ); Wed, 17 Aug 2022 09:04:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239542AbiHQNEI (ORCPT ); Wed, 17 Aug 2022 09:04:08 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2FC537F91 for ; Wed, 17 Aug 2022 06:04:00 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id z25so18933517lfr.2 for ; Wed, 17 Aug 2022 06:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=vdE5nDV3qdB6mAn0Qwup5zvvjj6Xy+e1DVZdaTpFju4=; b=hbL4Mc0yVll+ohqUSOFIwI5UQgyQ9IAczH/skLzCKCFgstC9xHSqgdFyDWs7reUdHA py4cQCracHpGd4bYfZ0lgsS9wLGJdciW1hzyKhGcnWCu2/9UlYGesp0IEgN9C8tncS8Y dxonBj6qBS7Vz8Cp+xTxTpSsbwpqFzrIXjvVfZorMq9oNOCZM/J9jFsVw3znpTCYiuAC KUCVMRMrFzTTuRxiDuPcbm7GSxOGl0OIDunh8ts6tKX0uaPXBO6LGndw0D/1n8EHReTk dAcszMMKzUYHlaIvY/XO/HWPTkQCLU1FMFyw6qAopt9rrFTVQ4YiRk50/2YeRsqZIUav 9ytA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=vdE5nDV3qdB6mAn0Qwup5zvvjj6Xy+e1DVZdaTpFju4=; b=e+DeXg+1TKIhFm9BL6HFA0c4Kio0BoQAlEf7gWhEuJu3g11BU7+5UJFVgzBmRzuGWU avcfWRaD4ScMIm01TNF0nEsmi6ALe9y8ik38bh9xXBJiWK7P1/od8Vab3IrL+HkZVJEv 5X0ovcYlqBhI121zatC9u2b6jIGkL39pnZaqEhqV7owltg7WL+3htXo9/6YGs3XGv9jm HaLdfF3xJPKBEqCVJjwvrcK01UAQjlDb8nDkE9ldDJPh2EBEvEZjExWTNOri87ffHtip l5RlLOIENxK1pFjOAm2eBfZ/+b2XO7z+46x4TNuDoKXrvf+m6e963GM+4H3qsltlqqLc ucnA== X-Gm-Message-State: ACgBeo0OQ3GcZvS1CQUYgjpGwp6/Al+L6kr2ZAmH8ohdJfEtWvlFlgPK DCg8we+DoupvJeCNgOHxtO4G3A== X-Google-Smtp-Source: AA6agR4TcR6MepQivrVzkp+HkVxK5fgE0thyMcGv9meclAUouUUgdAshS0KF0s85NEVvW9ZPsqBjrg== X-Received: by 2002:a05:6512:2248:b0:48a:f36a:2e63 with SMTP id i8-20020a056512224800b0048af36a2e63mr9118402lfu.485.1660741438859; Wed, 17 Aug 2022 06:03:58 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:58 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 06/14] arm64: dts: qcom: sc7180: add missing TCSR syscon compatible Date: Wed, 17 Aug 2022 16:03:34 +0300 Message-Id: <20220817130342.568396-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" TCSR syscon node should come with dedicated compatible. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index b82c335c25af..49f28cb531f6 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1468,7 +1468,7 @@ tcsr_mutex_regs: syscon@1f40000 { }; =20 tcsr_regs: syscon@1fc0000 { - compatible =3D "syscon"; + compatible =3D "qcom,sc7180-tcsr", "syscon"; reg =3D <0 0x01fc0000 0 0x40000>; }; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3846C25B08 for ; Wed, 17 Aug 2022 13:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239567AbiHQNEt (ORCPT ); Wed, 17 Aug 2022 09:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239584AbiHQNER (ORCPT ); Wed, 17 Aug 2022 09:04:17 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15C7B399F0 for ; Wed, 17 Aug 2022 06:04:02 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id u1so18928101lfq.4 for ; Wed, 17 Aug 2022 06:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DL4opHqld4qCjVSblJBLt63Edv/Ob11xgTM5Drh1lj4=; b=mNTk2jWW7BPZjsiEHfFstCuM03Z30YRzcwqNDvf/vgliYt5PJjHCdjedZ+SToXIRi1 sMUhVGl5i3ltCiHJ4kGNgmqP7Cqp3AdkLTMGt/3LKf1trh0Ony5/9dH9XTKlupZg1eiI UFC9Xsg9KnPjRxygmsSH8m68tLKFF8sY2coFuxxluWZ590HSpEfOJYBsIEcgd8yFfO21 nRcN3f786/KZ15r8BiuM6AxltTSECW1FuYLJuNUW9CHDZYLRFkEs7wqjOb5EeDEKKmut dytda06RcSu8K8/p98yeSQIt7MCtton95J1mk38ntwftc+RjJIvHe58ZQF+OxDj/4Yqh Vnqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DL4opHqld4qCjVSblJBLt63Edv/Ob11xgTM5Drh1lj4=; b=c5/YN7RSLegwWqq8pEbW3Sp1sAJ4Lc4QqV6X0wRWIMP3t9rKM+Fcqpb/iYiRmRhn+g Z24yfa2cX7YzFDGkI+QA66XbRPiUI1awrhC0EBQUMZ95ffEAqD2rgKUlBwIBDpOeZplC nIBEeYzws0kwQQgTuC+NI8YX4d1Wmk/iS5jMWYQ47SFIhoJK/ELULi6T1RCihPlopXpm GvQqhnGt4jJxIdGArLONLQ3mZ4y0xB+Ka9by/Qd+/6NlwtmYEG2icSiA3+CmKYVsQzXi E4F2ij3aLE21hwWT/W+uzbyIZHrF3KENx1c778HuqB9cyrwqruvj5sRQYK+XZNq2+obf 6BvA== X-Gm-Message-State: ACgBeo00dEbIZRF8tnHOk+tCkmwPqdnRZgwlddnz3rkJhO3k0lS7eqj0 +WhuMBslCJguexRJCei3y0CP7A== X-Google-Smtp-Source: AA6agR6+V//N5hqRVIChR7d/APwjJuKhzsEbiuHog+4LSACfqRJoz/zZzCw0gJU//JJ6cDsz8a/CSQ== X-Received: by 2002:a05:6512:3501:b0:48b:205f:91a2 with SMTP id h1-20020a056512350100b0048b205f91a2mr8569143lfs.83.1660741440168; Wed, 17 Aug 2022 06:04:00 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:03:59 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 07/14] arm64: dts: qcom: sc7180: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:35 +0300 Message-Id: <20220817130342.568396-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index 49f28cb531f6..5d2dd21da79c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1464,10 +1464,15 @@ ipa: ipa@1e40000 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0 0x01f40000 0 0x40000>; + reg =3D <0 0x01f40000 0 0x20000>; }; =20 - tcsr_regs: syscon@1fc0000 { + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,sc7180-tcsr", "syscon"; + reg =3D <0 0x01f60000 0 0x20000>; + }; + + tcsr_regs_2: syscon@1fc0000 { compatible =3D "qcom,sc7180-tcsr", "syscon"; reg =3D <0 0x01fc0000 0 0x40000>; }; @@ -1932,8 +1937,8 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names =3D "mss_restart", "pdc_reset"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; - qcom,spare-regs =3D <&tcsr_regs 0xb3e4>; + qcom,halt-regs =3D <&tcsr_regs_1 0x3000 0x5000 0x4000>; + qcom,spare-regs =3D <&tcsr_regs_2 0xb3e4>; =20 status =3D "disabled"; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C929C32771 for ; Wed, 17 Aug 2022 13:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239602AbiHQNFi (ORCPT ); Wed, 17 Aug 2022 09:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239607AbiHQNEi (ORCPT ); Wed, 17 Aug 2022 09:04:38 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25A2239BBD for ; Wed, 17 Aug 2022 06:04:03 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id v10so13479704ljh.9 for ; Wed, 17 Aug 2022 06:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DbSnvFkY9bvjJ+mlDkzyxC4/7mNnK/XqOObaGJH93/Q=; b=DCXz4XYINVpHYEIMfmn91NIOhMiYQDX8amq9srJMdlyklU16yHc0GsXqp2R3vAsKJZ eUB89uRwZgzbpTbLUfup3FuESytUkTEjOH2ayHi4YSEzShHbWCVJ4+X3PT+oafCwmYB/ w0tSfdgooKQUQ2gx3jPmG9jWPs6PKYP1ZARpXJFdmbFKEFcEYjBb6u9YAajQNjGLnSZA mnQ7Tjl/jv0Ik6KktCuqWEmL+gsgPWIlw408Wgh3vOMdanfSEJwJkpvXmlgDMaYKQpcu BQpqJN1KtIfU1armkcIxH0uN2kfHw3oNmSo0ZTTR5I2OCXpWsbnco54oomjKkiLzqYw1 c4tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DbSnvFkY9bvjJ+mlDkzyxC4/7mNnK/XqOObaGJH93/Q=; b=ktBXp+u1XJ7nOak8RdZOHuyGa62R/u6x1L+6ZShhg7GZCFwhuMXXqpJMaWPdkFwc5i gROnwnH1cAlkZnqX6c14eKw8w0ZQ4qpkTMfncRxzFheJCXaxABcNHXFrocfMUCukXQzR IQ+L/HmrOrqYBKwY/x37grJuyzAl3nT6jr5Cv8Hmr2plhixp1EriHylRcT2L1vPznpZS wXHgMRUvE8RGI1dd7TDSF62GsRZ/8fDZqeQdMqAQZcSq7aubN+k10n+WZQqV4nKfFOao llObF70YZH1Dt/EnwWo3aUUbMFPxCRLHGG757JYBotuaAuhnG495FJpp9SEm4+ve2Yq/ 4j4A== X-Gm-Message-State: ACgBeo2foPCFtFmntb017Ldo/TCg2KiH8gidjO527zgTnCnUZKzJPGhr RZPB7sbfnQhI8yk9fAQd9I4CuA== X-Google-Smtp-Source: AA6agR6LJukHMCtjGeJCKZ10+lfXnY0NJek6O2mC9zKYYS73f8w/yuUFVBQrcBJuS3faugWXHdjczA== X-Received: by 2002:a2e:bf11:0:b0:261:9343:fb2 with SMTP id c17-20020a2ebf11000000b0026193430fb2mr3084063ljr.47.1660741441473; Wed, 17 Aug 2022 06:04:01 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:01 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 08/14] arm64: dts: qcom: sc7180: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:36 +0300 Message-Id: <20220817130342.568396-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'reg' is a required= property qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'syscon' does not m= atch any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index 5d2dd21da79c..e8debb0da411 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -555,12 +555,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - smem { compatible =3D "qcom,smem"; memory-region =3D <&smem_mem>; @@ -1462,9 +1456,10 @@ ipa: ipa@1e40000 { status =3D "disabled"; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0 0x01f40000 0 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D10C32772 for ; Wed, 17 Aug 2022 13:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232466AbiHQNEx (ORCPT ); Wed, 17 Aug 2022 09:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239537AbiHQNEW (ORCPT ); Wed, 17 Aug 2022 09:04:22 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67DB63C15B for ; Wed, 17 Aug 2022 06:04:04 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id z20so13508594ljq.3 for ; Wed, 17 Aug 2022 06:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=QCMHKhkVunzbtGiMJ/wq/fYfBgDNCThjx88/COvHDls=; b=iBbyiaFqKTDODYRVXGbUEnyLW64y2b+NXCcGhfcnBBw/8Ll59PGYqsbETO+Ymvq229 fTaHJ8yL/a6f0QlIAZ9lJT7oDtYt8T9P0oYQRJrlvHOgp6wYZRWmtSV+SgYijx+etsy7 Pzkp3S0YAkN/dt+aKsS4L3QHaO9gdZj4y+n06I9taPVq5jt8zkkwgXtlnPXGDJraK1jy LpTvvNJM8V8WpY3rRuIU6vGmF/n2Xwlf9ZMpp4kcNzXiecVQPCr3NTHrMEqlLGArDnFs a4j7X8f/eLt0DzFUOwT73Fp19X2byCbWXExCzXIE4oZrjCCrIBrbfDirqDFnwCu595DM Ea8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=QCMHKhkVunzbtGiMJ/wq/fYfBgDNCThjx88/COvHDls=; b=H0ELQ1v5Oz1U/Q1ZpG+jqrlLIVUw7r0L1dhmGEtH5ykbSVlJLzkZvUS1vCUvBVb33g tRotkW+0l0IKlCbUKKjJ5ATi8Cfpnpv4vsyEGMtobAlHB5Bd1aMvREV8mSq7I1xTT2wv qbn7oujyZ9lC9cJqRKR6MqiaPNAw8uor0sFWPIuUHAXWwBDh8zS5an7CYNUMWLUbweqD Jbcaa0fauM8mCI5pUdpXze8tygzLN+go68hI4w0VOBYFZPalTkxAUCiVyLtMQ3bVR83W t5hPM/MJ6mGpG6HZszwlv1CsG4Otz/uA3tmoElWXnllt5X5KsWTK13UTC6yyEZRBO7to xhzg== X-Gm-Message-State: ACgBeo2QH+dTii5b3P5Cw6/3F4o6VSqZBmyBgHOgWnMX6BgjGj+5MVD1 QwI4ps7O5oZ+4YisBpHoxwEDAg== X-Google-Smtp-Source: AA6agR4voDsvddPVWKd+rLt8r1aP0H5GQ0S4vnExx5ubs+n/b5cZm+o7DR00uvmEZWwy9VfOo90F/A== X-Received: by 2002:a05:651c:12cb:b0:25b:fa3f:c3f with SMTP id 11-20020a05651c12cb00b0025bfa3f0c3fmr8365132lje.364.1660741442798; Wed, 17 Aug 2022 06:04:02 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:02 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 09/14] arm64: dts: qcom: sc7280: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:37 +0300 Message-Id: <20220817130342.568396-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space, and allows to remove incorrect syscon compatible from TCSR mutex: qcom/sc7280-herobrine-crd.dtb: hwlock@1f40000: compatible: ['qcom,tcsr-mu= tex', 'syscon'] is too long Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qco= m/sc7280.dtsi index 13d7f267b289..89a8e6b9822a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2155,12 +2155,17 @@ ipa: ipa@1e40000 { }; =20 tcsr_mutex: hwlock@1f40000 { - compatible =3D "qcom,tcsr-mutex", "syscon"; - reg =3D <0 0x01f40000 0 0x40000>; + compatible =3D "qcom,tcsr-mutex"; + reg =3D <0 0x01f40000 0 0x20000>; #hwlock-cells =3D <1>; }; =20 - tcsr: syscon@1fc0000 { + tcsr_1: sycon@1f60000 { + compatible =3D "qcom,sc7280-tcsr", "syscon"; + reg =3D <0 0x01f60000 0 0x20000>; + }; + + tcsr_2: syscon@1fc0000 { compatible =3D "qcom,sc7280-tcsr", "syscon"; reg =3D <0 0x01fc0000 0 0x30000>; }; @@ -2522,9 +2527,9 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names =3D "mss_restart", "pdc_reset"; =20 - qcom,halt-regs =3D <&tcsr_mutex 0x23000 0x25000 0x28000 0x33000>; - qcom,ext-regs =3D <&tcsr 0x10000 0x10004 &tcsr_mutex 0x26004 0x26008>; - qcom,qaccept-regs =3D <&tcsr_mutex 0x23030 0x23040 0x23020>; + qcom,halt-regs =3D <&tcsr_1 0x3000 0x5000 0x8000 0x13000>; + qcom,ext-regs =3D <&tcsr_2 0x10000 0x10004 &tcsr_1 0x6004 0x6008>; + qcom,qaccept-regs =3D <&tcsr_1 0x3030 0x3040 0x3020>; =20 status =3D "disabled"; =20 @@ -3259,7 +3264,7 @@ remoteproc_wpss: remoteproc@8a00000 { <&pdc_reset PDC_WPSS_SYNC_RESET>; reset-names =3D "restart", "pdc_sync"; =20 - qcom,halt-regs =3D <&tcsr_mutex 0x37000>; + qcom,halt-regs =3D <&tcsr_1 0x17000>; =20 status =3D "disabled"; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21025C25B08 for ; Wed, 17 Aug 2022 13:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239630AbiHQNFm (ORCPT ); Wed, 17 Aug 2022 09:05:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239615AbiHQNEj (ORCPT ); Wed, 17 Aug 2022 09:04:39 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1F873D5AE for ; Wed, 17 Aug 2022 06:04:06 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id w15so13515772ljw.1 for ; Wed, 17 Aug 2022 06:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=G5Gw9O1HRC2HZ2RUee8k0rPKQP+uhhOAxZLOGmh5CkQ=; b=fJd0a7YMv0ZcjMFd3JlFycpH5vDcvehDTH1dHlGQdq8x9ko4JNTkvGo9ShJOog7mea pZt9h/chVYurKMP2w6zu3EjZw8d+9oRjNnvF3mrYkk+2K1uN7tSN+ppst6Hna71YDNTr g3Yymbw8LIPuqTI1ToLs1kLWnoYnR7tCR6kFOiQAq/VtmQo30GjX2wMQS+Fs0DcNIxaG 0W+M2shtPxiUbeSqBBNgEqrsRVFyPIE7DqVbPYOtrZxEg2OCYXh5eZgVqTX5+mpQoe0U U9rkywJHQWN6xxGYl1en/4KuO0lbtNV1nlZdomRFq/43tmyEbvXjRhHRIYJhHa2fj/UQ Q+5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=G5Gw9O1HRC2HZ2RUee8k0rPKQP+uhhOAxZLOGmh5CkQ=; b=hgIe+8D80YEjBaUmoGqtKaO8q5LR+kB/KWsbLHI85PZHrJGHkl+/I+WTJVtyh9I3C4 AuAZTim8cqFNwGXeQ55rKo/5nPjTh6erenevxcSaQN8z0oWGyvq1ur2uU3jg5nQkqdh2 Y3ev3daDrmjZ8q9pQ4dRodzFAmCp2x3C8Vt656+wOsMOgFUpD0oIvKXQBF2qXb/0NDoD XwZdGvGgHdYLW4QbMd1CrzbwbeLJD0E0IhhtKAIi4ERnlsZHcEiaLwfsJpjXWWiBpEBr 1V+vcNmxB7VnjQZKDe4TaLf60e8Cq8CdQls9JcoLTlJzf8m5kNIL4vbwuN0qWmbrow3Y D/Ew== X-Gm-Message-State: ACgBeo2VfBvxDcV5qta4tkXC+Hr9cBYAsP7R1wJi1YPRrvdmjFcyxK3q Z2Rg5i3cuBSpcNQ4LoXwJhpJIQ== X-Google-Smtp-Source: AA6agR5WXQrRTwjt8id+ceIUkD6C8jy56bGansLAj+V88Eet7oi7wGDthsIKYm2iqClkwXLkUy5f/w== X-Received: by 2002:a2e:9819:0:b0:25f:dbcd:3ad5 with SMTP id a25-20020a2e9819000000b0025fdbcd3ad5mr8039858ljj.527.1660741444164; Wed, 17 Aug 2022 06:04:04 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:03 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 10/14] arm64: dts: qcom: sdm845: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 16:03:38 +0300 Message-Id: <20220817130342.568396-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qco= m/sdm845.dtsi index f0e286715d1b..21ed14200986 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -2590,7 +2590,12 @@ ipa: ipa@1e40000 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0 0x01f40000 0 0x40000>; + reg =3D <0 0x01f40000 0 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,sdm845-tcsr", "syscon"; + reg =3D <0 0x01f60000 0 0x20000>; }; =20 tlmm: pinctrl@3400000 { @@ -3207,7 +3212,7 @@ mss_pil: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names =3D "mss_restart", "pdc_reset"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs =3D <&tcsr_regs_1 0x3000 0x5000 0x4000>; =20 power-domains =3D <&rpmhpd SDM845_CX>, <&rpmhpd SDM845_MX>, --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF14BC25B08 for ; Wed, 17 Aug 2022 13:05:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239656AbiHQNFy (ORCPT ); Wed, 17 Aug 2022 09:05:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239579AbiHQNEj (ORCPT ); Wed, 17 Aug 2022 09:04:39 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C0053E747 for ; Wed, 17 Aug 2022 06:04:07 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id z25so18933920lfr.2 for ; Wed, 17 Aug 2022 06:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=v+CAkv8Hlyo2PxpwLaCJcPFqOS7vWYe9QQHHKSYzECU=; b=z2gY6kWdx5thVEWNbyzgP/AV8QjMQfV030JlnCO2kJWlqICwWvYGcK+QYVxh741Jlf gadgcu+vGFl66aA0ey07hG3KsXQeIkkfQghuPqFZrC73X6uzdcs2RBT3XxcT3a+PJ7EJ x96Jca9TD4Op2SX2pfGnvaAekt6NI7ssHth6FWBwIcAncg7zlm2ZbNg76SEyHqRUzmh5 tR5sXvcYMdY9wCcCElJz+n4xhRaz1TI4lyDpvBMaqh8f1vLHFGy+9BCBgSL1PoRw1VEZ tEEgwqhYzf2JKX45+end44U3T5/RC1v7pG9wAUe3y44U0T3ysANHIsuKn0s/U2HwWa2O NwaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=v+CAkv8Hlyo2PxpwLaCJcPFqOS7vWYe9QQHHKSYzECU=; b=dBvFpv4qikIXCmnOcRyp76rb05yyQEJ1ErRWpvl4cRclOqXPyvUCwhKyyC0Fzuk/U/ TgCvUClAmbDtYHJVavlUVsB7CO5tIJRHdfiMlsNEqOQ2ak8UKhWBSghxisb82rDSb/QR vWYVJzC89bszgFVi5a6phodQiokTsOItbgRFMEfAwak1lpuqF80/7VeS9B4N42aJZoaX U6P3E9kKUqElgrY0V3mjE6nscqsrgd8U+huD8i1jLvA16cKLkJPN0uuiw03dk838OJOT Xk6UIibyjuH2WV+0qB5MEJgU/ACkqtrXVm5qFOB6hvjnG2UTTnSq+WSSPs3EoAQyGSqN W63Q== X-Gm-Message-State: ACgBeo0J58OPHfvtC10MA7H/Eo+TfnyEKC/U3/rSZdZ+KUyMrQKKhsy/ HmnAWRp+VrJD2w1P6UXnGIebMQ== X-Google-Smtp-Source: AA6agR6gGaNvA1OCrY5FS5lVoXuUR7cXFbR03kr2uyJ4BWGJd3ujkvni9qmraTptHX7xhHiknZ+wFw== X-Received: by 2002:ac2:4d4a:0:b0:48b:1f80:a93d with SMTP id 10-20020ac24d4a000000b0048b1f80a93dmr8147107lfp.403.1660741445480; Wed, 17 Aug 2022 06:04:05 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:05 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 11/14] arm64: dts: qcom: sdm845: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:39 +0300 Message-Id: <20220817130342.568396-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm845-shift-axolotl.dtb: hwlock: 'reg' is a required property qcom/sdm845-shift-axolotl.dtb: hwlock: 'syscon' does not match any of the= regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qco= m/sdm845.dtsi index 21ed14200986..bd0ec0664283 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -919,12 +919,6 @@ compute-cb@8 { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - smp2p-cdsp { compatible =3D "qcom,smp2p"; qcom,smem =3D <94>, <432>; @@ -2588,9 +2582,10 @@ ipa: ipa@1e40000 { status =3D "disabled"; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0 0x01f40000 0 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A0ABC25B08 for ; Wed, 17 Aug 2022 13:06:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239124AbiHQNGA (ORCPT ); Wed, 17 Aug 2022 09:06:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239583AbiHQNEk (ORCPT ); Wed, 17 Aug 2022 09:04:40 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F6653ECE9 for ; Wed, 17 Aug 2022 06:04:09 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id x9so13482856ljj.13 for ; Wed, 17 Aug 2022 06:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=uPnkJ9CZ7fbXWgaAUcfcWBXaeXKUW7FCT3L0V3onDIA=; b=Fc//ghCPlI2grror3k/gdiB3O/cjHqZyRs6QSvO/7x2zSS9OHfw8PAr62PzduFmqKy 8tFTKsMuhsxltwVTa3VkJlfRoP8v5W3/rDoUSXV7BVYsRdCEcumL2FYRr16R6bYV6LVl Zcflciwi81vjk1JVEMAuBeWY+f7AHICRyqyjqgh4d0uutrhHNMGwX3z98sbR+pwg/5NU GJsUUI1d49xWFqRI7krlV8INsAy7gz5Qsun4CZuOA7vnlFeuUKQVXBYZiXHyYesNO2Qx XiLFgvDYmrB08z4MEa+x75hajHfqIdsioU9d3wDXZEAmsoyLveg4pcfCYcEjHfYtz1xM RJZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=uPnkJ9CZ7fbXWgaAUcfcWBXaeXKUW7FCT3L0V3onDIA=; b=2AxVky/8J+uoH0vnNa28gZ7V3uIHF2xXQjorCs250tqoOjwhIw8wBKUCMzHouuv6lf CHC30FzjmdLYfwWwRhpCcc6ig9rcNZ+NKgGxzCI4fO7q8pPp1ena4ijWZjY8Q0oFzsQ7 LCemW0ZVpo98Vs5udQw6KXdWlyKR8XEl5aqqmxXmuj7wxyn4awytxYacgWoMSw+QN4z/ X5w/JqMEnqvC82QNK5+vdZ/n8ylzYw4Q+zPXPKd1EF50UcxIhyReMfK0daCw6O/M79B7 HddieqtglwawPOuhpGia4YxAooN/6c7LXIuhq0BQ/z/z40w/W8zLo5fTqy9NPdQj9Go/ hLGg== X-Gm-Message-State: ACgBeo34PWWTRWcpsHsmuiWpL/KyL51i+IcqrUeT1W0Bz8YWIW0cGDmB UzBT0G/N5gxyFvWaIl4p1KbW5Q== X-Google-Smtp-Source: AA6agR6istx8JavCEXk3I5CtWbuvh0/no8XYd5sNH5SDdsxtdJ/jifPTQYUQdXQdDn3fvceLZTjHqw== X-Received: by 2002:a2e:7d08:0:b0:25e:c66f:2bc4 with SMTP id y8-20020a2e7d08000000b0025ec66f2bc4mr7530960ljc.22.1660741446898; Wed, 17 Aug 2022 06:04:06 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:06 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 12/14] arm64: dts: qcom: qcs404: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:40 +0300 Message-Id: <20220817130342.568396-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/qcs404-evb-4000.dtb: hwlock: 'reg' is a required property qcom/qcs404-evb-4000.dtb: hwlock: 'syscon' does not match any of the rege= xes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qco= m/qcs404.dtsi index 9ab990061522..3a94eb2cc448 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -295,12 +295,6 @@ smem { hwlocks =3D <&tcsr_mutex 3>; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - soc: soc@0 { #address-cells =3D <1>; #size-cells =3D <1>; @@ -726,9 +720,10 @@ gcc: clock-controller@1800000 { assigned-clock-rates =3D <19200000>; }; =20 - tcsr_mutex_regs: syscon@1905000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1905000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x01905000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr: syscon@1937000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB19C25B08 for ; Wed, 17 Aug 2022 13:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236793AbiHQNGH (ORCPT ); Wed, 17 Aug 2022 09:06:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235930AbiHQNEk (ORCPT ); Wed, 17 Aug 2022 09:04:40 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08B9633E28 for ; Wed, 17 Aug 2022 06:04:08 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id w5so18925892lfq.5 for ; Wed, 17 Aug 2022 06:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DqeinnIMS7tnZ1s/F5WbYXe7dS10PhHD2RlaXqtenk4=; b=i0GvDg8TPViBlqsgSYnRwUvswrg91GsMb+QaX4/VEVX2zBTIOPJt4gpUlxkvcXpBvT xK6+oxY6A3mVE05M0AW4zmDifbsfOCNDRjAH70dyD8TJliMxGLVYLN6Vp8u5xera9IT1 RoEouXPxXYB4W7DoAzax/1F30Pq2WI3Y7jLZO3h8V5s+C7h9aNwK29gPFeZK58PwrGx/ nuQn+j7/AwPxahNDvRsGaG1KtaSXjBkYaa8r57BzaSNVFNE48ryz03CCBznEcwwSdj+6 zsFWcsCqStRuqJKbNDFTU+Owsfv2bZZzwNRCDLLV2gvayHioBcyKT8RLkEu4a9wF4Wtd YRUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DqeinnIMS7tnZ1s/F5WbYXe7dS10PhHD2RlaXqtenk4=; b=5e/8s/TE1RJnKoW9MBTGodxAAVmRhPcXR9Wyozw+sg/XNcYG0/zhedyTIT2CRWQ4N7 y4wKyv2UdKfmL4kYHq/xEv5bNWun98hMuK0Yq6Ql8uDkMBBmaca/jRwCwgxkoZRO5EkS BUKaSH+MRm5zzq7MSDlOx7YnpBw/fFzUCn5K9VY8yyoi21kfu0hgBdt4kYUomFM9duBB n48uFt4SEh6eiqAn936uAor43v+C1s33ZuyHnfPw2DBwyFFnu6TuHej2QB76OXj7taZF lyufGJvKYngv7xQ8efdjAXhCV73msAM/v19RGDpMNERJJU3tGdYiuJO2RCGTwrF5sjjY 0GJw== X-Gm-Message-State: ACgBeo2svZbmFqgUJ2hCc/VOieQIugKmYXOazPw8/6gnbOfgjpzzbm6r oJf4DdKwGCJ5QVOR38rkNs8n1g== X-Google-Smtp-Source: AA6agR5TbOLMn+IOpEsiRnErXR+auYE0jmCcgUOl4UbPjLbAdI9ArIKLFXB3SX2CkDNJG+YlZYa+Ug== X-Received: by 2002:a05:6512:22ce:b0:48c:190f:5c37 with SMTP id g14-20020a05651222ce00b0048c190f5c37mr8321869lfu.564.1660741448295; Wed, 17 Aug 2022 06:04:08 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:07 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 13/14] arm64: dts: qcom: sdm630: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:41 +0300 Message-Id: <20220817130342.568396-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'reg' is a required p= roperty qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'syscon' does not mat= ch any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qco= m/sdm630.dtsi index 1bc9091cad2a..40a40d00eae4 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -697,9 +697,10 @@ tsens: thermal-sensor@10ae000 { #thermal-sensor-cells =3D <1>; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; - reg =3D <0x01f40000 0x40000>; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; + reg =3D <0x01f40000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tlmm: pinctrl@3100000 { @@ -2351,12 +2352,6 @@ intc: interrupt-controller@17a00000 { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - sound: sound { }; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:00 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C64C25B08 for ; Wed, 17 Aug 2022 13:05:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239644AbiHQNFo (ORCPT ); Wed, 17 Aug 2022 09:05:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239620AbiHQNEj (ORCPT ); Wed, 17 Aug 2022 09:04:39 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B92D443332 for ; Wed, 17 Aug 2022 06:04:14 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id z6so18912019lfu.9 for ; Wed, 17 Aug 2022 06:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=GGC6/FAtFLtsPec3v0Z//ulLsaLmio7LVXcsIKWCfDM=; b=Jh4Qy9iXI/c1oGXbZ0lnM/OpRok+s+cFSr4oZ/HZf/Wiu4RDv1f090LKWQXlfy2mQR 8vfSRgiphbSgHJ3xzY7oaBL+nsNpYIbGQ5estuegJ9wB+r3EbUOVo/+Czc+LLXgO+TN3 A5OGKUFN1Ii3mv8HYwxdWOvh9Pi1MazXBN/uX+YK3FyjmtPXKds1PIH9Q7C0fwpHn3mQ tkpzoIfkB5YwAnSZYf5f1q2kSp7fXo5kvFgG+EL0YiE+Tj1qFCwVvaZbFB/cFQpc3/mZ SATiRY3hkH2rApYsAKgOAmGLpPksC2V/uBntzjMrMT18SdNdzu1o/YTbeZhoFY/y/Y2g GFsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=GGC6/FAtFLtsPec3v0Z//ulLsaLmio7LVXcsIKWCfDM=; b=5L0KXm3wXUMbxb3VD/fR2+akPt8gGaEnMV9kNUth2hpCK0jxWuygOAXv1zUMs8MDHM YDGvFaZrJfkbNGh58aq56Tm57v2PaeVzmvcoQwt+4XXM5RcUvzlyQ+8vOd5qF24BsW1s 0p3TB1MhNqJp4IRgXco5VK2yErZGBezfQMUoFS7YYfA58j2fytq805NIIRZC4nYT69oq hMx4BUcpuUXCjyyw1qKh9h5XCxsTkZFhrcdytt9NM3+6b11JfWQjVmO9wEgvFKyTscwk F44Xp7Smbth2/Q9HbgbhXve30eAkK0BmU1W1mgjaOevhwkwcIy/Q6U5hA7SYT7nscOBi uVvQ== X-Gm-Message-State: ACgBeo3hAaJsmf+zMwAJyV7YIx6E9l6+rqRqca9ijlf+nMls/lz4oy9G YUi3FZD5v3guqywlLc01pSbanQ== X-Google-Smtp-Source: AA6agR7FDblqVQT9gybR5hPpqOJr92pA+VUM4Qhig09FQMQsWhnjjQeFyrRKTjyc7K2GZP4L90Ut5Q== X-Received: by 2002:a19:3856:0:b0:491:7b45:7617 with SMTP id d22-20020a193856000000b004917b457617mr5988001lfj.47.1660741449662; Wed, 17 Aug 2022 06:04:09 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id v1-20020ac25601000000b0048b3768d2ecsm1683243lfd.174.2022.08.17.06.04.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 06:04:09 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 14/14] arm64: dts: qcom: sm8150: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 16:03:42 +0300 Message-Id: <20220817130342.568396-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> References: <20220817130342.568396-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sm8150-mtp.dtb: hwlock: 'reg' is a required property qcom/sm8150-mtp.dtb: hwlock: 'syscon' does not match any of the regexes: = 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qco= m/sm8150.dtsi index 7d509ecd44da..dc6770391813 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -585,12 +585,6 @@ scm: scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - memory@80000000 { device_type =3D "memory"; /* We expect the bootloader to fill in the size */ @@ -2054,9 +2048,10 @@ ipa_virt: interconnect@1e00000 { qcom,bcm-voters =3D <&apps_bcm_voter>; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; - reg =3D <0x0 0x01f40000 0x0 0x40000>; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; + reg =3D <0 0x01f40000 0 0x20000>; + #hwlock-cells =3D <1>; }; =20 remoteproc_slpi: remoteproc@2400000 { --=20 2.34.1