From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ECB9C32774 for ; Wed, 17 Aug 2022 12:04:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239211AbiHQMEc (ORCPT ); Wed, 17 Aug 2022 08:04:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239196AbiHQMEU (ORCPT ); Wed, 17 Aug 2022 08:04:20 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 037024CA1B for ; Wed, 17 Aug 2022 05:04:17 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id z20so13361657ljq.3 for ; Wed, 17 Aug 2022 05:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=IB+sPWwaEMPz1OqOHo1E0jzt4v44qohfF0waJg4s+1w=; b=hbHSmbOgPrUflh2qJIINqXaOfHaRrEN3He2IRoZyS/a2LnHvI3KNsB9xVvigmWcXF7 giImKKhZxRbfuZiDPxdX7TRaSyIbb8fvK8tGXezscV3a0j0MGJ2+c7i6RYfB0ddzxCMm 8DkZ1vUgktzWgRTB7GifTszH+WjixTZhz7FYtJdwrt/V+iyec9LmXX/Uzow8Ai7nSxIK 3YxqNOlQyEA5MDmtIc4w5jogg5QusEgFEEEFyCpiRSQ54xA0MxIrUW8M16LmuioQwyhB vikAeo6nAuvfa3bdWK9m62LqP+IuOPZARrHd5KQ91goclHHZs9CrJirjXdu601zFfQ/M h+9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=IB+sPWwaEMPz1OqOHo1E0jzt4v44qohfF0waJg4s+1w=; b=W9sFKlE60W2UFRyFso0BZ1BvPQKQnVdloUBh4WyNR5FVgBTsA/heAjjuofl4c8NMvW VIWFBIEJJ88A6Sm9fbmQ6QwWIzLrXm5RAeKaj3dC5VvQewZ1JebR8NsCdi8gow2tExIt 4A5nHOT2t6ZNazZHfOZworswnhCVmX7VWSltFS9Zj9EKRRBpJYmRAKi/da4hOd14BsaF VLjtZFBvunKXvA2klZ+aB/H7fiVkSJNB8cvKh5r1dlLLru1/pLvvidUj3aG85orS2N7n KJ7yOGn/Xq7obHtcoD2eFAr6tX4rUtYoSVF56Zn1jwVGIK/k9c30WkeeE/uEnAQsJHXh t9UQ== X-Gm-Message-State: ACgBeo0mhUVdYX7Im+haEyFtKSXfZbINs5tHBWZX+kBBvmw4HYD7AT7J MpSVbnkAx5aNZK1BBLJS226Mlg== X-Google-Smtp-Source: AA6agR5fKkvGxBwkL0hj6yQpGY56qpuYYqOvN2B34Y3KlAtc0/6tWAnB8u6Xx03g8ffThw4Yks6DwQ== X-Received: by 2002:a2e:82d5:0:b0:25e:4d8d:4c67 with SMTP id n21-20020a2e82d5000000b0025e4d8d4c67mr7425426ljh.490.1660737855398; Wed, 17 Aug 2022 05:04:15 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:14 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 01/14] dt-bindings: mfd: qcom,tcsr: add SC7x80, SDM845 and MSM8996/8 Date: Wed, 17 Aug 2022 15:03:50 +0300 Message-Id: <20220817120403.458000-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Document existing (MSM8996, SC7280) and new compatibles for TCSR syscon registers. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documen= tation/devicetree/bindings/mfd/qcom,tcsr.yaml index 2f816fd0c9ec..19bc1cc5e0c5 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml @@ -18,6 +18,10 @@ properties: oneOf: - items: - enum: + - qcom,sc7180-tcsr + - qcom,sc7280-tcsr + - qcom,sdm845-tcsr + - qcom,msm8998-tcsr - qcom,tcsr-apq8064 - qcom,tcsr-apq8084 - qcom,tcsr-ipq8064 @@ -27,6 +31,7 @@ properties: - qcom,tcsr-msm8953 - qcom,tcsr-msm8960 - qcom,tcsr-msm8974 + - qcom,tcsr-msm8996 - const: syscon - items: - const: qcom,tcsr-ipq6018 --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5FD2C32774 for ; Wed, 17 Aug 2022 12:04:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239224AbiHQMEa (ORCPT ); Wed, 17 Aug 2022 08:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239194AbiHQMEU (ORCPT ); Wed, 17 Aug 2022 08:04:20 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B18A64C62A for ; Wed, 17 Aug 2022 05:04:15 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id l10so13343515lje.7 for ; Wed, 17 Aug 2022 05:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=ReOjLSRdM73U3T0jSSkVf1kkbc1X9kpMxiIghbKwlM0=; b=z0TsarAxIowZ9kSH9JdfzT94ayGy1+6y9CBhIAvRIXYPpHTdcOP2rigvWy3itZufME R0TagUtnAhzsaNXXZGhTU/b7hPmV/r50VgkD0Du020fiGzIJi/tjt9ivXGzNOMqL04vZ 8Wjm3HK5lgRcW5JryJas9fiPVVEc+jtjecO1I9BtrYCxZM9pGvtCksp3+cmPfFqwfZ3x nqxKnPrq8YbmUtV28KGB5vNetemnGIYXsP3IYzORMDW1GqPgT8TBcWib4MBWX5WM4Nsl AbhGOzqQ0OwmWs4tGwE8KdRKtj/38oSsBXzWP3rKcfg9rQvidJJgIxtw3UC0GXv1ACV/ 9mww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=ReOjLSRdM73U3T0jSSkVf1kkbc1X9kpMxiIghbKwlM0=; b=n442gCkh1//dXy849hsWqTQ19k/CzG7bMZvoyylbT1Z34r4gptEJKb4o746uQz8V+k 2bSBBOlAS13DPMBaS2KuIlw/DfnfWMbOMg66ZUC26xo9KkL/ANtUw5r4Nv7ca0oSZrJ7 UfYOBH9ixaKYFHf15/cCylV1T/79CUeqiHZQx6K9AyfAnkZHuSOa91Z1PYhvHSF0cIYu vqSOuyROKA6zUBeRyy+zzsZ/XeLvD32s458W3zDyDsTczfQxqGg7p1lqLw1t123HWNCK hDI9GOiPa77LRInqF6FLmKN/jYcP/zFpbg3b8XMrBzJn5Fq60dsGV1Ac2F8pC66HrRhc 07nA== X-Gm-Message-State: ACgBeo3tyL3Pr3OVzHqpC4vRkvEARR1Jrx4Mf1ehdkJxeaXbrjjTl9M1 jOuXsaEQbk1cpGKgY81mLMfHRw== X-Google-Smtp-Source: AA6agR4HaRuQaKBpbYd2r7g/Qd0i+GDhUEFiJdCWvdd78tKYkxTUqpJzc2jYZuh9mukaJIWD0s2AIA== X-Received: by 2002:a2e:b911:0:b0:261:8189:64e7 with SMTP id b17-20020a2eb911000000b00261818964e7mr5077716ljb.179.1660737853970; Wed, 17 Aug 2022 05:04:13 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:13 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 01/14] dt-bindings: mfd: qcom,tcsr: add SC7180, SC7280, SDM845 and MSM8998 Date: Wed, 17 Aug 2022 15:03:49 +0300 Message-Id: <20220817120403.458000-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Document existing (SC7280) and new compatibles for TCSR syscon registers. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documen= tation/devicetree/bindings/mfd/qcom,tcsr.yaml index 2f816fd0c9ec..849295b058b6 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml @@ -18,6 +18,10 @@ properties: oneOf: - items: - enum: + - qcom,sc7180-tcsr + - qcom,sc7280-tcsr + - qcom,sdm845-tcsr + - qcom,msm8998-tcsr - qcom,tcsr-apq8064 - qcom,tcsr-apq8084 - qcom,tcsr-ipq8064 --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E50CAC2BB41 for ; Wed, 17 Aug 2022 12:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239236AbiHQMEj (ORCPT ); Wed, 17 Aug 2022 08:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239205AbiHQME1 (ORCPT ); Wed, 17 Aug 2022 08:04:27 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD124B4B5 for ; Wed, 17 Aug 2022 05:04:18 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id z20so13361718ljq.3 for ; Wed, 17 Aug 2022 05:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=7xLpyvjcjxtFjBdq2TnMTpFX2axCPt8X9rBvt8vK73g=; b=OCl7RP5B3diVVIlZ1sxJjymAcMtuFqHzkuw+8yc3snwyOed1ZRJArA+IcW+HOA9oEQ f+ratGG0lP05xhtuZF7AXUso/5Wk9CTIpfEa5U9b/5Jntj6Cn9YKqyaoLEEAN/bkXfjL LPSASlUxzjjGKsJe1/Uw0HObPUepsMzaJHO2AqwyWMQ4JhkMUwSkAcq/3u2sMYnDyWRX qq2kAMMYaI2yFimpgYDtfNzmRVW7B9ZQg4hdMxyFZeyEmMcw7Vz3AQQ3xstDhU55vtxP NdBz0C3oRDgZ6X1/nf8OuxNNA7LYoF1mYy3tA5cXk7OQKrX7pDtZoKeHTgEsluYdyAqj m6KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=7xLpyvjcjxtFjBdq2TnMTpFX2axCPt8X9rBvt8vK73g=; b=ZuQz2LW1m1BShnBF2mNUOdW9xAH8lhlKKPR/bjQF7AdfRFjxk9yOZPRsn0sceIJcLJ bgJhnpgYKqMxMyf/BU07RMVvL/4o2LFTp51k2oClDX+6habnhBpyB50bUnXsnr/wquY8 8zGSBi35yGUK4sooqb+97O+Orj3rbLcJQHZobrY7NvLbWwxOqUVjh4/sPEcSn4DoPw+v K1ZRZM6apw+YFE9nVla5JkSsK0As5Ft15nNRj/4RQs1CwvDKszJNDa8nQ84Ego1rgg/F QUie5LjCDXTKw4ExwQTXSBAWD+4l1VL+VhZa7VzfJzKLqKPs0fBOxtm7e/bqbMe7btif eW0A== X-Gm-Message-State: ACgBeo0G4Wk5NvrGbjMyURdbsMXBGEOadxn4o+RPxPeJug7zW+MZOjIx 5Gd8vgxiTy7zMRd8myVnOe6eoQ== X-Google-Smtp-Source: AA6agR5r2qyeSvJtZI4WU8K3RqHXaRKZJMrxzhGEoQa7yoh9SaWiOmc56Mb8c6MEpg1WwJ1mGXbGHg== X-Received: by 2002:a2e:a552:0:b0:25e:6fa1:a6c4 with SMTP id e18-20020a2ea552000000b0025e6fa1a6c4mr7374386ljn.90.1660737856798; Wed, 17 Aug 2022 05:04:16 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:16 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 02/14] arm64: dts: qcom: msm8996: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:51 +0300 Message-Id: <20220817120403.458000-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qc= om/msm8996.dtsi index 742eac4ce9b3..3411ced96db6 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -359,7 +359,7 @@ opp-2150400000 { firmware { scm { compatible =3D "qcom,scm-msm8996", "qcom,scm"; - qcom,dload-mode =3D <&tcsr 0x13000>; + qcom,dload-mode =3D <&tcsr_2 0x13000>; }; }; =20 @@ -840,10 +840,15 @@ pnoc: interconnect@5c0000 { =20 tcsr_mutex_regs: syscon@740000 { compatible =3D "syscon"; - reg =3D <0x00740000 0x40000>; + reg =3D <0x00740000 0x20000>; }; =20 - tcsr: syscon@7a0000 { + tcsr_1: sycon@760000 { + compatible =3D "qcom,tcsr-msm8996", "syscon"; + reg =3D <0x00760000 0x20000>; + }; + + tcsr_2: syscon@7a0000 { compatible =3D "qcom,tcsr-msm8996", "syscon"; reg =3D <0x007a0000 0x18000>; }; @@ -2413,7 +2418,7 @@ mss_pil: remoteproc@2080000 { qcom,smem-states =3D <&mpss_smp2p_out 0>; qcom,smem-state-names =3D "stop"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs =3D <&tcsr_1 0x3000 0x5000 0x4000>; =20 status =3D "disabled"; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C804C25B08 for ; Wed, 17 Aug 2022 12:04:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239243AbiHQMEg (ORCPT ); Wed, 17 Aug 2022 08:04:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239207AbiHQME2 (ORCPT ); Wed, 17 Aug 2022 08:04:28 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4A5B4D166 for ; Wed, 17 Aug 2022 05:04:19 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id bx38so13322817ljb.10 for ; Wed, 17 Aug 2022 05:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DmgjoU3ZwmShD+iuLbm/N6H6WPhywoNwmKzID5e5568=; b=j/QnFP4W4/aHt9WeYXXpq/i3mE8ytEu0XXcD6vrAlm/2ebp/72isn/wHDJpyGGZySm INKCpl1NSLTrfpDYofC4eskzicQo8glDFvPt1YDtdU+/lWVTqd0knSXiG50CkvQM/kui oYcX936jAbvkqP3TFwny0FKcFoAk6WgUpVqRptwBt74Fg9rNK2p3z5j7uKq5XYLjR2qR 111dk7lQzoH3wo+b8QJLBvnFopMMXOoy0iRFhLYjmGqzKic664AWx507p12to5fhwsT7 kIs/QRuLCraUolYhQmqsAGemb/ySIX/CoW5kzBuxDelUee5k6sv6xm3lM10njXwI1Hyy Ddvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DmgjoU3ZwmShD+iuLbm/N6H6WPhywoNwmKzID5e5568=; b=Nc7PWcoB8CyriR6Q54n6a8/GNdJjBJQsJcAsQlJstiluo5Go5eZAY2ZXRs8qzggkrn XXQYjmK63cGeA4GFaGNx8UBUIBvu0s6Q1vc1Nnib34owRK/2Vx1zMBMdA2WxPUetQdpq flxWj0khsymc2K0heLoKIUozWgiQGc0+XYUq0CLptt6C3bWKpZKwDu/Mnus+hUY0aIz2 IF6q33okNMDHdO5sR43aNAE0C/jksm1gt/K4pj32nm4yd2MoLSvh8z7Aen0+f0cY7k0E nYJ+bJWyBB8VFqlxjvLIyGIB6FUmTbSL35ZlTnzKri32YsUNCfcs9vbLwDXs1Q6mDK32 DxNA== X-Gm-Message-State: ACgBeo3Hk3TxRM9xDVVJ3bIbdz4wpjsdNlhoyDQ53ABBvk/oJlhepyUv vqaSbXnYeBcGEk1kbM//2u3BgA== X-Google-Smtp-Source: AA6agR6I1w5MNcoo7t8sGOgTtQ9uIgjNN68nM8xwTvZCFW+XbogVVwEdriDsOLVKVlwF05vdl3PWsQ== X-Received: by 2002:a2e:8188:0:b0:25e:4ae6:5503 with SMTP id e8-20020a2e8188000000b0025e4ae65503mr7460455ljg.412.1660737858207; Wed, 17 Aug 2022 05:04:18 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:17 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 03/14] arm64: dts: qcom: msm8996: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:03:52 +0300 Message-Id: <20220817120403.458000-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'reg' is a required property qcom/msm8996-xiaomi-natrium.dtb: hwlock: 'syscon' does not match any of t= he regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qc= om/msm8996.dtsi index 3411ced96db6..166374566a49 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -363,12 +363,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - memory@80000000 { device_type =3D "memory"; /* We expect the bootloader to fill in the reg */ @@ -838,9 +832,10 @@ pnoc: interconnect@5c0000 { <&rpmcc RPM_SMD_PCNOC_A_CLK>; }; =20 - tcsr_mutex_regs: syscon@740000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@740000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x00740000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_1: sycon@760000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1828DC32773 for ; Wed, 17 Aug 2022 12:04:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239266AbiHQMEn (ORCPT ); Wed, 17 Aug 2022 08:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239215AbiHQME2 (ORCPT ); Wed, 17 Aug 2022 08:04:28 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A10684D259 for ; Wed, 17 Aug 2022 05:04:21 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id u6so13350156ljk.8 for ; Wed, 17 Aug 2022 05:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=d81NAUVI3O6mHh9rRCLTkzFGlVQOgUX55hJVWZukNlg=; b=O5fDAXAHPeoUaYrEtDaUax7G81BrEIS1GD2raYLyy2z0UnXG590QYeBcIpPci5Hfwi y8XODPOEh0iIZJqhxkVQCQYxsknov/nV2qf+XO9QB/MVZLuu6W5URKsFK48qhYxm+PNd ZyLMG4TzoVTUD/w+47OlgaBNByS43kUYyc4qSRJ97kgiZbINhTTwsPZUL3iYU28x86BU NECJa2pnRKa0S/e8inilSWhA6NUvZFAUvdKJz9jOAQpMRN3y2xkW8mmylpZ1JbN3wUr4 gMpEmdMTejgyNT/oJqTu7NW1NfeYaOtmHzzxWuuXGfvinl1qYAr1Snq8OPUtejGAJwLF Vo0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=d81NAUVI3O6mHh9rRCLTkzFGlVQOgUX55hJVWZukNlg=; b=lPMaGte6Njb02T396Fvk8leF658y9ZQfPluKh+icyOYVWw+zHeX82F8RFqfKoCcC1R q7/Py9v9ns6a979Yk1AaeqFte71xWOWixISN+/RO6C4bIpopxv36+gdjDdZU31pz+NOl KGx2Nz31bZXgQ3FcMALesSDEKIkAbhqx0LziKyU9XHSajI35OIFxvmZDeRENMk92TbLU BRVeGSNgHbV02ASkjaIVItTyWuLEet9xwdlNARF2Y5YpPeMn6pwCFqOnzqd9rU1MilIs 4nbaT9r3Og8G3DJrGY7c3bqEIeHYFEwfXkzdt2q/pbK9YjDa5fNA/I+Ox8BpR0BZLmT8 jpHQ== X-Gm-Message-State: ACgBeo1FShqCyctnowMlg3Dd5Kiav++ZzbwaXw9AGRYuSwEjkF5zLuLp kIOFg/+XkFEo0080HsH9tIaM7g== X-Google-Smtp-Source: AA6agR6u79wvYDGUZO0tZdytxlWZ5j1jtPZwx3ppR2OhdecQ870NyUimRspfcWf/hGog/YX78QVQuw== X-Received: by 2002:a05:651c:1149:b0:25e:6918:22bf with SMTP id h9-20020a05651c114900b0025e691822bfmr7770720ljo.258.1660737859951; Wed, 17 Aug 2022 05:04:19 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:19 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 04/14] arm64: dts: qcom: msm8998: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:53 +0300 Message-Id: <20220817120403.458000-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qc= om/msm8998.dtsi index 02d21bff2198..f0806ed103f1 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -1049,7 +1049,12 @@ ufsphy_lanes: phy@1da7400 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0x01f40000 0x40000>; + reg =3D <0x01f40000 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,msm8998-tcsr", "syscon"; + reg =3D <0x01f60000 0x20000>; }; =20 tlmm: pinctrl@3400000 { @@ -1340,7 +1345,7 @@ remoteproc_mss: remoteproc@4080000 { resets =3D <&gcc GCC_MSS_RESTART>; reset-names =3D "mss_restart"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs =3D <&tcsr_regs_1 0x3000 0x5000 0x4000>; =20 power-domains =3D <&rpmpd MSM8998_VDDCX>, <&rpmpd MSM8998_VDDMX>; --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF085C32773 for ; Wed, 17 Aug 2022 12:04:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239286AbiHQMEs (ORCPT ); Wed, 17 Aug 2022 08:04:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239190AbiHQME2 (ORCPT ); Wed, 17 Aug 2022 08:04:28 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8E4E4D269 for ; Wed, 17 Aug 2022 05:04:21 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id y23so13315728ljh.12 for ; Wed, 17 Aug 2022 05:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=Oc1vz9/DWeA4ULM94yDKxE44YQvZ9a9JuzHX3olMNuY=; b=JOw7aJug/ittMZM397qQMP7PNTssn5birDsiYlSxKAIqKhSQbv6lAKSCuZs95wxO7u 8FDAG0U7R8LOo9kZ7FFgm9Q9JuT7uHTTFwzZ9oAwMAtJJHrHXYlgKkcPW3/AkUN0Ujf2 Wr6TLPgDUKOUfj7nXJvmDzUt1/IXwFXHvsecnB3oeQ/Os3tazhB4kdHZQQgotF1G3Ngz 99fq5R5bD2+xvF+cL1hXtUV+2f9iB4f6E00rg+b9g+fpkS7Mt1W0bd6isEXx1ppHrpYZ ncJeSD7TfMTnBdzzNGgvaIKyYEEbfaNHXeFqE0C+aGkAJEGSJn2Zk26nhCAZax9vyn95 SCPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=Oc1vz9/DWeA4ULM94yDKxE44YQvZ9a9JuzHX3olMNuY=; b=lC/eTarYtAkTaMs9HU4TvZ11edNxlThsfRpgxfd3q3cJS0zL9gcS4n4HvH9Gl75MjI MdBLR6kvAIONgMRT7lRn1k7HV25Mem5YO4FmGNQnfRioM3Pm/A6nHQR1pKqjQOpY4Nir v8CSBDqZ+DwLCVq1mWT5pJLiSB3wozLXQiCsgZrzvTT61yPA9cDSiy28p2sJ/85+UuMu 1ln6C3xjgUGLELEXCV4zeuDvocf79eJOIpb3Fy+YOeVgb0E7u2JsGyCPSJEyi/3/hAva vv+Yh3ggULjJpOCPpdCF9kxzaCiMPHszhay//S55AYxM5gWLNLtRMIkL1be2fmlZLLmS gryA== X-Gm-Message-State: ACgBeo1xn/Tu+SZHPpn7WLjz6iv2dTGQvGOvku3WOP3IVtFIpc3m1p7s gF5yayYXFB1Ol7fgrztFohEWag== X-Google-Smtp-Source: AA6agR76QSaUVvbpXrRlU59d3Q0u7kPWVrRH4iu47NsubtYBm+HnQouPetdXzqwxfxU/2nye1BF8+w== X-Received: by 2002:a2e:90d8:0:b0:261:7ffd:2783 with SMTP id o24-20020a2e90d8000000b002617ffd2783mr5628856ljg.59.1660737861398; Wed, 17 Aug 2022 05:04:21 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:20 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 05/14] arm64: dts: qcom: msm8998: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:03:54 +0300 Message-Id: <20220817120403.458000-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'reg' is a required property qcom/msm8998-asus-novago-tp370ql.dtb: hwlock: 'syscon' does not match any= of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qc= om/msm8998.dtsi index f0806ed103f1..22b2da74d105 100644 --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi @@ -308,12 +308,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - psci { compatible =3D "arm,psci-1.0"; method =3D "smc"; @@ -1047,9 +1041,10 @@ ufsphy_lanes: phy@1da7400 { }; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x01f40000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D11C2BB41 for ; Wed, 17 Aug 2022 12:04:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239245AbiHQMEp (ORCPT ); Wed, 17 Aug 2022 08:04:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239226AbiHQMEa (ORCPT ); Wed, 17 Aug 2022 08:04:30 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6766E4D81D for ; Wed, 17 Aug 2022 05:04:24 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id d14so18703064lfl.13 for ; Wed, 17 Aug 2022 05:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=vdE5nDV3qdB6mAn0Qwup5zvvjj6Xy+e1DVZdaTpFju4=; b=MothkAULivGE5t/I0REdZsq/qGcfROwwWXGp3na9KFPPN4Zy+AkQjk+a0Y/7uxdNOK y/rd68UEDiJfDd0k1X+s/+W6B3oJ5LIBi1a9jWW+YazHaXqsR3/YUGwwQBjXpbAe26uP nE0ccEQodw2lbJNqg1kVJ/yaAQ+A21DtE8dwpVhuwiu6exZ0hTA8CqOiV4sZrK4KAzwP 66VRRSHWybNDC+CrLzUjRS/OdXMY8VbZCML6lXC5+LWyToW6/2AN9MPoeJ8KWZcH6Foo 3HkrBrZdUgQ/09M2nvkN0Mo6EDYAi3fjdXf1H31qUq0lD1Phz3ECJx5937M6XEQGIgc1 Q+1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=vdE5nDV3qdB6mAn0Qwup5zvvjj6Xy+e1DVZdaTpFju4=; b=aVNwrfqyGUgrZzcYeHlJj68qH2testrxzE1RBfv8D8YipeAmOYt5Lu5+l+32rzkrLs aWYPAhpr2riM6VMozOfUanzhdpHadD1uIIl1KWa2XiXMoEprhgObG09wmRWe4GbTlyEZ vgWPfrMGhHL9CPbvtOyGDFDeaLSRvTc1c6vYsUtWG6/VIa9c1YgfmV5nCXo0oQWPxG8G kGQR/Pu82Ik4BmxkEH0nw1bXGSwLVFpxF3KtC48WgGX5jWs3T28qiOWe5PXm+WzyuD2g z61jP9EaYxug2Wc7YDM6K0OYf1GwsprYNOZ7GHy5LlK3j7E1fXl9SzxrKCAO6xr3XCj9 EARg== X-Gm-Message-State: ACgBeo2k+tl1EO7YK+ga1o86yPyJ06NJBKkLZYfPCw4oArZ1Q7h7Kx/k nRpG1tAJURJKQYt7uKI1nEKvqw== X-Google-Smtp-Source: AA6agR5OKAEP8ghN+km9ORmOMDn8PGCxJIGdj0PByz2HcfuUHt9EcrDunP64yn9/DfeV3R372TNFNA== X-Received: by 2002:a05:6512:3c8b:b0:48c:ffd4:a8ce with SMTP id h11-20020a0565123c8b00b0048cffd4a8cemr7954884lfv.628.1660737862807; Wed, 17 Aug 2022 05:04:22 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:22 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 06/14] arm64: dts: qcom: sc7180: add missing TCSR syscon compatible Date: Wed, 17 Aug 2022 15:03:55 +0300 Message-Id: <20220817120403.458000-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" TCSR syscon node should come with dedicated compatible. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index b82c335c25af..49f28cb531f6 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1468,7 +1468,7 @@ tcsr_mutex_regs: syscon@1f40000 { }; =20 tcsr_regs: syscon@1fc0000 { - compatible =3D "syscon"; + compatible =3D "qcom,sc7180-tcsr", "syscon"; reg =3D <0 0x01fc0000 0 0x40000>; }; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9696C32772 for ; Wed, 17 Aug 2022 12:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239299AbiHQMEx (ORCPT ); Wed, 17 Aug 2022 08:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239235AbiHQMEf (ORCPT ); Wed, 17 Aug 2022 08:04:35 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 239AE4E630 for ; Wed, 17 Aug 2022 05:04:26 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id s9so13342838ljs.6 for ; Wed, 17 Aug 2022 05:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DL4opHqld4qCjVSblJBLt63Edv/Ob11xgTM5Drh1lj4=; b=U2Jpcx+6tKXhMdjtMZqfWrRNWoL3zSXnFX/6QxN/18h95toNTTH0X4ig3QhdDQyqWd TU1N5xdIDsBxDLNUElGF1XL0Tp+oUdOHqnqv+ltREiWU2qV6wQ25QqOE6CDDmrGAuRDP e3Yba/VEDsWHH6WydK5P1D0XZ0VE/KJK0Dw7F5FgjwFp88k7+xYZgH44HGzUJqDQ+2o6 pEvwwifG4hcqO223C8431alSDRFQ9A2GT7024e0XUL9tFS+A7tzNONQIxufkGIsv/foL r9bDtpQXHUCddwgce7Uho+0jmP02j39CD4Kf8Yc1V/VZRWwXyQ4NgA5B3mm+3WudcK7a qi7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DL4opHqld4qCjVSblJBLt63Edv/Ob11xgTM5Drh1lj4=; b=5WRReFglTFuh5eJJqSPN7mgL7GgSK3SYj1qxLdYNI9NvqlNCCcDqBpmDHF9CG/2Gl8 vJ/9Y7kbJ2uOVJDRxTPEPW0b91P+10n4gkIa5JnERf1CPimSZWa74sbOU2wuVn5H/8i5 r8jhYD4fGUw3BiYIL7eqEeJu6msuiTM86GeRPyZKlNlcoqS1KQNz3stwf6KNlcu+tH74 mapOYljkkM1GX+xg7kGYapFwjLe6yT+ul9tLw9Osca5vM13naRl8P1GVmTZnXWde2Rjf Ls+x44sKW/LYO0jQQfq87M3a8Rz81j31VcBdLE4BKVBmwMkncMRVvUr+IQsAQLZexKJ9 +y7A== X-Gm-Message-State: ACgBeo26VneJ4qxkreT1Rcxbhm/mZ6UDtB370/Lmk194IU6wxxew0MRW uspJ8rgAnk1BvNgAeB0/CxXvAQ== X-Google-Smtp-Source: AA6agR4EfDgBjPb1aBWDeDqMamM4ROl/UhQom14B0yGPr97jZN5jxsD8NtrDo1Hl9u/Rw4HQgueDmg== X-Received: by 2002:a2e:597:0:b0:25e:4a64:1628 with SMTP id 145-20020a2e0597000000b0025e4a641628mr7626153ljf.378.1660737864392; Wed, 17 Aug 2022 05:04:24 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:23 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 07/14] arm64: dts: qcom: sc7180: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:56 +0300 Message-Id: <20220817120403.458000-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index 49f28cb531f6..5d2dd21da79c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1464,10 +1464,15 @@ ipa: ipa@1e40000 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0 0x01f40000 0 0x40000>; + reg =3D <0 0x01f40000 0 0x20000>; }; =20 - tcsr_regs: syscon@1fc0000 { + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,sc7180-tcsr", "syscon"; + reg =3D <0 0x01f60000 0 0x20000>; + }; + + tcsr_regs_2: syscon@1fc0000 { compatible =3D "qcom,sc7180-tcsr", "syscon"; reg =3D <0 0x01fc0000 0 0x40000>; }; @@ -1932,8 +1937,8 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names =3D "mss_restart", "pdc_reset"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; - qcom,spare-regs =3D <&tcsr_regs 0xb3e4>; + qcom,halt-regs =3D <&tcsr_regs_1 0x3000 0x5000 0x4000>; + qcom,spare-regs =3D <&tcsr_regs_2 0xb3e4>; =20 status =3D "disabled"; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72799C32772 for ; Wed, 17 Aug 2022 12:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239248AbiHQMEz (ORCPT ); Wed, 17 Aug 2022 08:04:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239240AbiHQMEg (ORCPT ); Wed, 17 Aug 2022 08:04:36 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B5A74F651 for ; Wed, 17 Aug 2022 05:04:27 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id u1so18735807lfq.4 for ; Wed, 17 Aug 2022 05:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DbSnvFkY9bvjJ+mlDkzyxC4/7mNnK/XqOObaGJH93/Q=; b=VMufVlr3u+pUoXDgiGfPz3XPbBKafmaGKzn6bmaiKba1I9hURUbjKqgBD+zt+6qIze mfMFjg368kc1fsOcLA9OOX9n2WPX7rdgGCNIH8zYVuacBApl820j5gHk5HmoLYZEER97 G890T7nHXRfei3vKzNwaeJ9chudhIKO9FSjEDLZp6eFNMKP4PXp7j+M6tNzR4iHB09hs RT8kt3uhjfvG6Ib6KqlmOsiwXjJp7p3kpS6LvLD/mjTwGp0syZBVuhaBSFlUVgT9rJC3 3oOMQmK2vGBr4Wxd/v++GFjJbylPmlfrhWbV7spBctETRf84nJh2hyAXrmUxgbnPclNL tBDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DbSnvFkY9bvjJ+mlDkzyxC4/7mNnK/XqOObaGJH93/Q=; b=OXeQx0tvuMdP06O7wH3OKvmAXUCKI+TrsBkZ4kEDZV5M9ZoBvg//FyYtHDdJgQfqEZ O6RA4dYy90Oeblbpv/uuyJbltt+zz+KjBRmTZcm4yPIahybsZlzZUh/Kp+4Ss2cvT5sf Dfm3aalFvr8lC9jXVmFsXI4NIlPj2nLJBoDYOhx4Hvel9v6Tqqqr1jytqFLRG1Bax+bY tLbW60AdV8i3HbcBoPt41Em0MAmzu2CPNu6n0YouPBtgnpvpA30G8PnybSxJujo8WpuO xgJxp/HOOnpDMW62iC9O0xwe8LmjC1zH4HSOARINSm3zytfZrV/R0cvuQR0rpSYuSVmS zzMw== X-Gm-Message-State: ACgBeo0ITHGU863fYhTeC92skn0veZQcyxSyPwDwgCEizu45dUoqkmUy i6LxRVS8iOwq4PhJk1z/qw0wEQ== X-Google-Smtp-Source: AA6agR5iQBUte+94JslVCBUtz7QXQfDuFjA1iFoSnomMCkgrjB2XEOCZ7NyAh6iO+SvCaj0s605HRw== X-Received: by 2002:ac2:499a:0:b0:48a:e96b:9f66 with SMTP id f26-20020ac2499a000000b0048ae96b9f66mr8259895lfl.12.1660737865730; Wed, 17 Aug 2022 05:04:25 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:25 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 08/14] arm64: dts: qcom: sc7180: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:03:57 +0300 Message-Id: <20220817120403.458000-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'reg' is a required= property qcom/sc7180-trogdor-wormdingler-rev1-inx.dtb: hwlock: 'syscon' does not m= atch any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index 5d2dd21da79c..e8debb0da411 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -555,12 +555,6 @@ scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - smem { compatible =3D "qcom,smem"; memory-region =3D <&smem_mem>; @@ -1462,9 +1456,10 @@ ipa: ipa@1e40000 { status =3D "disabled"; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0 0x01f40000 0 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD114C25B08 for ; Wed, 17 Aug 2022 12:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239281AbiHQME7 (ORCPT ); Wed, 17 Aug 2022 08:04:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239254AbiHQMEj (ORCPT ); Wed, 17 Aug 2022 08:04:39 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0149D4D164 for ; Wed, 17 Aug 2022 05:04:28 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id a9so18700621lfm.12 for ; Wed, 17 Aug 2022 05:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=QCMHKhkVunzbtGiMJ/wq/fYfBgDNCThjx88/COvHDls=; b=jMVMljrAXcYn6hVHQqGcd6DmXZC3bnx+dOnbvpw03W+hSQ1yLtV0yLSF4E0K/vW1PH oalzUaSW36/TGpx1jvmKYfJnOc4cgVr4qtZeIyKFcSEM2D+P81umCkxaU2W3uAXwr6uh ee/qbI/7n8m0SzL5Foh+yEM0axQYOjoy0oTPG1c65x8yk5pvaDFmBuBgJ5U6/X4Havsr mnSeAsv5VFRGZr88sBTI7F7D3sawGuq8j48d28YDpkyobzHE/kJrD/7xJmTB3MjKGsu6 ToSYcvWwkrQufRZReX2PNGrqdAhOI1W52Om5OJriqZj3FC7u++OGv1HXos0EixfwxHaD 2NGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=QCMHKhkVunzbtGiMJ/wq/fYfBgDNCThjx88/COvHDls=; b=jQxYW9ySRL3NR8So2JVE023PJUWUM63+3k5KrpFyWlDytuaRXlZq3j6eivt8bVYU00 CjBqcWOjU90FINHyAA3Ft39oFFFqhNIRq9gFukDRYvxcB6jSpPigiC+jfpkx6zkSwbZF eIz5jvWfaWVLlLbueb/21EDLFQrGotodRUDR7lLdKf1J5tsr1zdtidVC+HR/PJgurkL/ ON1dhR5YplNL/0Whgvg+/ZeChv1Q+0X1Pv73usmKErjTG9kkHoIGrGA9LFQN8wH4bKy5 3IbhZ+CzVyC/4p0be9uzKqNlgdgpf1acqZxaYmGnATyMGLBSrmRLE9BtimZzjDBAsTuz HU9Q== X-Gm-Message-State: ACgBeo3jOjufxoBbbVnRtoJAN9d0MGHn/Lri2lbT0x6egDtn0TpNL1TU F3PynQ/QkKkC7m4uhJmmkg2+EA== X-Google-Smtp-Source: AA6agR5S+APZgwcw+bIIDVGoAnuC/13B7ipF5b8+EdFoYAALnaA5p2FIyrCTjzHmbNXDwKwD1Go7xg== X-Received: by 2002:a05:6512:238c:b0:48b:132:8392 with SMTP id c12-20020a056512238c00b0048b01328392mr8117244lfv.658.1660737867059; Wed, 17 Aug 2022 05:04:27 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:26 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 09/14] arm64: dts: qcom: sc7280: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:58 +0300 Message-Id: <20220817120403.458000-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space, and allows to remove incorrect syscon compatible from TCSR mutex: qcom/sc7280-herobrine-crd.dtb: hwlock@1f40000: compatible: ['qcom,tcsr-mu= tex', 'syscon'] is too long Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qco= m/sc7280.dtsi index 13d7f267b289..89a8e6b9822a 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2155,12 +2155,17 @@ ipa: ipa@1e40000 { }; =20 tcsr_mutex: hwlock@1f40000 { - compatible =3D "qcom,tcsr-mutex", "syscon"; - reg =3D <0 0x01f40000 0 0x40000>; + compatible =3D "qcom,tcsr-mutex"; + reg =3D <0 0x01f40000 0 0x20000>; #hwlock-cells =3D <1>; }; =20 - tcsr: syscon@1fc0000 { + tcsr_1: sycon@1f60000 { + compatible =3D "qcom,sc7280-tcsr", "syscon"; + reg =3D <0 0x01f60000 0 0x20000>; + }; + + tcsr_2: syscon@1fc0000 { compatible =3D "qcom,sc7280-tcsr", "syscon"; reg =3D <0 0x01fc0000 0 0x30000>; }; @@ -2522,9 +2527,9 @@ remoteproc_mpss: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names =3D "mss_restart", "pdc_reset"; =20 - qcom,halt-regs =3D <&tcsr_mutex 0x23000 0x25000 0x28000 0x33000>; - qcom,ext-regs =3D <&tcsr 0x10000 0x10004 &tcsr_mutex 0x26004 0x26008>; - qcom,qaccept-regs =3D <&tcsr_mutex 0x23030 0x23040 0x23020>; + qcom,halt-regs =3D <&tcsr_1 0x3000 0x5000 0x8000 0x13000>; + qcom,ext-regs =3D <&tcsr_2 0x10000 0x10004 &tcsr_1 0x6004 0x6008>; + qcom,qaccept-regs =3D <&tcsr_1 0x3030 0x3040 0x3020>; =20 status =3D "disabled"; =20 @@ -3259,7 +3264,7 @@ remoteproc_wpss: remoteproc@8a00000 { <&pdc_reset PDC_WPSS_SYNC_RESET>; reset-names =3D "restart", "pdc_sync"; =20 - qcom,halt-regs =3D <&tcsr_mutex 0x37000>; + qcom,halt-regs =3D <&tcsr_1 0x17000>; =20 status =3D "disabled"; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C9EC25B08 for ; Wed, 17 Aug 2022 12:05:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239336AbiHQMFC (ORCPT ); Wed, 17 Aug 2022 08:05:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239263AbiHQMEl (ORCPT ); Wed, 17 Aug 2022 08:04:41 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E31E4F6B3 for ; Wed, 17 Aug 2022 05:04:30 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id v10so13331652ljh.9 for ; Wed, 17 Aug 2022 05:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=G5Gw9O1HRC2HZ2RUee8k0rPKQP+uhhOAxZLOGmh5CkQ=; b=FO6pkLjUvDS7GG3+dFzSYGZfDf/jqiKePe8B9y9yiDTDJCtSzPJYtScOvXgGTpYxSJ HcEJ3tBn34XbI4eHscrmAQDRaytwwXOYG8L6DZdN0DLsoH3lD3sYvRvXjDf7tsDL3Lxu mi3KXPa4mN4j45quv0b0nLakPgll63tmV4JvhICcJ/FAhwDp0f40wCuaha7fK9ASEhUa oDEs/yUILjgjgokjrVY5qO9R7reBi0+FeisMvr9nJ/2XHe6nBDtBNbwRcMJOZmeRlOOH r816zprWZiMRQ7b4Xm/LZIre1x7ldNzaEKEtqjPi51XiK5JkRGZmyy2zwvbCt3hfh2Le +e2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=G5Gw9O1HRC2HZ2RUee8k0rPKQP+uhhOAxZLOGmh5CkQ=; b=MfeUVE/A3FNhhOmX8y/h1twBKK/+pwTzRCBPN3uTQPFvNe3BbTCaLg7DZwyGrE0RDX ZVAU+i4Q6kiT9W9EJA1N3FEqBDgrYYGsYI/mFpZrwz+uewzd7oWs3t/wc5SSDexKs53H JOy4xcFHZsiFwL3LdJtCHmcUY1p1+5Zw3SzGoNE+SwqsHFKfb/4MJa2CNm4asekwQtWI oPZcq4EHKHvxFbsSjNoRIuhCJyX/qIMAeNeJkrEQd4P2WTaSTL8Eea8EBkrembNmJzrC UtPJ/HLf3pqE2fli7lhm9HQcsx2wBGuGD/hfKNRrYD/VwMjYspeIAi+nnRnEh7/UugVv +cBg== X-Gm-Message-State: ACgBeo2BFYLOd1DnYt2avFIpp8L20hQHSuzQLVzGmUmCAYa0QyslTw0+ zcbyDabstPQWLjKBn74GeM7KHw== X-Google-Smtp-Source: AA6agR4IHiOubNO+AQY3O5FQFJEvUcmjobZ70PRwztSjlcEHmpGYy8OKKZMrZ78HD0ApkyktFlQN8Q== X-Received: by 2002:a05:651c:19a7:b0:25f:dcbb:c9d1 with SMTP id bx39-20020a05651c19a700b0025fdcbbc9d1mr8064112ljb.450.1660737868505; Wed, 17 Aug 2022 05:04:28 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:27 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 10/14] arm64: dts: qcom: sdm845: split TCSR halt regs out of mutex Date: Wed, 17 Aug 2022 15:03:59 +0300 Message-Id: <20220817120403.458000-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR halt regs are next to TCSR mutex, so before converting the TCSR mutex into device with address space, we need to split the halt regs to its own syscon device. This also describes more accurately the devices and their IO address space. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qco= m/sdm845.dtsi index f0e286715d1b..21ed14200986 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -2590,7 +2590,12 @@ ipa: ipa@1e40000 { =20 tcsr_mutex_regs: syscon@1f40000 { compatible =3D "syscon"; - reg =3D <0 0x01f40000 0 0x40000>; + reg =3D <0 0x01f40000 0 0x20000>; + }; + + tcsr_regs_1: sycon@1f60000 { + compatible =3D "qcom,sdm845-tcsr", "syscon"; + reg =3D <0 0x01f60000 0 0x20000>; }; =20 tlmm: pinctrl@3400000 { @@ -3207,7 +3212,7 @@ mss_pil: remoteproc@4080000 { <&pdc_reset PDC_MODEM_SYNC_RESET>; reset-names =3D "mss_restart", "pdc_reset"; =20 - qcom,halt-regs =3D <&tcsr_mutex_regs 0x23000 0x25000 0x24000>; + qcom,halt-regs =3D <&tcsr_regs_1 0x3000 0x5000 0x4000>; =20 power-domains =3D <&rpmhpd SDM845_CX>, <&rpmhpd SDM845_MX>, --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B6D0C25B08 for ; Wed, 17 Aug 2022 12:05:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239345AbiHQMFF (ORCPT ); Wed, 17 Aug 2022 08:05:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239271AbiHQMEo (ORCPT ); Wed, 17 Aug 2022 08:04:44 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61B295004E for ; Wed, 17 Aug 2022 05:04:30 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id u6so13350559ljk.8 for ; Wed, 17 Aug 2022 05:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=v+CAkv8Hlyo2PxpwLaCJcPFqOS7vWYe9QQHHKSYzECU=; b=BIe1yai8AxnqH1xCULHo/Dm0+9wX5oQHpkNKEW9N3FM0YIpnB/eekBBEHoyu/2fQHj D0NNjM2bh4MnJ13IH1XqBpBGk2GF+GzuwC8HqnzO+tLFDZvtLdUa2zS8712eV6VzhKQm c6SBILRw31/pIPY20qUe/F979IN7p+CDxXxmHScjgmVFn7x1TuJGkAF26VsyoOkMq5Qr +SOOwqtpGKa8LCHiBAQq5XON3nPIyYOIsg5b5Rf35m7k4EbZtNYHYSciV/XLTjKFZ6xP +2J1TpzZALOZoAKaHsm+Gykzbm6wSCq6kpXhpfJ1Qbgo3fu3NVoFajTCep27Mz6W7rEA 5C4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=v+CAkv8Hlyo2PxpwLaCJcPFqOS7vWYe9QQHHKSYzECU=; b=rC1GLEE6uJXBTqJMrWylcxLhvrw/BwfUsFH2d6KuDdiUuNlh8M9SVli45Bd7HFqsMl rEWXDBUN6dirWqs91HQbwgCNIp3WjuXgY83D2Ph1Sh3fVVVO+Yt6GdHUjLvkKrnXk5RA ZW7o0CnBFsu06Euh8f3fpXeABRY5EwgckC2ubMuh5STg0+ZhwqSz1dJqT6ZGuHAxMCcm KJKgOD25pCZoYTKZVpl+uhDfBFMEPrFtm3Vuf+j1S2EM63h8JWwt/i26B5stsS841Q+b 5y+6klBsb1SXVY32PcRydhjCfzLEJWRANCuEiXDuiCNENYP0oLxJSurZbUs8EmKGifM6 +btg== X-Gm-Message-State: ACgBeo1Spz3oh8gbXmB08PnsGOCtXhIIodTiB24joaseyOrZNXH13DKR ICeGicml7UPuXEVcYgZwwFrWhg== X-Google-Smtp-Source: AA6agR4TQRBWxy15ymqHuWCuBX5sSHPtGTKsjhtaZQ1BFvzFN58HPIlUMcLKM7hU3iREL5h32T6BCQ== X-Received: by 2002:a2e:9e56:0:b0:261:7544:d79d with SMTP id g22-20020a2e9e56000000b002617544d79dmr1640455ljk.296.1660737869972; Wed, 17 Aug 2022 05:04:29 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:29 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 11/14] arm64: dts: qcom: sdm845: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:04:00 +0300 Message-Id: <20220817120403.458000-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm845-shift-axolotl.dtb: hwlock: 'reg' is a required property qcom/sdm845-shift-axolotl.dtb: hwlock: 'syscon' does not match any of the= regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qco= m/sdm845.dtsi index 21ed14200986..bd0ec0664283 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -919,12 +919,6 @@ compute-cb@8 { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - smp2p-cdsp { compatible =3D "qcom,smp2p"; qcom,smem =3D <94>, <432>; @@ -2588,9 +2582,10 @@ ipa: ipa@1e40000 { status =3D "disabled"; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0 0x01f40000 0 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr_regs_1: sycon@1f60000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4BFAC25B08 for ; Wed, 17 Aug 2022 12:05:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239352AbiHQMFI (ORCPT ); Wed, 17 Aug 2022 08:05:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239278AbiHQMEr (ORCPT ); Wed, 17 Aug 2022 08:04:47 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2249B52809 for ; Wed, 17 Aug 2022 05:04:33 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id bx38so13323377ljb.10 for ; Wed, 17 Aug 2022 05:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=uPnkJ9CZ7fbXWgaAUcfcWBXaeXKUW7FCT3L0V3onDIA=; b=IDHaSU6pyLGf+5+N3yvRmfRgyJcjMsogzmLS081dmkCfeis8uKnxylfpfJAA8NJXId /XJuDrlcaCU2jMog5sXRjQPaeuX7qOIPFRHnRej6IrbbfsKYLalESvxEwD+jslWDH7IB 3c0+P6nLvaCIcKm3/mowwdy3X1wv9mRbJyMxtihUDHL5pwTkojV6qtLrXhSY3clPW4lg LOxac6hQryRoJbvyJQRaQeIDs4EXY7FjRj+oJQV+72CsfVktzDuW0LzFHfFyKaCM/Ag5 r0gu8lY5HwkAp7JrWSBF9WuD+3gdZmHhyy5/HrUrxu/mUx8hD9NuQGrLxi7MMjlonET0 y/Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=uPnkJ9CZ7fbXWgaAUcfcWBXaeXKUW7FCT3L0V3onDIA=; b=MWKj8NC3xOnwrQ6PPKqVVGDaBVCf7wL6wEv7cEIR8ThKRJ0NSEortAfDAhAfKN1GCC dN2vCdpXvApGO5kB7O70M7vxP6cqyAxfdV6bc95CbJ3O4vq16SbCXW/VmPROpxHf8YWX 3IqSfqZjylpYI3pyU5refGvAyd24C9RAwDBslgGwnRv6vRtt5WR+by2EF7XKXqbO+KE2 svLysR6LI2dbfp1PcoGrD1QEBsq97jlnj8VIpVTfURjIy2ta45gKm8qcDmfShrTlZfRf I3n4RCz0D8WvZY2sgnxE5Ahgxu3dyCR0S0V+k95EUp0DfCusUgIvFHbVOzG5bq024p+N 0mGw== X-Gm-Message-State: ACgBeo3EZvaj7fSgH/10qnCh3XhNWyLU6Ura0dZaDEQT82ILdVNiz1er ZiOHzPoZy5Q1KdLqORg+KmU3oA== X-Google-Smtp-Source: AA6agR7bIZTAKEEfgXGTIR/qHFIgh5ti3RzKbK9pp9MhdH2pDL2oT/6qOvRuC3eCe51dEpLa8LqWJQ== X-Received: by 2002:a2e:850f:0:b0:25e:67a8:4e11 with SMTP id j15-20020a2e850f000000b0025e67a84e11mr8067779lji.30.1660737871488; Wed, 17 Aug 2022 05:04:31 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:30 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 12/14] arm64: dts: qcom: qcs404: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:04:01 +0300 Message-Id: <20220817120403.458000-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/qcs404-evb-4000.dtb: hwlock: 'reg' is a required property qcom/qcs404-evb-4000.dtb: hwlock: 'syscon' does not match any of the rege= xes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qco= m/qcs404.dtsi index 9ab990061522..3a94eb2cc448 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -295,12 +295,6 @@ smem { hwlocks =3D <&tcsr_mutex 3>; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - soc: soc@0 { #address-cells =3D <1>; #size-cells =3D <1>; @@ -726,9 +720,10 @@ gcc: clock-controller@1800000 { assigned-clock-rates =3D <19200000>; }; =20 - tcsr_mutex_regs: syscon@1905000 { - compatible =3D "syscon"; + tcsr_mutex: hwlock@1905000 { + compatible =3D "qcom,tcsr-mutex"; reg =3D <0x01905000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tcsr: syscon@1937000 { --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74FA0C25B08 for ; Wed, 17 Aug 2022 12:05:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239368AbiHQMFP (ORCPT ); Wed, 17 Aug 2022 08:05:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239289AbiHQMEu (ORCPT ); Wed, 17 Aug 2022 08:04:50 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C71E556B94 for ; Wed, 17 Aug 2022 05:04:34 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id e15so18784730lfs.0 for ; Wed, 17 Aug 2022 05:04:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=DqeinnIMS7tnZ1s/F5WbYXe7dS10PhHD2RlaXqtenk4=; b=HA4YX3lATWHZy1PycT9JEiDmaVCC74tJ89+lBTjqcQesxYBXT6y37LEBBk9hjQE1m1 cLisYJI+duLjN0FEqQH0R7h53RyPZLxgcA0Q1AyY/3SmYfsCb4pwk5SGe3yj7MlNk8Bo MiZzcOHR0qLkntxsOPVC9RGn7CoXNqkSgV9gR55uucH3vSASXDp6THl3sZhPsAjAT/fM SiTFRsRTpd0Lm1W+OLhQbbuN0HuZ6VOnWsXoYcluoSbtEuraU07JaVqhYXXvZo6JXKy8 lWIsDaWTsLtcg5m+WyVoXINwchBoMIRMLYJ3b4yNj7IgMl9rfFKThNOTCDjFhNfdSa0G zt7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=DqeinnIMS7tnZ1s/F5WbYXe7dS10PhHD2RlaXqtenk4=; b=GKRT4dPlSVmplI80inLXxSXsgZKalMefPq8QcgWGKKMqKOl2D3+E76MQj/1LBU5Js9 tIihSakPMisE+5EPTomgKWclsIXfoTy2/zoHSOLb/O5PTTQlNXo0qN/eQcs+UyY7a/EG DNqg7ECG149AVSzDGaROgi7+0HZygWBAdNJ8TpLiqv2YTcIXa8ivRqMFMJ0Q6hH75Izc hcVuJuRo8TCUpTuRW1zHDIk8xJiETEIzuRf279/kUeO8Deh9XBGEDM0CDeYZMwp49kX7 sUzEPyov7xNth4zFFQcDt2CM6CFywsVnCnxS8SoPnh5nrbDD/jb2monHBxDncrTkVI5u BwNg== X-Gm-Message-State: ACgBeo2IcI5cy8Wq/G5dI48vQIjJAA7dZepi4QtcyYe6Tkz5nyjCM1qn s58rIAU/BnoieeGD7BlXBEv7sg== X-Google-Smtp-Source: AA6agR6Ad+YVXQ2ESPuMzul02yuxva58dgnkUgd2uhe5MsvfrsJV4vu40ijZIXllqyCSouRi1YOZtA== X-Received: by 2002:a05:6512:6c4:b0:491:c8f9:1994 with SMTP id u4-20020a05651206c400b00491c8f91994mr5822628lff.179.1660737872906; Wed, 17 Aug 2022 05:04:32 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:32 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 13/14] arm64: dts: qcom: sdm630: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:04:02 +0300 Message-Id: <20220817120403.458000-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'reg' is a required p= roperty qcom/sdm636-sony-xperia-ganges-mermaid.dtb: hwlock: 'syscon' does not mat= ch any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qco= m/sdm630.dtsi index 1bc9091cad2a..40a40d00eae4 100644 --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi @@ -697,9 +697,10 @@ tsens: thermal-sensor@10ae000 { #thermal-sensor-cells =3D <1>; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; - reg =3D <0x01f40000 0x40000>; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; + reg =3D <0x01f40000 0x20000>; + #hwlock-cells =3D <1>; }; =20 tlmm: pinctrl@3100000 { @@ -2351,12 +2352,6 @@ intc: interrupt-controller@17a00000 { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - sound: sound { }; =20 --=20 2.34.1 From nobody Sat Apr 11 00:46:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2AEAC25B08 for ; Wed, 17 Aug 2022 12:05:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239358AbiHQMFL (ORCPT ); Wed, 17 Aug 2022 08:05:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239285AbiHQMEs (ORCPT ); Wed, 17 Aug 2022 08:04:48 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2174B58099 for ; Wed, 17 Aug 2022 05:04:36 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id s9so13343336ljs.6 for ; Wed, 17 Aug 2022 05:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=GGC6/FAtFLtsPec3v0Z//ulLsaLmio7LVXcsIKWCfDM=; b=miMj+avNVe2LIWr1HvJA4rGseGDIOeygunPdCMBN6CSnZr4fZvx1MS7rw6GUgMhxyg nSN1YKLeXmDvVX8VfYcgxDVCZNdAmWzyqwCfgEtSYumifD1B2mrenI0UyZJNw09CXFEk 5SzgDvS6O5xTedd1yXhWCDDr4y6LLmMmvYYEZ/MpUCubbVcM911wrnIicI/IWgI7FO4q 7VaEcQiKliQ6RyNkAcm5vDWX3vwAjSHG8dW5QPjlDOQwvcJTUk4njD+QpsWG2qwo26pA id3OXB7qggMKuwKb57RbdptQkVxbBZwBxHOBbpqEh9wW8kIEpVrmv0FY5kNYa4rvdS+Y oiIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=GGC6/FAtFLtsPec3v0Z//ulLsaLmio7LVXcsIKWCfDM=; b=0rMygVD2VdWWnBxRlgHiIFdrjxSQbFaku9Nnj0OJXgcPkg4LeTkgH8ioiNW/v9iHNF kSITDSCAG+RwG+mfUiST8F2Zm7/crGDFeCmfZQyvKbpog3ZNIxgpjpz5DYDCUARB87TW Dg0OfdSvON5NR+YRdz3zJexZhJJjQjdSs/2x936CLEROaHftQd48ZwUbRfBWR+xiV/SR cYZl3joka6eDwjfx+9uffWuwXZEE8/TVtvihiv4MZmucUKCRemI5rAfW4WGW70QD57VD cjJgy6q876Wx9FeNHSXYxLP2igT4gw1Q0FrJoGfiHMtx8wr6oPMCeSY9/ZpLCW54NSUB k8tw== X-Gm-Message-State: ACgBeo1GNqQfF8k1grG+X7ImiIdl3OP+qqeByU1jekVklL6r0sU0Y/KH 6O8+Q4UeA4G8KwvjN3dVjMwH4A== X-Google-Smtp-Source: AA6agR7gyE2mBf2oCkQu9AfMIjk25LfntH6SuRYtq8dw+mhllXqptMMvleWmyxNwiDl4Z/Wens5vAA== X-Received: by 2002:a2e:bea8:0:b0:25f:e9ab:5a1b with SMTP id a40-20020a2ebea8000000b0025fe9ab5a1bmr7549871ljr.448.1660737874403; Wed, 17 Aug 2022 05:04:34 -0700 (PDT) Received: from krzk-bin.. (d15l54h48cw7vbh-qr4-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1b1c:14b7:109b:ed76]) by smtp.gmail.com with ESMTPSA id d15-20020a05651221cf00b0048a97042251sm1670496lft.22.2022.08.17.05.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 05:04:33 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Lee Jones , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 14/14] arm64: dts: qcom: sm8150: switch TCSR mutex to MMIO Date: Wed, 17 Aug 2022 15:04:03 +0300 Message-Id: <20220817120403.458000-16-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> References: <20220817120403.458000-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TCSR mutex bindings allow device to be described only with address space (so it uses MMIO, not syscon regmap). This seems reasonable as TCSR mutex is actually a dedicated IO address space and it also fixes DT schema checks: qcom/sm8150-mtp.dtb: hwlock: 'reg' is a required property qcom/sm8150-mtp.dtb: hwlock: 'syscon' does not match any of the regexes: = 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qco= m/sm8150.dtsi index 7d509ecd44da..dc6770391813 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -585,12 +585,6 @@ scm: scm { }; }; =20 - tcsr_mutex: hwlock { - compatible =3D "qcom,tcsr-mutex"; - syscon =3D <&tcsr_mutex_regs 0 0x1000>; - #hwlock-cells =3D <1>; - }; - memory@80000000 { device_type =3D "memory"; /* We expect the bootloader to fill in the size */ @@ -2054,9 +2048,10 @@ ipa_virt: interconnect@1e00000 { qcom,bcm-voters =3D <&apps_bcm_voter>; }; =20 - tcsr_mutex_regs: syscon@1f40000 { - compatible =3D "syscon"; - reg =3D <0x0 0x01f40000 0x0 0x40000>; + tcsr_mutex: hwlock@1f40000 { + compatible =3D "qcom,tcsr-mutex"; + reg =3D <0 0x01f40000 0 0x20000>; + #hwlock-cells =3D <1>; }; =20 remoteproc_slpi: remoteproc@2400000 { --=20 2.34.1