From nobody Sat Apr 11 02:20:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 522AEC25B08 for ; Wed, 17 Aug 2022 06:11:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238837AbiHQGLo (ORCPT ); Wed, 17 Aug 2022 02:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238830AbiHQGLj (ORCPT ); Wed, 17 Aug 2022 02:11:39 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2049.outbound.protection.outlook.com [40.107.101.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B973F79613; Tue, 16 Aug 2022 23:11:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jBekvz9igXUq5fyUkQWK96zNbd/5AgMqgFxci+tE23wNiPZsktAyV1bWI4dte5dvvi729PG7nM6n6gj6OPgsBuFf86lKkagZrNILXLzb/jDTmFWq1gZ2aTY8+v2A0WLsfPOeHRLoOWNRviTRZsbEAMa3qd8EehHSC0M1pkNOcX/Tl4qzria5/wRNvwA9+3j48nmvFsMWWrlbP9txF48yidaYFrJD2qNb/i+omsz73TQDR5EG66Hfm8JAVcMUi8CC+Ins4/mfLP6ctAwaAWLbue7UWqSlFQwqNqhfLVZ0bS8G27xtARd/pmAIMvDLTOMAUFNojOovWIimlfXbA9SKsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S3EVv2d4aphGOylGW5hVdADiw5bHG25A6kmbLQhrJo0=; b=eBxF3we32XKXJoUyuMya4DcPyjLO3QitdFszqEfFQ+RYeumhFt7hBM1p0tOvTwBjbOMBKj9l4PlsQnLDeSo8iRF232ystK+ojS1JJZjluWdwuDAwCEwcPGp0eJjHLdhxcoizAAmGGJMhik0PlRYIAt6I/J+Wh9aDCA9ebcFgM/Va98h1fomLAPoEaa02D+olz1UhXwq9OhC1rroWhQF7R6AByDprcyr23Q6LiljOaTCEBL36kzBbxrIUwGhrtsqcVaqygKXUWmVX+JLe4uucOXcvsX9+VD0UuNtTMJmFNd/Kw9fR4Up3ZLH5+pMieC1TE7cUZht9Wbtoo+jjd0hhjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S3EVv2d4aphGOylGW5hVdADiw5bHG25A6kmbLQhrJo0=; b=iqBAFRxEHiij2Kcb6l2kYcKpkW7Y9I87iT9qZJPmthZ2GPxCFy3ULj8+uy4W1QgYfuBPwYGC/8VzO7FrEYuuAXGMt5Lqqo3TSPWxUY/3rFCJ/36omx8VzXPTz+r8mzAFBOAHnV025HjzNg6SXbBZL/w64PqlSdr/aZbHXpGwzDk= Received: from BN9PR03CA0733.namprd03.prod.outlook.com (2603:10b6:408:110::18) by BL3PR02MB8985.namprd02.prod.outlook.com (2603:10b6:208:3b5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Wed, 17 Aug 2022 06:11:35 +0000 Received: from BN1NAM02FT058.eop-nam02.prod.protection.outlook.com (2603:10b6:408:110:cafe::99) by BN9PR03CA0733.outlook.office365.com (2603:10b6:408:110::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11 via Frontend Transport; Wed, 17 Aug 2022 06:11:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT058.mail.protection.outlook.com (10.13.2.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5546.15 via Frontend Transport; Wed, 17 Aug 2022 06:11:35 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 16 Aug 2022 23:11:34 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 16 Aug 2022 23:11:34 -0700 Envelope-to: vkoul@kernel.org, lars@metafoo.de, adrianml@alumnos.upm.es, libaokun1@huawei.com, marex@denx.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, swati.agarwal@amd.com, harini.katakam@amd.com, radhey.shyam.pandey@amd.com, michal.simek@amd.com Received: from [10.140.6.78] (port=46002 helo=xhdswatia40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oOCH8-000GsX-DL; Tue, 16 Aug 2022 23:11:34 -0700 From: Swati Agarwal To: , , , , CC: , , , , , , , , , , Subject: [PATCH v2 1/3] dmaengine: xilinx_dma: Fix devm_platform_ioremap_resource error handling Date: Wed, 17 Aug 2022 11:41:23 +0530 Message-ID: <20220817061125.4720-2-swati.agarwal@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220817061125.4720-1-swati.agarwal@xilinx.com> References: <20220817061125.4720-1-swati.agarwal@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 020ff5cf-0077-4dc3-1bd3-08da801756c1 X-MS-TrafficTypeDiagnostic: BL3PR02MB8985:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /bdQTVh7SAGgHBYrEHWlStnrWsKgXzVHHlfEQjKvXWLPldIECUIL/7R+sQk16HeqgcR5sb5mDy5E2lz1iZj4dQ7s1yHF8SeWKJxuMNcBoHsEWyGJAMuIlgIiibrETiCSWqNZcPohqWgmTtfGF7jrSJt7w41f5juYh+/DB4X2VXcePxgWcPiIryzWnRgoX+wnGcOx6O1YZ8NS0gGtPddfQpGejikWtEPXEIt9hRa1XVqcQ7e2nkHH1RM3ld5V3Z7GR0AY51KoQEtrsym9axqFCZq0vW1TMgIeHH3xXnRoq13PA3ftVynI7WXO6IFbIQGDBTpCnNoOaiTvE8N3bFEmRReJaHwJysQQZJ+mUEi7tKXIopxrIIR5hQuhS/haF7rwCeRVIE02Z1CjV5s0y6PYLsqCpZbpUjK7Fus4a/O2u2G5We6SshKrSrkzcxAsPxYVChNKYGgJ9K64DpcyFGneu04exxcph1Ixc07aS0AH+YwhLbB8RwhjSrzUEwkK/+Yx2o3wr1O8ZOkItgeqwHv4F5gvvU6fn0YKlEAwJJLmSNb90zjtOMq8NMb8ZPBeJx4BV4AJvvYqaLeFr57eIK6pGEOJ6EKmcZAwrJSWlZend0bUz5WL8k9xZ3h8/nyn3w3aiHYp78WfH+7F765us4IGldrNBnrwy6v1+hSxYUyKWaXTSwnFbZ9SRMYjut1wHND2vJ2msasi7skMOXwQwlte0vd57yGyCM0BAhW6bAZ0QH4/cQptTlejkxrFpQ3i5gfm6sR+5HL9sBd37EYpAjNhVpDpZ0hCWPzr0SFuaDiYKc5BZGP3TNkjV76WquYCG7P/ZoWsQLO3GoRSoXOQ6mot8A== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(39860400002)(346002)(36840700001)(40470700004)(46966006)(83380400001)(356005)(7636003)(36860700001)(44832011)(8936002)(40480700001)(5660300002)(7416002)(9786002)(36756003)(70586007)(70206006)(2906002)(4326008)(316002)(6666004)(426003)(54906003)(26005)(110136005)(186003)(8676002)(1076003)(41300700001)(2616005)(336012)(478600001)(47076005)(40460700003)(82740400003)(82310400005)(7696005)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 06:11:35.3039 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 020ff5cf-0077-4dc3-1bd3-08da801756c1 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT058.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR02MB8985 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add missing cleanup in devm_platform_ioremap_resource(). When probe fails remove dma channel resources and disable clocks in accordance with the order of resources allocated . Signed-off-by: Swati Agarwal --- drivers/dma/xilinx/xilinx_dma.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index cd62bbb50e8b..ba0dccaa8cf1 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -3160,9 +3160,10 @@ static int xilinx_dma_probe(struct platform_device *= pdev) =20 /* Request and map I/O memory */ xdev->regs =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(xdev->regs)) - return PTR_ERR(xdev->regs); - + if (IS_ERR(xdev->regs)) { + err =3D PTR_ERR(xdev->regs); + goto disable_clks; + } /* Retrieve the DMA engine properties from the device tree */ xdev->max_buffer_len =3D GENMASK(XILINX_DMA_MAX_TRANS_LEN_MAX - 1, 0); xdev->s2mm_chan_id =3D xdev->dma_config->max_channels / 2; @@ -3259,7 +3260,7 @@ static int xilinx_dma_probe(struct platform_device *p= dev) for_each_child_of_node(node, child) { err =3D xilinx_dma_child_probe(xdev, child); if (err < 0) - goto disable_clks; + goto error; } =20 if (xdev->dma_config->dmatype =3D=3D XDMA_TYPE_VDMA) { @@ -3294,12 +3295,12 @@ static int xilinx_dma_probe(struct platform_device = *pdev) =20 return 0; =20 -disable_clks: - xdma_disable_allclks(xdev); error: for (i =3D 0; i < xdev->dma_config->max_channels; i++) if (xdev->chan[i]) xilinx_dma_chan_remove(xdev->chan[i]); +disable_clks: + xdma_disable_allclks(xdev); =20 return err; } --=20 2.17.1 From nobody Sat Apr 11 02:20:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95520C25B08 for ; Wed, 17 Aug 2022 06:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238855AbiHQGLs (ORCPT ); Wed, 17 Aug 2022 02:11:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238838AbiHQGLo (ORCPT ); Wed, 17 Aug 2022 02:11:44 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2051.outbound.protection.outlook.com [40.107.223.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFCAE79A4A; Tue, 16 Aug 2022 23:11:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c/zW9FY0hyr07vMDJYdZSyevOGeh6Z7AYkOk/e1IksJ0gnRz3K2v3Aa09SDsxuo4d1+qu+dtp1Mc7NsurGmZfcv7oammD4mMNZuzi5knDGeBo2F4CYjhT9qMOEL1veyeR8p4yJNIutiS/Hm9b7IqyULmGFhKgoL95Mx8/9PcmN0nY0KpsoZMDKE4IJEHNdg4HlNGSuoNuJ2mGtB/SwQXWTiHx6ddk1fVl01RCBnV5B6iyK+Pj3f+PMIcG4vqA2/7R8vEKGnymPfjVIcn4sooOpGuLaAxP6UN4ShTbbQlNo9mPm/Ee2bMoq62LLtzOXQYxUns/8pGkEtU6YLkbx+gHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDb+IkdjolsD8gX05Ms+LaztnJjqMuoa+YQVCMKaHB8=; b=kW0ci+ze/J5S7rL2Zjv4ofRAHbIBG7b6h95lWw1ktZp6X5jvmIRIG0dlYJLYeJtG/t5WunSJsWLaY/IgMNQnm6NeoFohcix1fmK7gUXF9+n968U7t9dOTlV1cqFSqJnjtJT8fI8TfECGo5yLlyodru+b2HrE7/HJYyeBhb/7pZDtB+tmhW0S2/u8jDtVpAxJf7FdvA+asut090WipwzFBdwaNX7SIG/UlgzBf5himwp2UKM7bjOmYx0Qr8d/BolGARlIBH8+ZunsVeEih/0YOiEozcfiFXZdyIaKkFCU74+LD+ng855SDrFSx6WzYuTMGhf2slC+vbjgOGF73qupbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDb+IkdjolsD8gX05Ms+LaztnJjqMuoa+YQVCMKaHB8=; b=kry6qnnSbvIodtJbUGklIRUmuP4Vius9H164ylTo2vx7r+HEbS2JU4bUVlqiappfBO+b6XcIzPfQlKO27qv/0xRrQkxuK+Sftpvc2AZdJNXO/DaAYErPdE6sfu97iVQT6XO1XWpDTHdDLk+QksheCo7vL/UYM+DtYw0ZVScZPzU= Received: from BN9PR03CA0729.namprd03.prod.outlook.com (2603:10b6:408:110::14) by BL3PR02MB8115.namprd02.prod.outlook.com (2603:10b6:208:35e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Wed, 17 Aug 2022 06:11:40 +0000 Received: from BN1NAM02FT058.eop-nam02.prod.protection.outlook.com (2603:10b6:408:110:cafe::95) by BN9PR03CA0729.outlook.office365.com (2603:10b6:408:110::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.16 via Frontend Transport; Wed, 17 Aug 2022 06:11:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT058.mail.protection.outlook.com (10.13.2.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5546.15 via Frontend Transport; Wed, 17 Aug 2022 06:11:40 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 16 Aug 2022 23:11:39 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 16 Aug 2022 23:11:39 -0700 Envelope-to: vkoul@kernel.org, lars@metafoo.de, adrianml@alumnos.upm.es, libaokun1@huawei.com, marex@denx.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, swati.agarwal@amd.com, harini.katakam@amd.com, radhey.shyam.pandey@amd.com, michal.simek@amd.com Received: from [10.140.6.78] (port=46002 helo=xhdswatia40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oOCHC-000GsX-PS; Tue, 16 Aug 2022 23:11:39 -0700 From: Swati Agarwal To: , , , , CC: , , , , , , , , , , Subject: [PATCH v2 2/3] dmaengine: xilinx_dma: cleanup for fetching xlnx,num-fstores property Date: Wed, 17 Aug 2022 11:41:24 +0530 Message-ID: <20220817061125.4720-3-swati.agarwal@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220817061125.4720-1-swati.agarwal@xilinx.com> References: <20220817061125.4720-1-swati.agarwal@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 044090e1-bf1b-48d0-5042-08da801759ab X-MS-TrafficTypeDiagnostic: BL3PR02MB8115:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ws/vTgC4hgtIuc2yvWjX9mRhNUQphzH1TufW6kgwK5qttdmHKQNXlltq4AELwPXMhsD6sp2KZqr0lSEyQHxvK2ynI9R07fmKEGraNm0u78GCAG8vNZo8mHHZko23uv8BftIJaTImm60+B5l+MFZGc4GkyYG0UB++WbqGRsICDC/RgC4fXwWWd74Lw49Fad8ScDMcpfpvaKyE7dMQChVk8sxzduk2NN3nZJyETXAlDWVyi+P0bfu8EeQHOxou3ZzUEv3iEllnygMcCU5sg3jzshn2vKx06Zj8pDvVhkNzmP2iub1U/ZduoYcZHmFZ3eBGGE1mrq0f188h2CBDhjk1TIwApCPxvNgFt8BKCoKW2qpzAU8IHYe3boJAbcq468d2qMjmbTsoi7gUzqbVtGRqwfOWMpfVBQL6THvUP6NdjxbYtuvEH9BByta/vCQJ1B8y8UHQGbxluWOZZnmNKR0egRCh51KApx/9WUDi7x6xGe9zpnMWdCs8VXKjy/BUtd8dbnTPU+8hwRZbvvsYtItzu5PKVKWVm3dPZqE0xSmiWedJ8Z5/+BiSWCTh/8+HHSdsRXPSS6JHmp6Xzt5oxkioqOteX3LnXd7Omkyad+1lVQpCT4nxr/dwcijVk8PbRKBR8pxrM/DESTxuRZnftIvsKG3aqpie14mkX56+7dgH3kmFJE0/mDDKLAdk58kX2WfxSSkVuVmo6lp3mctHHMTka/8+ecQhbJrzR4ep9zwqv2lp+0jZA7dHXRRMf+hZ5ao9JHl57RpFCKdNzHsrjh8ixXu8rKkn2mc/pkLmWHTrpysOpBxWN6LLgUBDCW35WAKsC6hUpffenU+opD0IvG010g== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(376002)(346002)(396003)(46966006)(40470700004)(36840700001)(2906002)(4326008)(26005)(82310400005)(44832011)(2616005)(7696005)(40480700001)(7416002)(36860700001)(8936002)(40460700003)(41300700001)(36756003)(478600001)(9786002)(110136005)(54906003)(6666004)(356005)(82740400003)(426003)(47076005)(83380400001)(336012)(7636003)(1076003)(186003)(4744005)(8676002)(5660300002)(316002)(70206006)(70586007)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 06:11:40.1942 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 044090e1-bf1b-48d0-5042-08da801759ab X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT058.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR02MB8115 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Free the allocated resources for missing xlnx,num-fstores property. Signed-off-by: Swati Agarwal --- drivers/dma/xilinx/xilinx_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index ba0dccaa8cf1..f63ec9d862ff 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -3191,7 +3191,7 @@ static int xilinx_dma_probe(struct platform_device *p= dev) if (err < 0) { dev_err(xdev->dev, "missing xlnx,num-fstores property\n"); - return err; + goto disable_clks; } =20 err =3D of_property_read_u32(node, "xlnx,flush-fsync", --=20 2.17.1 From nobody Sat Apr 11 02:20:01 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 479B5C25B08 for ; Wed, 17 Aug 2022 06:11:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238861AbiHQGLv (ORCPT ); Wed, 17 Aug 2022 02:11:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238849AbiHQGLs (ORCPT ); Wed, 17 Aug 2022 02:11:48 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2053.outbound.protection.outlook.com [40.107.237.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 097497A527; Tue, 16 Aug 2022 23:11:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TILnaZtFRRzT1dR6Y40kNBO9tbE3XfDrBK50weZPD3oGXNSJqrCP2frl/6HMLR9KoKeQeDSuLY2/HMKjJ9qTPWAuldioNDlf/+nFI0GzXZy9ALJtQD0obviw4AKXScEZJogEDcpiMLtv/y0DZrpF7ru5keGVEfHJM+K82hhLWkgHJtaRE9vYKKfL53gigPuldEX5cGqMnP/BET4ldulDHChzA3tAo1MroxRNiaqVzSBLTreqQixNbKt0pFEutFDz97sfinQWQOY832Ktqz45j/FF8oGU2fJmEvlFClWGsqt/bisGU0fzugkbgFcsO4REuoyWAyRCLgiKuUXKLoQkvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cn0bTQhbJNyN9rfrlMOD+JUDJqBB96ZPf6EdZle+JWc=; b=WcE2MYw08wtwQ0s78vdplcqBhyhYu9sT6+Ad3SutxMgQdbNVPjATX8lZNkq/5kVjWWOacXA8Md/5r42wOE0Zu1gwhoNeAVfngkgVZtn+NJ/NY97WbTjDrhOfxGh71g0qxWg8vMRH5cySjR6DuRUsa3wC/fYAQLPk2g04GdwGMyas9gcio6ev35fYIDEFpKKvumRpPytn78NNi6L7AiFPpVoYf3ZZ5Bi8LzoX7acktQb4TWQTdhT2EtTlbE5SIzZcwVvbj7bWUgce9qD73awA/47uO4PTHPAHmtctvnVKYXr/QvQofucVixo/cAo6LogPpvyf0cEfXJnUTjbp44aKqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cn0bTQhbJNyN9rfrlMOD+JUDJqBB96ZPf6EdZle+JWc=; b=SW2wkHCX0pqq5SCQ8UAIokndLJ4h4XM7X/ilkvpFmVVMf0/OBebAdHKXAPRE2dx3cc0e5BW4YHAeFzAenJLeRgoWgXq9sToPYAZSaAO4Tf3j+Qm2SkhYFsk9YhXWeToNiWWGdD7hK3NfeMjaiqbKAjGxdEZMGr8gFektxeSy9s8= Received: from BN0PR02CA0012.namprd02.prod.outlook.com (2603:10b6:408:e4::17) by DM6PR02MB6496.namprd02.prod.outlook.com (2603:10b6:5:1bd::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Wed, 17 Aug 2022 06:11:45 +0000 Received: from BN1NAM02FT040.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e4:cafe::98) by BN0PR02CA0012.outlook.office365.com (2603:10b6:408:e4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.12 via Frontend Transport; Wed, 17 Aug 2022 06:11:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT040.mail.protection.outlook.com (10.13.2.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5546.15 via Frontend Transport; Wed, 17 Aug 2022 06:11:44 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 16 Aug 2022 23:11:43 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 16 Aug 2022 23:11:43 -0700 Envelope-to: vkoul@kernel.org, lars@metafoo.de, adrianml@alumnos.upm.es, libaokun1@huawei.com, marex@denx.de, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, swati.agarwal@amd.com, harini.katakam@amd.com, radhey.shyam.pandey@amd.com, michal.simek@amd.com Received: from [10.140.6.78] (port=46002 helo=xhdswatia40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oOCHH-000GsX-5L; Tue, 16 Aug 2022 23:11:43 -0700 From: Swati Agarwal To: , , , , CC: , , , , , , , , , , Subject: [PATCH v2 3/3] dmaengine: xilinx_dma: Report error in case of dma_set_mask_and_coherent API failure Date: Wed, 17 Aug 2022 11:41:25 +0530 Message-ID: <20220817061125.4720-4-swati.agarwal@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220817061125.4720-1-swati.agarwal@xilinx.com> References: <20220817061125.4720-1-swati.agarwal@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1605b740-49a6-4b93-9b46-08da80175c2a X-MS-TrafficTypeDiagnostic: DM6PR02MB6496:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vrp1H4tDvMOsc7vtzJts8N9PSYd7rihZyI3cjgjTM5hkz+0m4uX76lzeLDBkarfHL05YzyBhKX92ZD5LpnJ+gvGds1ZdtX9G9epw83M7ZV67a3sfAku7lmeeSZoy5piR9klxXRqGWmy4ejY7cldXJrPa4L11Zmj0KPMyNFyhQQMO9MWij1EceFfZaItSxQVJt1GJtGPpx5JE+ncmDAio3s/CGt2m6dO012H8RUeTZ6aqqoYzMrzPtC4PAQ8ugQ5XI6Ke1m1zuvk/YueY8s9usTgdUum4Rm6z2b7Ie3d+JzvO2T3KRzBX1xr26Otaup3FAwhgg1BXbutgsw4IC69CzAsmgLoGsUHZsq574eGeF134QG1z0ayh5Gxj3t5yyXEEhND3MIYyNjtTREqX5H+E7UJyXUylT7pzXRneDn/1utdkZsGlr+Jm5FUN64Y/AGi0eJ/imTmpRh7e58DaJjFfw6wLHgEOa18jfNNYhOV6TcWMs8KqnXjN6mcxwK7YXSCP67woNs/47avVC6XqA6VO/7DdKEv4J9RRbKUlbfgP+M6CbfO9qtHd7xbotsNpi46ideTfBIjwOSLdrjWaMzd0e7Rs8nsJnjBH5mQ7GSHdz+DCVKkaelOmzZ02Mju1V1v41BUOZon5jcGfOiwZKozUgu1It458qn2RSMOEOS5CCypK1y/HcTlhm9cKc45ubai1f2DsSXhaAuNW0f4fALWA1sE2yj3c1N9SnPnC9YBUrhfSP7fKI208muw1cpUEC+v4vJpO+ekTc7t456ThSaBztPITovK8luazsp+iMjrgIV+KdFjcZds80l9fMBXvOiwKdbCYFyGSP2Zu5wr7/eJ85A== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(39860400002)(396003)(36840700001)(46966006)(40470700004)(186003)(478600001)(7696005)(6666004)(336012)(26005)(41300700001)(2616005)(426003)(47076005)(1076003)(83380400001)(36756003)(5660300002)(82310400005)(40480700001)(54906003)(2906002)(70206006)(8676002)(110136005)(316002)(40460700003)(356005)(70586007)(7636003)(36860700001)(9786002)(44832011)(4326008)(7416002)(82740400003)(8936002)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 06:11:44.3839 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1605b740-49a6-4b93-9b46-08da80175c2a X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT040.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6496 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver does not handle the failure case while calling dma_set_mask_and_coherent API. In case of failure, capture the return value of API and then report an error. Addresses-coverity: Unchecked return value (CHECKED_RETURN) Signed-off-by: Swati Agarwal Reviewed-by: Radhey Shyam Pandey --- drivers/dma/xilinx/xilinx_dma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dm= a.c index f63ec9d862ff..7ce8bb160a59 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -3211,7 +3211,11 @@ static int xilinx_dma_probe(struct platform_device *= pdev) xdev->ext_addr =3D false; =20 /* Set the dma mask bits */ - dma_set_mask_and_coherent(xdev->dev, DMA_BIT_MASK(addr_width)); + err =3D dma_set_mask_and_coherent(xdev->dev, DMA_BIT_MASK(addr_width)); + if (err < 0) { + dev_err(xdev->dev, "DMA mask error %d\n", err); + goto disable_clks; + } =20 /* Initialize the DMA engine */ xdev->common.dev =3D &pdev->dev; --=20 2.17.1