From nobody Sat Apr 11 02:20:40 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62BB7C2BB41 for ; Tue, 16 Aug 2022 22:39:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238039AbiHPWj5 (ORCPT ); Tue, 16 Aug 2022 18:39:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230056AbiHPWj4 (ORCPT ); Tue, 16 Aug 2022 18:39:56 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D65B37963B; Tue, 16 Aug 2022 15:39:54 -0700 (PDT) Received: from rustam-GF63-Thin-9RCX.. (unknown [136.169.224.60]) by mail.ispras.ru (Postfix) with ESMTPSA id 0977B40D403E; Tue, 16 Aug 2022 22:39:48 +0000 (UTC) From: Rustam Subkhankulov To: Vladimir Oltean Cc: Rustam Subkhankulov , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Alexey Khoroshilov , ldv-project@linuxtesting.org Subject: [PATCH] net: dsa: sja1105: fix buffer overflow in sja1105_setup_devlink_regions() Date: Wed, 17 Aug 2022 03:38:45 +0300 Message-Id: <20220817003845.389644-1-subkhankulov@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If an error occurs in dsa_devlink_region_create(), then 'priv->regions' array will be accessed by negative index '-1'. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Rustam Subkhankulov Fixes: bf425b82059e ("net: dsa: sja1105: expose static config as devlink re= gion") --- drivers/net/dsa/sja1105/sja1105_devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/sja1105/sja1105_devlink.c b/drivers/net/dsa/sj= a1105/sja1105_devlink.c index 0569ff066634..10c6fea1227f 100644 --- a/drivers/net/dsa/sja1105/sja1105_devlink.c +++ b/drivers/net/dsa/sja1105/sja1105_devlink.c @@ -93,7 +93,7 @@ static int sja1105_setup_devlink_regions(struct dsa_switc= h *ds) =20 region =3D dsa_devlink_region_create(ds, ops, 1, size); if (IS_ERR(region)) { - while (i-- >=3D 0) + while (--i >=3D 0) dsa_devlink_region_destroy(priv->regions[i]); return PTR_ERR(region); } --=20 2.34.1