From nobody Sat Apr 11 02:21:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F5C3C25B0E for ; Tue, 16 Aug 2022 13:31:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235826AbiHPNbB (ORCPT ); Tue, 16 Aug 2022 09:31:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231520AbiHPNaZ (ORCPT ); Tue, 16 Aug 2022 09:30:25 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFABAB8A7C for ; Tue, 16 Aug 2022 06:30:22 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id j3so10567806ljo.0 for ; Tue, 16 Aug 2022 06:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc; bh=5Maa5mHCDvID2XEbeA3TvbZciKfZbejdkqWh3jCTW2w=; b=WBByk97cZs3CogZGSwc4iXNJ+Pjg63T3GFhsuU/mdkJvXfscSR4OMJdBNNP2eyRAqe cPko9V6kv7gwBdG5ksCTrM+P+isaIeMzepjszn+q7YYVmBNftGz0M3F5JlKP8ubhPVJY GYujjeKW/pJjNhyhd4V+ApiN0Am69HJWyJKK6+sBJr1b9HcSZjbctPsfpDog4Kc8+WiJ gdYsmVgD3JqCCE1lSM8m4P277ehknAHp8beR11tD82aF3wpIEg4nn/3au0XhAda/g6HW Ib4WdGdO3XqU+CITfIN3NxnvoXUUPgIevepPrCtfaQDX9D5MZY97TZigqt9VvDNT6wEL IodA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc; bh=5Maa5mHCDvID2XEbeA3TvbZciKfZbejdkqWh3jCTW2w=; b=Auh5qK6jN0rsuILhp/+9zxeNAylysFtCES+E9Fx/3pcUZYP5XA4H8b+BJX3li31/D9 gRLkvG7EKuF+4rrxkOodMEFgXENV6vMUQE0oH/w9Lq7FLL2597tDhATbrnVwqN/NlJnq KM8rwWl3dxP2anM4TCSRnm1Max9OjftovRCqmojOsneR+9ALiUqzy9aWizR+rbu9s9+f 1h2/39MXgrfE32RfQ4hwK0Nxnq9aV2OGKYDNZ4ptWPqk/Hr4pg9QWmmT8aOGZQ624LBm IP1z7qFglu1EjCLRPMLShD9YGSdy9d9s58X4bxbj5eYF8ZVljS7wXEaqTNi3kZlhWxcv 4Jaw== X-Gm-Message-State: ACgBeo0dnMLNFCqqvN+Cl+Efb+c4vmOMG6sizLyr4cFdS9gw/BuWHkE4 8AQdljz7std+lnhNDWt1+A5gvA== X-Google-Smtp-Source: AA6agR5KkdbueNzav6IGro95WRos+dXgFJPzwKDgHnq+77Qu54W5MBRJc0paIAniQQ8p8D0SCY52+Q== X-Received: by 2002:a2e:8e71:0:b0:261:74ad:ab5f with SMTP id t17-20020a2e8e71000000b0026174adab5fmr5785039ljk.387.1660656620931; Tue, 16 Aug 2022 06:30:20 -0700 (PDT) Received: from krzk-bin.. (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id k19-20020a2eb753000000b0025e42f8e771sm1816301ljo.34.2022.08.16.06.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 06:30:20 -0700 (PDT) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/2] dt-bindings: pinctrl: samsung: stop using bindings header with constants Date: Tue, 16 Aug 2022 16:30:15 +0300 Message-Id: <20220816133016.77553-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220816133016.77553-1-krzysztof.kozlowski@linaro.org> References: <20220816133016.77553-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The bindings header with pin controller register values is being deprecated and DTS already switched to a DTS-local header. Do not reference the bindings header in schema and replace the defines with raw values. Signed-off-by: Krzysztof Kozlowski Acked-by: Linus Walleij Reviewed-by: Rob Herring --- .../pinctrl/samsung,pinctrl-pins-cfg.yaml | 1 - .../bindings/pinctrl/samsung,pinctrl.yaml | 63 ++++++++----------- 2 files changed, 27 insertions(+), 37 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-pins= -cfg.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-pins-= cfg.yaml index 9869d4dceddb..f796f27bf0e6 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-pins-cfg.ya= ml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-pins-cfg.ya= ml @@ -20,7 +20,6 @@ description: | The values used for config properties should be derived from the hardware manual and these values are programmed as-is into the pin pull up/down a= nd driver strength register of the pin-controller. - See also include/dt-bindings/pinctrl/samsung.h with useful constants. =20 See also Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml = for additional information and example. diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml= b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml index 3a65c66ca71d..dafa51c69c06 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml @@ -15,9 +15,6 @@ description: | This is a part of device tree bindings for Samsung S3C/S5P/Exynos SoC pin controller. =20 - Pin group settings (like drive strength, pull up/down) are available as - macros in include/dt-bindings/pinctrl/samsung.h. - All the pin controller nodes should be represented in the aliases node u= sing the following format 'pinctrl{n}' where n is a unique number for the ali= as. =20 @@ -138,8 +135,6 @@ additionalProperties: false =20 examples: - | - #include - pinctrl@7f008000 { compatible =3D "samsung,s3c64xx-pinctrl"; reg =3D <0x7f008000 0x1000>; @@ -166,8 +161,8 @@ examples: =20 uart0-data-pins { samsung,pins =3D "gpa-0", "gpa-1"; - samsung,pin-function =3D ; - samsung,pin-pud =3D ; + samsung,pin-function =3D <2>; + samsung,pin-pud =3D <0>; }; =20 // ... @@ -175,7 +170,6 @@ examples: =20 - | #include - #include =20 pinctrl@11400000 { compatible =3D "samsung,exynos4210-pinctrl"; @@ -197,9 +191,9 @@ examples: =20 uart0-data-pins { samsung,pins =3D "gpa0-0", "gpa0-1"; - samsung,pin-function =3D ; - samsung,pin-pud =3D ; - samsung,pin-drv =3D ; + samsung,pin-function =3D <2>; + samsung,pin-pud =3D <0>; + samsung,pin-drv =3D <0>; }; =20 // ... @@ -207,14 +201,14 @@ examples: sleep0: sleep-state { gpa0-0-pin { samsung,pins =3D "gpa0-0"; - samsung,pin-con-pdn =3D ; - samsung,pin-pud-pdn =3D ; + samsung,pin-con-pdn =3D <2>; + samsung,pin-pud-pdn =3D <0>; }; =20 gpa0-1-pin { samsung,pins =3D "gpa0-1"; - samsung,pin-con-pdn =3D ; - samsung,pin-pud-pdn =3D ; + samsung,pin-con-pdn =3D <0>; + samsung,pin-pud-pdn =3D <0>; }; =20 // ... @@ -223,7 +217,6 @@ examples: =20 - | #include - #include =20 pinctrl@11000000 { compatible =3D "samsung,exynos4210-pinctrl"; @@ -272,26 +265,26 @@ examples: =20 sd0-clk-pins { samsung,pins =3D "gpk0-0"; - samsung,pin-function =3D ; - samsung,pin-pud =3D ; - samsung,pin-drv =3D ; + samsung,pin-function =3D <2>; + samsung,pin-pud =3D <0>; + samsung,pin-drv =3D <3>; }; =20 sd4-bus-width8-pins { part-1-pins { samsung,pins =3D "gpk0-3", "gpk0-4", "gpk0-5", "gpk0-6"; - samsung,pin-function =3D ; - samsung,pin-pud =3D ; - samsung,pin-drv =3D ; + samsung,pin-function =3D <3>; + samsung,pin-pud =3D <3>; + samsung,pin-drv =3D <3>; }; =20 part-2-pins { samsung,pins =3D "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6"; - samsung,pin-function =3D ; - samsung,pin-pud =3D ; - samsung,pin-drv =3D ; + samsung,pin-function =3D <4>; + samsung,pin-pud =3D <3>; + samsung,pin-drv =3D <3>; }; }; =20 @@ -299,16 +292,15 @@ examples: =20 otg-gp-pins { samsung,pins =3D "gpx3-3"; - samsung,pin-function =3D ; - samsung,pin-pud =3D ; - samsung,pin-drv =3D ; + samsung,pin-function =3D <1>; + samsung,pin-pud =3D <0>; + samsung,pin-drv =3D <0>; samsung,pin-val =3D <0>; }; }; =20 - | #include - #include =20 pinctrl@10580000 { compatible =3D "samsung,exynos5433-pinctrl"; @@ -352,9 +344,9 @@ examples: initial_alive: initial-state { gpa0-0-pin { samsung,pins =3D "gpa0-0"; - samsung,pin-function =3D ; - samsung,pin-pud =3D ; - samsung,pin-drv =3D ; + samsung,pin-function =3D <0>; + samsung,pin-pud =3D <1>; + samsung,pin-drv =3D <0>; }; =20 // ... @@ -363,7 +355,6 @@ examples: =20 - | #include - #include =20 pinctrl@114b0000 { compatible =3D "samsung,exynos5433-pinctrl"; @@ -384,9 +375,9 @@ examples: i2s0-bus-pins { samsung,pins =3D "gpz0-0", "gpz0-1", "gpz0-2", "gpz0-3", "gpz0-4", "gpz0-5", "gpz0-6"; - samsung,pin-function =3D ; - samsung,pin-pud =3D ; - samsung,pin-drv =3D ; + samsung,pin-function =3D <2>; + samsung,pin-pud =3D <0>; + samsung,pin-drv =3D <0>; }; =20 // ... --=20 2.34.1 From nobody Sat Apr 11 02:21:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93DBC38147 for ; Tue, 16 Aug 2022 13:30:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235767AbiHPNas (ORCPT ); Tue, 16 Aug 2022 09:30:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235763AbiHPNa0 (ORCPT ); Tue, 16 Aug 2022 09:30:26 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35E23B8F28 for ; Tue, 16 Aug 2022 06:30:24 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id v2so14934261lfi.6 for ; Tue, 16 Aug 2022 06:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=rpFTAZjl2pleYfeFAlCfw7Z2JDn36v61i5OIVLO2w5I=; b=uvTyRrDNC6QxEbZyA44Zxl3dL5k8aNXBoKjruHNBXGtk2zV6fnuu5vtZ4/2VwKy1/w 1JPKp2UYomYYlmfRq6xgSv65G3QbqSt8okEA9Zal7bs2g+N4DMft9up8OGlH4E6QA0Lt gy6tWDnwimp4O8ZuTVeavEa2wTzOcaqmwRTDXQ+178hWWkkIYdpgmXZzNih2pdvWejUb Y80rYquHbGE7znX/n+mmZRKoTN7NsS4gLtmmP2jqzK9V3KV4Jcm3WPaKdIWpppfwue8f oRQfxNDbbIaNn2yyXcxDSeONpbGTpxdrECS+nJ5Z20pVahG3+E+mbhZS3/1UuAFSWG0r Yr1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=rpFTAZjl2pleYfeFAlCfw7Z2JDn36v61i5OIVLO2w5I=; b=kwkNb9awQKbcYuooNUhDEwQNeaxBNwCkXr8B3sfUA0Z37dyy1jbcTNCCIXyrtrJtJL PAq1GLdjYUiGiil4AxN6fxRAIKkiv8fvkJMIm+6jJUjx1ZzVG8xCU23p0F7Xvtvg8PS4 VO89vsXq6OPS5LiWC17GO6zFKac90SvvlZ2ZVp7GD10gpL7T17nQbPHlNmOR2dNp33Sj rE+RB1c1rlnYCZKQSiz+VuZLjkLxV/skZKRXDe+ZdJZbLdv8Kw4E3o16Hcn5PsvpddUY nMPeYx4ovvI696iOOze6UiuUBJhWi9qxxaZOhqcwme6DlP4Z5sVpgUHLSDJoQzGZGMXV jbqA== X-Gm-Message-State: ACgBeo2FX7hxw7lLIaUiEkGTnJn0Wr14L+LFQVgiH+6cY/ecfxQi1PFD jAwLg2wSSwndbr9KGj6Y2yx4jA== X-Google-Smtp-Source: AA6agR4Goe1n8aiYtC29+SCFdUP5bbCFlxfNYNF/MgBrjfL/Ht7JGKQpdw+rOfy5V5n3hRIXo+LcWA== X-Received: by 2002:a05:6512:39c3:b0:48b:90c2:da4c with SMTP id k3-20020a05651239c300b0048b90c2da4cmr6806066lfu.282.1660656622369; Tue, 16 Aug 2022 06:30:22 -0700 (PDT) Received: from krzk-bin.. (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id k19-20020a2eb753000000b0025e42f8e771sm1816301ljo.34.2022.08.16.06.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Aug 2022 06:30:21 -0700 (PDT) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Chanho Park , Rob Herring Subject: [PATCH v4 2/2] dt-bindings: pinctrl: samsung: deprecate header with register constants Date: Tue, 16 Aug 2022 16:30:16 +0300 Message-Id: <20220816133016.77553-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220816133016.77553-1-krzysztof.kozlowski@linaro.org> References: <20220816133016.77553-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" For convenience (less code duplication, some meaning added to raw number), the pin controller pin configuration register values were defined in the bindings header. These are not some IDs or other abstraction layer but raw numbers used in the registers These constants do not fit the purpose of bindings. They do not provide any abstraction, any hardware and driver independent ID. With minor exceptions, the Linux drivers actually do not use the bindings header at all. All of the constants were moved already to headers local to DTS (residing in DTS directory) and to Samsung pinctrl driver (where applicable), so remove any references to the bindings header and add a warning tha tit is deprecated. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Chanho Park Acked-by: Rob Herring Reviewed-by: Linus Walleij --- include/dt-bindings/pinctrl/samsung.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pi= nctrl/samsung.h index 950970634dfe..d1da5ff68d0c 100644 --- a/include/dt-bindings/pinctrl/samsung.h +++ b/include/dt-bindings/pinctrl/samsung.h @@ -10,6 +10,13 @@ #ifndef __DT_BINDINGS_PINCTRL_SAMSUNG_H__ #define __DT_BINDINGS_PINCTRL_SAMSUNG_H__ =20 +/* + * These bindings are deprecated, because they do not match the actual + * concept of bindings but rather contain pure register values. + * Instead include the header in the DTS source directory. + */ +#warning "These bindings are deprecated. Instead use the header in the DTS= source directory." + #define EXYNOS_PIN_PULL_NONE 0 #define EXYNOS_PIN_PULL_DOWN 1 #define EXYNOS_PIN_PULL_UP 3 --=20 2.34.1