From nobody Mon Sep 29 21:17:49 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91643C00140 for ; Tue, 16 Aug 2022 01:04:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234185AbiHPBEE (ORCPT ); Mon, 15 Aug 2022 21:04:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348688AbiHPA5r (ORCPT ); Mon, 15 Aug 2022 20:57:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38B0ADB05B; Mon, 15 Aug 2022 13:49:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A1FD6B811A6; Mon, 15 Aug 2022 20:49:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD7E8C433C1; Mon, 15 Aug 2022 20:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660596544; bh=w43Nn+CdXHZ0uAurAwKFhgQo8GpfGScQCXNh5qjlBX4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BuiOuTb3ZXWi88VF/YKT0XARd7yWJa7ec3KJ3PtWknjZeNqvIk/4YSlFzl/905qE2 PlIfML5cAdi5HaUWrUcnCfkKXI0jT0TteXdU68Il47xds78x+2kyLDbUrFcJMMkPzK sPB9pkHF7GMuMUEapdU2WwaeZ5IIEDMjdWv3Th5A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jianglei Nie , SeongJae Park , Andrew Morton , Sasha Levin Subject: [PATCH 5.19 1112/1157] mm/damon/reclaim: fix potential memory leak in damon_reclaim_init() Date: Mon, 15 Aug 2022 20:07:48 +0200 Message-Id: <20220815180524.793320919@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Jianglei Nie [ Upstream commit 188043c7f4f2bd662f2a55957d684fffa543e600 ] damon_reclaim_init() allocates a memory chunk for ctx with damon_new_ctx(). When damon_select_ops() fails, ctx is not released, which will lead to a memory leak. We should release the ctx with damon_destroy_ctx() when damon_select_ops() fails to fix the memory leak. Link: https://lkml.kernel.org/r/20220714063746.2343549-1-niejianglei2021@16= 3.com Fixes: 4d69c3457821 ("mm/damon/reclaim: use damon_select_ops() instead of d= amon_{v,p}a_set_operations()") Signed-off-by: Jianglei Nie Reviewed-by: SeongJae Park Cc: Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- mm/damon/reclaim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index 4b07c29effe9..0b3c7396cb90 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -441,8 +441,10 @@ static int __init damon_reclaim_init(void) if (!ctx) return -ENOMEM; =20 - if (damon_select_ops(ctx, DAMON_OPS_PADDR)) + if (damon_select_ops(ctx, DAMON_OPS_PADDR)) { + damon_destroy_ctx(ctx); return -EINVAL; + } =20 ctx->callback.after_wmarks_check =3D damon_reclaim_after_wmarks_check; ctx->callback.after_aggregation =3D damon_reclaim_after_aggregation; --=20 2.35.1