From nobody Mon Sep 29 21:09:37 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C71C25B0D for ; Tue, 16 Aug 2022 04:53:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233191AbiHPEx3 (ORCPT ); Tue, 16 Aug 2022 00:53:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233110AbiHPEuk (ORCPT ); Tue, 16 Aug 2022 00:50:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 334D819AB82; Mon, 15 Aug 2022 13:47:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9541CB811A0; Mon, 15 Aug 2022 20:47:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C9E4C433C1; Mon, 15 Aug 2022 20:47:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660596424; bh=o2amVQnMjpMZVwW10U/wPBMwSxjuorkuewoLVWlfbSg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hoesMLbFmzES9LyVEuUZB40tWA+SJbxm9lclLFH5J1pm1uA13V6Zwgeh1vGNJy29Y OSCd1mAi5WD2Mfv4XbABvmoooDXek3SsCV+QoZc43TMfpv+LNv9F4l11mxI7Cq4LDP TrTovzNUUj+nwq9WZynN6Uq/sCKG/Qut9Lk+mSHs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tyler Hicks , Christian Schoenebeck , Dominique Martinet , Sasha Levin Subject: [PATCH 5.19 1074/1157] net/9p: Initialize the iounit field during fid creation Date: Mon, 15 Aug 2022 20:07:10 +0200 Message-Id: <20220815180523.080296854@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Tyler Hicks [ Upstream commit aa7aeee169480e98cf41d83c01290a37e569be6d ] Ensure that the fid's iounit field is set to zero when a new fid is created. Certain 9P operations, such as OPEN and CREATE, allow the server to reply with an iounit size which the client code assigns to the p9_fid struct shortly after the fid is created by p9_fid_create(). On the other hand, an XATTRWALK operation doesn't allow for the server to specify an iounit value. The iounit field of the newly allocated p9_fid struct remained uninitialized in that case. Depending on allocation patterns, the iounit value could have been something reasonable that was carried over from previously freed fids or, in the worst case, could have been arbitrary values from non-fid related usages of the memory location. The bug was detected in the Windows Subsystem for Linux 2 (WSL2) kernel after the uninitialized iounit field resulted in the typical sequence of two getxattr(2) syscalls, one to get the size of an xattr and another after allocating a sufficiently sized buffer to fit the xattr value, to hit an unexpected ERANGE error in the second call to getxattr(2). An uninitialized iounit field would sometimes force rsize to be smaller than the xattr value size in p9_client_read_once() and the 9P server in WSL refused to chunk up the READ on the attr_fid and, instead, returned ERANGE to the client. The virtfs server in QEMU seems happy to chunk up the READ and this problem goes undetected there. Link: https://lkml.kernel.org/r/20220710141402.803295-1-tyhicks@linux.micro= soft.com Fixes: ebf46264a004 ("fs/9p: Add support user. xattr") Cc: stable@vger.kernel.org Signed-off-by: Tyler Hicks Reviewed-by: Christian Schoenebeck Signed-off-by: Dominique Martinet Signed-off-by: Sasha Levin --- net/9p/client.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/net/9p/client.c +++ b/net/9p/client.c @@ -886,16 +886,13 @@ static struct p9_fid *p9_fid_create(stru struct p9_fid *fid; =20 p9_debug(P9_DEBUG_FID, "clnt %p\n", clnt); - fid =3D kmalloc(sizeof(*fid), GFP_KERNEL); + fid =3D kzalloc(sizeof(*fid), GFP_KERNEL); if (!fid) return NULL; =20 - memset(&fid->qid, 0, sizeof(fid->qid)); fid->mode =3D -1; fid->uid =3D current_fsuid(); fid->clnt =3D clnt; - fid->rdir =3D NULL; - fid->fid =3D 0; refcount_set(&fid->count, 1); =20 idr_preload(GFP_KERNEL);