From nobody Mon Sep 29 21:22:40 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB81DC25B0D for ; Tue, 16 Aug 2022 04:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233070AbiHPExK (ORCPT ); Tue, 16 Aug 2022 00:53:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232851AbiHPEt7 (ORCPT ); Tue, 16 Aug 2022 00:49:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A137198EFE; Mon, 15 Aug 2022 13:46:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 19CABB81197; Mon, 15 Aug 2022 20:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5902BC433C1; Mon, 15 Aug 2022 20:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660596391; bh=o535tWdjj0uexPJKKPrDxPX7BBwJbM7NqPGXgCvn8HI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YsCr8KV8OBixhFvvr9q1QuaqpBynp5tl0BoiZxH023eY1QGMBxuLKX5omiK1jyYST KnVdGlEtqvaFTDbLO0VI6dBIk87L8YZ0ZMv6xf/RhhZoAgyuZou/PiiXTHdsozq95o xkxoZrQ966sg0eZr8QnaS0ltwEdl+SD5PyjepX/s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kernel test robot , Alexander Lobakin , Andy Shevchenko , Lu Baolu , Yury Norov , Sasha Levin Subject: [PATCH 5.19 1065/1157] iommu/vt-d: avoid invalid memory access via node_online(NUMA_NO_NODE) Date: Mon, 15 Aug 2022 20:07:01 +0200 Message-Id: <20220815180522.674659278@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Alexander Lobakin [ Upstream commit b0b0b77ea611e3088e9523e60860f4f41b62b235 ] KASAN reports: [ 4.668325][ T0] BUG: KASAN: wild-memory-access in dmar_parse_one_rhsa (arc= h/x86/include/asm/bitops.h:214 arch/x86/include/asm/bitops.h:226 include/as= m-generic/bitops/instrumented-non-atomic.h:142 include/linux/nodemask.h:415= drivers/iommu/intel/dmar.c:497) [ 4.676149][ T0] Read of size 8 at addr 1fffffff85115558 by task swap= per/0/0 [ 4.683454][ T0] [ 4.685638][ T0] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc3= -00004-g0e862838f290 #1 [ 4.694331][ T0] Hardware name: Supermicro SYS-5018D-FN4T/X10SDV-8C-T= LN4F, BIOS 1.1 03/02/2016 [ 4.703196][ T0] Call Trace: [ 4.706334][ T0] [ 4.709133][ T0] ? dmar_parse_one_rhsa (arch/x86/include/asm/bitops.h:214 a= rch/x86/include/asm/bitops.h:226 include/asm-generic/bitops/instrumented-no= n-atomic.h:142 include/linux/nodemask.h:415 drivers/iommu/intel/dmar.c:497) after converting the type of the first argument (@nr, bit number) of arch_test_bit() from `long` to `unsigned long`[0]. Under certain conditions (for example, when ACPI NUMA is disabled via command line), pxm_to_node() can return %NUMA_NO_NODE (-1). It is valid 'magic' number of NUMA node, but not valid bit number to use in bitops. node_online() eventually descends to test_bit() without checking for the input, assuming it's on caller side (which might be good for perf-critical tasks). There, -1 becomes %ULONG_MAX which leads to an insane array index when calculating bit position in memory. For now, add an explicit check for @node being not %NUMA_NO_NODE before calling test_bit(). The actual logics didn't change here at all. [0] https://github.com/norov/linux/commit/0e862838f290147ea9c16db852d8d494b= 552d38d Fixes: ee34b32d8c29 ("dmar: support for parsing Remapping Hardware Static A= ffinity structure") Cc: stable@vger.kernel.org # 2.6.33+ Reported-by: kernel test robot Signed-off-by: Alexander Lobakin Reviewed-by: Andy Shevchenko Reviewed-by: Lu Baolu Signed-off-by: Yury Norov Signed-off-by: Sasha Levin --- drivers/iommu/intel/dmar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c index 9699ca101c62..64b14ac4c7b0 100644 --- a/drivers/iommu/intel/dmar.c +++ b/drivers/iommu/intel/dmar.c @@ -494,7 +494,7 @@ static int dmar_parse_one_rhsa(struct acpi_dmar_header = *header, void *arg) if (drhd->reg_base_addr =3D=3D rhsa->base_address) { int node =3D pxm_to_node(rhsa->proximity_domain); =20 - if (!node_online(node)) + if (node !=3D NUMA_NO_NODE && !node_online(node)) node =3D NUMA_NO_NODE; drhd->iommu->node =3D node; return 0; --=20 2.35.1