From nobody Mon Sep 29 20:12:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB8E8C25B08 for ; Tue, 16 Aug 2022 00:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241326AbiHPAtI (ORCPT ); Mon, 15 Aug 2022 20:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346951AbiHPApt (ORCPT ); Mon, 15 Aug 2022 20:45:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6037912D; Mon, 15 Aug 2022 13:42:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0D643B80EA8; Mon, 15 Aug 2022 20:42:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D112C433D6; Mon, 15 Aug 2022 20:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660596133; bh=WF7gVEsWaD81stKo2H4fD5esY9t3YMHFHgogMQnH3z8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EYKS1SfXcoU/ieYBPfw7V4Zl2a6SQOS39h9iqiRVkT1ktwc4dAcAtQOsokGEqZVuH eeVdQUhO/sMwiR8J7KYH+o2CJRHcOGt4azVvqUEsGPmwfCxh1LO7L0CPCTNC+tFgfv g6Trnfli1/n0YsxiY2MYvSvhfvaV08SUnsYebI0o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Mark Brown , Sasha Levin Subject: [PATCH 5.19 0984/1157] ASoC: audio-graph-card: Add of_node_put() in fail path Date: Mon, 15 Aug 2022 20:05:40 +0200 Message-Id: <20220815180519.105579478@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Liang He [ Upstream commit 65fb8e2ef3531a6e950060fca6e551c923fb0f0e ] In asoc_simple_parse_dai(), we should call of_node_put() for the reference returned by of_graph_get_port_parent() in fail path. Fixes: ae30a694da4c ("ASoC: simple-card-utils: add asoc_simple_card_parse_d= ai()") Signed-off-by: Liang He Link: https://lore.kernel.org/r/20220721144308.1301587-1-windhl@126.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/generic/audio-graph-card.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio= -graph-card.c index 2b598af8feef..b327372f2e4a 100644 --- a/sound/soc/generic/audio-graph-card.c +++ b/sound/soc/generic/audio-graph-card.c @@ -158,8 +158,10 @@ static int asoc_simple_parse_dai(struct device_node *e= p, * if he unbinded CPU or Codec. */ ret =3D snd_soc_get_dai_name(&args, &dlc->dai_name); - if (ret < 0) + if (ret < 0) { + of_node_put(node); return ret; + } =20 dlc->of_node =3D node; =20 --=20 2.35.1