From nobody Mon Sep 29 21:18:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC324C3F6B0 for ; Tue, 16 Aug 2022 04:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232489AbiHPEpf (ORCPT ); Tue, 16 Aug 2022 00:45:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231244AbiHPEmA (ORCPT ); Tue, 16 Aug 2022 00:42:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5E4D31EF5; Mon, 15 Aug 2022 13:36:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 63056611D6; Mon, 15 Aug 2022 20:36:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B4FFC433D6; Mon, 15 Aug 2022 20:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660595801; bh=P6zsy+Br50IxBtDghnh0AItILePGuWVPwZtgnBjUs34=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xmcTCX/h7vgy5NZGLnGpDxpa3D5NVTngVNBxy1VQf7yJF+b7CCdH7TJdZm3Atb33J Aqxke/qRzu7Jm45eRy2moWm1wvlLQIgg5VmAl5a5ESe1Pgo7klaISYCnS0YLvdV3wW /KDVjNlqhriDzSHGTXAK4zLhYM5S7coY27OwLNvU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bean Huo , Christoph Hellwig , Jens Axboe , Sasha Levin Subject: [PATCH 5.19 0880/1157] nvme: use command_id instead of req->tag in trace_nvme_complete_rq() Date: Mon, 15 Aug 2022 20:03:56 +0200 Message-Id: <20220815180514.631632038@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Bean Huo [ Upstream commit 679c54f2de672b7d79d02f8c4ad483ff6dd8ce2e ] Use command_id instead of req->tag in trace_nvme_complete_rq(), because of commit e7006de6c238 ("nvme: code command_id with a genctr for use authentication after release"), cmd->common.command_id is set to ((genctl & 0xf)< 12 | req->tag), no longer req->tag, which makes cid in trace_nvme_complete_rq and trace_nvme_setup_cmd are not the same. Fixes: e7006de6c238 ("nvme: code command_id with a genctr for use authentic= ation after release") Signed-off-by: Bean Huo Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/nvme/host/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/trace.h index 37c7f4c89f92..6f0eaf6a1528 100644 --- a/drivers/nvme/host/trace.h +++ b/drivers/nvme/host/trace.h @@ -98,7 +98,7 @@ TRACE_EVENT(nvme_complete_rq, TP_fast_assign( __entry->ctrl_id =3D nvme_req(req)->ctrl->instance; __entry->qid =3D nvme_req_qid(req); - __entry->cid =3D req->tag; + __entry->cid =3D nvme_req(req)->cmd->common.command_id; __entry->result =3D le64_to_cpu(nvme_req(req)->result.u64); __entry->retries =3D nvme_req(req)->retries; __entry->flags =3D nvme_req(req)->flags; --=20 2.35.1