From nobody Mon Sep 29 22:43:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 408EDC25B0D for ; Tue, 16 Aug 2022 00:33:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350187AbiHPAd1 (ORCPT ); Mon, 15 Aug 2022 20:33:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352794AbiHPAbC (ORCPT ); Mon, 15 Aug 2022 20:31:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5864B1859BA; Mon, 15 Aug 2022 13:36:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B90D9611D2; Mon, 15 Aug 2022 20:36:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA1BBC433D6; Mon, 15 Aug 2022 20:36:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660595766; bh=09RnNxg19SQJ4cNTRE294GN7J1KK248eGE8198Ys4xk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UeYd+pxgN3vcsTpqLbTFYF7420chX1DstmTocfo4B+KvUxFx+30S20gCBTpF4+mEs XkEdxrTNu++BBt9a3UcKLBGn4gKBYIBt+KRmfVnWbQz5zRRKsT4+JyG972SQPK2zyY 2SoXOXo0aa6Ea8xL9mshNWsAEt+jVhsKhqyBZmEE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Jonathan Cameron , Sasha Levin Subject: [PATCH 5.19 0835/1157] iio: adc: max1027: unlock on error path in max1027_read_single_value() Date: Mon, 15 Aug 2022 20:03:11 +0200 Message-Id: <20220815180512.893249817@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Dan Carpenter [ Upstream commit 06ee60eb507f00fb3643876ec05318c63332dc88 ] If max1027_wait_eoc() fails then call iio_device_release_direct_mode() before returning. Fixes: a0e831653ef9 ("iio: adc: max1027: Introduce an end of conversion hel= per") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/YsbztVuAXnau2cIZ@kili Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/adc/max1027.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c index b725d012625c..136fcf753837 100644 --- a/drivers/iio/adc/max1027.c +++ b/drivers/iio/adc/max1027.c @@ -349,8 +349,7 @@ static int max1027_read_single_value(struct iio_dev *in= dio_dev, if (ret < 0) { dev_err(&indio_dev->dev, "Failed to configure conversion register\n"); - iio_device_release_direct_mode(indio_dev); - return ret; + goto release; } =20 /* @@ -360,11 +359,12 @@ static int max1027_read_single_value(struct iio_dev *= indio_dev, */ ret =3D max1027_wait_eoc(indio_dev); if (ret) - return ret; + goto release; =20 /* Read result */ ret =3D spi_read(st->spi, st->buffer, (chan->type =3D=3D IIO_TEMP) ? 4 : = 2); =20 +release: iio_device_release_direct_mode(indio_dev); =20 if (ret < 0) --=20 2.35.1