From nobody Mon Sep 29 21:07:49 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 656F1C25B08 for ; Tue, 16 Aug 2022 00:04:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355566AbiHPAAy (ORCPT ); Mon, 15 Aug 2022 20:00:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355972AbiHOXx0 (ORCPT ); Mon, 15 Aug 2022 19:53:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4906D15BBB7; Mon, 15 Aug 2022 13:18:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9768BB80EA8; Mon, 15 Aug 2022 20:18:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFB55C433C1; Mon, 15 Aug 2022 20:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660594680; bh=twaGXF0MvgZEXkpoKJrkeQCigkqeCs2jGuviee0Fe20=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KlBFdAEmb/KviagQE9qBjAub9kaY6CPDpQsQyY21Aw4/x7cS5VLOAyAc5Pf0mpLI+ fiD15xv4ER77M65Nc3ynEfEnEkFWelJ0kFEJYM/2LjDMWvMh5caTcqg4VVuyM3nKhJ X4eio71mKfQOa3sYivzg/5XsLye0szzLS+Gv+Wfk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Daniel Borkmann , Martin KaFai Lau , Alan Maguire , Sasha Levin Subject: [PATCH 5.19 0525/1157] libbpf: Fix str_has_sfx()s return value Date: Mon, 15 Aug 2022 19:58:01 +0200 Message-Id: <20220815180500.671777579@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Dan Carpenter [ Upstream commit 14229b8153a3ca51d97a22a18c68deeae64afce0 ] The return from strcmp() is inverted so it wrongly returns true instead of false and vice versa. Fixes: a1c9d61b19cb ("libbpf: Improve library identification for uprobe bin= ary path resolution") Signed-off-by: Dan Carpenter Signed-off-by: Daniel Borkmann Acked-by: Martin KaFai Lau Cc: Alan Maguire Link: https://lore.kernel.org/bpf/YtZ+/dAA195d99ak@kili Signed-off-by: Sasha Levin --- tools/lib/bpf/libbpf_internal.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/lib/bpf/libbpf_internal.h b/tools/lib/bpf/libbpf_interna= l.h index ef5d975078e5..230ac5699c3d 100644 --- a/tools/lib/bpf/libbpf_internal.h +++ b/tools/lib/bpf/libbpf_internal.h @@ -109,9 +109,9 @@ static inline bool str_has_sfx(const char *str, const c= har *sfx) size_t str_len =3D strlen(str); size_t sfx_len =3D strlen(sfx); =20 - if (sfx_len <=3D str_len) - return strcmp(str + str_len - sfx_len, sfx); - return false; + if (sfx_len > str_len) + return false; + return strcmp(str + str_len - sfx_len, sfx) =3D=3D 0; } =20 /* Symbol versioning is different between static and shared library. --=20 2.35.1