From nobody Mon Sep 29 21:09:05 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1CC4C00140 for ; Mon, 15 Aug 2022 23:57:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354846AbiHOX5e (ORCPT ); Mon, 15 Aug 2022 19:57:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355385AbiHOXwB (ORCPT ); Mon, 15 Aug 2022 19:52:01 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CEAC92F6E; Mon, 15 Aug 2022 13:16:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 15FBBB8115B; Mon, 15 Aug 2022 20:16:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47133C433D6; Mon, 15 Aug 2022 20:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660594605; bh=MEBQGLR4Wi8YUObvifBBBpQoQcSMmdCnvx59pobyrQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wHKxf8d0kxwoQ9MwisoKksDJPeHs+QQmC/gi05Ak+XqgrYEH4bg1dR3WEoWmqM5TX Zgi7Q7tfP/fMCxQeqB6uaLP1XSX5GpAql3+ecG+MACnwrns431rjGVP9CZa3zVIiAX bGHTODN3LjlNNATqHwdTCrMpQUQSjjgXGp503ZqU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Andy Shevchenko , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.19 0501/1157] media: ov7251: add missing disable functions on error in ov7251_set_power_on() Date: Mon, 15 Aug 2022 19:57:37 +0200 Message-Id: <20220815180459.734281331@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Yang Yingliang [ Upstream commit 7a9795b31049b7e233d050a82b00094155a695c7 ] Add the missing gpiod_set_value_cansleep() and clk_disable_unprepare() before return from ov7251_set_power_on() in the error handling case. Fixes: 9e1d3012cc10 ("media: i2c: Remove .s_power() from ov7251") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Andy Shevchenko Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/ov7251.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/ov7251.c b/drivers/media/i2c/ov7251.c index 0e7be15bc20a..ad9689820ecc 100644 --- a/drivers/media/i2c/ov7251.c +++ b/drivers/media/i2c/ov7251.c @@ -934,6 +934,8 @@ static int ov7251_set_power_on(struct device *dev) ARRAY_SIZE(ov7251_global_init_setting)); if (ret < 0) { dev_err(ov7251->dev, "error during global init\n"); + gpiod_set_value_cansleep(ov7251->enable_gpio, 0); + clk_disable_unprepare(ov7251->xclk); ov7251_regulators_disable(ov7251); return ret; } --=20 2.35.1