From nobody Mon Sep 29 21:15:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50DCC00140 for ; Mon, 15 Aug 2022 23:32:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243819AbiHOXcX (ORCPT ); Mon, 15 Aug 2022 19:32:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344063AbiHOX0K (ORCPT ); Mon, 15 Aug 2022 19:26:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6108E80499; Mon, 15 Aug 2022 13:06:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F088B60025; Mon, 15 Aug 2022 20:06:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F203CC433C1; Mon, 15 Aug 2022 20:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660593996; bh=9/FwdszUVmHSP32BE8L/M81PIdZNgATYQgM69wIrkN4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j7w0nk1mfFhmAbdz5BKelKOU7I9jPFanJcwMy0sePnWerR9Z8RY6bVD7KQx7Zh4xG kYtJMDb6cgt/ArCEmL4QpieJr7upYLq3EWTL9nVyESTsdca0rQV7Ru0CLYr0sE4FJ7 Ccmw4EWe1cu5IxvmL2Pq65z33+JP/KNXn0Xsyb5o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "=?UTF-8?q?N=C3=ADcolas=20F . =20R . =20A . =20Prado?=" , AngeloGioacchino Del Regno , Robert Foss , Sasha Levin Subject: [PATCH 5.19 0359/1157] drm/bridge: anx7625: Zero error variable when panel bridge not present Date: Mon, 15 Aug 2022 19:55:15 +0200 Message-Id: <20220815180454.076004289@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: N=C3=ADcolas F. R. A. Prado [ Upstream commit 3f49f7591e7150c502aa8d04354941ec2394153f ] While parsing the DT, the anx7625 driver checks for the presence of a panel bridge on endpoint 1. If it is missing, pdata->panel_bridge stores the error pointer and the function returns successfully without first cleaning that variable. This is an issue since other functions later check for the presence of a panel bridge by testing the trueness of that variable. In order to ensure proper behavior, zero out pdata->panel_bridge before returning when no panel bridge is found. Fixes: 9e82ea0fb1df ("drm/bridge: anx7625: switch to devm_drm_of_get_bridge= ") Signed-off-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Robert Foss Link: https://patchwork.freedesktop.org/patch/msgid/20220613163705.1531721-= 1-nfraprado@collabora.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/analogix/anx7625.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/br= idge/analogix/anx7625.c index 01f46d9189c1..0117fd8c62ae 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1657,8 +1657,10 @@ static int anx7625_parse_dt(struct device *dev, =20 pdata->panel_bridge =3D devm_drm_of_get_bridge(dev, np, 1, 0); if (IS_ERR(pdata->panel_bridge)) { - if (PTR_ERR(pdata->panel_bridge) =3D=3D -ENODEV) + if (PTR_ERR(pdata->panel_bridge) =3D=3D -ENODEV) { + pdata->panel_bridge =3D NULL; return 0; + } =20 return PTR_ERR(pdata->panel_bridge); } --=20 2.35.1