From nobody Mon Sep 29 21:22:40 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66C7CC25B0E for ; Mon, 15 Aug 2022 23:32:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347438AbiHOXbL (ORCPT ); Mon, 15 Aug 2022 19:31:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245313AbiHOXZk (ORCPT ); Mon, 15 Aug 2022 19:25:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C592BA158; Mon, 15 Aug 2022 13:06:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B26E4B80EA8; Mon, 15 Aug 2022 20:06:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1AEDC433D6; Mon, 15 Aug 2022 20:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660593959; bh=+83nn2Vmra04i9vGT7jKTSovy3N5iVDyO+3QwXpaetQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j22rfsS4EHktNElLY1/DHBQFpMAcoDvK5CwF/ysnPRMLDdQKXZeAszgOfIHlyR0sA fPcc2naNqnUNTDk8c9f8BPD2E24a/GHfL5ZsmXBznfhnhRDy9cFswya0uhBhjWwayN yjMGU5TLRBB0ku6CQ34MhXiJIalQo6QX2OR/mxS4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Peng Wu , Hulk Robot , Herbert Xu , Sasha Levin Subject: [PATCH 5.19 0354/1157] crypto: sun8i-ss - fix a NULL vs IS_ERR() check in sun8i_ss_hashkey Date: Mon, 15 Aug 2022 19:55:10 +0200 Message-Id: <20220815180453.869574638@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Peng Wu [ Upstream commit 7e8df1fc2d669d04c1f8a9e2d61d7afba1b43df4 ] The crypto_alloc_shash() function never returns NULL. It returns error pointers. Fixes: 801b7d572c0a ("crypto: sun8i-ss - add hmac(sha1)") Signed-off-by: Peng Wu Reported-by: Hulk Robot Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/cr= ypto/allwinner/sun8i-ss/sun8i-ss-hash.c index 845019bd9591..36a82b22953c 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c @@ -30,8 +30,8 @@ static int sun8i_ss_hashkey(struct sun8i_ss_hash_tfm_ctx = *tfmctx, const u8 *key, int ret =3D 0; =20 xtfm =3D crypto_alloc_shash("sha1", 0, CRYPTO_ALG_NEED_FALLBACK); - if (!xtfm) - return -ENOMEM; + if (IS_ERR(xtfm)) + return PTR_ERR(xtfm); =20 len =3D sizeof(*sdesc) + crypto_shash_descsize(xtfm); sdesc =3D kmalloc(len, GFP_KERNEL); --=20 2.35.1