From nobody Mon Sep 29 20:18:39 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99500C00140 for ; Mon, 15 Aug 2022 23:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244603AbiHOXIj (ORCPT ); Mon, 15 Aug 2022 19:08:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352994AbiHOXG5 (ORCPT ); Mon, 15 Aug 2022 19:06:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1552386704; Mon, 15 Aug 2022 12:59:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 90BEFB80EB1; Mon, 15 Aug 2022 19:59:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF6B8C433C1; Mon, 15 Aug 2022 19:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660593541; bh=6+wA0NmZlSrQQuTg7iIoaIhed/v8R2Ua5FQQXmq+c7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LHliD1EQunhhpL8XeRTGSI14rhCCvWnuyjcY885jIxbjauc+qBQP0xymPklG7anxu 180ntmpYG+Qidjiuoeqr/rJz4wPTPLLLlKW7JeNqSuEDHMsshMrd55YyF84wW+RNp0 BVWcXoas8B3I5SCLos4Ih89uB8UFxDCNQnGmGId0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luca Weiss , Konrad Dybcio , Stephan Gerhold , Bjorn Andersson , Sasha Levin Subject: [PATCH 5.19 0285/1157] ARM: dts: qcom: msm8974: Disable remoteprocs by default Date: Mon, 15 Aug 2022 19:54:01 +0200 Message-Id: <20220815180451.017500034@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Stephan Gerhold [ Upstream commit 8d8be8dd7c1f5d50f84ecc7a6a41962da48c6164 ] The remoteproc configuration in qcom-msm8974.dtsi is incomplete because it lacks the regulator supplies that should be added in the board DT files. Some of the msm8974 boards are currently missing the regulator supplies and should have the remoteprocs disabled to avoid making use of the incomplete configuration. This also fixes dtbs_check warnings after moving "qcom,msm8974-mss-pil" to DT schema, which rightfully complains that the -supply properties are missing for some boards: qcom-apq8074-dragonboard.dtb: remoteproc@fc880000: 'pll-supply' is a required property From schema: remoteproc/qcom,msm8916-mss-pil.yaml remoteproc@fc880000: 'mss-supply' is a required property From schema: remoteproc/qcom,msm8916-mss-pil.yaml remoteproc@fc880000: 'oneOf' conditional failed, one must be fixed: 'power-domains' is a required property 'power-domain-names' is a required property, or 'cx-supply' is a required property 'mx-supply' is a required property Cc: Luca Weiss Cc: Konrad Dybcio Fixes: f300826d27be ("ARM: dts: qcom-msm8974: Sort and clean up nodes") Signed-off-by: Stephan Gerhold Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220712124421.3129206-4-stephan.gerhold@ke= rnkonzept.com Signed-off-by: Sasha Levin --- arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++++ arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts | 2 ++ arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 2 ++ 3 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-m= sm8974.dtsi index 3c31c95aa6b9..2d9416d1a6c8 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi @@ -1182,6 +1182,8 @@ remoteproc_mss: remoteproc@fc880000 { qcom,smem-states =3D <&modem_smp2p_out 0>; qcom,smem-state-names =3D "stop"; =20 + status =3D "disabled"; + mba { memory-region =3D <&mba_region>; }; @@ -1662,6 +1664,8 @@ remoteproc_adsp: remoteproc@fe200000 { qcom,smem-states =3D <&adsp_smp2p_out 0>; qcom,smem-state-names =3D "stop"; =20 + status =3D "disabled"; + smd-edge { interrupts =3D ; =20 diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm= /boot/dts/qcom-msm8974pro-fairphone-fp2.dts index 58cb2ce1e4df..8a6b8e4de887 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts @@ -147,10 +147,12 @@ wcnss { }; =20 &remoteproc_adsp { + status =3D "okay"; cx-supply =3D <&pm8841_s2>; }; =20 &remoteproc_mss { + status =3D "okay"; cx-supply =3D <&pm8841_s2>; mss-supply =3D <&pm8841_s3>; mx-supply =3D <&pm8841_s1>; diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/= boot/dts/qcom-msm8974pro-samsung-klte.dts index d6b2300a8223..577cbffad010 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts @@ -457,10 +457,12 @@ fuelgauge_pin: fuelgauge-int-pin { }; =20 &remoteproc_adsp { + status =3D "okay"; cx-supply =3D <&pma8084_s2>; }; =20 &remoteproc_mss { + status =3D "okay"; cx-supply =3D <&pma8084_s2>; mss-supply =3D <&pma8084_s6>; mx-supply =3D <&pma8084_s1>; --=20 2.35.1