From nobody Mon Sep 29 21:07:51 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4826C00140 for ; Mon, 15 Aug 2022 23:08:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346119AbiHOXIT (ORCPT ); Mon, 15 Aug 2022 19:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352702AbiHOXF5 (ORCPT ); Mon, 15 Aug 2022 19:05:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B27ED785B6; Mon, 15 Aug 2022 12:58:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 018EEB81157; Mon, 15 Aug 2022 19:58:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 632ECC433D7; Mon, 15 Aug 2022 19:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660593525; bh=RyfyMD2avYPrcXzgnjWluHibnunGgUa10wADbejMdW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ki2dpbVUUSqsP0NV3zNcY/v+equitFl6Ec/K10WnT+vVuOyzAdzGLN7Ir4v5rLhH7 GIt5dVzsKZ9EKDZ4xp+s2DtmtDy5iU1lIK2XcE7ZArW5+iTjsPbArT7QDLbWz2C+0/ /L7+IMA9BGRXi9gxuDDF1g1Htuh1P6X9hGVd0JPQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Konrad Dybcio , Marijn Suijten , Bjorn Andersson , Sasha Levin Subject: [PATCH 5.19 0283/1157] arm64: dts: qcom: msm8998: Make regulator voltages multiple of step-size Date: Mon, 15 Aug 2022 19:53:59 +0200 Message-Id: <20220815180450.931748149@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Marijn Suijten [ Upstream commit 2aa54fa87cca1fa43870a9caf4fcce00eb087fa5 ] These voltages are not a multiple of the given step-size 8000 (with base voltage 1664000) in pm8998_pldo, resulting in PLDO regulators l18 and l22 failing to validate and in turn not probing the rpm-pm8998-regulator driver: l18: unsupportable voltage constraints 2856000-2848000uV qcom_rpm_smd_regulator rpm-glink:rpm-requests:pm8998-regulators: l18: d= evm_regulator_register() failed, ret=3D-22 Round the voltages down for the sake of erring on the safe side, leaving a comment in place to document this discrepancy wrt downstream sources. Fixes: 390883af89d2 ("arm64: dts: qcom: msm8998: Introduce support for Sony= Yoshino platform") Reported-by: Konrad Dybcio Signed-off-by: Marijn Suijten Reviewed-by: Konrad Dybcio Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220507153627.1478268-1-marijn.suijten@som= ainline.org Signed-off-by: Sasha Levin --- .../dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dt= s b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts index 4a1f98a21031..c21333aa73c2 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts +++ b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts @@ -26,11 +26,13 @@ &lab { }; =20 &vreg_l18a_2p85 { - regulator-min-microvolt =3D <2850000>; - regulator-max-microvolt =3D <2850000>; + /* Note: Round-down from 2850000 to be a multiple of PLDO step-size 8000 = */ + regulator-min-microvolt =3D <2848000>; + regulator-max-microvolt =3D <2848000>; }; =20 &vreg_l22a_2p85 { - regulator-min-microvolt =3D <2700000>; - regulator-max-microvolt =3D <2700000>; + /* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 = */ + regulator-min-microvolt =3D <2696000>; + regulator-max-microvolt =3D <2696000>; }; --=20 2.35.1