From nobody Mon Sep 29 21:09:36 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D14C25B08 for ; Mon, 15 Aug 2022 23:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346547AbiHOXC2 (ORCPT ); Mon, 15 Aug 2022 19:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352761AbiHOXBC (ORCPT ); Mon, 15 Aug 2022 19:01:02 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FACB857D4; Mon, 15 Aug 2022 12:57:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0BDB8CE12C3; Mon, 15 Aug 2022 19:57:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFD77C433D7; Mon, 15 Aug 2022 19:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660593462; bh=8RXkZKFvrd2qoUJvhKiv/H00JN0pGT/nZea2GiKVapQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yrplVk32eZl66qa3h0/nvB82/ojqns/qNJYh9muaWeYfxTtK+zmhZRkIsohaHE1R3 d14JueIWlY1sWYSuTqdVKpBa3QsRg1x/k8ifL/jicN/ycqn5VJ06DjGjQX3lmZU4vz RapsK5zPEisYQJKYPwPd/Ogu+c4DeLvI1rUFIpsA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yang Yingliang , Mark Brown , Sasha Levin Subject: [PATCH 5.19 0271/1157] spi: tegra20-slink: fix UAF in tegra_slink_remove() Date: Mon, 15 Aug 2022 19:53:47 +0200 Message-Id: <20220815180450.455627043@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Yang Yingliang [ Upstream commit 7e9984d183bb1e99e766c5c2b950ff21f7f7b6c0 ] After calling spi_unregister_master(), the refcount of master will be decrease to 0, and it will be freed in spi_controller_release(), the device data also will be freed, so it will lead a UAF when using 'tspi'. To fix this, get the master before unregister and put it when finish using it. Fixes: 26c863418221 ("spi: tegra20-slink: Don't use resource-managed spi_re= gister helper") Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20220713094024.1508869-1-yangyingliang@huaw= ei.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-tegra20-slink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slin= k.c index 38360434d6e9..148043d0c2b8 100644 --- a/drivers/spi/spi-tegra20-slink.c +++ b/drivers/spi/spi-tegra20-slink.c @@ -1136,7 +1136,7 @@ static int tegra_slink_probe(struct platform_device *= pdev) =20 static int tegra_slink_remove(struct platform_device *pdev) { - struct spi_master *master =3D platform_get_drvdata(pdev); + struct spi_master *master =3D spi_master_get(platform_get_drvdata(pdev)); struct tegra_slink_data *tspi =3D spi_master_get_devdata(master); =20 spi_unregister_master(master); @@ -1151,6 +1151,7 @@ static int tegra_slink_remove(struct platform_device = *pdev) if (tspi->rx_dma_chan) tegra_slink_deinit_dma_param(tspi, true); =20 + spi_master_put(master); return 0; } =20 --=20 2.35.1