From nobody Mon Sep 29 21:12:44 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA9A1C00140 for ; Mon, 15 Aug 2022 22:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343843AbiHOW6y (ORCPT ); Mon, 15 Aug 2022 18:58:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352735AbiHOW4l (ORCPT ); Mon, 15 Aug 2022 18:56:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF2D513DEA9; Mon, 15 Aug 2022 12:56:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E5F461295; Mon, 15 Aug 2022 19:56:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B9E7C433D6; Mon, 15 Aug 2022 19:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660593360; bh=AD1b7mfMgGwtW/zWqHOes73iBEik57omvCsoHrf0wS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FcdEJxoHDhMROU9HE4ayCIKiL84IQvkZXEWGzDTfnoK59oeVxQLHpGykQz9vIRqk1 XIzpKFJ4zzojjF5c70sYk+Q+Nblnn1p9K08HrCUvJs/e3yjFtP6080bDQ7GHpmFCyd XK+mBbPZ/Ej0m4g8G6ry8eBcygide6TUCd18wo5o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marijn Suijten , Bjorn Andersson , Sasha Levin Subject: [PATCH 5.19 0256/1157] arm64: dts: qcom: sm6125: Move sdc2 pinctrl from seine-pdx201 to sm6125 Date: Mon, 15 Aug 2022 19:53:32 +0200 Message-Id: <20220815180449.835187309@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Marijn Suijten [ Upstream commit 6990640a93ba4e76dd62ca3ea1082a7354db09d7 ] Both the sdc2-on and sdc2-off pinctrl nodes are used by the sdhci@4784000 node in sm6125.dtsi. Surprisingly sdc2-off is defined in sm6125, yet its sdc2-on counterpart is only defined in board-specific DT for the Sony Seine PDX201 board/device resulting in an "undefined label &sdc2_state_on" error if sm6125.dtsi were included elsewhere. This sm6125 base dtsi should not rely on externally defined labels; the properties referencing it should then also be written externally. Since the sdc2-on pin configuration is board-independent just like sdc2-off, move it from seine-pdx201.dts into sm6125.dtsi. The SDCard-detect pin (gpio98) is however board-specific, and remains as an overwrite in seine-pdx201.dts for both the on and off state. As a drive-by cleanup, reorder bias- and drive-strength properties. Fixes: cff4bbaf2a2d ("arm64: dts: qcom: Add support for SM6125") Fixes: 82e1783890b7 ("arm64: dts: qcom: sm6125: Add support for Sony Xperia= 10II") Signed-off-by: Marijn Suijten Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220508100336.127176-1-marijn.suijten@soma= inline.org Signed-off-by: Sasha Levin --- .../qcom/sm6125-sony-xperia-seine-pdx201.dts | 34 +++++-------------- arch/arm64/boot/dts/qcom/sm6125.dtsi | 24 +++++++++++-- 2 files changed, 30 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts b= /arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts index 871ccbba445b..4916e6c8b625 100644 --- a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts +++ b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts @@ -91,8 +91,16 @@ &hsusb_phy1 { &sdc2_state_off { sd-cd { pins =3D "gpio98"; + drive-strength =3D <2>; bias-disable; + }; +}; + +&sdc2_state_on { + sd-cd { + pins =3D "gpio98"; drive-strength =3D <2>; + bias-pull-up; }; }; =20 @@ -102,32 +110,6 @@ &sdhc_1 { =20 &tlmm { gpio-reserved-ranges =3D <22 2>, <28 6>; - - sdc2_state_on: sdc2-on { - clk { - pins =3D "sdc2_clk"; - bias-disable; - drive-strength =3D <16>; - }; - - cmd { - pins =3D "sdc2_cmd"; - bias-pull-up; - drive-strength =3D <10>; - }; - - data { - pins =3D "sdc2_data"; - bias-pull-up; - drive-strength =3D <10>; - }; - - sd-cd { - pins =3D "gpio98"; - bias-pull-up; - drive-strength =3D <2>; - }; - }; }; =20 &usb3 { diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qco= m/sm6125.dtsi index 135e6e0da27a..a0d8580739c5 100644 --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi @@ -389,20 +389,40 @@ tlmm: pinctrl@500000 { sdc2_state_off: sdc2-off { clk { pins =3D "sdc2_clk"; - bias-disable; drive-strength =3D <2>; + bias-disable; }; =20 cmd { pins =3D "sdc2_cmd"; + drive-strength =3D <2>; bias-pull-up; + }; + + data { + pins =3D "sdc2_data"; drive-strength =3D <2>; + bias-pull-up; + }; + }; + + sdc2_state_on: sdc2-on { + clk { + pins =3D "sdc2_clk"; + drive-strength =3D <16>; + bias-disable; + }; + + cmd { + pins =3D "sdc2_cmd"; + drive-strength =3D <10>; + bias-pull-up; }; =20 data { pins =3D "sdc2_data"; + drive-strength =3D <10>; bias-pull-up; - drive-strength =3D <2>; }; }; }; --=20 2.35.1