From nobody Mon Sep 29 22:49:04 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D442C25B08 for ; Mon, 15 Aug 2022 22:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345692AbiHOW2V (ORCPT ); Mon, 15 Aug 2022 18:28:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349770AbiHOWVf (ORCPT ); Mon, 15 Aug 2022 18:21:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85B9FB5A55; Mon, 15 Aug 2022 12:43:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3B77B80EA9; Mon, 15 Aug 2022 19:43:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14837C433D7; Mon, 15 Aug 2022 19:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660592623; bh=qVsnoEGnc5qFPD1U5EZTUH1PL3z3jAHDLEAbNbMTyz0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v12fKWm+5LN8Qq/hl1Grvfg8wQHNwWI6kCQNxocNic2gKiMeJLkf7Cu9/nskcvi/l 78l2ISy9SjSSfcrR3mVBPeYZzHw7psUsDAL/GnLnQynS+STw9Fjv4FaIYJZ4tIwUzi cTaoa39DvE88B09CBDBFjPsqPKuV199AC7d0jjus= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable , Michael Grzeschik Subject: [PATCH 5.19 0139/1157] usb: dwc3: gadget: fix high speed multiplier setting Date: Mon, 15 Aug 2022 19:51:35 +0200 Message-Id: <20220815180445.188777902@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Michael Grzeschik commit 8affe37c525d800a2628c4ecfaed13b77dc5634a upstream. For High-Speed Transfers the prepare_one_trb function is calculating the multiplier setting for the trb based on the length parameter of the trb currently prepared. This assumption is wrong. For trbs with a sg list, the length of the actual request has to be taken instead. Fixes: 40d829fb2ec6 ("usb: dwc3: gadget: Correct ISOC DATA PIDs for short p= ackets") Cc: stable Signed-off-by: Michael Grzeschik Link: https://lore.kernel.org/r/20220704141812.1532306-3-m.grzeschik@pengut= ronix.de Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1264,10 +1264,10 @@ static void dwc3_prepare_one_trb(struct unsigned int mult =3D 2; unsigned int maxp =3D usb_endpoint_maxp(ep->desc); =20 - if (trb_length <=3D (2 * maxp)) + if (req->request.length <=3D (2 * maxp)) mult--; =20 - if (trb_length <=3D maxp) + if (req->request.length <=3D maxp) mult--; =20 trb->size |=3D DWC3_TRB_SIZE_PCM1(mult);