From nobody Mon Sep 29 22:46:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5BAC2BB45 for ; Mon, 15 Aug 2022 22:28:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348033AbiHOW21 (ORCPT ); Mon, 15 Aug 2022 18:28:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349798AbiHOWVg (ORCPT ); Mon, 15 Aug 2022 18:21:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9F49B5A4E; Mon, 15 Aug 2022 12:43:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CA5F610A5; Mon, 15 Aug 2022 19:43:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06F7DC433B5; Mon, 15 Aug 2022 19:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660592626; bh=ptbstcd6stve8vBtBfyzgL8zEE8ay3I+XdRF4HhLEpc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bzK1m2eEGEIJkZm8D058Lm7D0lpKzS08u8akVJlJSul2FgL9xsFTlFXWUI7RTG3H+ ZJ8IOhIo95BbF7YtiNOQ431X+DwQKkvI2t6oxYziH1jAjQ4kkAOJ1q8eyrnG7Q2YDx zXcItG7ihoCbR9UEU6mLUd/4OHtx7EtSiyFxLpa4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yi Guo , Nadav Haklai , Narendra Hadke , =?UTF-8?q?Pali=20Roh=C3=A1r?= Subject: [PATCH 5.19 0117/1157] serial: mvebu-uart: uart2 error bits clearing Date: Mon, 15 Aug 2022 19:51:13 +0200 Message-Id: <20220815180444.294323311@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Narendra Hadke commit a7209541239e5dd44d981289e5f9059222d40fd1 upstream. For mvebu uart2, error bits are not cleared on buffer read. This causes interrupt loop and system hang. Cc: stable@vger.kernel.org Reviewed-by: Yi Guo Reviewed-by: Nadav Haklai Signed-off-by: Narendra Hadke Signed-off-by: Pali Roh=C3=A1r Link: https://lore.kernel.org/r/20220726091221.12358-1-pali@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/mvebu-uart.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uar= t.c index 0429c2a54290..ff61a8d00014 100644 --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -265,6 +265,7 @@ static void mvebu_uart_rx_chars(struct uart_port *port,= unsigned int status) struct tty_port *tport =3D &port->state->port; unsigned char ch =3D 0; char flag =3D 0; + int ret; =20 do { if (status & STAT_RX_RDY(port)) { @@ -277,6 +278,16 @@ static void mvebu_uart_rx_chars(struct uart_port *port= , unsigned int status) port->icount.parity++; } =20 + /* + * For UART2, error bits are not cleared on buffer read. + * This causes interrupt loop and system hang. + */ + if (IS_EXTENDED(port) && (status & STAT_BRK_ERR)) { + ret =3D readl(port->membase + UART_STAT); + ret |=3D STAT_BRK_ERR; + writel(ret, port->membase + UART_STAT); + } + if (status & STAT_BRK_DET) { port->icount.brk++; status &=3D ~(STAT_FRM_ERR | STAT_PAR_ERR); --=20 2.37.1