From nobody Fri Oct 24 20:23:59 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6763C00140 for ; Mon, 15 Aug 2022 20:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346087AbiHOU3i (ORCPT ); Mon, 15 Aug 2022 16:29:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347309AbiHOUWP (ORCPT ); Mon, 15 Aug 2022 16:22:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2181333A3B; Mon, 15 Aug 2022 12:02:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B1B8461281; Mon, 15 Aug 2022 19:02:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C88DC433D6; Mon, 15 Aug 2022 19:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660590138; bh=KXsiz/clbAFn5tBxvwlcvQAnIlwUuukB5cDniMj0fBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h3VGVVMwGUaW8RuWvSZu+uCfTIG+ghJKjTUlyLhp1CNN/68vX+8OeLwhW2TOnFUgD a3KP1cjKBieGsmmHGga4OKkPAMOQqAYS6MUaHSrF6BXQBz++3kpHPDCt/k/254p3LP YBDPH6HzvSLcb5J5ngGAcdYCzDJBz6Qlai/bgaX0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thadeu Lima de Souza Cascardo , Pablo Neira Ayuso Subject: [PATCH 5.18 0131/1095] netfilter: nf_tables: do not allow CHAIN_ID to refer to another table Date: Mon, 15 Aug 2022 19:52:10 +0200 Message-Id: <20220815180434.997918368@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Thadeu Lima de Souza Cascardo commit 95f466d22364a33d183509629d0879885b4f547e upstream. When doing lookups for chains on the same batch by using its ID, a chain from a different table can be used. If a rule is added to a table but refers to a chain in a different table, it will be linked to the chain in table2, but would have expressions referring to objects in table1. Then, when table1 is removed, the rule will not be removed as its linked to a chain in table2. When expressions in the rule are processed or removed, that will lead to a use-after-free. When looking for chains by ID, use the table that was used for the lookup by name, and only return chains belonging to that same table. Fixes: 837830a4b439 ("netfilter: nf_tables: add NFTA_RULE_CHAIN_ID attribut= e") Signed-off-by: Thadeu Lima de Souza Cascardo Cc: Signed-off-by: Pablo Neira Ayuso Signed-off-by: Greg Kroah-Hartman --- net/netfilter/nf_tables_api.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -2472,6 +2472,7 @@ err: } =20 static struct nft_chain *nft_chain_lookup_byid(const struct net *net, + const struct nft_table *table, const struct nlattr *nla) { struct nftables_pernet *nft_net =3D nft_pernet(net); @@ -2482,6 +2483,7 @@ static struct nft_chain *nft_chain_looku struct nft_chain *chain =3D trans->ctx.chain; =20 if (trans->msg_type =3D=3D NFT_MSG_NEWCHAIN && + chain->table =3D=3D table && id =3D=3D nft_trans_chain_id(trans)) return chain; } @@ -3415,7 +3417,7 @@ static int nf_tables_newrule(struct sk_b return -EOPNOTSUPP; =20 } else if (nla[NFTA_RULE_CHAIN_ID]) { - chain =3D nft_chain_lookup_byid(net, nla[NFTA_RULE_CHAIN_ID]); + chain =3D nft_chain_lookup_byid(net, table, nla[NFTA_RULE_CHAIN_ID]); if (IS_ERR(chain)) { NL_SET_BAD_ATTR(extack, nla[NFTA_RULE_CHAIN_ID]); return PTR_ERR(chain); @@ -9597,7 +9599,7 @@ static int nft_verdict_init(const struct tb[NFTA_VERDICT_CHAIN], genmask); } else if (tb[NFTA_VERDICT_CHAIN_ID]) { - chain =3D nft_chain_lookup_byid(ctx->net, + chain =3D nft_chain_lookup_byid(ctx->net, ctx->table, tb[NFTA_VERDICT_CHAIN_ID]); if (IS_ERR(chain)) return PTR_ERR(chain);