From nobody Fri Oct 24 20:31:40 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0C9C00140 for ; Mon, 15 Aug 2022 20:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346490AbiHOU1N (ORCPT ); Mon, 15 Aug 2022 16:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347238AbiHOUWH (ORCPT ); Mon, 15 Aug 2022 16:22:07 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A04B4B0C7; Mon, 15 Aug 2022 12:01:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1426FCE129B; Mon, 15 Aug 2022 19:01:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9EA0C433D6; Mon, 15 Aug 2022 19:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660590085; bh=BPy1qZmW6qarSAy4+2lCRNVA0QAUPJ9Z4/7km8FScoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B+VG5z9qS0dZOi0o31hoPF9u69dApR8nuv8es+JE0UGi1rMbaax/JhttkECt9o6ZV O2Zol7rSgMiYCNxK7voA0WBrVVFA9UAzrRPRuTl1z5+cwVGHlI9Gi4hHwhCROpUNso ySET9QCLzh/TnEufVRklZSCTy0BiICtv0MSw1Sjw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable , Michael Grzeschik Subject: [PATCH 5.18 0129/1095] usb: dwc3: gadget: fix high speed multiplier setting Date: Mon, 15 Aug 2022 19:52:08 +0200 Message-Id: <20220815180434.916608675@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Michael Grzeschik commit 8affe37c525d800a2628c4ecfaed13b77dc5634a upstream. For High-Speed Transfers the prepare_one_trb function is calculating the multiplier setting for the trb based on the length parameter of the trb currently prepared. This assumption is wrong. For trbs with a sg list, the length of the actual request has to be taken instead. Fixes: 40d829fb2ec6 ("usb: dwc3: gadget: Correct ISOC DATA PIDs for short p= ackets") Cc: stable Signed-off-by: Michael Grzeschik Link: https://lore.kernel.org/r/20220704141812.1532306-3-m.grzeschik@pengut= ronix.de Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/gadget.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1263,10 +1263,10 @@ static void dwc3_prepare_one_trb(struct unsigned int mult =3D 2; unsigned int maxp =3D usb_endpoint_maxp(ep->desc); =20 - if (trb_length <=3D (2 * maxp)) + if (req->request.length <=3D (2 * maxp)) mult--; =20 - if (trb_length <=3D maxp) + if (req->request.length <=3D maxp) mult--; =20 trb->size |=3D DWC3_TRB_SIZE_PCM1(mult);