From nobody Sun Dec 14 06:22:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EDAEC00140 for ; Mon, 15 Aug 2022 18:18:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239969AbiHOSSg (ORCPT ); Mon, 15 Aug 2022 14:18:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233476AbiHOSR7 (ORCPT ); Mon, 15 Aug 2022 14:17:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6B3612767; Mon, 15 Aug 2022 11:15:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8424C61272; Mon, 15 Aug 2022 18:15:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B7EDC433C1; Mon, 15 Aug 2022 18:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660587323; bh=buQXgdihAZQFIjgmqnCjRRerLiW5pM93FNA+Se/f4xY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MeI8fg0HLGNxtHGPrcXZMqYGFglAodFxT000QbAVDWBBE+FR/GpNHh73oiYY2fGSA SAAMUGeq4J/U55aOVTBlnbdZ+EXcorfas7eTzWQ/UAo3TaLBrKbvejNzsVYAxeIW1o rNCAoIVrHVlHWNfWO1B+uDbgLn7P1/ldTVtIR91k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Nguyen , David Rientjes , Peter Gonda , John Allen , Herbert Xu Subject: [PATCH 5.15 047/779] crypto: ccp - Use kzalloc for sev ioctl interfaces to prevent kernel memory leak Date: Mon, 15 Aug 2022 19:54:51 +0200 Message-Id: <20220815180339.263122505@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: John Allen commit 13dc15a3f5fd7f884e4bfa8c011a0ae868df12ae upstream. For some sev ioctl interfaces, input may be passed that is less than or equal to SEV_FW_BLOB_MAX_SIZE, but larger than the data that PSP firmware returns. In this case, kmalloc will allocate memory that is the size of the input rather than the size of the data. Since PSP firmware doesn't fully overwrite the buffer, the sev ioctl interfaces with the issue may return uninitialized slab memory. Currently, all of the ioctl interfaces in the ccp driver are safe, but to prevent future problems, change all ioctl interfaces that allocate memory with kmalloc to use kzalloc and memset the data buffer to zero in sev_ioctl_do_platform_status. Fixes: 38103671aad3 ("crypto: ccp: Use the stack and common buffer for stat= us commands") Fixes: e799035609e15 ("crypto: ccp: Implement SEV_PEK_CSR ioctl command") Fixes: 76a2b524a4b1d ("crypto: ccp: Implement SEV_PDH_CERT_EXPORT ioctl com= mand") Fixes: d6112ea0cb344 ("crypto: ccp - introduce SEV_GET_ID2 command") Cc: stable@vger.kernel.org Reported-by: Andy Nguyen Suggested-by: David Rientjes Suggested-by: Peter Gonda Signed-off-by: John Allen Reviewed-by: Peter Gonda Acked-by: David Rientjes Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/ccp/sev-dev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -388,6 +388,8 @@ static int sev_ioctl_do_platform_status( struct sev_user_data_status data; int ret; =20 + memset(&data, 0, sizeof(data)); + ret =3D __sev_do_cmd_locked(SEV_CMD_PLATFORM_STATUS, &data, &argp->error); if (ret) return ret; @@ -441,7 +443,7 @@ static int sev_ioctl_do_pek_csr(struct s if (input.length > SEV_FW_BLOB_MAX_SIZE) return -EFAULT; =20 - blob =3D kmalloc(input.length, GFP_KERNEL); + blob =3D kzalloc(input.length, GFP_KERNEL); if (!blob) return -ENOMEM; =20 @@ -665,7 +667,7 @@ static int sev_ioctl_do_get_id2(struct s input_address =3D (void __user *)input.address; =20 if (input.address && input.length) { - id_blob =3D kmalloc(input.length, GFP_KERNEL); + id_blob =3D kzalloc(input.length, GFP_KERNEL); if (!id_blob) return -ENOMEM; =20 @@ -784,14 +786,14 @@ static int sev_ioctl_do_pdh_export(struc if (input.cert_chain_len > SEV_FW_BLOB_MAX_SIZE) return -EFAULT; =20 - pdh_blob =3D kmalloc(input.pdh_cert_len, GFP_KERNEL); + pdh_blob =3D kzalloc(input.pdh_cert_len, GFP_KERNEL); if (!pdh_blob) return -ENOMEM; =20 data.pdh_cert_address =3D __psp_pa(pdh_blob); data.pdh_cert_len =3D input.pdh_cert_len; =20 - cert_blob =3D kmalloc(input.cert_chain_len, GFP_KERNEL); + cert_blob =3D kzalloc(input.cert_chain_len, GFP_KERNEL); if (!cert_blob) { ret =3D -ENOMEM; goto e_free_pdh;