From nobody Sat Apr 11 05:14:52 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27CE8C00140 for ; Mon, 15 Aug 2022 16:29:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231931AbiHOQ35 (ORCPT ); Mon, 15 Aug 2022 12:29:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbiHOQ3z (ORCPT ); Mon, 15 Aug 2022 12:29:55 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C128C6312 for ; Mon, 15 Aug 2022 09:29:54 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27F5xWZl014310; Mon, 15 Aug 2022 11:29:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=XOSQIEBYRibhN+BuG700vLasfza9lIc99RIqSQfW5xI=; b=AAISgoVYv+ot2czOQu1IIfKPwuKHgkN2dneKRRwMGH2pa/LAsbVzBmrK7/yPs5ZAJUCh rPTsd2yUZCcJio7LwR4rpeMTd64Lc0PjGiGLW/eQbSrp9WO66uhorXCudFWayfN0F37o /TJ8CQIYOBG8PbHH0VbgLGFdU+nAtLI9Z7FlX84k6YHqq8tXjVOmEjWM98nGRM0aOZ7C 0di8o5u0hziY2VAvNfssVAYEk+/xUu8C0MD7oceTR8cI8qvMyLZB7tn7bPj6A3wBN1bB cDvnqz7yovX6+3fZET78IhBFYZ46lUJTDi0ZpBw3fDlhZRGJ2GVPPYefC5rBdS9ppr6g RQ== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3hx8cpagg5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Aug 2022 11:29:09 -0500 Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.9; Mon, 15 Aug 2022 11:29:08 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.9 via Frontend Transport; Mon, 15 Aug 2022 11:29:08 -0500 Received: from sbinding-cirrus-dsktp2.ad.cirrus.com (unknown [198.90.202.160]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id E5659477; Mon, 15 Aug 2022 16:29:07 +0000 (UTC) From: Stefan Binding To: Jaroslav Kysela , Takashi Iwai CC: , , , Stefan Binding Subject: [PATCH v2] ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties Date: Mon, 15 Aug 2022 17:29:06 +0100 Message-ID: <20220815162906.463108-1-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 1R1CxgufRMNLWcCJScFrwXhABy8LJ58g X-Proofpoint-GUID: 1R1CxgufRMNLWcCJScFrwXhABy8LJ58g X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" For devices which use HID CSC3551, correct ACPI _DSD properties are required to be able support those systems. Add error message to clarify this. Signed-off-by: Stefan Binding --- sound/pci/hda/cs35l41_hda.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index 129bffb431c2..15e2a0009080 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -1163,6 +1163,11 @@ static int cs35l41_no_acpi_dsd(struct cs35l41_hda *c= s35l41, struct device *physd hw_cfg->gpio1.func =3D CS35l41_VSPK_SWITCH; hw_cfg->gpio1.valid =3D true; } else { + /* + * Note: CLSA010(0/1) are special cases which use a slightly different d= esign. + * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be = supported. + */ + dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %= s.\n", hid); hw_cfg->valid =3D false; hw_cfg->gpio1.valid =3D false; hw_cfg->gpio2.valid =3D false; --=20 2.34.1