From nobody Sat Apr 11 09:23:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0FDDC00140 for ; Fri, 12 Aug 2022 22:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbiHLWZc (ORCPT ); Fri, 12 Aug 2022 18:25:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236872AbiHLWZ1 (ORCPT ); Fri, 12 Aug 2022 18:25:27 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 967AADFF9; Fri, 12 Aug 2022 15:25:26 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C43195C00DF; Fri, 12 Aug 2022 18:25:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 12 Aug 2022 18:25:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1660343125; x=1660429525; bh=WD JjZIPzmGrvANwtsGfu72gUriLccPqBOATCf+65cIU=; b=iqfL5OP+d/iGe+r1O1 xwLBJN6PTV/WjEsDXW8ODZgdjXl9AJYcPQsQ9sU3OtRpxIPF8P4u51dxqiCMcNTR W8o5w92EElkpc6SDh7im6bNzP6Kka10MwVWg1SrPrgiiOqsPJ3vF1kfev7/A7ByM HMwtm7osOJBjlzD2H9jxQkZVbdFb/j4zVOVnuGsPaalNPYzfcVMO5l+Z4EUv0B9B jXP+cB0FM5WjHGL6vPvZFQurRD0+dt/m2J6SHcTovsqr43z5Y68rd63fkA8RUF12 UrlHaaLHEm4zk/gJbbP+QxzOgr2XdbDLvJ1g/MMKJl0GiXjQqHgaCkkSfaqfRPSf WwIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1660343125; x=1660429525; bh=WDJjZIPzmGrvA NwtsGfu72gUriLccPqBOATCf+65cIU=; b=1viNpmd6647vguvt0Z0VaO9MUIbIS 4UuCrAvaLOtzYsNroZgq34TVfIaf9kyakzC2E/4sfVp+waYsIiZ81lDIJ7EJqMTn t6ErfPOTkE1X28LtdR0OVgYzk8+x3IhbZ/bwhWnhMiTrRymLMyQcB3SutQubxsIp H4I8YrGOGpn9NdTaXIx8yrDrha3qkjU5Lba7/4R5QRioeIIqSoPejPTIwKMDoCj8 QpBBKOZX9jk/osynLOc2H2ApUkSMTNq/SkTaAAVtBWroaA8BybJWgIeAeH0Uz+PN gWB8uAHihxfcPz5eYAopr3eTx6AEUdbLFdfGBEWk8kQtXnOjC4BecG/Tg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehl jhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfetfedugfetudeuheetjefhue fggfelleetvdevtefhueeujeefvdegleevhefgnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:25:22 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Luke D. Jones" Subject: [PATCH 1/6] Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method") Date: Sat, 13 Aug 2022 10:25:04 +1200 Message-Id: <20220812222509.292692-2-luke@ljones.dev> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220812222509.292692-1-luke@ljones.dev> References: <20220812222509.292692-1-luke@ljones.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The dgpu_disable attribute was not documented, this adds the required documentation. Signed-off-by: Luke D. Jones --- Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentat= ion/ABI/testing/sysfs-platform-asus-wmi index 04885738cf15..0f932fd60f4a 100644 --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi @@ -57,3 +57,12 @@ Description: * 0 - default, * 1 - overboost, * 2 - silent + +What: /sys/devices/platform//dgpu_disable +Date: Aug 2022 +KernelVersion: 5.17 +Contact: "Luke Jones" +Description: + Disable discrete GPU: + * 0 - Enable dGPU, + * 1 - Disable dGPU, \ No newline at end of file --=20 2.37.1 From nobody Sat Apr 11 09:23:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693CFC00140 for ; Fri, 12 Aug 2022 22:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233964AbiHLWZg (ORCPT ); Fri, 12 Aug 2022 18:25:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233587AbiHLWZc (ORCPT ); Fri, 12 Aug 2022 18:25:32 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0339711C3D; Fri, 12 Aug 2022 15:25:29 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 2FD785C00D7; Fri, 12 Aug 2022 18:25:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 12 Aug 2022 18:25:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1660343129; x=1660429529; bh=Rm oH5vq/I46MuGI9F8KRFZv8vU/H1wAMHsY9Io/i5LE=; b=fOe+2pvDLRY/2USbMh bb3hVdYJPWl7nTMs2GM0qCLpl7GSApcSrrCIu/e4mlbqjg81kdbMvwhcQ7oA5WIJ 8Lo3XuoVR+3AHH35wpfAf7bAxXTZK2u/Kiq+GY5Lj3do8luLfNjlpw7nCASu1a8t 2Tzro+BKbTIDog1eTeYdJv+XpiIs+TaDCwXAqBYGcbweoLuK3ID1+puCsEkWvYS2 /BZEpqwgKCZTOD0NGLHmMxGQKXUfgMyxdStDapb6aZUfhLwVDq6peKfmwADYb6L0 luDUQw+WOHwNdwPQwkA3hMMI0vgKICRNgk75YK9pxDw8zA9+aFFlqL+jfqihIg5n Td5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1660343129; x=1660429529; bh=RmoH5vq/I46Mu GI9F8KRFZv8vU/H1wAMHsY9Io/i5LE=; b=VuzKFfRjJ48cE9KqPxe2qJKWL2fIO tfD6n5sdxWRTZ124dykuMk0tLKJfmsVejPw8eQuBVVwAt0BhVMBQkJEocgU2CcSD ZRu5U1k6K/cI8VUWZKuXmYW76TwfljiI5t5t/75xynyJp3oALV9qKYjHTN/SGtww /1xS48VAXQ7X5HGDQeLqaYFi6qkbmfyLCHQFjbS4pqwf9xkYo1/D8UeZ99kN/Rzu 1UyBB8G2dz1Qu2ceWK1EiH3iA/B8jNf3pzdXo5EVWA5rio0eWiqCp3PPj5Mg2HP/ 2lEzg51KdXBt0YZ4kXMaY2/FcQLpSaZ6q6EmWkQ+MR1hB3dtkge73BZDw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehl jhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfetfedugfetudeuheetjefhue fggfelleetvdevtefhueeujeefvdegleevhefgnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:25:26 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Luke D. Jones" Subject: [PATCH 2/6] Fixes: 382b91db8044 ("asus-wmi: Add egpu enable method") Date: Sat, 13 Aug 2022 10:25:05 +1200 Message-Id: <20220812222509.292692-3-luke@ljones.dev> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220812222509.292692-1-luke@ljones.dev> References: <20220812222509.292692-1-luke@ljones.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The egpu_enable attribute was not documented, this adds the required documentation. Signed-off-by: Luke D. Jones --- Documentation/ABI/testing/sysfs-platform-asus-wmi | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentat= ion/ABI/testing/sysfs-platform-asus-wmi index 0f932fd60f4a..b984bdcd0c40 100644 --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi @@ -65,4 +65,14 @@ Contact: "Luke Jones" Description: Disable discrete GPU: * 0 - Enable dGPU, - * 1 - Disable dGPU, \ No newline at end of file + * 1 - Disable dGPU, + +What: /sys/devices/platform//egpu_enable +Date: Aug 2022 +KernelVersion: 5.17 +Contact: "Luke Jones" +Description: + Enable the external GPU paired with ROG X-Flow laptops. + Toggling this setting will also trigger ACPI to disable the= dGPU: + * 0 - Disable, + * 1 - Enable, \ No newline at end of file --=20 2.37.1 From nobody Sat Apr 11 09:23:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9BFEC00140 for ; Fri, 12 Aug 2022 22:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233612AbiHLWZu (ORCPT ); Fri, 12 Aug 2022 18:25:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236909AbiHLWZd (ORCPT ); Fri, 12 Aug 2022 18:25:33 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E042711C2D; Fri, 12 Aug 2022 15:25:32 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 43F355C00D7; Fri, 12 Aug 2022 18:25:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 12 Aug 2022 18:25:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1660343132; x=1660429532; bh=0Y iK5scLqv7YJI3+IlX7HQcxM6Vz4adJuNg5MHEkMoY=; b=pe+37fDVNB9E8ksAIX fjSMyuEiRzZXLhSiYsesXyRnVbR9oo4shGxys8faxW9gYSdq4IKUjUbyVP+r00cr xpINzgp4IdedcnIzkPghRV0j1h6+jkte+4o9NuyDtILJKtIbQhShWhOnOK8f13Jq SPlXHV4iZHV9APtgNZ0P0I/w17VipF80l5xBRh1SUMlKicscSFGNGt3R6lFeppEg FYw+R65+L06hYGb+89YNcqw9FtdI1JqiWX87r7yeNrnXGtOO1ChLYF3/RpO3fWiu guPKOf9+UKvviHdW2Y+mUgT0+bsLX/A0ayc/8h2FrAUeCJY7GyBKhRQxxSPnBky5 ufUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1660343132; x=1660429532; bh=0YiK5scLqv7YJ I3+IlX7HQcxM6Vz4adJuNg5MHEkMoY=; b=mF5DR8gVl16+ytcL9Im6uyoddI30W DGuTGZ1hWPYOV56gWY/fB2GhoDnHQol4EdzsxlxAmnumk6UDbVvyJYB/ipfV1HqD rQyY37cR8Zf7tRVEvkJPivMY3vnB0GfO53llHUAiYNRkgYm/HVQywA964i1UMy3h Eqv2sLID+/nHPFVLQtR5Dn4vLaa5v6AOm00CZItat7tJpp3RsG8ehtfNMI3HyoFt KNXVl44lmRNU2F/PiKxjVVBjBwAllloNyoG8o+o3Upxz2EBZbahjkfseQqpvqg1H vPPyIS3Tqp5msyI3GkJFqllMzdvp2e8KB5JFXrBkwpKmhYme/BINjLeoQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehl jhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfetfedugfetudeuheetjefhue fggfelleetvdevtefhueeujeefvdegleevhefgnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:25:29 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Luke D. Jones" Subject: [PATCH 3/6] Fixes: ca91ea34778f ("asus-wmi: Add panel overdrive functionality") Date: Sat, 13 Aug 2022 10:25:06 +1200 Message-Id: <20220812222509.292692-4-luke@ljones.dev> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220812222509.292692-1-luke@ljones.dev> References: <20220812222509.292692-1-luke@ljones.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The panel_od attribute was not documented, this adds the required documentation. Signed-off-by: Luke D. Jones --- Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentat= ion/ABI/testing/sysfs-platform-asus-wmi index b984bdcd0c40..574b5170a37d 100644 --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi @@ -74,5 +74,14 @@ Contact: "Luke Jones" Description: Enable the external GPU paired with ROG X-Flow laptops. Toggling this setting will also trigger ACPI to disable the= dGPU: + * 0 - Disable, + * 1 - Enable, + +What: /sys/devices/platform//panel_od +Date: Aug 2022 +KernelVersion: 5.17 +Contact: "Luke Jones" +Description: + Enable an LCD response-time boost to reduce or remove ghost= ing: * 0 - Disable, * 1 - Enable, \ No newline at end of file --=20 2.37.1 From nobody Sat Apr 11 09:23:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87062C25B0F for ; Fri, 12 Aug 2022 22:25:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237680AbiHLWZ4 (ORCPT ); Fri, 12 Aug 2022 18:25:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237198AbiHLWZi (ORCPT ); Fri, 12 Aug 2022 18:25:38 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1990613CC9; Fri, 12 Aug 2022 15:25:36 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 61B105C00D7; Fri, 12 Aug 2022 18:25:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 12 Aug 2022 18:25:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1660343135; x=1660429535; bh=rI emY+VOAQgq3T+nOuejCbzaVBU7MiBaAFixMtxCVDE=; b=VTABD5QQCIuAbP0ZEy CQl5OOSVILc5fcAjH/Fh7pBGojIWWMSOGs2pzuObWvT2I0sk/clIsL7ev6PuJp3R 4FC3SipH4LJ8BXx/cwnHhAaCb+Odfq5/VdVWU5UQugOlaHXKCCkwWwHVHjCu9jtS doSdDc/hlsZ57Op1d9BvR+e3Kkw900YLsG5l9+OqvuO1FDgccnunvjG7ZlCncM1t WYZt81Dh2KXIaG8grTHO/3rMiSl03ZMAqyLwkqIqxMmJPHpQErIK6TEJuBUDVNYX IQ2XwCupToI9Si/tdeQHAjxsG6ajiKUgeGZec7klIJbBBJBEsACHlowrr2NwgmaG yOOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1660343135; x=1660429535; bh=rIemY+VOAQgq3 T+nOuejCbzaVBU7MiBaAFixMtxCVDE=; b=V37o8u5bIdtNeFw7gN2YFHBwKM6rY QezqvLtZia49Z1ZoA8E+1YGrI5JhQZNelC7wcUOJ9NtB3KusWMHgCFbxoBEocos5 54GMIuTsYxarn84wPyfBxK2ALTK7NiO2X6NcXNTAJEJTHdJTPoTN2h09Iz5kS+Vr csW9GEA2dmQ0dzEPo27GPGOEu+ATBNQRba/k17a85VLWNMVOuPfkrR7MbgRSufBW lgwyn3ZXLwjvmB5U83m5jXQcbccudZA0Y7Ur22XCZko8jZ+VJnj/m1w39Od/sK3W G2D9pKqHRedj2U3Mz7miBQDy8SJAX33n3X59uCkaagkoFoikQeKdSA34A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehl jhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfetfedugfetudeuheetjefhue fggfelleetvdevtefhueeujeefvdegleevhefgnecuvehluhhsthgvrhfuihiivgepuden ucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:25:32 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Luke D. Jones" Subject: [PATCH 4/6] asus-wmi: Refactor disable_gpu attribute Date: Sat, 13 Aug 2022 10:25:07 +1200 Message-Id: <20220812222509.292692-5-luke@ljones.dev> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220812222509.292692-1-luke@ljones.dev> References: <20220812222509.292692-1-luke@ljones.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The settings for these attributes can be read from the device, this is now done instead of reading a stored value from module. The stored value is also removed. This means the simpler asus_wmi_dev_is_present() can be used in *_check_present() - it is not an error for these methods to be missing. The _write() functions have their bodies shifted in to *_store() which simplifies things further. Signed-off-by: Luke D. Jones --- drivers/platform/x86/asus-wmi.c | 73 +++++++++++---------------------- 1 file changed, 24 insertions(+), 49 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index 0e7fbed8a50d..a72ecc4e33b7 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -232,7 +232,6 @@ struct asus_wmi { bool egpu_enable; =20 bool dgpu_disable_available; - bool dgpu_disable; =20 bool throttle_thermal_policy_available; u8 throttle_thermal_policy_mode; @@ -562,47 +561,10 @@ static void lid_flip_tablet_mode_get_state(struct asu= s_wmi *asus) /* dGPU ******************************************************************= **/ static int dgpu_disable_check_present(struct asus_wmi *asus) { - u32 result; - int err; - asus->dgpu_disable_available =3D false; =20 - err =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_DGPU, &result); - if (err) { - if (err =3D=3D -ENODEV) - return 0; - return err; - } - - if (result & ASUS_WMI_DSTS_PRESENCE_BIT) { + if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_DGPU)) asus->dgpu_disable_available =3D true; - asus->dgpu_disable =3D result & ASUS_WMI_DSTS_STATUS_BIT; - } - - return 0; -} - -static int dgpu_disable_write(struct asus_wmi *asus) -{ - u32 retval; - u8 value; - int err; - - /* Don't rely on type conversion */ - value =3D asus->dgpu_disable ? 1 : 0; - - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_DGPU, value, &retval); - if (err) { - pr_warn("Failed to set dgpu disable: %d\n", err); - return err; - } - - if (retval > 1) { - pr_warn("Failed to set dgpu disable (retval): 0x%x\n", retval); - return -EIO; - } - - sysfs_notify(&asus->platform_device->dev.kobj, NULL, "dgpu_disable"); =20 return 0; } @@ -611,9 +573,13 @@ static ssize_t dgpu_disable_show(struct device *dev, struct device_attribute *attr, char *buf) { struct asus_wmi *asus =3D dev_get_drvdata(dev); - u8 mode =3D asus->dgpu_disable; + int result; =20 - return sysfs_emit(buf, "%d\n", mode); + result =3D asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_DGPU); + if (result < 0) + return result; + + return sysfs_emit(buf, "%d\n", result); } =20 /* @@ -626,24 +592,33 @@ static ssize_t dgpu_disable_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { - bool disable; - int result; + int result, err; + u32 disable; =20 struct asus_wmi *asus =3D dev_get_drvdata(dev); =20 - result =3D kstrtobool(buf, &disable); + result =3D kstrtou32(buf, 10, &disable); if (result) return result; =20 - asus->dgpu_disable =3D disable; + if (disable > 1) + return -EINVAL; =20 - result =3D dgpu_disable_write(asus); - if (result) - return result; + err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_DGPU, disable, &result); + if (err) { + pr_warn("Failed to set dgpu disable: %d\n", err); + return err; + } + + if (result > 1) { + pr_warn("Failed to set dgpu disable (result): 0x%x\n", result); + return -EIO; + } + + sysfs_notify(&asus->platform_device->dev.kobj, NULL, "dgpu_disable"); =20 return count; } - static DEVICE_ATTR_RW(dgpu_disable); =20 /* eGPU ******************************************************************= **/ --=20 2.37.1 From nobody Sat Apr 11 09:23:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B496C00140 for ; Fri, 12 Aug 2022 22:26:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237243AbiHLW0H (ORCPT ); Fri, 12 Aug 2022 18:26:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237670AbiHLWZm (ORCPT ); Fri, 12 Aug 2022 18:25:42 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EAB9165A1; Fri, 12 Aug 2022 15:25:39 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D23C05C00D7; Fri, 12 Aug 2022 18:25:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 12 Aug 2022 18:25:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1660343138; x=1660429538; bh=QP RBJNcjcaoF0UH+AoGMng9AecsIOHPCAQZk3jqaN58=; b=O4cN9Z9+zaSipDLRYj CkyGWQPVbDWeCgX/JW4y6OGKFz8AI5cGc6ZC9YaYVjc0gG/Or3921E3iBZ8aF/vh xX9m+IaebcDqcoVdcfm7G8IHlu5NTXAhp9udVGUWsRd2wuFA5at2it8nDQ6tOJDe qrd8PTFgiJt/NEgV32FM9GyL6qVD8O4+UwbSlDopummb7jhO0F1GaaaUz0pFfZED R0NA8z5Xz2KbB4EcJ1JQkeyLT1iB8Wr/Iz2RlGliYjH38ki2na/Dxbbr9NA7csl6 4SQg4m7dt6jwleWTNt4ShmFmv0k1qopF+RvH6g6JJ1gfHPslk5uee+Q2BvOA3xgW rpng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1660343138; x=1660429538; bh=QPRBJNcjcaoF0 UH+AoGMng9AecsIOHPCAQZk3jqaN58=; b=kPLJCpUUt715ZpTvAagsu7mqQWTG5 7u6ddKzbyuZnIbpOpEcog2CxRCeV1+VQWMTzZm8poB6emcqFxDmUacV5gjtavPLe tG2ZDAn5UzuIfomv3dG1LL1egKjni017UeKgxTpP9N1fAMfq9TC+NzSAEWAqaKWA 8M10vvA60i/p296kbQXqaHvJVYvIsmvmBeuUti2g3xwKKpZH0HXm9VZ3aGcnt1z0 i38XfPONGUo98Yju2YeZ5E7D0Npy9uS50vKoA/nyCYlmsl/BGe5KCUjPrdHtUarU NZhNiXoT/DgKD0PJGka4ehFNY0Baj1BXiLBRo1Aubm27rY4NAuV96JBfA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehl jhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfetfedugfetudeuheetjefhue fggfelleetvdevtefhueeujeefvdegleevhefgnecuvehluhhsthgvrhfuihiivgepvden ucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:25:35 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Luke D. Jones" Subject: [PATCH 5/6] asus-wmi: Refactor egpu_enable attribute Date: Sat, 13 Aug 2022 10:25:08 +1200 Message-Id: <20220812222509.292692-6-luke@ljones.dev> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220812222509.292692-1-luke@ljones.dev> References: <20220812222509.292692-1-luke@ljones.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The settings for these attributes can be read from the device, this is now done instead of reading a stored value from module. The stored value is also removed. This means the simpler asus_wmi_dev_is_present() can be used in *_check_present() - it is not an error for these methods to be missing. The _write() functions have their bodies shifted in to *_store() which simplifies things further. Signed-off-by: Luke D. Jones --- drivers/platform/x86/asus-wmi.c | 84 ++++++++++----------------------- 1 file changed, 26 insertions(+), 58 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index a72ecc4e33b7..87b042fac1ce 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -228,9 +228,7 @@ struct asus_wmi { u8 fan_boost_mode_mask; u8 fan_boost_mode; =20 - bool egpu_enable_available; // 0 =3D enable - bool egpu_enable; - + bool egpu_enable_available; bool dgpu_disable_available; =20 bool throttle_thermal_policy_available; @@ -624,48 +622,10 @@ static DEVICE_ATTR_RW(dgpu_disable); /* eGPU ******************************************************************= **/ static int egpu_enable_check_present(struct asus_wmi *asus) { - u32 result; - int err; - asus->egpu_enable_available =3D false; =20 - err =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_EGPU, &result); - if (err) { - if (err =3D=3D -ENODEV) - return 0; - return err; - } - - if (result & ASUS_WMI_DSTS_PRESENCE_BIT) { + if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_EGPU)) asus->egpu_enable_available =3D true; - asus->egpu_enable =3D result & ASUS_WMI_DSTS_STATUS_BIT; - } - - return 0; -} - -static int egpu_enable_write(struct asus_wmi *asus) -{ - u32 retval; - u8 value; - int err; - - /* Don't rely on type conversion */ - value =3D asus->egpu_enable ? 1 : 0; - - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_EGPU, value, &retval); - - if (err) { - pr_warn("Failed to set egpu disable: %d\n", err); - return err; - } - - if (retval > 1) { - pr_warn("Failed to set egpu disable (retval): 0x%x\n", retval); - return -EIO; - } - - sysfs_notify(&asus->platform_device->dev.kobj, NULL, "egpu_enable"); =20 return 0; } @@ -674,9 +634,13 @@ static ssize_t egpu_enable_show(struct device *dev, struct device_attribute *attr, char *buf) { struct asus_wmi *asus =3D dev_get_drvdata(dev); - bool mode =3D asus->egpu_enable; + int result; + + result =3D asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_EGPU); + if (result < 0) + return result; =20 - return sysfs_emit(buf, "%d\n", mode); + return sysfs_emit(buf, "%d\n", result); } =20 /* The ACPI call to enable the eGPU also disables the internal dGPU */ @@ -684,29 +648,33 @@ static ssize_t egpu_enable_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { - bool enable; - int result; + int result, err; + u32 enable; =20 struct asus_wmi *asus =3D dev_get_drvdata(dev); =20 - result =3D kstrtobool(buf, &enable); - if (result) - return result; + err =3D kstrtou32(buf, 10, &enable); + if (err) + return err; =20 - asus->egpu_enable =3D enable; + if (enable > 1) + return -EINVAL; =20 - result =3D egpu_enable_write(asus); - if (result) - return result; + err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_EGPU, enable, &result); + if (err) { + pr_warn("Failed to set egpu disable: %d\n", err); + return err; + } =20 - /* Ensure that the kernel status of dgpu is updated */ - result =3D dgpu_disable_check_present(asus); - if (result) - return result; + if (result > 1) { + pr_warn("Failed to set egpu disable (retval): 0x%x\n", result); + return -EIO; + } + + sysfs_notify(&asus->platform_device->dev.kobj, NULL, "egpu_enable"); =20 return count; } - static DEVICE_ATTR_RW(egpu_enable); =20 /* Battery ***************************************************************= *****/ --=20 2.37.1 From nobody Sat Apr 11 09:23:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56121C00140 for ; Fri, 12 Aug 2022 22:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237553AbiHLW0T (ORCPT ); Fri, 12 Aug 2022 18:26:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237164AbiHLWZs (ORCPT ); Fri, 12 Aug 2022 18:25:48 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC80B11C3D; Fri, 12 Aug 2022 15:25:42 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 266D85C00D7; Fri, 12 Aug 2022 18:25:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 12 Aug 2022 18:25:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1660343142; x=1660429542; bh=eZ uPw2SQFgh1mWTwJWJZNQBE+LeJoM1X4oFRjAj7Xew=; b=bt29gbav/Md945DtqI NKESz2gvizfztEqqqcc6KvSyAxea1sLRRqnKNQ0QBWFTZa9iunvc/lsdceL5oSlW Zf018+F82GiyD1JgD32jC3ItTZBwUqPHA13reby86f/KDtkRzaiSx+kVZ1VVDF8t VWvwIb2RJWqVoz3fzMTWdEeQDHw2wejvmwQJm5AUL6LO96GYtFiSma2SCn0IFj3p 2PQTgjLtrV4j5hXC+6cvVJsp4RvQ1ziyooRepxGuFAzbkO9M4aTVQqjHSU+K6xuv I4Z03qXWr/tWqRTCgrMBAnLhr3uoPz2qCFLN5gLwPtDS2JkbJJX5hd3rdqCg2/x2 MQrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1660343142; x=1660429542; bh=eZuPw2SQFgh1m WTwJWJZNQBE+LeJoM1X4oFRjAj7Xew=; b=ThqxP7tIA/GcOg4lWiq0ofmyUjfVm NPl2QpzmQ4aS/+q7Aevovgpj52H6qNAfV3YCiYmiDOjB9h2RdHm76Egej1lylJiH JuDcVLc0GuDtOjMPfrlC88PnlQRbrImNvRaf6bsZKpvWkgKoOL/ehCEfbEI69NRT oGKETpSrYHtN42cC5cBXfkJ8dqyCCC0bno+sn4bl/Cb2KCfS5mksmgp7JDhxm7WD 3/d2rNX0erU1cuROFre7+xfKtpqi5IGvy6a48Ehy4+sSM2z9EkFuQWQpm+w+Kncl pgVCSXpZ+aEIqg7jceEARrGy2vLmll5v32Vj4PsYRNrzMU+R8mUDBohAQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehl jhhonhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfetfedugfetudeuheetjefhue fggfelleetvdevtefhueeujeefvdegleevhefgnecuvehluhhsthgvrhfuihiivgepuden ucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:25:39 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: markgross@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Luke D. Jones" Subject: [PATCH 6/6] asus-wmi: Refactor panel_od attribute Date: Sat, 13 Aug 2022 10:25:09 +1200 Message-Id: <20220812222509.292692-7-luke@ljones.dev> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220812222509.292692-1-luke@ljones.dev> References: <20220812222509.292692-1-luke@ljones.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The settings for these attributes can be read from the device, this is now done instead of reading a stored value from module. The stored value is also removed. This means the simpler asus_wmi_dev_is_present() can be used in *_check_present() - it is not an error for these methods to be missing. The _write() functions have their bodies shifted in to *_store() which simplifies things further. Signed-off-by: Luke D. Jones --- drivers/platform/x86/asus-wmi.c | 74 +++++++++++---------------------- 1 file changed, 25 insertions(+), 49 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index 87b042fac1ce..b2595a2d1b0a 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -245,7 +245,6 @@ struct asus_wmi { bool battery_rsoc_available; =20 bool panel_overdrive_available; - bool panel_overdrive; =20 struct hotplug_slot hotplug_slot; struct mutex hotplug_lock; @@ -1475,48 +1474,10 @@ static int asus_wmi_rfkill_init(struct asus_wmi *as= us) /* Panel Overdrive *******************************************************= *****/ static int panel_od_check_present(struct asus_wmi *asus) { - u32 result; - int err; - asus->panel_overdrive_available =3D false; =20 - err =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_PANEL_OD, &result); - if (err) { - if (err =3D=3D -ENODEV) - return 0; - return err; - } - - if (result & ASUS_WMI_DSTS_PRESENCE_BIT) { + if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_PANEL_OD)) asus->panel_overdrive_available =3D true; - asus->panel_overdrive =3D result & ASUS_WMI_DSTS_STATUS_BIT; - } - - return 0; -} - -static int panel_od_write(struct asus_wmi *asus) -{ - u32 retval; - u8 value; - int err; - - /* Don't rely on type conversion */ - value =3D asus->panel_overdrive ? 1 : 0; - - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_PANEL_OD, value, &retval); - - if (err) { - pr_warn("Failed to set panel overdrive: %d\n", err); - return err; - } - - if (retval > 1) { - pr_warn("Failed to set panel overdrive (retval): 0x%x\n", retval); - return -EIO; - } - - sysfs_notify(&asus->platform_device->dev.kobj, NULL, "panel_od"); =20 return 0; } @@ -1525,32 +1486,47 @@ static ssize_t panel_od_show(struct device *dev, struct device_attribute *attr, char *buf) { struct asus_wmi *asus =3D dev_get_drvdata(dev); + int result; =20 - return sysfs_emit(buf, "%d\n", asus->panel_overdrive); + result =3D asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_PANEL_OD); + if (result < 0) + return result; + + return sysfs_emit(buf, "%d\n", result); } =20 static ssize_t panel_od_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { - bool overdrive; - int result; + int result, err; + u32 overdrive; =20 struct asus_wmi *asus =3D dev_get_drvdata(dev); =20 - result =3D kstrtobool(buf, &overdrive); + result =3D kstrtou32(buf, 10, &overdrive); if (result) return result; =20 - asus->panel_overdrive =3D overdrive; - result =3D panel_od_write(asus); + if (overdrive > 1) + return -EINVAL; =20 - if (result) - return result; + err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_PANEL_OD, overdrive, &result= ); + + if (err) { + pr_warn("Failed to set panel overdrive: %d\n", err); + return err; + } + + if (result > 1) { + pr_warn("Failed to set panel overdrive (result): 0x%x\n", result); + return -EIO; + } + + sysfs_notify(&asus->platform_device->dev.kobj, NULL, "panel_od"); =20 return count; } - static DEVICE_ATTR_RW(panel_od); =20 /* Quirks ****************************************************************= *****/ --=20 2.37.1