From nobody Sat Apr 11 12:30:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FB5C19F2A for ; Thu, 11 Aug 2022 13:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235190AbiHKNyV (ORCPT ); Thu, 11 Aug 2022 09:54:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235162AbiHKNyM (ORCPT ); Thu, 11 Aug 2022 09:54:12 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2489E6C104 for ; Thu, 11 Aug 2022 06:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660226050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZhGKF7+dCMLetRacbIFf8HUIdAhXW0qkVdcin2fPWSI=; b=anzWDGTYQtYYUXvbgBMNlsxLXX7afkoAyc15/Q3Sh3SlXrg3FupFcwdqnaAdsv3s9od/gE 5yKJlJMN4v7vzcK678qe5mzFik84+n7FmY4n10xLR61lK2DYZGNc8TDJ+9HP/ZZrkBUHgl ugJ5Z0wUIzo384F+lhlcedRDGFGsrpU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-644-BK5UrAvbNpOGfXyxE2r_8g-1; Thu, 11 Aug 2022 09:54:09 -0400 X-MC-Unique: BK5UrAvbNpOGfXyxE2r_8g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1FBCE8117B0; Thu, 11 Aug 2022 13:54:08 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD95D40D2827; Thu, 11 Aug 2022 13:54:02 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: virtualization@lists.linux-foundation.org, Jason Wang , "Michael S. Tsirkin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: ecree.xilinx@gmail.com, gautam.dawar@amd.com, Zhang Min , pabloc@xilinx.com, Piotr.Uminski@intel.com, Dan Carpenter , tanuj.kamde@amd.com, Zhu Lingshan , martinh@xilinx.com, Christophe JAILLET , lvivier@redhat.com, martinpo@xilinx.com, hanand@xilinx.com, Eli Cohen , lulu@redhat.com, habetsm.xilinx@gmail.com, Parav Pandit , Longpeng , Wu Zongyong , Si-Wei Liu , Stefano Garzarella , dinang@xilinx.com, Xie Yongji Subject: [PATCH v8 1/3] vdpa: delete unreachable branch on vdpasim_suspend Date: Thu, 11 Aug 2022 15:53:51 +0200 Message-Id: <20220811135353.2549658-2-eperezma@redhat.com> In-Reply-To: <20220811135353.2549658-1-eperezma@redhat.com> References: <20220811135353.2549658-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It was a leftover from previous versions. Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_= sim.c index 213883487f9b..79a50edf8998 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c @@ -509,16 +509,9 @@ static int vdpasim_reset(struct vdpa_device *vdpa) static int vdpasim_suspend(struct vdpa_device *vdpa) { struct vdpasim *vdpasim =3D vdpa_to_sim(vdpa); - int i; =20 spin_lock(&vdpasim->lock); vdpasim->running =3D false; - if (vdpasim->running) { - /* Check for missed buffers */ - for (i =3D 0; i < vdpasim->dev_attr.nvqs; ++i) - vdpasim_kick_vq(vdpa, i); - - } spin_unlock(&vdpasim->lock); =20 return 0; --=20 2.31.1 From nobody Sat Apr 11 12:30:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A13EC19F2A for ; Thu, 11 Aug 2022 13:54:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235265AbiHKNyp (ORCPT ); Thu, 11 Aug 2022 09:54:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235159AbiHKNy3 (ORCPT ); Thu, 11 Aug 2022 09:54:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1DA43760DB for ; Thu, 11 Aug 2022 06:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660226067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Qqan27qkIlEMWlFRm4oE0aMcqVLoB6Ybk+9lIy2V1I=; b=IHDfzQSBI+U3JM+DaqiETbYmdSGngP1WrOoDOfnAsYD8sgLpKia6fDteXMMJSgiRug9UhB NgPr/0CrnMvb5gkJaA+dTXjbuL6mbaD07W9gfIP8y8LEFYd8kegSVnEg19wzD8tQdGFunV jZfKSsXeF3Bn2BaBzUM74o+zYNP5v1s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-pUYzMhu_Om-5Y3E5QtubUg-1; Thu, 11 Aug 2022 09:54:14 -0400 X-MC-Unique: pUYzMhu_Om-5Y3E5QtubUg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 727F9811E84; Thu, 11 Aug 2022 13:54:13 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E21640D2827; Thu, 11 Aug 2022 13:54:08 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: virtualization@lists.linux-foundation.org, Jason Wang , "Michael S. Tsirkin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: ecree.xilinx@gmail.com, gautam.dawar@amd.com, Zhang Min , pabloc@xilinx.com, Piotr.Uminski@intel.com, Dan Carpenter , tanuj.kamde@amd.com, Zhu Lingshan , martinh@xilinx.com, Christophe JAILLET , lvivier@redhat.com, martinpo@xilinx.com, hanand@xilinx.com, Eli Cohen , lulu@redhat.com, habetsm.xilinx@gmail.com, Parav Pandit , Longpeng , Wu Zongyong , Si-Wei Liu , Stefano Garzarella , dinang@xilinx.com, Xie Yongji Subject: [PATCH v8 2/3] vdpa: Remove wrong doc of VHOST_VDPA_SUSPEND ioctl Date: Thu, 11 Aug 2022 15:53:52 +0200 Message-Id: <20220811135353.2549658-3-eperezma@redhat.com> In-Reply-To: <20220811135353.2549658-1-eperezma@redhat.com> References: <20220811135353.2549658-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It was a leftover from previous versions. Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang --- include/linux/vdpa.h | 2 +- include/uapi/linux/vhost.h | 15 +++++---------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index d282f464d2f1..6c4e6ea7f7eb 100644 --- a/include/linux/vdpa.h +++ b/include/linux/vdpa.h @@ -218,7 +218,7 @@ struct vdpa_map_file { * @reset: Reset device * @vdev: vdpa device * Returns integer: success (0) or error (< 0) - * @suspend: Suspend or resume the device (optional) + * @suspend: Suspend the device (optional) * @vdev: vdpa device * Returns integer: success (0) or error (< 0) * @get_config_size: Get the size of the configuration space includes diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h index 6d9f45163155..89fcb2afe472 100644 --- a/include/uapi/linux/vhost.h +++ b/include/uapi/linux/vhost.h @@ -171,17 +171,12 @@ #define VHOST_VDPA_SET_GROUP_ASID _IOW(VHOST_VIRTIO, 0x7C, \ struct vhost_vring_state) =20 -/* Suspend or resume a device so it does not process virtqueue requests an= ymore +/* Suspend a device so it does not process virtqueue requests anymore * - * After the return of ioctl with suspend !=3D 0, the device must finish a= ny - * pending operations like in flight requests. It must also preserve all t= he - * necessary state (the virtqueue vring base plus the possible device spec= ific - * states) that is required for restoring in the future. The device must n= ot - * change its configuration after that point. - * - * After the return of ioctl with suspend =3D=3D 0, the device can continue - * processing buffers as long as typical conditions are met (vq is enabled, - * DRIVER_OK status bit is enabled, etc). + * After the return of ioctl the device must finish any pending operations= . It + * must also preserve all the necessary state (the virtqueue vring base pl= us + * the possible device specific states) that is required for restoring in = the + * future. The device must not change its configuration after that point. */ #define VHOST_VDPA_SUSPEND _IOW(VHOST_VIRTIO, 0x7D, int) =20 --=20 2.31.1 From nobody Sat Apr 11 12:30:42 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D1CC25B0E for ; Thu, 11 Aug 2022 13:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235240AbiHKNyg (ORCPT ); Thu, 11 Aug 2022 09:54:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235135AbiHKNy1 (ORCPT ); Thu, 11 Aug 2022 09:54:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 856F861D66 for ; Thu, 11 Aug 2022 06:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660226065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6inRrhICS2L+j8kFy9iUcAEGaJYSzOH4irG6UMt8jBk=; b=F3njOtkVSgIGxOGWUUOYYAIFA/2ArbaJ9yPDF1/oDWpyc3Z0nPtqONqUF0aXRFd9chRvMl Rife1u8bRz39tSPmLYM1pkvqi/Sf61trTOWYc3q9SESMQDfb8i2XGWacaA+/ayLLqLcGHW nwplx4eVNRvG7YWK7nXXjCN7F4ykU1A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-jpiI7v9WOoKMCts-OUNHog-1; Thu, 11 Aug 2022 09:54:22 -0400 X-MC-Unique: jpiI7v9WOoKMCts-OUNHog-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C99898032F6; Thu, 11 Aug 2022 13:54:19 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA43240D282E; Thu, 11 Aug 2022 13:54:13 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: virtualization@lists.linux-foundation.org, Jason Wang , "Michael S. Tsirkin" , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: ecree.xilinx@gmail.com, gautam.dawar@amd.com, Zhang Min , pabloc@xilinx.com, Piotr.Uminski@intel.com, Dan Carpenter , tanuj.kamde@amd.com, Zhu Lingshan , martinh@xilinx.com, Christophe JAILLET , lvivier@redhat.com, martinpo@xilinx.com, hanand@xilinx.com, Eli Cohen , lulu@redhat.com, habetsm.xilinx@gmail.com, Parav Pandit , Longpeng , Wu Zongyong , Si-Wei Liu , Stefano Garzarella , dinang@xilinx.com, Xie Yongji Subject: [PATCH v8 3/3] vhost: Remove invalid parameter of VHOST_VDPA_SUSPEND ioctl Date: Thu, 11 Aug 2022 15:53:53 +0200 Message-Id: <20220811135353.2549658-4-eperezma@redhat.com> In-Reply-To: <20220811135353.2549658-1-eperezma@redhat.com> References: <20220811135353.2549658-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It was a leftover from previous versions. Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang --- Note that I'm not sure this removal is valid. The ioctl is not in master branch by the send date of this patch, but there are commits on vhost branch that do have it. --- include/uapi/linux/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h index 89fcb2afe472..768ec46a88bf 100644 --- a/include/uapi/linux/vhost.h +++ b/include/uapi/linux/vhost.h @@ -178,6 +178,6 @@ * the possible device specific states) that is required for restoring in = the * future. The device must not change its configuration after that point. */ -#define VHOST_VDPA_SUSPEND _IOW(VHOST_VIRTIO, 0x7D, int) +#define VHOST_VDPA_SUSPEND _IO(VHOST_VIRTIO, 0x7D) =20 #endif --=20 2.31.1