From nobody Sat Apr 11 13:57:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8650C00140 for ; Wed, 10 Aug 2022 11:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232073AbiHJLn3 (ORCPT ); Wed, 10 Aug 2022 07:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231876AbiHJLnZ (ORCPT ); Wed, 10 Aug 2022 07:43:25 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B610677571 for ; Wed, 10 Aug 2022 04:43:22 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id s9so15818939ljs.6 for ; Wed, 10 Aug 2022 04:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=KRr7duS52TODFaYDFxdheo3ZE1Z29DCImBOABo5du1w=; b=L5bSi9j5tjzNYxKY/Yjve3HQTu5putRB3hOcGDpbo8kEHFySaD8u2jNqhyhgxw5PSY ilAiLUNa/T5OFqIpIF/cwUJPb6RBzELpPa4RGLQmxCLAh+dKYfLiMrnrm5PntvEpG/4o rWyJe0i4PARwDTKX25pa6Pl3gXMtgxi4kx4nO0hQHQQVLPDNwu4bMCHROeTUqd+RX9GD xE21kcgTC6gSjguLlKzyylBIPTA1YL6t1Ir61sGELzAf8s7aXeCNobk/V6ftThHsHzC8 m9hUj4f98RIUuIKIw1083ZqM9pO+DXYb2Vcq60xnMYchNP5yM/s0uBpTY+gEiHE9EBnK WhwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=KRr7duS52TODFaYDFxdheo3ZE1Z29DCImBOABo5du1w=; b=lBJW3H/bQOUFvd4NphH9CPNdtbl239nGWBDeOenjPwmd/HhDZ8kSPrqImmHHBan/YQ W8wrqU7nZGsHGF96aTUH1uh2AharCwT9cYGPDMtf4MRZwQ6JIAcEKrWn6yeWjdu2ovJ+ UmosKWW7w+b50tWzw9c584OUwopuiXa1Ybdxu9Fwuyk+rsHXbYwmYtekkmN7ukm01z6C XfSku/nVMXT+b9fx8pyoIRPN9jMM5onMzbfh3Nun2vimk4iLEfgyXReylm7K/Ob/UXzL XBGuUqrVlYyIpO6XWwhSh2ek29C/XHwspae4ISpBWcYj8WghCELf4twe5f0CE/tFVeD4 Gssw== X-Gm-Message-State: ACgBeo1BvsU9Zi+IJTkk5sEhM/CfFwTK/sXGer/25hvAQMrxhqTqp5w9 dvpuXb+PM8iU/1YuDSee4kHhBw== X-Google-Smtp-Source: AA6agR58RoUom5V9F0K5f8O7nc43sAMKbqRT2vJAmqcRE8MN5wQHYZN/H6+z2EXmE7lIKsqk6gh2zA== X-Received: by 2002:a2e:391d:0:b0:25e:7237:13ef with SMTP id g29-20020a2e391d000000b0025e723713efmr9176026lja.350.1660131801071; Wed, 10 Aug 2022 04:43:21 -0700 (PDT) Received: from localhost (c-e429e555.07-21-73746f28.bbcust.telenor.se. [85.229.41.228]) by smtp.gmail.com with ESMTPSA id a17-20020a056512375100b0048b969ac5cdsm319863lfs.5.2022.08.10.04.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 04:43:20 -0700 (PDT) From: Anders Roxell To: nathan@kernel.org, ndesaulniers@google.com, mpe@ellerman.id.au Cc: llvm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Anders Roxell , Arnd Bergmann , Christophe Leroy Subject: [PATCHv3, resend] powerpc: mm: radix_tlb: rearrange the if-else block Date: Wed, 10 Aug 2022 13:43:18 +0200 Message-Id: <20220810114318.3220630-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Clang warns: arch/powerpc/mm/book3s64/radix_tlb.c:1191:23: error: variable 'hstart' is u= ninitialized when used here [-Werror,-Wuninitialized] __tlbiel_va_range(hstart, hend, pid, ^~~~~~ arch/powerpc/mm/book3s64/radix_tlb.c:1175:23: note: initialize the variable= 'hstart' to silence this warning unsigned long hstart, hend; ^ =3D 0 arch/powerpc/mm/book3s64/radix_tlb.c:1191:31: error: variable 'hend' is uni= nitialized when used here [-Werror,-Wuninitialized] __tlbiel_va_range(hstart, hend, pid, ^~~~ arch/powerpc/mm/book3s64/radix_tlb.c:1175:29: note: initialize the variable= 'hend' to silence this warning unsigned long hstart, hend; ^ =3D 0 2 errors generated. Rework the 'if (IS_ENABLE(CONFIG_TRANSPARENT_HUGEPAGE))' so hstart/hend always gets initialized, this will silence the warnings. That will also simplify the 'else' path. Clang is getting confused with these warnings, but the warnings is a false-positive. Suggested-by: Arnd Bergmann Suggested-by: Nathan Chancellor Reviewed-by: Christophe Leroy Reviewed-by: Nathan Chancellor Signed-off-by: Anders Roxell --- arch/powerpc/mm/book3s64/radix_tlb.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/mm/book3s64/radix_tlb.c b/arch/powerpc/mm/book3s6= 4/radix_tlb.c index 4e29b619578c..6d7a1ef723e6 100644 --- a/arch/powerpc/mm/book3s64/radix_tlb.c +++ b/arch/powerpc/mm/book3s64/radix_tlb.c @@ -1179,15 +1179,12 @@ static inline void __radix__flush_tlb_range(struct = mm_struct *mm, } } } else { - bool hflush =3D false; + bool hflush; unsigned long hstart, hend; =20 - if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { - hstart =3D (start + PMD_SIZE - 1) & PMD_MASK; - hend =3D end & PMD_MASK; - if (hstart < hend) - hflush =3D true; - } + hstart =3D (start + PMD_SIZE - 1) & PMD_MASK; + hend =3D end & PMD_MASK; + hflush =3D IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && hstart < hend; =20 if (type =3D=3D FLUSH_TYPE_LOCAL) { asm volatile("ptesync": : :"memory"); --=20 2.35.1