From nobody Sat Apr 11 15:31:03 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40EFCC00140 for ; Wed, 10 Aug 2022 09:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbiHJJc6 (ORCPT ); Wed, 10 Aug 2022 05:32:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232126AbiHJJcs (ORCPT ); Wed, 10 Aug 2022 05:32:48 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 610BA6DFBC; Wed, 10 Aug 2022 02:32:47 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27A67cOD023304; Wed, 10 Aug 2022 11:32:22 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=selector1; bh=Qj1r6e9mxrtGp6B3i68iIDNeiMPcv4wvqbC7+nzT2t4=; b=vbeYuUIELYYvBpPjSJVyvDbi8hQk4JLoGRKdfOGzI22yeyGrqtg2VPB7MPYcOsjeIv8g K1EzujlWZE7Ca/XcTH5E2vEI5p89bx5R8JCyymnIb9k9l3iZprZgklm/Tb5ErypcNhVZ jhufphbdaokw8c0Qv3AhxlMvST2UV8twsOZ9PXrVaj9YX/9l72ORoTjgNgE0ywgeYseI nnq1jDIIDPzD4Dw1QfDKYozNKKPc/w0p8Z06T1I15cUg3SNTM+sukk/jODXPxhMvSYsV CFQk3tMM1Hkct8V1bK9XXbc0bORJGi/SIIrIb2Lt1xVfEfRf8xvi7oI2Hg0zXH7O9jW1 +A== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3huwrr3vfq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Aug 2022 11:32:22 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6C552100034; Wed, 10 Aug 2022 11:32:21 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6669221B52F; Wed, 10 Aug 2022 11:32:21 +0200 (CEST) Received: from localhost (10.75.127.117) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Wed, 10 Aug 2022 11:32:21 +0200 From: To: Mark Brown , Alexandre Torgue CC: , , , , , Subject: [PATCH v2 1/2] spi: stm32_qspi: Add transfer_one_message() spi callback Date: Wed, 10 Aug 2022 11:32:14 +0200 Message-ID: <20220810093215.794977-2-patrice.chotard@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220810093215.794977-1-patrice.chotard@foss.st.com> References: <20220810093215.794977-1-patrice.chotard@foss.st.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.75.127.117] X-ClientProxiedBy: GPXDAG2NODE5.st.com (10.75.127.69) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-10_03,2022-08-09_02,2022-06-22_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Patrice Chotard Add transfer_one_message() spi callback in order to use the QSPI interface as a communication channel using up to 8 qspi lines (QSPI configured in dual flash mode). Signed-off-by: Patrice Chotard v2: _ use parallel-memories property _ set auto_runtime_pm to true _ remove pm_runtime_*() usage in transfer_one_message() callback --- drivers/spi/spi-stm32-qspi.c | 103 ++++++++++++++++++++++++++++++++--- 1 file changed, 96 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index f3fe92300639..a649b28ab111 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -355,10 +356,10 @@ static int stm32_qspi_get_mode(u8 buswidth) return buswidth; } =20 -static int stm32_qspi_send(struct spi_mem *mem, const struct spi_mem_op *o= p) +static int stm32_qspi_send(struct spi_device *spi, const struct spi_mem_op= *op) { - struct stm32_qspi *qspi =3D spi_controller_get_devdata(mem->spi->master); - struct stm32_qspi_flash *flash =3D &qspi->flash[mem->spi->chip_select]; + struct stm32_qspi *qspi =3D spi_controller_get_devdata(spi->master); + struct stm32_qspi_flash *flash =3D &qspi->flash[spi->chip_select]; u32 ccr, cr; int timeout, err =3D 0, err_poll_status =3D 0; =20 @@ -465,7 +466,7 @@ static int stm32_qspi_poll_status(struct spi_mem *mem, = const struct spi_mem_op * qspi->fmode =3D CCR_FMODE_APM; qspi->status_timeout =3D timeout_ms; =20 - ret =3D stm32_qspi_send(mem, op); + ret =3D stm32_qspi_send(mem->spi, op); mutex_unlock(&qspi->lock); =20 pm_runtime_mark_last_busy(qspi->dev); @@ -489,7 +490,7 @@ static int stm32_qspi_exec_op(struct spi_mem *mem, cons= t struct spi_mem_op *op) else qspi->fmode =3D CCR_FMODE_INDW; =20 - ret =3D stm32_qspi_send(mem, op); + ret =3D stm32_qspi_send(mem->spi, op); mutex_unlock(&qspi->lock); =20 pm_runtime_mark_last_busy(qspi->dev); @@ -545,7 +546,7 @@ static ssize_t stm32_qspi_dirmap_read(struct spi_mem_di= rmap_desc *desc, else qspi->fmode =3D CCR_FMODE_INDR; =20 - ret =3D stm32_qspi_send(desc->mem, &op); + ret =3D stm32_qspi_send(desc->mem->spi, &op); mutex_unlock(&qspi->lock); =20 pm_runtime_mark_last_busy(qspi->dev); @@ -554,6 +555,81 @@ static ssize_t stm32_qspi_dirmap_read(struct spi_mem_d= irmap_desc *desc, return ret ?: len; } =20 +static int stm32_qspi_transfer_one_message(struct spi_controller *ctrl, + struct spi_message *msg) +{ + struct stm32_qspi *qspi =3D spi_controller_get_devdata(ctrl); + struct spi_transfer *transfer; + struct spi_device *spi =3D msg->spi; + struct spi_mem_op op; + int ret; + + if (!spi->cs_gpiod) + return -EOPNOTSUPP; + + mutex_lock(&qspi->lock); + + gpiod_set_value_cansleep(spi->cs_gpiod, true); + + list_for_each_entry(transfer, &msg->transfers, transfer_list) { + u8 dummy_bytes =3D 0; + + memset(&op, 0, sizeof(op)); + + dev_dbg(qspi->dev, "tx_buf:%p tx_nbits:%d rx_buf:%p rx_nbits:%d len:%d d= ummy_data:%d\n", + transfer->tx_buf, transfer->tx_nbits, + transfer->rx_buf, transfer->rx_nbits, + transfer->len, transfer->dummy_data); + + /* + * QSPI hardware supports dummy bytes transfer. + * If current transfer is dummy byte, merge it with the next + * transfer in order to take into account QSPI block constraint + */ + if (transfer->dummy_data) { + op.dummy.buswidth =3D transfer->tx_nbits; + op.dummy.nbytes =3D transfer->len; + dummy_bytes =3D transfer->len; + + /* if happens, means that message is not correctly built */ + if (list_is_last(&transfer->transfer_list, &msg->transfers)) + goto end_of_transfer; + + transfer =3D list_next_entry(transfer, transfer_list); + } + + op.data.nbytes =3D transfer->len; + + if (transfer->rx_buf) { + qspi->fmode =3D CCR_FMODE_INDR; + op.data.buswidth =3D transfer->rx_nbits; + op.data.dir =3D SPI_MEM_DATA_IN; + op.data.buf.in =3D transfer->rx_buf; + } else { + qspi->fmode =3D CCR_FMODE_INDW; + op.data.buswidth =3D transfer->tx_nbits; + op.data.dir =3D SPI_MEM_DATA_OUT; + op.data.buf.out =3D transfer->tx_buf; + } + + ret =3D stm32_qspi_send(spi, &op); + if (ret) + goto end_of_transfer; + + msg->actual_length +=3D transfer->len + dummy_bytes; + } + +end_of_transfer: + gpiod_set_value_cansleep(spi->cs_gpiod, false); + + mutex_unlock(&qspi->lock); + + msg->status =3D ret; + spi_finalize_current_message(ctrl); + + return ret; +} + static int stm32_qspi_setup(struct spi_device *spi) { struct spi_controller *ctrl =3D spi->master; @@ -579,7 +655,7 @@ static int stm32_qspi_setup(struct spi_device *spi) flash->presc =3D presc; =20 mutex_lock(&qspi->lock); - qspi->cr_reg =3D CR_APMS | 3 << CR_FTHRES_SHIFT | CR_SSHIFT | CR_EN; + qspi->cr_reg |=3D CR_APMS | 3 << CR_FTHRES_SHIFT | CR_SSHIFT | CR_EN; writel_relaxed(qspi->cr_reg, qspi->io_base + QSPI_CR); =20 /* set dcr fsize to max address */ @@ -741,11 +817,24 @@ static int stm32_qspi_probe(struct platform_device *p= dev) =20 mutex_init(&qspi->lock); =20 + /* + * Dual flash mode is only enable in case "parallel-memories" and + * "cs-gpios" properties are found in DT + */ + if (of_property_read_bool(dev->of_node, "parallel-memories") && + of_gpio_named_count(dev->of_node, "cs-gpios")) { + qspi->cr_reg =3D CR_DFM; + dev_dbg(dev, "Dual flash mode enable"); + } + ctrl->mode_bits =3D SPI_RX_DUAL | SPI_RX_QUAD | SPI_TX_DUAL | SPI_TX_QUAD; ctrl->setup =3D stm32_qspi_setup; ctrl->bus_num =3D -1; ctrl->mem_ops =3D &stm32_qspi_mem_ops; + ctrl->use_gpio_descriptors =3D true; + ctrl->transfer_one_message =3D stm32_qspi_transfer_one_message; + ctrl->auto_runtime_pm =3D true; ctrl->num_chipselect =3D STM32_QSPI_MAX_NORCHIP; ctrl->dev.of_node =3D dev->of_node; =20 --=20 2.25.1