From nobody Sat Apr 11 19:32:34 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD121C00140 for ; Mon, 8 Aug 2022 06:50:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234115AbiHHGuo (ORCPT ); Mon, 8 Aug 2022 02:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbiHHGuj (ORCPT ); Mon, 8 Aug 2022 02:50:39 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E66BCDF3A for ; Sun, 7 Aug 2022 23:50:34 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id k26so14847408ejx.5 for ; Sun, 07 Aug 2022 23:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NXFy/L+O5xnM71JLbyMm2nhzjOenjYylX2CI7hWvxRI=; b=NbqL7OPKRd8KSSwMCPHh3EbqOgxTtixjGuNh3aKKF7E9MkRb6PUgJM/lZltuuUs4Xn uQ6fi3rOV9BvFkReA42ejpaFumQ1JSjdqaQKE23upHD1unO1s6R7FMjRLi60wgz/ZCxq sOy/fVx3MYIvr/riimQIR2ZWTnVDUloBmDiQDXQ8srfAS6h54iMyT9rlawn/aQ4fYEOd yhspgHZ+nogX5AqUhljotXgPojLsOxbVcc8/Laig0x28eRJqnTjsPJE9Ri1q7sp9+kTp sN2v8yeXy/0SYlRilzjZP8Gu9g4aDZ3QZACTKJUsyiV4eL/luZBJAC8heD2S1pY5xGfV o5xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NXFy/L+O5xnM71JLbyMm2nhzjOenjYylX2CI7hWvxRI=; b=KxTRyMH+H+qA2A4iAJR6ln9pTYJqI3ooDmk7DwCBnlgZqGYgYxivGDqqhi49eR9TAm NM56jLbZFayRUOUWuKcyq7yzE99h70I2w8Wm44a+YfwYf/mKFjfFJb3T2bfbsFcij9ML ftjliTarkDyZ0hkUZEa4U2BG2IZbVkfsBngii5qumYUsfr/cNJsuBuaVWG9bwdDmN4YD IvWyvNjhcQezdBc+/s8DZIA7A0cq7N4+3nPxAp/c/FELL/EsdmiUogNAqOYgGvqfbIX/ yiInapp8yGp2IebhmRrtN8oIJLarwp23zqT+Cm0MB2f/TaI55guq7iDUNMi7S2Y7XuqQ HPWA== X-Gm-Message-State: ACgBeo2rkTkRMYK9Dn74CSDSCDFUOWNg3s/XmhT1lVzSYEdjuZGIjk/x wG8UFxFVj1qlm5Ul/CMnC7k= X-Google-Smtp-Source: AA6agR6+XdvuEaZal6me3MXp+qYOJmuitsFaydsUOBpYKUxIuPELn8Q/tHVmSQz6Zer7vsout9mFig== X-Received: by 2002:a17:906:c781:b0:726:c967:8d1b with SMTP id cw1-20020a170906c78100b00726c9678d1bmr12907535ejb.54.1659941433407; Sun, 07 Aug 2022 23:50:33 -0700 (PDT) Received: from localhost.localdomain (ip5f5abb84.dynamic.kabel-deutschland.de. [95.90.187.132]) by smtp.gmail.com with ESMTPSA id 16-20020a170906329000b007313a2575d2sm2259844ejw.104.2022.08.07.23.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 23:50:33 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH] staging: r8188eu: do not spam the kernel log Date: Mon, 8 Aug 2022 08:50:23 +0200 Message-Id: <20220808065023.3175-1-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Drivers should not spam the kernel log if they work properly. Convert the functions Hal_EfuseParseIDCode88E() and _netdev_open() to use netdev_dbg() instead of pr_info() so that developers can still enable it if they want to see this information. Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 ++- drivers/staging/r8188eu/os_dep/os_intfs.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/stag= ing/r8188eu/hal/rtl8188e_hal_init.c index 5b8f1a912bbb..58a193334b91 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -688,6 +688,7 @@ Hal_EfuseParseIDCode88E( ) { struct eeprom_priv *pEEPROM =3D &padapter->eeprompriv; + struct net_device *netdev =3D padapter->pnetdev; u16 EEPROMId; =20 /* Check 0x8129 again for making sure autoload status!! */ @@ -699,7 +700,7 @@ Hal_EfuseParseIDCode88E( pEEPROM->bautoload_fail_flag =3D false; } =20 - pr_info("EEPROM ID =3D 0x%04x\n", EEPROMId); + netdev_dbg(netdev, "EEPROM ID =3D 0x%04x\n", EEPROMId); } =20 static void Hal_ReadPowerValueFromPROM_8188E(struct txpowerinfo24g *pwrInf= o24G, u8 *PROMContent, bool AutoLoadFail) diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8= 188eu/os_dep/os_intfs.c index cac9553666e6..22e91657f3fb 100644 --- a/drivers/staging/r8188eu/os_dep/os_intfs.c +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c @@ -635,7 +635,7 @@ int _netdev_open(struct net_device *pnetdev) if (status =3D=3D _FAIL) goto netdev_open_error; =20 - pr_info("MAC Address =3D %pM\n", pnetdev->dev_addr); + netdev_dbg(pnetdev, "MAC Address =3D %pM\n", pnetdev->dev_addr); =20 status =3D rtw_start_drv_threads(padapter); if (status =3D=3D _FAIL) { --=20 2.37.1