From nobody Sat Apr 11 20:56:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A948C3F6B0 for ; Mon, 8 Aug 2022 00:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234631AbiHHAgT (ORCPT ); Sun, 7 Aug 2022 20:36:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230357AbiHHAgM (ORCPT ); Sun, 7 Aug 2022 20:36:12 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DD4463EB for ; Sun, 7 Aug 2022 17:36:11 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id by13-20020a056a00400d00b0052ec5a1cd4dso2644171pfb.21 for ; Sun, 07 Aug 2022 17:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:reply-to:from:to:cc; bh=asDbFP4JFb0e7xA7oblyxbYFEsRwuDE3XnS3dP45ers=; b=LPofzHp+QejVs7YORkGjTw0QzbKv6neHoKdc1Kn+bCR9ask7qi7J6yXD4Ru3ua4A8x LH5FpGl3wy8hfJZlzucaU+VpuxwY+1EbOFPV33yOWEHlEejKqPyb1d2csrHvfFoRXKiL mVJbBno//jGY6tUY7SqBSMGAlrFfzF4Ls/ra5q7zb7gZsn9+IGcuRQd4eVbASi5gK6Zw 4/GND6X2SMSiyIOKes/BrDeUtjgfZU9Oh9+s+UMXR9C4237pBJDkSKVsM+dVPE1y/BqW OVeeh/FGpz/0yXL84AG4I2E1G4Wb9j/1JavzYSZLI6n9bfmvyBU9Z90WK2dEs6elR7K+ tGNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc; bh=asDbFP4JFb0e7xA7oblyxbYFEsRwuDE3XnS3dP45ers=; b=ltMpn6nnHOjisRSxQtrIgr35psbagK+fpN0YecVOkbL9jNao507AloCPpbAaaVOzjb SkE+rltrLRF24MiQlzIdQLkY5LRqpzyC+xsx4Qc8qnG7H3bQx92mjzeRrq5OJpW5FH/e 9DbE15mDPlrWwPt0C/A+y93iO4xnmOJgJaqljtB0GPIRTmgI9qeaFsQGe75OvSrvHm4+ Ap/UTt6W/GPAjvTGV50KbRVSbSF0zGFuvHi4i7xUOVkFGnkvwSS+HRZ80PXpFPJXW4kb upxPr8wDKfkUJqNdgVZRSnYcNohekV9VkEj0M5QWcdKi4slg4Jdv/hdqM8CSWHaH7hLr mLPg== X-Gm-Message-State: ACgBeo3HAoKEKBIv/GZL3wSp4sLn/LxkMUr2qbgP9yzqFqEaN2IcL4lH 6VfWZLUr3tCxSn9Uc6Ts5TiDpZ0b/CVn X-Google-Smtp-Source: AA6agR6fsNI1kDM+j+yiPgAkODdBZ5nkVNdQ+2RFnfzoIbQbkcztGnkSv3+NNlbmmX3iiKTbeBpl9f0UcnIk X-Received: from mizhang-super.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1071]) (user=mizhang job=sendgmr) by 2002:a17:902:cec6:b0:16e:ec03:ff1 with SMTP id d6-20020a170902cec600b0016eec030ff1mr16704649plg.96.1659918970839; Sun, 07 Aug 2022 17:36:10 -0700 (PDT) Reply-To: Mingwei Zhang Date: Mon, 8 Aug 2022 00:36:04 +0000 In-Reply-To: <20220808003606.424212-1-mizhang@google.com> Message-Id: <20220808003606.424212-2-mizhang@google.com> Mime-Version: 1.0 References: <20220808003606.424212-1-mizhang@google.com> X-Mailer: git-send-email 2.37.1.559.g78731f0fdb-goog Subject: [PATCH v3 1/3] KVM: x86: Update trace function for nested VM entry to support VMX From: Mingwei Zhang To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang , David Matlack Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update trace function for nested VM entry to support VMX. Existing trace function only supports nested VMX and the information printed out is AMD specific. So, update trace_kvm_nested_vmrun() to trace_kvm_nested_vmenter(), since 'vmenter' is generic. Add a new field 'isa' to recognize Intel and AMD; Update the output to print out VMX/SVM related naming respectively, eg., vmcb vs. vmcs; npt vs. ept. Opportunistically update the call site of trace_kvm_nested_vmenter() to make one line per parameter. Signed-off-by: Mingwei Zhang --- arch/x86/kvm/svm/nested.c | 6 ++++-- arch/x86/kvm/trace.h | 28 ++++++++++++++++++---------- arch/x86/kvm/x86.c | 2 +- 3 files changed, 23 insertions(+), 13 deletions(-) diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index ba7cd26f438f..0a148a352c3a 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -724,11 +724,13 @@ int enter_svm_guest_mode(struct kvm_vcpu *vcpu, u64 v= mcb12_gpa, struct vcpu_svm *svm =3D to_svm(vcpu); int ret; =20 - trace_kvm_nested_vmrun(svm->vmcb->save.rip, vmcb12_gpa, + trace_kvm_nested_vmenter(svm->vmcb->save.rip, + vmcb12_gpa, vmcb12->save.rip, vmcb12->control.int_ctl, vmcb12->control.event_inj, - vmcb12->control.nested_ctl); + vmcb12->control.nested_ctl, + KVM_ISA_SVM); =20 trace_kvm_nested_intercepts(vmcb12->control.intercepts[INTERCEPT_CR] & 0x= ffff, vmcb12->control.intercepts[INTERCEPT_CR] >> 16, diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h index de4762517569..3ef29c7e4f69 100644 --- a/arch/x86/kvm/trace.h +++ b/arch/x86/kvm/trace.h @@ -578,10 +578,11 @@ TRACE_EVENT(kvm_pv_eoi, /* * Tracepoint for nested VMRUN */ -TRACE_EVENT(kvm_nested_vmrun, +TRACE_EVENT(kvm_nested_vmenter, TP_PROTO(__u64 rip, __u64 vmcb, __u64 nested_rip, __u32 int_ctl, - __u32 event_inj, bool npt), - TP_ARGS(rip, vmcb, nested_rip, int_ctl, event_inj, npt), + __u32 event_inj, bool tdp_enabled, __u32 isa), + TP_ARGS(rip, vmcb, nested_rip, int_ctl, event_inj, tdp_enabled, + isa), =20 TP_STRUCT__entry( __field( __u64, rip ) @@ -589,7 +590,8 @@ TRACE_EVENT(kvm_nested_vmrun, __field( __u64, nested_rip ) __field( __u32, int_ctl ) __field( __u32, event_inj ) - __field( bool, npt ) + __field( bool, tdp_enabled ) + __field( __u32, isa ) ), =20 TP_fast_assign( @@ -598,14 +600,20 @@ TRACE_EVENT(kvm_nested_vmrun, __entry->nested_rip =3D nested_rip; __entry->int_ctl =3D int_ctl; __entry->event_inj =3D event_inj; - __entry->npt =3D npt; + __entry->tdp_enabled =3D tdp_enabled; + __entry->isa =3D isa; ), =20 - TP_printk("rip: 0x%016llx vmcb: 0x%016llx nrip: 0x%016llx int_ctl: 0x%08x= " - "event_inj: 0x%08x npt: %s", - __entry->rip, __entry->vmcb, __entry->nested_rip, - __entry->int_ctl, __entry->event_inj, - __entry->npt ? "on" : "off") + TP_printk("rip: 0x%016llx %s: 0x%016llx nested_rip: 0x%016llx " + "int_ctl: 0x%08x event_inj: 0x%08x nested_%s: %s", + __entry->rip, + __entry->isa =3D=3D KVM_ISA_VMX ? "vmcs" : "vmcb", + __entry->vmcb, + __entry->nested_rip, + __entry->int_ctl, + __entry->event_inj, + __entry->isa =3D=3D KVM_ISA_VMX ? "ept" : "npt", + __entry->tdp_enabled ? "on" : "off") ); =20 TRACE_EVENT(kvm_nested_intercepts, diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 1910e1e78b15..52f6351dc15b 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -13084,7 +13084,7 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_inj_virq); EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_page_fault); EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_msr); EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_cr); -EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_nested_vmrun); +EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_nested_vmenter); EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_nested_vmexit); EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_nested_vmexit_inject); EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_nested_intr_vmexit); --=20 2.37.1.559.g78731f0fdb-goog