From nobody Sat Apr 11 21:30:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E86C19F2D for ; Sat, 6 Aug 2022 19:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234054AbiHFT4r (ORCPT ); Sat, 6 Aug 2022 15:56:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233670AbiHFT4O (ORCPT ); Sat, 6 Aug 2022 15:56:14 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19E97261E for ; Sat, 6 Aug 2022 12:56:07 -0700 (PDT) Received: from dslb-188-097-043-167.188.097.pools.vodafone-ip.de ([188.97.43.167] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1oKPtw-0004Tu-NG; Sat, 06 Aug 2022 21:56:00 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 13/13] staging: r8188eu: simplify _InitNormalChipTwoOutEpPriority Date: Sat, 6 Aug 2022 21:55:40 +0200 Message-Id: <20220806195540.777390-14-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220806195540.777390-1-martin@kaiser.cx> References: <20220806195540.777390-1-martin@kaiser.cx> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Simplify the _InitNormalChipTwoOutEpPriority function, now that we have only one configuration for the queues. Remove the variables which are constant. Keep only those settings that depend on wifi_spec. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/usb_halinit.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8= 188eu/hal/usb_halinit.c index fc4d25b835d3..e1d56370a471 100644 --- a/drivers/staging/r8188eu/hal/usb_halinit.c +++ b/drivers/staging/r8188eu/hal/usb_halinit.c @@ -228,26 +228,17 @@ static void _InitNormalChipRegPriority(struct adapter= *Adapter, u16 beQ, static void _InitNormalChipTwoOutEpPriority(struct adapter *Adapter) { struct registry_priv *pregistrypriv =3D &Adapter->registrypriv; - u16 beQ, bkQ, viQ, voQ, mgtQ, hiQ; - u16 valueHi =3D QUEUE_HIGH; - u16 valueLow =3D QUEUE_NORMAL; + u16 bkQ, voQ; =20 if (!pregistrypriv->wifi_spec) { - beQ =3D valueLow; - bkQ =3D valueLow; - viQ =3D valueHi; - voQ =3D valueHi; - mgtQ =3D valueHi; - hiQ =3D valueHi; + bkQ =3D QUEUE_NORMAL; + voQ =3D QUEUE_HIGH; } else {/* for WMM ,CONFIG_OUT_EP_WIFI_MODE */ - beQ =3D valueLow; - bkQ =3D valueHi; - viQ =3D valueHi; - voQ =3D valueLow; - mgtQ =3D valueHi; - hiQ =3D valueHi; + bkQ =3D QUEUE_HIGH; + voQ =3D QUEUE_NORMAL; } - _InitNormalChipRegPriority(Adapter, beQ, bkQ, viQ, voQ, mgtQ, hiQ); + _InitNormalChipRegPriority(Adapter, QUEUE_NORMAL, bkQ, QUEUE_HIGH, + voQ, QUEUE_HIGH, QUEUE_HIGH); } =20 static void _InitNormalChipThreeOutEpPriority(struct adapter *Adapter) --=20 2.30.2