From nobody Fri Mar 29 10:15:50 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D16D8C19F29 for ; Sat, 6 Aug 2022 06:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241531AbiHFGJx (ORCPT ); Sat, 6 Aug 2022 02:09:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238582AbiHFGJt (ORCPT ); Sat, 6 Aug 2022 02:09:49 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE20C201BE for ; Fri, 5 Aug 2022 23:09:47 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id z22so5666228edd.6 for ; Fri, 05 Aug 2022 23:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G8+xp6CTSirrV4c005hxKlVzfV8/Z9ZKPx/4fznm5Fs=; b=qm/O7bVoyDkHehE0iPMgiaTuAFSxuvL8uWOMPJnTJvkXUlfi59RTM9UjN7MZ4/z/Ok 0Xizcy4D44lj2whvjpgcoAdRIU0u0pawZW6Klw4N4V7KBgbsfFCIPEbPPw4JnCSJCRRN 9K4S12vDtXj2a0jAB6zsjy9ie178iPgtV0VCzon9zEAwJ2JPI4rjDN4T9rc/6sLCsgZH movlXm7q4BvZxLVAMVMwKMRwfZI+a0sMS6vBCDijnH/YxBzMJHKsx4seOqZWHmNFTOlu /z6NF/S/6X07uA378LIMjSHcmh5R8EetkVqyA+tOcwhjLEqJOzbXhT57s9GzHTa9mHss SG1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G8+xp6CTSirrV4c005hxKlVzfV8/Z9ZKPx/4fznm5Fs=; b=SSF1hiCrtsC/1lYeVrtpw4scFsvZlWjITwcO8fSCsRquGCHHbOjwaW6AweK9AaQjvx 2bVv9J6X03tk2C4GclEmqqDLK8dDYz7MgvmEaJUnNJrL2AqCzfbW+uRSY/75AvtazKiA GAbGuclZIOVnDhsBQ/I3u/NbqJrcWhizk5unn23YNEM2+aB/yNTi053q7d+mMalPXIJ4 2Hwqei0rCRSJEFJZzi4Wqp5I1hAkk5oje4YnEvqguSqNh/agTb3REUJo+MRerxvecCS5 cUGD85NPv9B5TsiadHAHkFyJlQs1eZsqESbuTC4GuXivjZvDCl1uvO54zp7TMmtfAD2+ KrQw== X-Gm-Message-State: ACgBeo3+eHtfc5RriYt1IZJ5WT+XmB2shhc/wXweR8ZrbRTFu1SEyMqL 2KYfXZqwRzlggmDDDz8jYqE= X-Google-Smtp-Source: AA6agR6kHVI5r9LkxD3Z/MhoIZc89eS6Hr3svWarqPsCS9gOi+bQEi0QxT8flVyhGJOjRuJNnAXU9A== X-Received: by 2002:a05:6402:348f:b0:43d:e568:97bd with SMTP id v15-20020a056402348f00b0043de56897bdmr9278639edc.279.1659766186404; Fri, 05 Aug 2022 23:09:46 -0700 (PDT) Received: from localhost.localdomain (ip5f5abba5.dynamic.kabel-deutschland.de. [95.90.187.165]) by smtp.gmail.com with ESMTPSA id p10-20020a05640243ca00b0043a7293a03dsm1002357edc.7.2022.08.05.23.09.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 23:09:46 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/3] staging: r8188eu: use ffs() in phy_CalculateBitShift() Date: Sat, 6 Aug 2022 08:09:27 +0200 Message-Id: <20220806060929.11022-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220806060929.11022-1-straube.linux@gmail.com> References: <20220806060929.11022-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use ffs() in phy_CalculateBitShift() to simplify the function and improve readability. Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c b/drivers/stagin= g/r8188eu/hal/rtl8188e_phycfg.c index dea6d915a1f4..3d8fcc1f0b6a 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c @@ -25,13 +25,9 @@ */ static u32 phy_CalculateBitShift(u32 BitMask) { - u32 i; + u32 i =3D ffs(BitMask); =20 - for (i =3D 0; i <=3D 31; i++) { - if (((BitMask >> i) & 0x1) =3D=3D 1) - break; - } - return i; + return i ? i - 1 : 32; } =20 /** --=20 2.37.1 From nobody Fri Mar 29 10:15:50 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B73C25B08 for ; Sat, 6 Aug 2022 06:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241616AbiHFGJz (ORCPT ); Sat, 6 Aug 2022 02:09:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239603AbiHFGJt (ORCPT ); Sat, 6 Aug 2022 02:09:49 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94E02205D2 for ; Fri, 5 Aug 2022 23:09:48 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id tl27so8323894ejc.1 for ; Fri, 05 Aug 2022 23:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vcLF/W8KMFIaSXXvb2UsBctV0hSOCapQFAQgo06eWCM=; b=mqZ/ZAOCMrjjGKRH/ewbc55oJAItb5npnHzzg3svEYlyQrRuBTWHpd1MYWMO21bU/h WJqNXMcgdUboGwAZ4doAL9KZani3z5Lhx2a3r9wzoa/vmVZn+h0HUsnqaRYZ4pnNnvaJ 9aKihD5ZifPOTPT2n1dvmoSqOmETQrwSMKWUwqRr7FODOs50aPl1f0GNK65SXG6fT6aC cwOY7MIU5tk5qgMso97lqMRFB+LgqPd/ghtAlPzyZ8C7KWuBxiM48VnAXsYXrb8Io99e N0kyNbeXxcd0iph4zrBbYLXrITH7o/8vtAXYPB9v5ZWvzZAc3ezG26a/ElBvc9Nk6xVO uFpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vcLF/W8KMFIaSXXvb2UsBctV0hSOCapQFAQgo06eWCM=; b=fZDLxKOI7TxKww18u7kZCeOBrvGiZs3zEnWVI2+u5iQHCKPp1cEvJaBbtaXBYRauMW 0aEP5mjx/BEHfM4iWa0u1sp0Sz+0DJyR6ss+Z5mcQ1P/dkpGYGRHfAtOzxngf3UEQkUB m1x3i9VdP8KvV30Mm5QGKqk6eyGMx9EtATqaSCGQal+qKocjIMCRBo4MV8aQoCrT1Bg+ 5tgq5vrNWnOl8VQSHWl5rRV+5/34NRlDIvAHrSAmWUx4HHVEXq6MNVDqUc1hVETzpN7s sGZnoV50rqozcAnUQCXdWaslooCVUhgbqfegpl/lLY7c24OadC1pxsC8hI84KK9Oy+g2 iijw== X-Gm-Message-State: ACgBeo0bkI21xsBPffqtlw9BDyxLvkLHLLg4fDV8FnQu3CUOrZEreMQR pZUsSt/pzDRc84d/+EiWeRV7pAMsF1E= X-Google-Smtp-Source: AA6agR4td96QHPH8bB6zZWLnwKy3oZ8M0MJyA522BMox/A2/flPPk04ZrDVrBUW3AHdmlXxP36M/bA== X-Received: by 2002:a17:906:847c:b0:730:b6a0:e0d with SMTP id hx28-20020a170906847c00b00730b6a00e0dmr7459809ejc.126.1659766187034; Fri, 05 Aug 2022 23:09:47 -0700 (PDT) Received: from localhost.localdomain (ip5f5abba5.dynamic.kabel-deutschland.de. [95.90.187.165]) by smtp.gmail.com with ESMTPSA id p10-20020a05640243ca00b0043a7293a03dsm1002357edc.7.2022.08.05.23.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 23:09:46 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/3] staging: r8188eu: avoid camel case in phy_CalculateBitShift() Date: Sat, 6 Aug 2022 08:09:28 +0200 Message-Id: <20220806060929.11022-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220806060929.11022-1-straube.linux@gmail.com> References: <20220806060929.11022-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename the function phy_CalculateBitShift() and its parameter BitMask to avoid camel case. phy_CalculateBitShift -> phy_calculate_bit_shift BitMask -> bitmask Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c b/drivers/stagin= g/r8188eu/hal/rtl8188e_phycfg.c index 3d8fcc1f0b6a..e9e24efabd76 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c @@ -23,9 +23,9 @@ * Output: none * Return: u32 Return the shift bit bit position of the mask */ -static u32 phy_CalculateBitShift(u32 BitMask) +static u32 phy_calculate_bit_shift(u32 bitmask) { - u32 i =3D ffs(BitMask); + u32 i =3D ffs(bitmask); =20 return i ? i - 1 : 32; } @@ -58,7 +58,7 @@ rtl8188e_PHY_QueryBBReg( if (res) return 0; =20 - BitShift =3D phy_CalculateBitShift(BitMask); + BitShift =3D phy_calculate_bit_shift(BitMask); ReturnValue =3D (OriginalValue & BitMask) >> BitShift; return ReturnValue; } @@ -91,7 +91,7 @@ void rtl8188e_PHY_SetBBReg(struct adapter *Adapter, u32 R= egAddr, u32 BitMask, u3 if (res) return; =20 - BitShift =3D phy_CalculateBitShift(BitMask); + BitShift =3D phy_calculate_bit_shift(BitMask); Data =3D ((OriginalValue & (~BitMask)) | (Data << BitShift)); } =20 @@ -263,7 +263,7 @@ u32 rtl8188e_PHY_QueryRFReg(struct adapter *Adapter, u3= 2 RegAddr, u32 BitMask) =20 Original_Value =3D phy_RFSerialRead(Adapter, RegAddr); =20 - BitShift =3D phy_CalculateBitShift(BitMask); + BitShift =3D phy_calculate_bit_shift(BitMask); Readback_Value =3D (Original_Value & BitMask) >> BitShift; return Readback_Value; } @@ -298,7 +298,7 @@ rtl8188e_PHY_SetRFReg( /* RF data is 12 bits only */ if (BitMask !=3D bRFRegOffsetMask) { Original_Value =3D phy_RFSerialRead(Adapter, RegAddr); - BitShift =3D phy_CalculateBitShift(BitMask); + BitShift =3D phy_calculate_bit_shift(BitMask); Data =3D ((Original_Value & (~BitMask)) | (Data << BitShift)); } =20 --=20 2.37.1 From nobody Fri Mar 29 10:15:50 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBAAC19F29 for ; Sat, 6 Aug 2022 06:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241669AbiHFGJ7 (ORCPT ); Sat, 6 Aug 2022 02:09:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241428AbiHFGJu (ORCPT ); Sat, 6 Aug 2022 02:09:50 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C95120199 for ; Fri, 5 Aug 2022 23:09:49 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id r4so5654361edi.8 for ; Fri, 05 Aug 2022 23:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5I+v5QzSk+bZ7pDEdk0V2aAobL+DUNvbn5oomeG6tvY=; b=HeQCo2ZfyOw4W49h46NkhEu6w+zLcUJVhq/30mHdViNiPMyxecNFQaRnNTeFn8H5zz ghd8/ZUrSpmwkW7DlPlRp6bXNrJFJNp0udcmU/MernpCLbyMUNCznjdME/WoGKW3lWLA 9lrZJwnaGRnC420kqt9fyWMeRqBhIkgsF1fkoiNkh+7xJWXSWJv2pWAhnJcZ2255eUK0 ra/c8jB0vht7yqYEubTjwyzQtMEQDI/GSfol8XKg/t4ka42dTAZVT2Uah8l0DD9J2g3a KleAZf5kZ1TYnPqjZ7g5lj7+eaRiIfUXa+nHqTh6l8ck4kdk2XQHPAC8HATAh7ZLNxvi Bncg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5I+v5QzSk+bZ7pDEdk0V2aAobL+DUNvbn5oomeG6tvY=; b=MHag2Wy90kjGGXuKNwj3bYIKlzseu9nsA1i1uvjQOPXDCi4qv7Xqvdwl+MCqojbeQq BAn7UQxSQEeZEdLFa/0h+S/tPNtOvMPUKR/Xp5LkYYUsn7Be2HOkhZuYs4VLgYQxsofp HDE+Tb/2keOsDngbxrlCWKNyiVl2PGqkIyR54EuVDg93w1yHwIf7noehfFGNSo3T0fXr 27VHdQXDSYX3r3WQu0zcWbsQlLAps/T/RW/DhAfjVOv76CcchScluBjGfu81iTylUyTo snck8MxJgaGAY/hRBCLQjakwFNfyayu2IgfOT4oDKpu9chDs2Kzw/JRCEVu+qmRxcihM 5i4A== X-Gm-Message-State: ACgBeo32PHWXPi4EsEwvx6+vCNfR//t4J6ZlYchLpLAutoZJMtESNEAV Sx6DGPs+HYj7ZJYFx9fJdt8= X-Google-Smtp-Source: AA6agR4X086kYSluvhH2r9JDQeydIYZWbBtoDvzYITewnsvHTsK+lv4A0M56P6j4odwzeMx6og0f/Q== X-Received: by 2002:aa7:d712:0:b0:43d:3651:7217 with SMTP id t18-20020aa7d712000000b0043d36517217mr9328225edq.79.1659766187590; Fri, 05 Aug 2022 23:09:47 -0700 (PDT) Received: from localhost.localdomain (ip5f5abba5.dynamic.kabel-deutschland.de. [95.90.187.165]) by smtp.gmail.com with ESMTPSA id p10-20020a05640243ca00b0043a7293a03dsm1002357edc.7.2022.08.05.23.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 23:09:47 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 3/3] staging: r8188eu: clean up comment for phy_calculate_bit_shift() Date: Sat, 6 Aug 2022 08:09:29 +0200 Message-Id: <20220806060929.11022-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220806060929.11022-1-straube.linux@gmail.com> References: <20220806060929.11022-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Clean up the comment for function phy_calculate_bit_shift(). Signed-off-by: Michael Straube Tested-by: Philipp Hortmann # Edimax N150 --- drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c b/drivers/stagin= g/r8188eu/hal/rtl8188e_phycfg.c index e9e24efabd76..a435ec65d4b1 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_phycfg.c @@ -12,17 +12,7 @@ /* 1. BB register R/W API */ /* */ =20 -/** -* Function: phy_CalculateBitShift -* -* OverView: Get shifted position of the BitMask -* -* Input: -* u32 BitMask, -* -* Output: none -* Return: u32 Return the shift bit bit position of the mask -*/ +/* Get shifted position of the bit mask */ static u32 phy_calculate_bit_shift(u32 bitmask) { u32 i =3D ffs(bitmask); --=20 2.37.1