From nobody Thu Apr 25 23:18:39 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE4F5C00140 for ; Sat, 6 Aug 2022 02:57:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241559AbiHFC5V (ORCPT ); Fri, 5 Aug 2022 22:57:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238055AbiHFC5U (ORCPT ); Fri, 5 Aug 2022 22:57:20 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75D1212D0C for ; Fri, 5 Aug 2022 19:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=S9YS6jdP8Hamx4Jny4WehGdZWztSJB+1gXBrm2yiZQI=; b=WNjslUijwH3x3RVJeuzxGvpFhJ +j1N47886zHF0fAnNcvuZ0LlqTxgPJU5BDHnYsn7xcdJz+p2G9dU6TgWkxDT5YnUFONqSHhH3diEt QQyWed16nEn7ca3uLLCRGLje8215w/ByabmDviHl80NirjKBFtN5AJVA8WcLZw2KyeQqKl/w1I+ED 2G6v71O9K6c6N2I5+FNYhDYwT8X8/zCL3it+AJfUXP1EyvwdTMG8Tbna5+cHm9CO63tnomtizd4cb Om4mHY2CyS72GnjVwNUDoPq0JIxg+znsXk6Yg4XhpjC40j2UFiSJkZ5xYlv1UKcHRmnOXQCzn12WE OGtOYcmw==; Received: from [2601:1c0:6280:3f0::a6b3] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oK9zw-00BmIt-Pp; Sat, 06 Aug 2022 02:57:09 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Qin Jian , Necip Fazil Yildiran , Arnd Bergmann , linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: sunplus: fix serial console kconfig and build problems Date: Fri, 5 Aug 2022 19:57:05 -0700 Message-Id: <20220806025705.7759-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix kconfig dependency warnings and subsequent build errors: WARNING: unmet direct dependencies detected for SERIAL_SUNPLUS Depends on [n]: TTY [=3Dn] && HAS_IOMEM [=3Dy] && (ARCH_SUNPLUS [=3Dy] ||= COMPILE_TEST [=3Dn]) Selected by [y]: - SOC_SP7021 [=3Dy] && ARCH_SUNPLUS [=3Dy] WARNING: unmet direct dependencies detected for SERIAL_SUNPLUS_CONSOLE Depends on [n]: TTY [=3Dn] && HAS_IOMEM [=3Dy] && SERIAL_SUNPLUS [=3Dy] Selected by [y]: - SOC_SP7021 [=3Dy] && ARCH_SUNPLUS [=3Dy] (samples, not all:) drivers/tty/serial/sunplus-uart.c:342: undefined reference to `uart_get_bau= d_rate' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.c:379: undefined refe= rence to `uart_update_timeout' drivers/tty/serial/sunplus-uart.c:526: undefined reference to `uart_console= _write' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.c:274: undefined refe= rence to `tty_flip_buffer_push' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.o:(.data+0xa8): undef= ined reference to `uart_console_device' drivers/tty/serial/sunplus-uart.c:720: undefined reference to `uart_registe= r_driver' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.c:726: undefined refe= rence to `uart_unregister_driver' drivers/tty/serial/sunplus-uart.c:551: undefined reference to `uart_parse_o= ptions' arm-linux-gnueabi-ld: drivers/tty/serial/sunplus-uart.c:553: undefined refe= rence to `uart_set_options' This is the same technique that is used 2 times in arch/arm/mach-versatile/Kconfig. Fixes: 0aa94eea8d95 ("ARM: sunplus: Add initial support for Sunplus SP7021 = SoC") Reported-by: kernel test robot Signed-off-by: Randy Dunlap Cc: Qin Jian Cc: Necip Fazil Yildiran Cc: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/mach-sunplus/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/arm/mach-sunplus/Kconfig +++ b/arch/arm/mach-sunplus/Kconfig @@ -18,8 +18,8 @@ config SOC_SP7021 select ARM_PSCI select PINCTRL select PINCTRL_SPPCTL - select SERIAL_SUNPLUS - select SERIAL_SUNPLUS_CONSOLE + select SERIAL_SUNPLUS if TTY + select SERIAL_SUNPLUS_CONSOLE if TTY help Support for Sunplus SP7021 SoC. It is based on ARM 4-core Cortex-A7 with various peripherals (e.g.: I2C, SPI, SDIO,