From nobody Thu Nov 14 08:53:12 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B67C25B0D for ; Fri, 5 Aug 2022 15:52:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241491AbiHEPwC (ORCPT ); Fri, 5 Aug 2022 11:52:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241351AbiHEPvU (ORCPT ); Fri, 5 Aug 2022 11:51:20 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7101D6BD44; Fri, 5 Aug 2022 08:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659714558; x=1691250558; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OunVwjFJhL1Q/tamMZepaupTRMyzPHvHM30RUkvfBQg=; b=ee76pxK95F2kPO0hw+AVtP0+sMSIvnSA8bbC772wAp9UilR1+4u/6Ii+ RdiqSiTXy5FAUls6NY89my/LiVX/E70DPgufoYarl4WGCck6in2QFlOFY UdTFyHLS2IAkFy4Kzn2MGilrmvmzYfoOXuXfUskd4DGKgsBUQiOE/Y0Rg Bxyh8mef4TVFpra7RsSCRrgMlAP8/SPB6aHikhVfw4e2NLg9A6IllNvTx 6q9Pvl8NFD5hiD+Dkdie1u7I8YApe9P66Ia7UQ2TulJB8rtEdT2LfoGvW QyMwCQwIKlrFZNg17tt1/JijkC07dvnX0SbykOxKpZDFFokPrbPvwZgMx g==; X-IronPort-AV: E=McAfee;i="6400,9594,10430"; a="316120626" X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="316120626" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2022 08:49:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,216,1654585200"; d="scan'208";a="693037586" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 05 Aug 2022 08:49:10 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C8674347; Fri, 5 Aug 2022 18:49:16 +0300 (EEST) From: Andy Shevchenko To: Gene Chen , Andy Shevchenko , Pavel Machek , Eddie James , Denis Osterland-Heim , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Matthias Brugger , Sean Wang , Kurt Kanzenbach , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH v2 06/11] leds: mt6323: Get rid of custom led_init_default_state_get() Date: Fri, 5 Aug 2022 18:49:02 +0300 Message-Id: <20220805154907.32263-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220805154907.32263-1-andriy.shevchenko@linux.intel.com> References: <20220805154907.32263-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" LED core provides a helper to parse default state from firmware node. Use it instead of custom implementation. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-mt6323.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c index f59e0e8bda8b..17ee88043f52 100644 --- a/drivers/leds/leds-mt6323.c +++ b/drivers/leds/leds-mt6323.c @@ -339,23 +339,23 @@ static int mt6323_led_set_dt_default(struct led_class= dev *cdev, struct device_node *np) { struct mt6323_led *led =3D container_of(cdev, struct mt6323_led, cdev); - const char *state; + enum led_default_state state; int ret =3D 0; =20 - state =3D of_get_property(np, "default-state", NULL); - if (state) { - if (!strcmp(state, "keep")) { - ret =3D mt6323_get_led_hw_brightness(cdev); - if (ret < 0) - return ret; - led->current_brightness =3D ret; - ret =3D 0; - } else if (!strcmp(state, "on")) { - ret =3D - mt6323_led_set_brightness(cdev, cdev->max_brightness); - } else { - ret =3D mt6323_led_set_brightness(cdev, LED_OFF); - } + state =3D led_init_default_state_get(of_fwnode_handle(np)); + switch (state) { + case LEDS_DEFSTATE_ON: + ret =3D mt6323_led_set_brightness(cdev, cdev->max_brightness); + break; + case LEDS_DEFSTATE_KEEP: + ret =3D mt6323_get_led_hw_brightness(cdev); + if (ret < 0) + return ret; + led->current_brightness =3D ret; + ret =3D 0; + break; + default: + ret =3D mt6323_led_set_brightness(cdev, LED_OFF); } =20 return ret; --=20 2.35.1