From nobody Sat Apr 11 21:02:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 992D6C00140 for ; Fri, 5 Aug 2022 15:07:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240905AbiHEPHt (ORCPT ); Fri, 5 Aug 2022 11:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231845AbiHEPHr (ORCPT ); Fri, 5 Aug 2022 11:07:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0FEF19C03 for ; Fri, 5 Aug 2022 08:07:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D49E614B5 for ; Fri, 5 Aug 2022 15:07:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F404EC433C1; Fri, 5 Aug 2022 15:07:43 +0000 (UTC) Date: Fri, 5 Aug 2022 11:07:42 -0400 From: Steven Rostedt To: LKML Cc: Ingo Molnar , Andrew Morton , Dan Carpenter , Daniel Bristot de Oliveira Subject: [for-linus][PATCH] rv: Unlock on error path in rv_unregister_reactor() Message-ID: <20220805110742.7a6d55c1@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Dan Carpenter (1): rv: Unlock on error path in rv_unregister_reactor() ---- kernel/trace/rv/rv_reactors.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --------------------------- commit f1a15b977ff864513133ecb611eb28603d32c1b4 Author: Dan Carpenter Date: Thu Aug 4 17:33:48 2022 +0300 rv: Unlock on error path in rv_unregister_reactor() =20 Unlock the "rv_interface_lock" mutex before returning. =20 Link: https://lkml.kernel.org/r/YuvYzNfGMgV+PIhd@kili =20 Fixes: 04acadcb4453 ("rv: Add runtime reactors interface") Signed-off-by: Dan Carpenter Signed-off-by: Steven Rostedt (Google) diff --git a/kernel/trace/rv/rv_reactors.c b/kernel/trace/rv/rv_reactors.c index a6522c196382..6aae106695b6 100644 --- a/kernel/trace/rv/rv_reactors.c +++ b/kernel/trace/rv/rv_reactors.c @@ -329,6 +329,7 @@ int rv_register_reactor(struct rv_reactor *reactor) int rv_unregister_reactor(struct rv_reactor *reactor) { struct rv_reactor_def *ptr, *next; + int ret =3D 0; =20 mutex_lock(&rv_interface_lock); =20 @@ -343,13 +344,14 @@ int rv_unregister_reactor(struct rv_reactor *reactor) ptr->reactor->name, ptr->counter); printk(KERN_WARNING "rv: the rv_reactor %s cannot be removed\n", ptr->reactor->name); - return -EBUSY; + ret =3D -EBUSY; + break; } } } =20 mutex_unlock(&rv_interface_lock); - return 0; + return ret; } =20 /*