From nobody Sun Apr 12 00:53:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 584DDC25B07 for ; Tue, 2 Aug 2022 19:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232371AbiHBTrq (ORCPT ); Tue, 2 Aug 2022 15:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbiHBTrl (ORCPT ); Tue, 2 Aug 2022 15:47:41 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41DDE4AD63; Tue, 2 Aug 2022 12:47:41 -0700 (PDT) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 272Jk1LZ010234; Tue, 2 Aug 2022 19:47:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : mime-version; s=pp1; bh=0TU5DLp61xDyAb6KBH+NW4/5l6RU7u/o/UOxwNx8Wek=; b=kGoVyer1Z8fx2kWHIygrZuUsTWNwaGZGHPPHjsZs9MXZ32+0ZuEyXNne5U7KhX5YtAus 7njL0BaT3EASi0/7bwuA1R0WFGhYWFg+ThWP0bwwFM/NB3B7gYH7jqI3Gdc4UDJa/oB2 JTXNHr/WV4ZrcK63yQhBt1/V0FpAPaS3+m4rxl9qQCQWHmtffYNMeuDhlVyyAW9TexUW pCuV6ZFauMYWGatmIo9z7O8eiuuGzZlGjlSPCDFuZMoNhvoLMeZ+Dk5YdBWp3FNk+Zkv omp2t6xquGP/quQsD56RFQgPSmEgvVwvcsh/g6I1cBmgi6RIZhFbwG0P8NfHQYmQUWAd ng== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hqac7r0f3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Aug 2022 19:47:15 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 272JK4Zk030027; Tue, 2 Aug 2022 19:47:14 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma03dal.us.ibm.com with ESMTP id 3hmv99gx8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Aug 2022 19:47:14 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 272JlD3157344452 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Aug 2022 19:47:13 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75F90124054; Tue, 2 Aug 2022 19:47:13 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B6310124052; Tue, 2 Aug 2022 19:47:12 +0000 (GMT) Received: from slate16.aus.stglabs.ibm.com (unknown [9.77.144.23]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 2 Aug 2022 19:47:12 +0000 (GMT) From: Eddie James To: joel@jms.id.au Cc: linux@roeck-us.net, jdelvare@suse.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-fsi@lists.ozlabs.org, devicetree@vger.kernel.org, Eddie James Subject: [PATCH 1/3] dt-bindings: hwmon: Add IBM OCC bindings Date: Tue, 2 Aug 2022 14:46:54 -0500 Message-Id: <20220802194656.240564-2-eajames@linux.ibm.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220802194656.240564-1-eajames@linux.ibm.com> References: <20220802194656.240564-1-eajames@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: qJ9ewh5M9TPRC9a7zPaWUAGNa0BG__BH X-Proofpoint-ORIG-GUID: qJ9ewh5M9TPRC9a7zPaWUAGNa0BG__BH Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-02_14,2022-08-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 clxscore=1015 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2208020092 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" These bindings describe the POWER processor On Chip Controller accessed from a service processor or baseboard management controller (BMC). Signed-off-by: Eddie James --- .../bindings/hwmon/ibm,occ-hmwon.yaml | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/ibm,occ-hmwon.y= aml diff --git a/Documentation/devicetree/bindings/hwmon/ibm,occ-hmwon.yaml b/D= ocumentation/devicetree/bindings/hwmon/ibm,occ-hmwon.yaml new file mode 100644 index 000000000000..8f8c3b8d7129 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/ibm,occ-hmwon.yaml @@ -0,0 +1,40 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/ibm,occ-hwmon.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IBM On-Chip Controller (OCC) accessed from a service processor + +maintainers: + - Eddie James + +description: | + This binding describes a POWER processor On-Chip Controller (OCC) + accessed from a service processor or baseboard management controller + (BMC). + +properties: + compatible: + enum: + - ibm,p9-occ-hwmon + - ibm,p10-occ-hwmon + + ibm,inactive-on-init: + description: This property describes whether or not the OCC should + be marked as active during device initialization. The alternative + is for user space to mark the device active based on higher level + communications between the BMC and the host processor. + type: boolean + +required: + - compatible + +additionalProperties: false + +examples: + - | + occ-hmwon { + compatible =3D "ibm,p9-occ-hwmon"; + ibm,inactive-on-init; + }; --=20 2.31.1 From nobody Sun Apr 12 00:53:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1936C00140 for ; Tue, 2 Aug 2022 19:47:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232994AbiHBTrt (ORCPT ); Tue, 2 Aug 2022 15:47:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231969AbiHBTrm (ORCPT ); Tue, 2 Aug 2022 15:47:42 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34FE452DD0; Tue, 2 Aug 2022 12:47:42 -0700 (PDT) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 272JVYfb020889; Tue, 2 Aug 2022 19:47:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=TV3sMebpyd3j0lWO2Fy/JyNFKcw+E5PtIgF4uxcUqhw=; b=lsv0kVEr2ggEmkC0NOIc+MkAAM1QSXEoORheLE1VmkbPqNgFT02DfRbCAk/vmiMKZUb+ facFl6CBk52hZuYNxD1G8kJfN+Y9L2EIo8SP88dNEi/Rz7dQDYXAxPQ8nUTFdrPLtFQl lpQUroKFMN+HKlxZ9VrSTzt5qYrAfmdcHpXCkbpqEAfJn1VnofyZugyDvMTnMsfC6iu1 rAt5voChn9/MmZ7IcylcOkBEyMGreVrW5TfRaoYv+4Dyx7p2ajm9Rh309o0IQo98MZdI 7crnNitdwq/d5MUS8dJf2F9vlbP4V6aYm6cm0fQliVEQkhal2xi2GjbASWerhxJQ6lzU Yg== Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hqa58re2y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Aug 2022 19:47:17 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 272JK4HN021387; Tue, 2 Aug 2022 19:47:16 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma02dal.us.ibm.com with ESMTP id 3hmv99h2wc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Aug 2022 19:47:16 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 272JlG1u55574920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Aug 2022 19:47:16 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 01CA2124053; Tue, 2 Aug 2022 19:47:16 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4046F124052; Tue, 2 Aug 2022 19:47:15 +0000 (GMT) Received: from slate16.aus.stglabs.ibm.com (unknown [9.77.144.23]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 2 Aug 2022 19:47:15 +0000 (GMT) From: Eddie James To: joel@jms.id.au Cc: linux@roeck-us.net, jdelvare@suse.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-fsi@lists.ozlabs.org, devicetree@vger.kernel.org, Eddie James Subject: [PATCH 2/3] fsi: occ: Support probing the hwmon child device from dts node Date: Tue, 2 Aug 2022 14:46:55 -0500 Message-Id: <20220802194656.240564-3-eajames@linux.ibm.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220802194656.240564-1-eajames@linux.ibm.com> References: <20220802194656.240564-1-eajames@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: XY3dOJ9PUBdWg16HdjC-zl3ZZflMl9pK X-Proofpoint-GUID: XY3dOJ9PUBdWg16HdjC-zl3ZZflMl9pK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-02_14,2022-08-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1015 mlxscore=0 adultscore=0 malwarescore=0 suspectscore=0 impostorscore=0 mlxlogscore=940 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2208020092 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is now a need for reading devicetree properties in the OCC hwmon driver, which isn't current supported as the FSI driver just instantiates a basic platform device. Add support for this use case by checking for an "occ-hwmon" node and if present, creating an OF device from it. Signed-off-by: Eddie James --- drivers/fsi/fsi-occ.c | 41 ++++++++++++++++++++++++++++++++++------- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c index 8f7f602b909d..abdd37d5507f 100644 --- a/drivers/fsi/fsi-occ.c +++ b/drivers/fsi/fsi-occ.c @@ -44,6 +44,7 @@ struct occ { struct device *sbefifo; char name[32]; int idx; + bool platform_hwmon; u8 sequence_number; void *buffer; void *client_buffer; @@ -598,7 +599,7 @@ int fsi_occ_submit(struct device *dev, const void *requ= est, size_t req_len, } EXPORT_SYMBOL_GPL(fsi_occ_submit); =20 -static int occ_unregister_child(struct device *dev, void *data) +static int occ_unregister_platform_child(struct device *dev, void *data) { struct platform_device *hwmon_dev =3D to_platform_device(dev); =20 @@ -607,12 +608,25 @@ static int occ_unregister_child(struct device *dev, v= oid *data) return 0; } =20 +static int occ_unregister_of_child(struct device *dev, void *data) +{ + struct platform_device *hwmon_dev =3D to_platform_device(dev); + + of_device_unregister(hwmon_dev); + if (dev->of_node) + of_node_clear_flag(dev->of_node, OF_POPULATED); + + return 0; +} + static int occ_probe(struct platform_device *pdev) { int rc; u32 reg; + char child_name[32]; struct occ *occ; - struct platform_device *hwmon_dev; + struct platform_device *hwmon_dev =3D NULL; + struct device_node *hwmon_node; struct device *dev =3D &pdev->dev; struct platform_device_info hwmon_dev_info =3D { .parent =3D dev, @@ -671,10 +685,20 @@ static int occ_probe(struct platform_device *pdev) return rc; } =20 - hwmon_dev_info.id =3D occ->idx; - hwmon_dev =3D platform_device_register_full(&hwmon_dev_info); - if (IS_ERR(hwmon_dev)) - dev_warn(dev, "failed to create hwmon device\n"); + hwmon_node =3D of_get_child_by_name(dev->of_node, hwmon_dev_info.name); + if (hwmon_node) { + snprintf(child_name, sizeof(child_name), "%s.%d", hwmon_dev_info.name, o= cc->idx); + hwmon_dev =3D of_platform_device_create(hwmon_node, child_name, dev); + of_node_put(hwmon_node); + } + + if (!hwmon_dev) { + occ->platform_hwmon =3D true; + hwmon_dev_info.id =3D occ->idx; + hwmon_dev =3D platform_device_register_full(&hwmon_dev_info); + if (IS_ERR(hwmon_dev)) + dev_warn(dev, "failed to create hwmon device\n"); + } =20 return 0; } @@ -690,7 +714,10 @@ static int occ_remove(struct platform_device *pdev) occ->buffer =3D NULL; mutex_unlock(&occ->occ_lock); =20 - device_for_each_child(&pdev->dev, NULL, occ_unregister_child); + if (occ->platform_hwmon) + device_for_each_child(&pdev->dev, NULL, occ_unregister_platform_child); + else + device_for_each_child(&pdev->dev, NULL, occ_unregister_of_child); =20 ida_simple_remove(&occ_ida, occ->idx); =20 --=20 2.31.1 From nobody Sun Apr 12 00:53:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91B6C19F2B for ; Tue, 2 Aug 2022 19:47:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233149AbiHBTrx (ORCPT ); Tue, 2 Aug 2022 15:47:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232123AbiHBTrp (ORCPT ); Tue, 2 Aug 2022 15:47:45 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0144E4AD63; Tue, 2 Aug 2022 12:47:44 -0700 (PDT) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 272JkEE8010761; Tue, 2 Aug 2022 19:47:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=UCu96v+PoXqH6TThpduEionJ8Gjk0/uHBNwYtT0Bioo=; b=Jh/0tCylrsH76M20KMM6rTUzE0CIEzbuArR/x8sD6WZ5JpfLboK6OJ3kaBv5WVH1gCUH UGceaDaLhziQiRs3OPnLTyrVhTZEwNPze4EDzrUwTcFZTv13BuYfdjoKk/k0tDa8JNLF fWQn1dKVqxzNBrZY93uQffJjaIz1LZn8TxfTsR0K9HyuFy/e81FLAUa+T6fa9LkqTJRD Tk9KgXuYmH0RTyqhEkegJz/MuAiHsGvXN+U5npe5wR4QHWoEueNAvs4wNtIehK/IX+Yn SL6OJ87rMiKo7nuYVCMOxy3Rc6QtQGLSFHvMRLP8CzRPvmNzasiqoeK8XdRua/9Hnvh+ rQ== Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hqac7r0g7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Aug 2022 19:47:20 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 272JKixv012973; Tue, 2 Aug 2022 19:47:18 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma04wdc.us.ibm.com with ESMTP id 3hmv99m0kb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Aug 2022 19:47:18 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 272JlIwN50921870 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Aug 2022 19:47:18 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3DD74124052; Tue, 2 Aug 2022 19:47:18 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6DF39124054; Tue, 2 Aug 2022 19:47:17 +0000 (GMT) Received: from slate16.aus.stglabs.ibm.com (unknown [9.77.144.23]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 2 Aug 2022 19:47:17 +0000 (GMT) From: Eddie James To: joel@jms.id.au Cc: linux@roeck-us.net, jdelvare@suse.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-fsi@lists.ozlabs.org, devicetree@vger.kernel.org, Eddie James Subject: [PATCH 3/3] hwmon: (occ) Check for device property for setting OCC active during probe Date: Tue, 2 Aug 2022 14:46:56 -0500 Message-Id: <20220802194656.240564-4-eajames@linux.ibm.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220802194656.240564-1-eajames@linux.ibm.com> References: <20220802194656.240564-1-eajames@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: GyuehN5cECTtDHGRUBr-72EanMVEfRD- X-Proofpoint-ORIG-GUID: GyuehN5cECTtDHGRUBr-72EanMVEfRD- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-02_14,2022-08-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 clxscore=1015 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2208020092 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" A previous commit changed the existing behavior of the driver to skip attempting to communicate with the OCC during probe. Return to the previous default behavior of automatically communicating with the OCC and make it optional with a new device-tree property. Signed-off-by: Eddie James Reported-by: kernel test robot --- drivers/hwmon/occ/common.c | 11 ++++++++++- drivers/hwmon/occ/p9_sbe.c | 9 +++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c index 45407b12db4b..95f16bb0e685 100644 --- a/drivers/hwmon/occ/common.c +++ b/drivers/hwmon/occ/common.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include =20 @@ -1216,8 +1217,16 @@ int occ_setup(struct occ *occ) occ->groups[0] =3D &occ->group; =20 rc =3D occ_setup_sysfs(occ); - if (rc) + if (rc) { dev_err(occ->bus_dev, "failed to setup sysfs: %d\n", rc); + return rc; + } + + if (!device_property_read_bool(occ->bus_dev, "ibm,inactive-on-init")) { + rc =3D occ_active(occ, true); + if (rc) + occ_shutdown_sysfs(occ); + } =20 return rc; } diff --git a/drivers/hwmon/occ/p9_sbe.c b/drivers/hwmon/occ/p9_sbe.c index 4a1fe4ee8e2c..bc0f190065aa 100644 --- a/drivers/hwmon/occ/p9_sbe.c +++ b/drivers/hwmon/occ/p9_sbe.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -179,9 +180,17 @@ static int p9_sbe_occ_remove(struct platform_device *p= dev) return 0; } =20 +static const struct of_device_id p9_sbe_occ_of_match[] =3D { + { .compatible =3D "ibm,p9-occ-hwmon" }, + { .compatible =3D "ibm,p10-occ-hwmon" }, + {} +}; +MODULE_DEVICE_TABLE(of, p8_i2c_occ_of_match); + static struct platform_driver p9_sbe_occ_driver =3D { .driver =3D { .name =3D "occ-hwmon", + .of_match_table =3D p9_sbe_occ_of_match, }, .probe =3D p9_sbe_occ_probe, .remove =3D p9_sbe_occ_remove, --=20 2.31.1