From nobody Sun Apr 12 02:48:15 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 700C0C3F6B0 for ; Tue, 2 Aug 2022 05:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235574AbiHBE77 (ORCPT ); Tue, 2 Aug 2022 00:59:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231599AbiHBE7z (ORCPT ); Tue, 2 Aug 2022 00:59:55 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91B372B255; Mon, 1 Aug 2022 21:59:54 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 008175C0183; Tue, 2 Aug 2022 00:59:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 02 Aug 2022 00:59:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1659416393; x=1659502793; bh=LVBbdeLHvCtClZ0OaBxyCsnLS Z5C9ApI2ez3gIz7M24=; b=ArkxyYpBljpK09bw1yAh37zF7u94QtErREAaw9mfA hjImPE2DCrqHJUhvQkhc61HdZyx//r6OAaKvyobuwy7Tn2JknH+pObwyDdnDZPNn mEKlGta607SohY+x4QnMcGkm57kzeJYOgiuXlEOp3KqBxAuMidyHK0okwpjqx6eG GWrY0+SaDYNJvTW7vIniw0wwx6XAA53oY1oNKORXxZ2cpSD8y9DLPdSf+jYHaoR8 c8hNDE6yt/n0fB6yWcy4/47dGi0MkrciP/J3jWJXtWdLUPzGnQnzAOAvmhOPOGD5 Y2nZzvjjYBRf8hhmbRWaL3rjpja7nBuLUtQFxJJMzwsPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1659416393; x=1659502793; bh=LVBbdeLHvCtClZ0OaBxyCsnLSZ5C9ApI2ez 3gIz7M24=; b=ZUSiklysGNAbxysqol2QYI2BnjjEIIe7FqF1cP+hx4z/Kac4mxb ZZ8iRU4IwWVZ1j1QCBV1WhUuQCkRvXEMVqLGWnci17fqrSeIvUedWirtKPz4THRG Kxzbk/N6Oq2liy994PAwJv8SkksEEWj8fNyRVGuLRMej2KgB+MRhvYfJ2n21crVB Cj17wD1es0sFX5JGp12tWcduNF2FY5kmvKeYPptbh5bfCLC3GzN9hrJw/LTKbJ6+ HTeBNHmpZPLWEn8khY22DNRnn5E2smowjzIt024w1kPDh9MzzD4XW1ned6h1l+N/ UKobQqpRoj8g6jokeWWDqEu2wfPmnUNp6cA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddvgedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpedfnfhukhgvucffrdculfhonhgvshdfuceolhhukhgvsehljhho nhgvshdruggvvheqnecuggftrfgrthhtvghrnhepgfdujedthfduudekffefkeeiffdttd dvhfegudduueffuefhfefggeefteevvdegnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhhukhgvsehljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 Aug 2022 00:59:50 -0400 (EDT) From: "Luke D. Jones" To: hdegoede@redhat.com Cc: corentin.chary@gmail.com, markgross@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, "Luke D. Jones" Subject: [PATCH] asus-wmi: Add support for TUF laptop keyboard RGB Date: Tue, 2 Aug 2022 16:59:42 +1200 Message-Id: <20220802045942.1565559-1-luke@ljones.dev> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Adds support for TUF laptop RGB control. This creates two sysfs paths to add control of basic keyboard LEDs, and power states. /sys/devices/platform/asus-nb-wmi/tuf_krgb_mode has the following as input options via U8 "n n n n n n": - Save or set, if set, then settings revert on cold boot - Mode, 0-8 for regular modes (if supported), 10-12 for "warning" styles - Red, 0-255 - Green, 0-255 - Blue, 0-255 - Speed, 0 =3D Slow, 1 =3D Medium, 2 =3D Fast /sys/devices/platform/asus-nb-wmi/tuf_krgb_state has the following as input options via boolean "b b b b b": - Save or set, if set, then settings revert on cold boot - Boot, if true, the keyboard displays animation on boot - Awake, if true, the keyboard LED's are on while device is awake - Sleep, if true, the keyboard shows animation while device is suspended - Keybaord, appears to have no effect Signed-off-by: Luke D. Jones --- drivers/platform/x86/asus-wmi.c | 168 +++++++++++++++++++++ include/linux/platform_data/x86/asus-wmi.h | 6 + 2 files changed, 174 insertions(+) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index 62ce198a3463..09277bd98249 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -234,6 +234,9 @@ struct asus_wmi { bool dgpu_disable_available; bool dgpu_disable; =20 + bool tuf_kb_rgb_mode_available; + bool tuf_kb_rgb_state_available; + bool throttle_thermal_policy_available; u8 throttle_thermal_policy_mode; =20 @@ -734,6 +737,153 @@ static ssize_t egpu_enable_store(struct device *dev, =20 static DEVICE_ATTR_RW(egpu_enable); =20 +/* TUF Laptop Keyboard RGB Modes *****************************************= *****/ +static int tuf_kb_rgb_mode_check_present(struct asus_wmi *asus) +{ + u32 result; + int err; + + asus->tuf_kb_rgb_mode_available =3D false; + + err =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_TUF_RGB_MODE, &result); + if (err) { + if (err =3D=3D -ENODEV) + return 0; + return err; + } + + if (result & ASUS_WMI_DSTS_PRESENCE_BIT) + asus->tuf_kb_rgb_mode_available =3D true; + + return 0; +} + +static ssize_t tuf_kb_rgb_mode_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + int err; + u32 ret; + u8 res, tmp, arg_num; + char *data, *part, *end; + u8 cmd, mode, r, g, b, speed; + + data =3D end =3D kstrdup(buf, GFP_KERNEL); + cmd =3D mode =3D r =3D g =3D b =3D speed =3D arg_num =3D 0; + + while ((part =3D strsep(&end, " ")) !=3D NULL) { + if (part =3D=3D NULL) + return -1; + + res =3D kstrtou8(part, 10, &tmp); + if (res) + return -1; + + if (arg_num =3D=3D 0) + // apply : set + cmd =3D tmp =3D=3D 1 ? 0xb5 : 0xb4; + else if (arg_num =3D=3D 1) + // From 0-8 are valid modes with 10-12 being "warning" + // style modes. All models have "pulse" mode 10. + mode =3D (tmp <=3D 12 && tmp !=3D 9) ? tmp : 10; + else if (arg_num =3D=3D 2) + r =3D tmp; + else if (arg_num =3D=3D 3) + g =3D tmp; + else if (arg_num =3D=3D 4) + b =3D tmp; + else if (arg_num =3D=3D 5) { + if (tmp =3D=3D 0) + speed =3D 0xe1; + else if (tmp =3D=3D 1) + speed =3D 0xeb; + else if (tmp =3D=3D 2) + speed =3D 0xf5; + } + + arg_num +=3D 1; + } + + err =3D asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, ASUS_WMI_DEVID_= TUF_RGB_MODE, + cmd | (mode << 8) | (r << 16) | (g << 24), (b) | (speed << 8), &ret); + if (err) + return err; + + kfree(data); + return count; +} + +static DEVICE_ATTR_WO(tuf_kb_rgb_mode); + +/* TUF Laptop Keyboard RGB States ****************************************= *****/ +static int tuf_kb_rgb_state_check_present(struct asus_wmi *asus) +{ + u32 result; + int err; + + asus->tuf_kb_rgb_state_available =3D false; + + err =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_TUF_RGB_STATE, &result= ); + if (err) { + if (err =3D=3D -ENODEV) + return 0; + return err; + } + + if (result & ASUS_WMI_DSTS_PRESENCE_BIT) + asus->tuf_kb_rgb_state_available =3D true; + + return 0; +} + +static ssize_t tuf_kb_rgb_state_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) +{ + int err; + u32 ret; + bool tmp; + char *data, *part, *end; + u8 save, flags, res, arg_num; + + save =3D flags =3D arg_num =3D 0; + data =3D end =3D kstrdup(buf, GFP_KERNEL); + + while ((part =3D strsep(&end, " ")) !=3D NULL) { + if (part =3D=3D NULL) + return -1; + + res =3D kstrtobool(part, &tmp); + if (res) + return -1; + + if (tmp) { + if (arg_num =3D=3D 0) // save : set + save =3D tmp =3D=3D 0 ? 0x0100 : 0x0000; + else if (arg_num =3D=3D 1) + flags |=3D 0x02; // boot + else if (arg_num =3D=3D 2) + flags |=3D 0x08; // awake + else if (arg_num =3D=3D 3) + flags |=3D 0x20; // sleep + else if (arg_num =3D=3D 4) + flags |=3D 0x80; // keyboard + } + + arg_num +=3D 1; + } + + err =3D asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, + ASUS_WMI_DEVID_TUF_RGB_STATE, 0xBD | save | (flags << 16), 0, &ret); + if (err) + return err; + + kfree(data); + return count; +} + +static DEVICE_ATTR_WO(tuf_kb_rgb_state); + /* Battery ***************************************************************= *****/ =20 /* The battery maximum charging percentage */ @@ -3258,6 +3408,8 @@ static struct attribute *platform_attributes[] =3D { &dev_attr_touchpad.attr, &dev_attr_egpu_enable.attr, &dev_attr_dgpu_disable.attr, + &dev_attr_tuf_kb_rgb_mode.attr, + &dev_attr_tuf_kb_rgb_state.attr, &dev_attr_lid_resume.attr, &dev_attr_als_enable.attr, &dev_attr_fan_boost_mode.attr, @@ -3286,6 +3438,12 @@ static umode_t asus_sysfs_is_visible(struct kobject = *kobj, devid =3D ASUS_WMI_DEVID_ALS_ENABLE; else if (attr =3D=3D &dev_attr_egpu_enable.attr) ok =3D asus->egpu_enable_available; + else if (attr =3D=3D &dev_attr_tuf_kb_rgb_mode.attr) + ok =3D asus->tuf_kb_rgb_mode_available; + else if (attr =3D=3D &dev_attr_tuf_kb_rgb_state.attr) + ok =3D asus->tuf_kb_rgb_state_available; + else if (attr =3D=3D &dev_attr_dgpu_disable.attr) + ok =3D asus->dgpu_disable_available; else if (attr =3D=3D &dev_attr_dgpu_disable.attr) ok =3D asus->dgpu_disable_available; else if (attr =3D=3D &dev_attr_fan_boost_mode.attr) @@ -3557,6 +3715,14 @@ static int asus_wmi_add(struct platform_device *pdev) if (err) goto fail_dgpu_disable; =20 + err =3D tuf_kb_rgb_mode_check_present(asus); + if (err) + goto fail_tuf_kb_rgb_mode; + + err =3D tuf_kb_rgb_state_check_present(asus); + if (err) + goto fail_tuf_kb_rgb_state; + err =3D fan_boost_mode_check_present(asus); if (err) goto fail_fan_boost_mode; @@ -3671,6 +3837,8 @@ static int asus_wmi_add(struct platform_device *pdev) fail_fan_boost_mode: fail_egpu_enable: fail_dgpu_disable: +fail_tuf_kb_rgb_mode: +fail_tuf_kb_rgb_state: fail_platform: fail_panel_od: kfree(asus); diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/pla= tform_data/x86/asus-wmi.h index a571b47ff362..af4191fb0508 100644 --- a/include/linux/platform_data/x86/asus-wmi.h +++ b/include/linux/platform_data/x86/asus-wmi.h @@ -98,6 +98,12 @@ /* dgpu on/off */ #define ASUS_WMI_DEVID_DGPU 0x00090020 =20 +/* TUF laptop RGB modes/colours */ +#define ASUS_WMI_DEVID_TUF_RGB_MODE 0x00100056 + +/* TUF laptop RGB power/state */ +#define ASUS_WMI_DEVID_TUF_RGB_STATE 0x00100057 + /* DSTS masks */ #define ASUS_WMI_DSTS_STATUS_BIT 0x00000001 #define ASUS_WMI_DSTS_UNKNOWN_BIT 0x00000002 --=20 2.37.1