From nobody Sun Apr 12 02:53:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71267C00144 for ; Mon, 1 Aug 2022 15:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233557AbiHAPUt (ORCPT ); Mon, 1 Aug 2022 11:20:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233479AbiHAPUX (ORCPT ); Mon, 1 Aug 2022 11:20:23 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9344163A1; Mon, 1 Aug 2022 08:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1659367217; bh=XAqn83IU+p5xFWZru1M9Z/Koix/dbCBx8Z5S9dSn99A=; h=X-UI-Sender-Class:From:To:Subject:Date:In-Reply-To:References; b=Gjk4VomK6CdEwTXU3N5RkIrq9nMEhhS8FcIOKifgPKqpRHESK6h70fD8LWnbQAmXz Arh/XiwlmLdEvoSFDbE91O8AcaoJPE5hzHMlMa4OsLUlohVMdNPwRi9gbTivfgNgeT 3JtxJJ+uDOzAhlDqlHJ7WdkKdPqJ0/qr6/a1Ijxk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from p100.fritz.box ([92.116.150.19]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MFbRs-1oEeWV01oU-00H8j0; Mon, 01 Aug 2022 17:20:17 +0200 From: Helge Deller To: linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] proc: Add get_task_cmdline_kernel() function Date: Mon, 1 Aug 2022 17:20:14 +0200 Message-Id: <20220801152016.36498-2-deller@gmx.de> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220801152016.36498-1-deller@gmx.de> References: <20220801152016.36498-1-deller@gmx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:BFaP3rjvpSIG2hRN1WaPfMJ7qZIYqn3KORPcHU+KRnhnoJoCrjC Qx2pflJ1Y78Ewr6EXBdlvFq4k3DIpIucP2wNPnqeqjAKMXo0F9PX2gg0jlLVcZbDiCRmy0q WR+pIDaFSvvbZIFUTBzwnzcCQLN01ihEIQ6LnyIs2dk00qkzuPNYe3oHnUKtnpgIn2jkoq1 49+z0Mk9K2QEIFV35J1eg== X-UI-Out-Filterresults: notjunk:1;V03:K0:yKP4hPGbm58=:7JpKpTDiGTz7ruDCLz1ZeN 5o8HlgRHqg/6545pO10M/mOKKthHSZjklBMOL8M/HzY+/zJ3BggYA6ECcJj46tWZQa+NSsTdo TsQm5MQ+LcEiAmU6PuI5c4uU+WU+2Pp3LVvPFxIiwRbTT95W1MG6QsU8OJujS08vVjrW7uVgl Uf965u6Xph/sWSd3oXDBEdSSUM5VCG2l9UcWLSLzKURvlNgVyAbaM1PT/41cc5Mq/x9HX3KIf JSCeQLIoWtIx9wm2TutVngv5wMm0HDfBU4w/Wq86mHE+Zw7v+NiRTCwxz3kTVt137Byq2IQ/p Hyw6xmBSNUiuMHXIYCVFl2p+jLdd/nIdZ9E35lyGDtOitKVHASxQ2BvDkwV5Bh/aP6dTeeZdZ hQiyBHzVsSqyQ50U3/+oWuz076ZS1VCq9VJkzdTEs8uC8vwRsr/cgr4ENImNTqOHT91LhUn37 96ewlbZyEi53ipiXhFEIF/yH4g3RN8K4c4fPAu/2Ckru/PTGqkdHzwnJ0kKoXZGT6TniShPFB 7B+mEvR9gbWrLfjq+x9JUoxwhMr3Ezh1rGtnnA2Ct5++kwq3biYvo0s6wYkhtChSFAsLv0zyH fnjKTEzWgYADqqIujSWq4TGObIOALESzWvG3HhWout47RzhIRlodTINR0DPBRSyLpJG0u50Ee A5nQZd8V1/rIbqp9CKv2yR3kroSGalEU4vdjHtM2Y7ZNnyADEC79YGoNzmEQ0hUByIxippd/c pzl1y6mbJuUJ3pcNdczRIrxKBZpSp5/19kIHDFtM2B1ZRfUNDckrIihEzUxG67thwRw56gG1a Fq2WOmtkQVFfL1fDMDHZCsqxUACAH6HGdwVuHNT8yL1NGaVHw9yD0WMlj0ZQw2kjjjhrKWrnV ZwoxQdwovvtY0PdUzC/zMRj5xIa5rv4y08F9GAy88Q8la70+bF5/9Tf++HpfjQRPmDzyGzWzt MXcTI7/dGt86f1evFzWehCMhPbYM3v/hygsocewda8/+qt7iRH6PVnyoWBs1F+HPQeatUrF2U ysViHw1wQV9wNQNTcs4lqchMb+23l7cpYwEknTe7T9rtuR1Z9cGQvhqpucE1uL3VYkprwU9mZ GgMKVTBHiPy+7GxjD0VtdD7OIRnOLsj+G7lxI9KKCuKTG6yeR6zErVc8g== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add a new function get_task_cmdline_kernel() which reads the command line of a process into a kernel buffer. This command line can then be dumped by arch code to print additional debug info on how a faulting process was started. The new function re-uses the existing code which provides the cmdline for the procfs. For that the existing functions were modified so that the buffer page is allocated outside of get_mm_proctitle() and get_mm_cmdline() and instead provided as parameter. Signed-off-by: Helge Deller Reported-by: kernel test robot --- fs/proc/base.c | 68 +++++++++++++++++++++++++++-------------- include/linux/proc_fs.h | 5 +++ 2 files changed, 50 insertions(+), 23 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 8dfa36a99c74..4da9a8b3c7d1 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -217,20 +217,17 @@ static int proc_root_link(struct dentry *dentry, stru= ct path *path) */ static ssize_t get_mm_proctitle(struct mm_struct *mm, char __user *buf, size_t count, unsigned long pos, - unsigned long arg_start) + unsigned long arg_start, char *page) { - char *page; int ret, got; + size_t size; - if (pos >=3D PAGE_SIZE) + size =3D min_t(size_t, PAGE_SIZE, count); + if (pos >=3D size) return 0; - page =3D (char *)__get_free_page(GFP_KERNEL); - if (!page) - return -ENOMEM; - ret =3D 0; - got =3D access_remote_vm(mm, arg_start, page, PAGE_SIZE, FOLL_ANON); + got =3D access_remote_vm(mm, arg_start, page, size, FOLL_ANON); if (got > 0) { int len =3D strnlen(page, got); @@ -238,7 +235,9 @@ static ssize_t get_mm_proctitle(struct mm_struct *mm, c= har __user *buf, if (len < got) len++; - if (len > pos) { + if (!buf) + ret =3D len; + else if (len > pos) { len -=3D pos; if (len > count) len =3D count; @@ -248,16 +247,15 @@ static ssize_t get_mm_proctitle(struct mm_struct *mm,= char __user *buf, ret =3D len; } } - free_page((unsigned long)page); return ret; } static ssize_t get_mm_cmdline(struct mm_struct *mm, char __user *buf, - size_t count, loff_t *ppos) + size_t count, loff_t *ppos, char *page) { unsigned long arg_start, arg_end, env_start, env_end; unsigned long pos, len; - char *page, c; + char c; /* Check if process spawned far enough to have cmdline. */ if (!mm->env_end) @@ -283,7 +281,7 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, cha= r __user *buf, len =3D env_end - arg_start; /* We're not going to care if "*ppos" has high bits set */ - pos =3D *ppos; + pos =3D ppos ? *ppos : 0; if (pos >=3D len) return 0; if (count > len - pos) @@ -299,7 +297,7 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, cha= r __user *buf, * pos is 0, and set a flag in the 'struct file'. */ if (access_remote_vm(mm, arg_end-1, &c, 1, FOLL_ANON) =3D=3D 1 && c) - return get_mm_proctitle(mm, buf, count, pos, arg_start); + return get_mm_proctitle(mm, buf, count, pos, arg_start, page); /* * For the non-setproctitle() case we limit things strictly @@ -311,10 +309,6 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, ch= ar __user *buf, if (count > arg_end - pos) count =3D arg_end - pos; - page =3D (char *)__get_free_page(GFP_KERNEL); - if (!page) - return -ENOMEM; - len =3D 0; while (count) { int got; @@ -323,7 +317,8 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, cha= r __user *buf, got =3D access_remote_vm(mm, pos, page, size, FOLL_ANON); if (got <=3D 0) break; - got -=3D copy_to_user(buf, page, got); + if (buf) + got -=3D copy_to_user(buf, page, got); if (unlikely(!got)) { if (!len) len =3D -EFAULT; @@ -335,12 +330,11 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, c= har __user *buf, count -=3D got; } - free_page((unsigned long)page); return len; } static ssize_t get_task_cmdline(struct task_struct *tsk, char __user *buf, - size_t count, loff_t *pos) + size_t count, loff_t *pos, char *page) { struct mm_struct *mm; ssize_t ret; @@ -349,23 +343,51 @@ static ssize_t get_task_cmdline(struct task_struct *t= sk, char __user *buf, if (!mm) return 0; - ret =3D get_mm_cmdline(mm, buf, count, pos); + ret =3D get_mm_cmdline(mm, buf, count, pos, page); mmput(mm); return ret; } +/* + * Place up to maxcount chars of the command line of the process into the + * cmdline buffer. + */ +void get_task_cmdline_kernel(struct task_struct *tsk, + char *cmdline, size_t maxcount) +{ + int i; + + memset(cmdline, 0, maxcount); + get_task_cmdline(tsk, NULL, maxcount - 1, NULL, cmdline); + + /* remove NULs between parameters */ + for (i =3D 0; i < maxcount - 2; i++) { + if (cmdline[i]) + continue; + if (cmdline[i+1] =3D=3D 0) + break; + cmdline[i] =3D ' '; + } +} + static ssize_t proc_pid_cmdline_read(struct file *file, char __user *buf, size_t count, loff_t *pos) { struct task_struct *tsk; ssize_t ret; + char *page; BUG_ON(*pos < 0); tsk =3D get_proc_task(file_inode(file)); if (!tsk) return -ESRCH; - ret =3D get_task_cmdline(tsk, buf, count, pos); + page =3D (char *)__get_free_page(GFP_KERNEL); + if (page) { + ret =3D get_task_cmdline(tsk, buf, count, pos, page); + free_page((unsigned long)page); + } else + ret =3D -ENOMEM; put_task_struct(tsk); if (ret > 0) *pos +=3D ret; diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index 81d6e4ec2294..9a256e86205c 100644 --- a/include/linux/proc_fs.h +++ b/include/linux/proc_fs.h @@ -158,6 +158,9 @@ int proc_pid_arch_status(struct seq_file *m, struct pid= _namespace *ns, struct pid *pid, struct task_struct *task); #endif /* CONFIG_PROC_PID_ARCH_STATUS */ +void get_task_cmdline_kernel(struct task_struct *tsk, + char *cmdline, size_t maxcount); + #else /* CONFIG_PROC_FS */ static inline void proc_root_init(void) @@ -216,6 +219,8 @@ static inline struct pid *tgid_pidfd_to_pid(const struc= t file *file) return ERR_PTR(-EBADF); } +static inline void get_task_cmdline_kernel(struct task_struct *, char *, s= ize_t) { } + #endif /* CONFIG_PROC_FS */ struct net; -- 2.37.1 From nobody Sun Apr 12 02:53:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F24C19F2C for ; Mon, 1 Aug 2022 15:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233624AbiHAPUm (ORCPT ); Mon, 1 Aug 2022 11:20:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233461AbiHAPUW (ORCPT ); Mon, 1 Aug 2022 11:20:22 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51F456543; Mon, 1 Aug 2022 08:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1659367217; bh=z93eW6O/Zqb2IzNmzjvUpniK5rxoeVr74jaCWZju6pw=; h=X-UI-Sender-Class:From:To:Subject:Date:In-Reply-To:References; b=gH59Kkd5UhulzziAXMulZi6ahqnrCaMzzRy5lp1bl7fhVilt5x1R8vrZ5ObgXZA9w /q1xvnHZXRuaAA0EiVmtWHTQJZTG7Bmjd9sc+p/QiS4gQxvn+1uuldnzdobzIsFRTL k2/HFgw26GNddkgRECtAEApSFT1ezHGBpdcXYQ6Y= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from p100.fritz.box ([92.116.150.19]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MjS5A-1nc0OB0Z0U-00kxEA; Mon, 01 Aug 2022 17:20:17 +0200 From: Helge Deller To: linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] lib/dump_stack: Add dump_stack_print_cmdline() and wire up in dump_stack_print_info() Date: Mon, 1 Aug 2022 17:20:15 +0200 Message-Id: <20220801152016.36498-3-deller@gmx.de> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220801152016.36498-1-deller@gmx.de> References: <20220801152016.36498-1-deller@gmx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:iUepW5wkUjPsZckWAYxGL+x9EAmhGDReEdlpXFYiT9j0izawb4Z Wtj6qgmcLjAo0N35RsY6Bv5h/kTh5iQ8bJmmb8wrIpsTW7uf/vm1Kg5G+u08KkB6MGDfuJV mmsXBB7rdXmNGJjXfCUJ4pscMRe92lty+C5JQcHkrHcFOzC6e+e1nIEoarh2duoUGzI+5he b43GaMjAS89WWodZQX5GA== X-UI-Out-Filterresults: notjunk:1;V03:K0:wM47MDtDfh0=:dbb6b7qymycG950Oyqo/2i DCnHtQ3xMp+Qld/uCQKhx38pGnLWuHmt7JW/N6hGh6nI74ollkm/P0Dr7gv6KeHwcpqdazxgC vtdU0M5Bi55CeWtKFzYLHbJ/WvHx93WAcZXMPYAhwZx5AFuqoPp3tIlLuQSIwsImY+ZzDHuV1 PBhgsSylXs41Abjt2uxSC0wYe7oUiPxEpPzQEcemvYPNA6OO4zo5cly1+T829vkKV28b9nJyI /BIm3NJjsAqxIWApGhZMlET5NXKGqE+yLmEtp1s3jlIEtMHXxANwgbRALx/NLWd1IM4PyY5fa 7iLPyOqM6in6zmlyWB/hHabuBV+HooUZcy7XY3G23JCBLEitKJJXXZi4Ya6gWtuZG/SkGtu0D wxu2IaDPlbxX1ued51iBCcZDPhGsbxNMR/33lPkgtvBA9Hcc8upbMCrKeMwCKBzgoq9mDjtEo GGAxFAMQWlkdyFKVfZhlOn4cNTaIgGOE2eDnc4gce3isqbgLI8jwYI7h5h3Ike8+LXF/kkEN+ Oq7M2+0eRH6s9A6hT0mNtw7E7NxX0Sq+rzeyfR15xAyXrETfTzn/sQEquPB2GjDWzPMFEuARO zF4X3bKW1lWoGrtQ3ICEkhd3aip8VXlU6Z5nIKTsSLTJSZjjD88cz3nFMucG+wzK87FPXnn58 gt9NjrBFeZgiu6QwCXREO4e+DjJya2tloMOnYmBvwfjuSyJ2ryG+UT5H6eG1NaTEDb6cfsq7T s32O6MdwrAtQbPqHaMRzhM+W8bIqoa+fejsikfnaepU9RVuRTT69YDWW0PY56bo2UebeHizDO J3yIb5KY/82vqECSNhCRRSX7cB3wvydOvEmfd5xS97b0N9hDdjRSt9gu3+4OBppqANa6j1X9C DpZM39pPCw+OgtnUDfLQoOhiRUcWbND3IBZFTpOMym31LfW2l9cF2Zd36p0b6Y8WVw9aZ1qJH ie5kCHDhN1H7J/qXsA2okg6ApYNCBflahwXNG0HDPvhUtmDTwXyDCCW52zNG/H+NDf//GZyWb MJy1OJLHyc2jynfq0ngiE6PKdZg8jJdtjuz9dQ3iS5y5A8fD+1WEoWfg7dK4zzy72keFTPg3b glQ5K6j629nvjoiNR8xsFXV5HVGTTz3kBfvMMfcTubsZfy374hbMX1xYA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add the function dump_stack_print_cmdline() which can be used by arch code to print the command line of the current processs. This function is useful in arch code when dumping information for a faulting process. Wire this function up in the dump_stack_print_info() function to include the dumping of the command line for architectures which use dump_stack_print_info(). As an example, with this patch a failing glibc testcase (which uses ld.so.1 as starting program) up to now reported just "ld.so.1" failing: do_page_fault() command=3D'ld.so.1' type=3D15 address=3D0x565921d8 in libc= .so[f7339000+1bb000] trap #15: Data TLB miss fault, vm_start =3D 0x0001a000, vm_end =3D 0x0001b= 000 and now it reports in addition: ld.so.1[1151] cmdline: /home/gnu/glibc/objdir/elf/ld.so.1 --library-path /= home/gnu/glibc/objdir:/home/gnu/glibc/objdir/math:/home/gnu/ /home/gnu/glibc/objdir/malloc/tst-safe-linking-malloc-hugetlb1 Signed-off-by: Helge Deller Reported-by: kernel test robot --- include/linux/printk.h | 5 +++++ lib/dump_stack.c | 17 +++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/include/linux/printk.h b/include/linux/printk.h index cf7d666ab1f8..5290a32a197d 100644 --- a/include/linux/printk.h +++ b/include/linux/printk.h @@ -191,6 +191,7 @@ u32 log_buf_len_get(void); void log_buf_vmcoreinfo_setup(void); void __init setup_log_buf(int early); __printf(1, 2) void dump_stack_set_arch_desc(const char *fmt, ...); +void dump_stack_print_cmdline(const char *log_lvl); void dump_stack_print_info(const char *log_lvl); void show_regs_print_info(const char *log_lvl); extern asmlinkage void dump_stack_lvl(const char *log_lvl) __cold; @@ -262,6 +263,10 @@ static inline __printf(1, 2) void dump_stack_set_arch_= desc(const char *fmt, ...) { } +static inline void dump_stack_print_cmdline(const char *log_lvl) +{ +} + static inline void dump_stack_print_info(const char *log_lvl) { } diff --git a/lib/dump_stack.c b/lib/dump_stack.c index 83471e81501a..c9b6a4c0c4e1 100644 --- a/lib/dump_stack.c +++ b/lib/dump_stack.c @@ -14,6 +14,7 @@ #include #include #include +#include static char dump_stack_arch_desc_str[128]; @@ -45,6 +46,20 @@ void __init dump_stack_set_arch_desc(const char *fmt, ..= .) #define BUILD_ID_VAL "" #endif +/** + * dump_stack_print_cmdline - print the command line of current process + * @log_lvl: log level + */ +void dump_stack_print_cmdline(const char *log_lvl) +{ + char cmdline[256]; + + /* get command line */ + get_task_cmdline_kernel(current, cmdline, sizeof(cmdline)); + printk("%s%s[%d] cmdline: %s\n", log_lvl, current->comm, + current->pid, cmdline); +} + /** * dump_stack_print_info - print generic debug info for dump_stack() * @log_lvl: log level @@ -62,6 +77,8 @@ void dump_stack_print_info(const char *log_lvl) (int)strcspn(init_utsname()->version, " "), init_utsname()->version, BUILD_ID_VAL); + dump_stack_print_cmdline(log_lvl); + if (dump_stack_arch_desc_str[0] !=3D '\0') printk("%sHardware name: %s\n", log_lvl, dump_stack_arch_desc_str); -- 2.37.1 From nobody Sun Apr 12 02:53:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B46C19F2A for ; Mon, 1 Aug 2022 15:20:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233516AbiHAPUg (ORCPT ); Mon, 1 Aug 2022 11:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233448AbiHAPUW (ORCPT ); Mon, 1 Aug 2022 11:20:22 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51D7A6541; Mon, 1 Aug 2022 08:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1659367217; bh=UovwDaLyuTgPejCzTK254N9IC9/vqRLIfV2J6pi3cos=; h=X-UI-Sender-Class:From:To:Subject:Date:In-Reply-To:References; b=gDZ6ap1GhRW3wDRPzYWXITLNEYJSxGMUzAMNiH8T/AbLtQzF38Zrcifu+D92uD+FE N60nsyQ6KS0v++CMaVCslO6pEopN1sk0ii7QufidIA8s8KN8kdbPEvq1NiroP27YV2 zPQl1cI6nEyzl70MD/jSjzS6rWhZ/+QqdKFHXr6I= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from p100.fritz.box ([92.116.150.19]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MuUj2-1nQyrD17Zq-00rWmA; Mon, 01 Aug 2022 17:20:17 +0200 From: Helge Deller To: linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] x86/fault: Dump command line of faulting process to syslog Date: Mon, 1 Aug 2022 17:20:16 +0200 Message-Id: <20220801152016.36498-4-deller@gmx.de> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220801152016.36498-1-deller@gmx.de> References: <20220801152016.36498-1-deller@gmx.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:KxWWu6d4Mf/HNZfb1iWzcFG+92jgDSJNUGRPzZjgSQlUKy2+Tkm BjxgNCup3o7EzTK7JqLhVfq4Sgenz2XfBiGqB6kKOHAgDJ7dkSfUVDWhXcJ59ogtQVDLxXe giv3v+nVJB6hw1OWd9TurCZK3OEUUW4kMzAke+wax9s4dZN7+WX1VTiHzqUFL0XWg7sYG0v d47uwu4Ar5S0FjSFZmWpg== X-UI-Out-Filterresults: notjunk:1;V03:K0:e6dDOJQOd/E=:ae8KEjXxSSY8z7qEgqLoRT 9Oy2SV3hu8ax6rhtx6rqY9L7/Xd/gnUXV+n76xOskY6c+RzHFw/jVm9AxVZ7d8mEPHornlUYb +v7b1p/MH9pPNVRs+T/t4NRR7brQy9mBMpYs8nKzmJIj/2gldv7eYw7urPxQJilWTTwsLyA26 15mgvYsmTMEmIYWXbizskHtDNlGclsV/qgVLjp6OdT9jcCU3bzgg42PI5huC6uDgYGWyoGDB7 kJBAYGInO6igzVfF1VN95K6p5pZiERslxpQxA+x9XQ1IrUVqBkCybdM2cwMleR1pPZm93OAan 5Zi07HzQa1r8qab5AIwDg2+dxtHhzUtA6m7qXdzgxdXt3Gh1sdktHzsFp5pFWRNNsFTqMryIL xtF0apeRQXn6X+/2hYO+//FTbFZSFiZoN3LXAYCPQ9cZwH7NshZWbaftWA3E9th/e13RlCgZ2 D5mK9t3cxIT1lFVH2HDoQtr2U9w5lfDAsGz2M3MBatiHQ9h5eostzwsarBapZsTL8JCCydbFw 4qKhqqQqnP4PeW7B5a/TctuEvvYLpQbr+1PGV/m3RC026MTC0ZG7B65PdKwUPqy+nHwkU2twg 4j3d/G75e/Qg17DGNCKh3woIdkIz91MhTwma08hHjC66t2+IW+iKQYMeHqmJRHOKa4yfzlGEW yC7VJVhbzPqEXOo4qM5XLWOApLu07oDYyxeBjopY7bJLR9b52PsA4evrRq8SvWS5ic7ByzgFU 942EZgn6tZrmsGg/jxZs7n/sNV2Ob/jmm/V64WWdiISheNFqK9dXwVS9wN8DdWs2ChsXn4Jxk vkP5J3b4ZkfBKmUAfX8nrdUuYOXPtqDGCLgCY5BI1JpAJ9vL965TGxfnTbWFSftqpTIHPHPfh BwpAF4P9y6A7MNtsmz6/wAXPpZ9/FFcyuI+IbmvSiBQhCJzMYZWeK8safXiSVDmuFTv0Nh+Gj 6T+CAVea0kodv1I2hQmk/AAHfGlkqERRTB+1XrErpLXLHfHvfaA/eYToJ4eetZ5Uspl/XfEfR bL7lxciRIK4V1uzdtfkGTyGqZNmtkzjcpVyiu6Ucbhu3AqtzEYEmBjjrMNWrf5dENlCjFZvkp EKFfMI98Ru/W6uO47qC6L/w3kLEhugldjNtJRcfg2OA2Rj4a7DZM+wzHQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If a process segfaults, include the command line of the faulting process in the syslog. In the example below, the "crash" program (which simply writes zero to addr= ess 0) was called with the parameters "this is a test": crash[2326]: segfault at 0 ip 0000561a7969c12e sp 00007ffe97a05630 error 6= in crash[561a7969c000+1000] crash[2326] cmdline: ./crash this is a test Code: 68 ff ff ff c6 05 19 2f 00 00 01 5d c3 0f 1f 80 00 00 00 00 c3 0f 1f= 80 00 00 00 00 e9 7b ff ff ff 55 48 89 e5 b8 00 00 00 00 00 01 00 00 = 00 b8 00 00 00 00 5d c3 0f 1f 44 00 00 41 57 4c 8d Signed-off-by: Helge Deller --- arch/x86/mm/fault.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index fad8faa29d04..d4e21c402e29 100644 --- a/arch/x86/mm/fault.c +++ b/arch/x86/mm/fault.c @@ -784,6 +784,8 @@ show_signal_msg(struct pt_regs *regs, unsigned long err= or_code, printk(KERN_CONT "\n"); + dump_stack_print_cmdline(loglvl); + show_opcodes(regs, loglvl); } -- 2.37.1