From nobody Sun Apr 12 04:35:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19B4C00140 for ; Mon, 1 Aug 2022 03:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239126AbiHADWz (ORCPT ); Sun, 31 Jul 2022 23:22:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238799AbiHADWt (ORCPT ); Sun, 31 Jul 2022 23:22:49 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D2D465A1 for ; Sun, 31 Jul 2022 20:22:47 -0700 (PDT) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Lx3Jd1FBJzjXfc; Mon, 1 Aug 2022 11:19:45 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 1 Aug 2022 11:22:44 +0800 Received: from thunder-town.china.huawei.com (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 1 Aug 2022 11:22:44 +0800 From: Zhen Lei To: Russell King , , , CC: Zhen Lei Subject: [PATCH] ARM: Remove the special printing format of pc and lr in __show_regs() Date: Mon, 1 Aug 2022 11:20:16 +0800 Message-ID: <20220801032016.1524-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently, instruction pointers are printed in [<%08lx>] format to make them more visible. However, it is not necessary in __show_regs() because they have the prefix 'pc :' or 'lr :', and it is also inconsistent with that of other registers, which causes misalignment. Before: pc : [<8019a48c>] lr : [<8019a48c>] psr: 60000013 sp : c0965f28 ip : 00000001 fp : 00000001 r10: be6052d8 r9 : 431bde82 r8 : d7b634db After: pc : 8019a46c lr : 8019a46c psr: 60000013 sp : c8a71f28 ip : 00000001 fp : 00000002 r10: 1ef6a458 r9 : 431bde82 r8 : d7b634db Signed-off-by: Zhen Lei --- KernelVersion: v5.19 arch/arm/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index 3d9cace63884013..3fb30d734c3568a 100644 --- a/arch/arm/kernel/process.c +++ b/arch/arm/kernel/process.c @@ -136,7 +136,7 @@ void __show_regs(struct pt_regs *regs) =20 printk("PC is at %pS\n", (void *)instruction_pointer(regs)); printk("LR is at %pS\n", (void *)regs->ARM_lr); - printk("pc : [<%08lx>] lr : [<%08lx>] psr: %08lx\n", + printk("pc : %08lx lr : %08lx psr: %08lx\n", regs->ARM_pc, regs->ARM_lr, regs->ARM_cpsr); printk("sp : %08lx ip : %08lx fp : %08lx\n", regs->ARM_sp, regs->ARM_ip, regs->ARM_fp); --=20 2.25.1