From nobody Tue Apr 14 22:46:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F4B7C00144 for ; Sat, 30 Jul 2022 03:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239842AbiG3DGm (ORCPT ); Fri, 29 Jul 2022 23:06:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232112AbiG3DG0 (ORCPT ); Fri, 29 Jul 2022 23:06:26 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8342C50182; Fri, 29 Jul 2022 20:06:24 -0700 (PDT) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Lvq2j3109z1M8Hr; Sat, 30 Jul 2022 11:03:25 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:21 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:21 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH v2 1/7] perf kwork: Add '--synth task' option for record Date: Sat, 30 Jul 2022 11:03:29 +0800 Message-ID: <20220730030335.78203-2-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220730030335.78203-1-yangjihong1@huawei.com> References: <20220730030335.78203-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since we don't need user space symbols, add '--synth task' option to skip costly synthesis. Suggested-by: Namhyung Kim Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index fb8c63656ad8..ff17711a554a 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -1631,6 +1631,10 @@ static int perf_kwork__record(struct perf_kwork *kwo= rk, "-R", "-m", "1024", "-c", "1", + /* + * Skip synthesis as we do not need user space symbols. + */ + "--synth", "task", }; =20 rec_argc =3D ARRAY_SIZE(record_args) + argc - 1; --=20 2.30.GIT From nobody Tue Apr 14 22:46:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86ED9C00144 for ; Sat, 30 Jul 2022 03:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239803AbiG3DGd (ORCPT ); Fri, 29 Jul 2022 23:06:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231672AbiG3DGZ (ORCPT ); Fri, 29 Jul 2022 23:06:25 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F3FE50064; Fri, 29 Jul 2022 20:06:24 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Lvq1Z1zN2zWfLT; Sat, 30 Jul 2022 11:02:26 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:22 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:21 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH v2 2/7] perf kwork: Replace hard-coded initialization of nr_tracepoints with ARRAY_SIZE macro Date: Sat, 30 Jul 2022 11:03:30 +0800 Message-ID: <20220730030335.78203-3-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220730030335.78203-1-yangjihong1@huawei.com> References: <20220730030335.78203-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use ARRAY_SIZE macro to replace hard-coded initialization of nr_tracepoints for future changes. Suggested-by: Namhyung Kim Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index ff17711a554a..2143280c2e95 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -817,7 +817,7 @@ static void irq_work_name(struct kwork_work *work, char= *buf, int len) static struct kwork_class kwork_irq =3D { .name =3D "irq", .type =3D KWORK_CLASS_IRQ, - .nr_tracepoints =3D 2, + .nr_tracepoints =3D ARRAY_SIZE(irq_tp_handlers), .tp_handlers =3D irq_tp_handlers, .class_init =3D irq_class_init, .work_init =3D irq_work_init, @@ -938,7 +938,7 @@ static void softirq_work_name(struct kwork_work *work, = char *buf, int len) static struct kwork_class kwork_softirq =3D { .name =3D "softirq", .type =3D KWORK_CLASS_SOFTIRQ, - .nr_tracepoints =3D 3, + .nr_tracepoints =3D ARRAY_SIZE(softirq_tp_handlers), .tp_handlers =3D softirq_tp_handlers, .class_init =3D softirq_class_init, .work_init =3D softirq_work_init, @@ -1035,7 +1035,7 @@ static void workqueue_work_name(struct kwork_work *wo= rk, char *buf, int len) static struct kwork_class kwork_workqueue =3D { .name =3D "workqueue", .type =3D KWORK_CLASS_WORKQUEUE, - .nr_tracepoints =3D 3, + .nr_tracepoints =3D ARRAY_SIZE(workqueue_tp_handlers), .tp_handlers =3D workqueue_tp_handlers, .class_init =3D workqueue_class_init, .work_init =3D workqueue_work_init, --=20 2.30.GIT From nobody Tue Apr 14 22:46:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D73C00144 for ; Sat, 30 Jul 2022 03:06:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239743AbiG3DGi (ORCPT ); Fri, 29 Jul 2022 23:06:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231927AbiG3DG0 (ORCPT ); Fri, 29 Jul 2022 23:06:26 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 373AC501A9; Fri, 29 Jul 2022 20:06:25 -0700 (PDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Lvq2k14HKzjXVC; Sat, 30 Jul 2022 11:03:26 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:23 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:22 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH v2 3/7] perf kwork: Fix spelling mistake: "Captuer" -> "Capture" Date: Sat, 30 Jul 2022 11:03:31 +0800 Message-ID: <20220730030335.78203-4-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220730030335.78203-1-yangjihong1@huawei.com> References: <20220730030335.78203-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Signed-off-by: Colin Ian King Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index 2143280c2e95..9e8b9f9e0472 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -1447,7 +1447,7 @@ static void sig_handler(int sig) * Simply capture termination signal so that * the program can continue after pause returns */ - pr_debug("Captuer signal %d\n", sig); + pr_debug("Capture signal %d\n", sig); } =20 static int perf_kwork__report_bpf(struct perf_kwork *kwork) --=20 2.30.GIT From nobody Tue Apr 14 22:46:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDFF7C00144 for ; Sat, 30 Jul 2022 03:06:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239880AbiG3DGr (ORCPT ); Fri, 29 Jul 2022 23:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232937AbiG3DG1 (ORCPT ); Fri, 29 Jul 2022 23:06:27 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D73B4E60E; Fri, 29 Jul 2022 20:06:25 -0700 (PDT) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Lvq4k4xFvz9sty; Sat, 30 Jul 2022 11:05:10 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:23 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:22 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH v2 4/7] perf kwork: Fix spelling mistake: "PRINT_TIME_UNIT_MESC_WIDTH" -> "PRINT_TIME_UNIT_MSEC_WIDTH" Date: Sat, 30 Jul 2022 11:03:32 +0800 Message-ID: <20220730030335.78203-5-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220730030335.78203-1-yangjihong1@huawei.com> References: <20220730030335.78203-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Suggested-by: Namhyung Kim Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index 9e8b9f9e0472..d6c09044a929 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -37,9 +37,9 @@ #define RPINT_DECIMAL_WIDTH 3 #define PRINT_BRACKETPAIR_WIDTH 2 #define PRINT_TIME_UNIT_SEC_WIDTH 2 -#define PRINT_TIME_UNIT_MESC_WIDTH 3 -#define PRINT_RUNTIME_HEADER_WIDTH (PRINT_RUNTIME_WIDTH + PRINT_TIME_UNIT_= MESC_WIDTH) -#define PRINT_LATENCY_HEADER_WIDTH (PRINT_LATENCY_WIDTH + PRINT_TIME_UNIT_= MESC_WIDTH) +#define PRINT_TIME_UNIT_MSEC_WIDTH 3 +#define PRINT_RUNTIME_HEADER_WIDTH (PRINT_RUNTIME_WIDTH + PRINT_TIME_UNIT_= MSEC_WIDTH) +#define PRINT_LATENCY_HEADER_WIDTH (PRINT_LATENCY_WIDTH + PRINT_TIME_UNIT_= MSEC_WIDTH) #define PRINT_TIMEHIST_CPU_WIDTH (PRINT_CPU_WIDTH + PRINT_BRACKETPAIR_WIDT= H) #define PRINT_TIMESTAMP_HEADER_WIDTH (PRINT_TIMESTAMP_WIDTH + PRINT_TIME_U= NIT_SEC_WIDTH) =20 --=20 2.30.GIT From nobody Tue Apr 14 22:46:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11264C00144 for ; Sat, 30 Jul 2022 03:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239861AbiG3DGx (ORCPT ); Fri, 29 Jul 2022 23:06:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239668AbiG3DG1 (ORCPT ); Fri, 29 Jul 2022 23:06:27 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33F4D50064; Fri, 29 Jul 2022 20:06:26 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Lvq400Yv2zmVBT; Sat, 30 Jul 2022 11:04:32 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:24 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:23 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH v2 5/7] perf kwork: Strdup function name in workqueue_work_init Date: Sat, 30 Jul 2022 11:03:33 +0800 Message-ID: <20220730030335.78203-6-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220730030335.78203-1-yangjihong1@huawei.com> References: <20220730030335.78203-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" perf_session has been deleted when report, maps data in session has been fr= ee, we need to copy duplicate of workqueue function symbol for future use. Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index d6c09044a929..33bcab2aafcd 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -1021,7 +1021,7 @@ static void workqueue_work_init(struct kwork_class *c= lass, work->cpu =3D sample->cpu; work->id =3D evsel__intval(evsel, sample, "work"); work->name =3D function_addr =3D=3D 0 ? NULL : - machine__resolve_kernel_addr(machine, &function_addr, &modp); + strdup(machine__resolve_kernel_addr(machine, &function_addr, &modp)); } =20 static void workqueue_work_name(struct kwork_work *work, char *buf, int le= n) --=20 2.30.GIT From nobody Tue Apr 14 22:46:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A73C00144 for ; Sat, 30 Jul 2022 03:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239948AbiG3DHO (ORCPT ); Fri, 29 Jul 2022 23:07:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239775AbiG3DG3 (ORCPT ); Fri, 29 Jul 2022 23:06:29 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABB345072D; Fri, 29 Jul 2022 20:06:28 -0700 (PDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Lvq2m3hPSz1M8Sh; Sat, 30 Jul 2022 11:03:28 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:25 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:24 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH v2 6/7] perf kwork: Expand capacity of bpf entries Date: Sat, 30 Jul 2022 11:03:34 +0800 Message-ID: <20220730030335.78203-7-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220730030335.78203-1-yangjihong1@huawei.com> References: <20220730030335.78203-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 100 kwork entries are not enough for a system with hundreds of cores, improving capacity. Signed-off-by: Yang Jihong --- tools/perf/util/bpf_skel/kwork_trace.bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/bpf_skel/kwork_trace.bpf.c b/tools/perf/util/b= pf_skel/kwork_trace.bpf.c index 063c124e0999..5300e8be64b0 100644 --- a/tools/perf/util/bpf_skel/kwork_trace.bpf.c +++ b/tools/perf/util/bpf_skel/kwork_trace.bpf.c @@ -5,7 +5,7 @@ #include #include =20 -#define KWORK_COUNT 100 +#define KWORK_COUNT 10000 #define MAX_KWORKNAME 128 =20 /* --=20 2.30.GIT From nobody Tue Apr 14 22:46:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DBB2C00144 for ; Sat, 30 Jul 2022 03:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239933AbiG3DHH (ORCPT ); Fri, 29 Jul 2022 23:07:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239770AbiG3DG2 (ORCPT ); Fri, 29 Jul 2022 23:06:28 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5C4B50182; Fri, 29 Jul 2022 20:06:27 -0700 (PDT) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Lvq1d4rsSzWfNG; Sat, 30 Jul 2022 11:02:29 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:25 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 30 Jul 2022 11:06:24 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH v2 7/7] perf kwork: Add some {} for multiline for/if blocks Date: Sat, 30 Jul 2022 11:03:35 +0800 Message-ID: <20220730030335.78203-8-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220730030335.78203-1-yangjihong1@huawei.com> References: <20220730030335.78203-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 47 ++++++++++++++++++++++---------------- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index 33bcab2aafcd..f33666ca3ee6 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -177,9 +177,10 @@ static void setup_sorting(struct perf_kwork *kwork, =20 for (tok =3D strtok_r(str, ", ", &tmp); tok; tok =3D strtok_r(NULL, ", ", &tmp)) { - if (sort_dimension__add(kwork, tok, &kwork->sort_list) < 0) + if (sort_dimension__add(kwork, tok, &kwork->sort_list) < 0) { usage_with_options_msg(usage_msg, options, "Unknown --sort key: `%s'", tok); + } } =20 pr_debug("Sort order: %s\n", kwork->sort_order); @@ -656,8 +657,9 @@ static void timehist_print_event(struct perf_kwork *kwo= rk, work->class->work_name(work, kwork_name, PRINT_KWORK_NAME_WIDTH); printf(" %-*s ", PRINT_KWORK_NAME_WIDTH, kwork_name); - } else + } else { printf(" %-*s ", PRINT_KWORK_NAME_WIDTH, ""); + } =20 /* *runtime @@ -669,11 +671,12 @@ static void timehist_print_event(struct perf_kwork *k= work, /* * delaytime */ - if (atom->prev !=3D NULL) + if (atom->prev !=3D NULL) { printf(" %*.*f ", PRINT_LATENCY_WIDTH, RPINT_DECIMAL_WIDTH, (double)(atom->time - atom->prev->time) / NSEC_PER_MSEC); - else + } else { printf(" %*s ", PRINT_LATENCY_WIDTH, " "); + } =20 /* * callchain @@ -761,9 +764,10 @@ static int process_irq_handler_entry_event(struct perf= _tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->entry_event) + if (kwork->tp_handler->entry_event) { return kwork->tp_handler->entry_event(kwork, &kwork_irq, evsel, sample, machine); + } return 0; } =20 @@ -774,9 +778,10 @@ static int process_irq_handler_exit_event(struct perf_= tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->exit_event) + if (kwork->tp_handler->exit_event) { return kwork->tp_handler->exit_event(kwork, &kwork_irq, evsel, sample, machine); + } return 0; } =20 @@ -832,10 +837,10 @@ static int process_softirq_raise_event(struct perf_to= ol *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->raise_event) + if (kwork->tp_handler->raise_event) { return kwork->tp_handler->raise_event(kwork, &kwork_softirq, evsel, sample, machine); - + } return 0; } =20 @@ -846,10 +851,10 @@ static int process_softirq_entry_event(struct perf_to= ol *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->entry_event) + if (kwork->tp_handler->entry_event) { return kwork->tp_handler->entry_event(kwork, &kwork_softirq, evsel, sample, machine); - + } return 0; } =20 @@ -860,10 +865,10 @@ static int process_softirq_exit_event(struct perf_too= l *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->exit_event) + if (kwork->tp_handler->exit_event) { return kwork->tp_handler->exit_event(kwork, &kwork_softirq, evsel, sample, machine); - + } return 0; } =20 @@ -953,10 +958,10 @@ static int process_workqueue_activate_work_event(stru= ct perf_tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->raise_event) + if (kwork->tp_handler->raise_event) { return kwork->tp_handler->raise_event(kwork, &kwork_workqueue, evsel, sample, machine); - + } return 0; } =20 @@ -967,10 +972,10 @@ static int process_workqueue_execute_start_event(stru= ct perf_tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->entry_event) + if (kwork->tp_handler->entry_event) { return kwork->tp_handler->entry_event(kwork, &kwork_workqueue, evsel, sample, machine); - + } return 0; } =20 @@ -981,10 +986,10 @@ static int process_workqueue_execute_end_event(struct= perf_tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->exit_event) + if (kwork->tp_handler->exit_event) { return kwork->tp_handler->exit_event(kwork, &kwork_workqueue, evsel, sample, machine); - + } return 0; } =20 @@ -1253,9 +1258,10 @@ static void print_skipped_events(struct perf_kwork *= kwork) } } =20 - if (verbose > 0) + if (verbose > 0) { printf(" INFO: use %lld atom pages\n", nr_list_entry(&kwork->atom_page_list)); + } } =20 static void print_bad_events(struct perf_kwork *kwork) @@ -1332,10 +1338,11 @@ static int perf_kwork__check_config(struct perf_kwo= rk *kwork, return -1; } =20 - list_for_each_entry(class, &kwork->class_list, list) + list_for_each_entry(class, &kwork->class_list, list) { if ((class->class_init !=3D NULL) && (class->class_init(class, session) !=3D 0)) return -1; + } =20 if (kwork->cpu_list !=3D NULL) { ret =3D perf_session__cpu_bitmap(session, --=20 2.30.GIT