From nobody Wed Apr 15 01:30:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94711C04A68 for ; Thu, 28 Jul 2022 12:02:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237489AbiG1MCC (ORCPT ); Thu, 28 Jul 2022 08:02:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237217AbiG1MBq (ORCPT ); Thu, 28 Jul 2022 08:01:46 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6BF5491F1; Thu, 28 Jul 2022 05:01:41 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Ltq1j2ww4zlVhf; Thu, 28 Jul 2022 19:59:05 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:39 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:38 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH 1/5] perf kwork: Add '--synth task' option for record Date: Thu, 28 Jul 2022 19:58:50 +0800 Message-ID: <20220728115854.80399-2-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220728115854.80399-1-yangjihong1@huawei.com> References: <20220728115854.80399-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since we don't need user space symbols, add '--synth task' option to skip costly synthesis. Suggested-by: Namhyung Kim Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index fb8c63656ad8..ff17711a554a 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -1631,6 +1631,10 @@ static int perf_kwork__record(struct perf_kwork *kwo= rk, "-R", "-m", "1024", "-c", "1", + /* + * Skip synthesis as we do not need user space symbols. + */ + "--synth", "task", }; =20 rec_argc =3D ARRAY_SIZE(record_args) + argc - 1; --=20 2.30.GIT From nobody Wed Apr 15 01:30:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F99C19F21 for ; Thu, 28 Jul 2022 12:01:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237291AbiG1MBx (ORCPT ); Thu, 28 Jul 2022 08:01:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237134AbiG1MBq (ORCPT ); Thu, 28 Jul 2022 08:01:46 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 024145A179; Thu, 28 Jul 2022 05:01:43 -0700 (PDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Ltq092mZnzWfbv; Thu, 28 Jul 2022 19:57:45 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:40 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:39 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH 2/5] perf kwork: Replace hard-coded initialization of nr_tracepoints with ARRAY_SIZE macro Date: Thu, 28 Jul 2022 19:58:51 +0800 Message-ID: <20220728115854.80399-3-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220728115854.80399-1-yangjihong1@huawei.com> References: <20220728115854.80399-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use ARRAY_SIZE macro to replace hard-coded initialization of nr_tracepoints for future changes. Suggested-by: Namhyung Kim Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index ff17711a554a..2143280c2e95 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -817,7 +817,7 @@ static void irq_work_name(struct kwork_work *work, char= *buf, int len) static struct kwork_class kwork_irq =3D { .name =3D "irq", .type =3D KWORK_CLASS_IRQ, - .nr_tracepoints =3D 2, + .nr_tracepoints =3D ARRAY_SIZE(irq_tp_handlers), .tp_handlers =3D irq_tp_handlers, .class_init =3D irq_class_init, .work_init =3D irq_work_init, @@ -938,7 +938,7 @@ static void softirq_work_name(struct kwork_work *work, = char *buf, int len) static struct kwork_class kwork_softirq =3D { .name =3D "softirq", .type =3D KWORK_CLASS_SOFTIRQ, - .nr_tracepoints =3D 3, + .nr_tracepoints =3D ARRAY_SIZE(softirq_tp_handlers), .tp_handlers =3D softirq_tp_handlers, .class_init =3D softirq_class_init, .work_init =3D softirq_work_init, @@ -1035,7 +1035,7 @@ static void workqueue_work_name(struct kwork_work *wo= rk, char *buf, int len) static struct kwork_class kwork_workqueue =3D { .name =3D "workqueue", .type =3D KWORK_CLASS_WORKQUEUE, - .nr_tracepoints =3D 3, + .nr_tracepoints =3D ARRAY_SIZE(workqueue_tp_handlers), .tp_handlers =3D workqueue_tp_handlers, .class_init =3D workqueue_class_init, .work_init =3D workqueue_work_init, --=20 2.30.GIT From nobody Wed Apr 15 01:30:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64288C04A68 for ; Thu, 28 Jul 2022 12:01:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237388AbiG1MB5 (ORCPT ); Thu, 28 Jul 2022 08:01:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237244AbiG1MBr (ORCPT ); Thu, 28 Jul 2022 08:01:47 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41D64691EA; Thu, 28 Jul 2022 05:01:43 -0700 (PDT) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Ltq1L2s9lz1M8QY; Thu, 28 Jul 2022 19:58:46 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:40 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:40 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH 3/5] perf kwork: Fix spelling mistake: "Captuer" -> "Capture" Date: Thu, 28 Jul 2022 19:58:52 +0800 Message-ID: <20220728115854.80399-4-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220728115854.80399-1-yangjihong1@huawei.com> References: <20220728115854.80399-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Signed-off-by: Colin Ian King Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index 2143280c2e95..9e8b9f9e0472 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -1447,7 +1447,7 @@ static void sig_handler(int sig) * Simply capture termination signal so that * the program can continue after pause returns */ - pr_debug("Captuer signal %d\n", sig); + pr_debug("Capture signal %d\n", sig); } =20 static int perf_kwork__report_bpf(struct perf_kwork *kwork) --=20 2.30.GIT From nobody Wed Apr 15 01:30:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A987CC19F21 for ; Thu, 28 Jul 2022 12:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237529AbiG1MCF (ORCPT ); Thu, 28 Jul 2022 08:02:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237232AbiG1MBq (ORCPT ); Thu, 28 Jul 2022 08:01:46 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22A1B24F1B; Thu, 28 Jul 2022 05:01:43 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Ltq0B3BFWzWfcW; Thu, 28 Jul 2022 19:57:46 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:41 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:40 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH 4/5] perf kwork: Fix spelling mistake: "PRINT_TIME_UNIT_MESC_WIDTH" -> "PRINT_TIME_UNIT_MSEC_WIDTH" Date: Thu, 28 Jul 2022 19:58:53 +0800 Message-ID: <20220728115854.80399-5-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220728115854.80399-1-yangjihong1@huawei.com> References: <20220728115854.80399-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Suggested-by: Namhyung Kim Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index 9e8b9f9e0472..d6c09044a929 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -37,9 +37,9 @@ #define RPINT_DECIMAL_WIDTH 3 #define PRINT_BRACKETPAIR_WIDTH 2 #define PRINT_TIME_UNIT_SEC_WIDTH 2 -#define PRINT_TIME_UNIT_MESC_WIDTH 3 -#define PRINT_RUNTIME_HEADER_WIDTH (PRINT_RUNTIME_WIDTH + PRINT_TIME_UNIT_= MESC_WIDTH) -#define PRINT_LATENCY_HEADER_WIDTH (PRINT_LATENCY_WIDTH + PRINT_TIME_UNIT_= MESC_WIDTH) +#define PRINT_TIME_UNIT_MSEC_WIDTH 3 +#define PRINT_RUNTIME_HEADER_WIDTH (PRINT_RUNTIME_WIDTH + PRINT_TIME_UNIT_= MSEC_WIDTH) +#define PRINT_LATENCY_HEADER_WIDTH (PRINT_LATENCY_WIDTH + PRINT_TIME_UNIT_= MSEC_WIDTH) #define PRINT_TIMEHIST_CPU_WIDTH (PRINT_CPU_WIDTH + PRINT_BRACKETPAIR_WIDT= H) #define PRINT_TIMESTAMP_HEADER_WIDTH (PRINT_TIMESTAMP_WIDTH + PRINT_TIME_U= NIT_SEC_WIDTH) =20 --=20 2.30.GIT From nobody Wed Apr 15 01:30:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB0CBC04A68 for ; Thu, 28 Jul 2022 12:02:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237437AbiG1MCA (ORCPT ); Thu, 28 Jul 2022 08:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237072AbiG1MBr (ORCPT ); Thu, 28 Jul 2022 08:01:47 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2743691F0; Thu, 28 Jul 2022 05:01:43 -0700 (PDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Ltq2b1bgxzmVML; Thu, 28 Jul 2022 19:59:51 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:41 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 28 Jul 2022 20:01:41 +0800 From: Yang Jihong To: , , , , , , , , , CC: , , , , Subject: [PATCH 5/5] perf kwork: Add some {} for multiline for/if blocks Date: Thu, 28 Jul 2022 19:58:54 +0800 Message-ID: <20220728115854.80399-6-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20220728115854.80399-1-yangjihong1@huawei.com> References: <20220728115854.80399-1-yangjihong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Yang Jihong --- tools/perf/builtin-kwork.c | 47 ++++++++++++++++++++++---------------- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/tools/perf/builtin-kwork.c b/tools/perf/builtin-kwork.c index d6c09044a929..b80f7279c4a8 100644 --- a/tools/perf/builtin-kwork.c +++ b/tools/perf/builtin-kwork.c @@ -177,9 +177,10 @@ static void setup_sorting(struct perf_kwork *kwork, =20 for (tok =3D strtok_r(str, ", ", &tmp); tok; tok =3D strtok_r(NULL, ", ", &tmp)) { - if (sort_dimension__add(kwork, tok, &kwork->sort_list) < 0) + if (sort_dimension__add(kwork, tok, &kwork->sort_list) < 0) { usage_with_options_msg(usage_msg, options, "Unknown --sort key: `%s'", tok); + } } =20 pr_debug("Sort order: %s\n", kwork->sort_order); @@ -656,8 +657,9 @@ static void timehist_print_event(struct perf_kwork *kwo= rk, work->class->work_name(work, kwork_name, PRINT_KWORK_NAME_WIDTH); printf(" %-*s ", PRINT_KWORK_NAME_WIDTH, kwork_name); - } else + } else { printf(" %-*s ", PRINT_KWORK_NAME_WIDTH, ""); + } =20 /* *runtime @@ -669,11 +671,12 @@ static void timehist_print_event(struct perf_kwork *k= work, /* * delaytime */ - if (atom->prev !=3D NULL) + if (atom->prev !=3D NULL) { printf(" %*.*f ", PRINT_LATENCY_WIDTH, RPINT_DECIMAL_WIDTH, (double)(atom->time - atom->prev->time) / NSEC_PER_MSEC); - else + } else { printf(" %*s ", PRINT_LATENCY_WIDTH, " "); + } =20 /* * callchain @@ -761,9 +764,10 @@ static int process_irq_handler_entry_event(struct perf= _tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->entry_event) + if (kwork->tp_handler->entry_event) { return kwork->tp_handler->entry_event(kwork, &kwork_irq, evsel, sample, machine); + } return 0; } =20 @@ -774,9 +778,10 @@ static int process_irq_handler_exit_event(struct perf_= tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->exit_event) + if (kwork->tp_handler->exit_event) { return kwork->tp_handler->exit_event(kwork, &kwork_irq, evsel, sample, machine); + } return 0; } =20 @@ -832,10 +837,10 @@ static int process_softirq_raise_event(struct perf_to= ol *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->raise_event) + if (kwork->tp_handler->raise_event) { return kwork->tp_handler->raise_event(kwork, &kwork_softirq, evsel, sample, machine); - + } return 0; } =20 @@ -846,10 +851,10 @@ static int process_softirq_entry_event(struct perf_to= ol *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->entry_event) + if (kwork->tp_handler->entry_event) { return kwork->tp_handler->entry_event(kwork, &kwork_softirq, evsel, sample, machine); - + } return 0; } =20 @@ -860,10 +865,10 @@ static int process_softirq_exit_event(struct perf_too= l *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->exit_event) + if (kwork->tp_handler->exit_event) { return kwork->tp_handler->exit_event(kwork, &kwork_softirq, evsel, sample, machine); - + } return 0; } =20 @@ -953,10 +958,10 @@ static int process_workqueue_activate_work_event(stru= ct perf_tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->raise_event) + if (kwork->tp_handler->raise_event) { return kwork->tp_handler->raise_event(kwork, &kwork_workqueue, evsel, sample, machine); - + } return 0; } =20 @@ -967,10 +972,10 @@ static int process_workqueue_execute_start_event(stru= ct perf_tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->entry_event) + if (kwork->tp_handler->entry_event) { return kwork->tp_handler->entry_event(kwork, &kwork_workqueue, evsel, sample, machine); - + } return 0; } =20 @@ -981,10 +986,10 @@ static int process_workqueue_execute_end_event(struct= perf_tool *tool, { struct perf_kwork *kwork =3D container_of(tool, struct perf_kwork, tool); =20 - if (kwork->tp_handler->exit_event) + if (kwork->tp_handler->exit_event) { return kwork->tp_handler->exit_event(kwork, &kwork_workqueue, evsel, sample, machine); - + } return 0; } =20 @@ -1253,9 +1258,10 @@ static void print_skipped_events(struct perf_kwork *= kwork) } } =20 - if (verbose > 0) + if (verbose > 0) { printf(" INFO: use %lld atom pages\n", nr_list_entry(&kwork->atom_page_list)); + } } =20 static void print_bad_events(struct perf_kwork *kwork) @@ -1332,10 +1338,11 @@ static int perf_kwork__check_config(struct perf_kwo= rk *kwork, return -1; } =20 - list_for_each_entry(class, &kwork->class_list, list) + list_for_each_entry(class, &kwork->class_list, list) { if ((class->class_init !=3D NULL) && (class->class_init(class, session) !=3D 0)) return -1; + } =20 if (kwork->cpu_list !=3D NULL) { ret =3D perf_session__cpu_bitmap(session, --=20 2.30.GIT