From nobody Sun Apr 19 12:43:19 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFBEC04A68 for ; Thu, 28 Jul 2022 00:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234780AbiG1AGE (ORCPT ); Wed, 27 Jul 2022 20:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233974AbiG1AGC (ORCPT ); Wed, 27 Jul 2022 20:06:02 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2F09A455 for ; Wed, 27 Jul 2022 17:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=56XHhnZ45uD7kuhdi5C7kKwazdECR0dfnBBECKqYRcs=; b=PcSdeyu64JbC+rRhu6t9oo4pmt 1nGvMV0L9WCeQRCEUrcF77aowjEiJgOf/JrhDrOXizT+T9W6twzTbMjm79bcHNAfZ2IqPMeM0d3TQ HvxXTX8NTaevdbGjXCVwAi8EeQPxI/7NJstpeqdC4uXCyl8u41ZboXDSzzIgeK49vYFWKbCP0kdFv Q/dHKCHot6Abuw4/7wDVwzkJmu8FWPK6IWfpHoRxvVJ6KUpsSrwDut8X1e0svIAaotRYRtLxh/F33 8YY+StwBhnEi5+s41DzqxPOBYgjgartLwHP3L18vFALCvAL6gRmlBYCfLx3na5n+3UffWrbc3c9RV c3/rlY6A==; Received: from [2601:1c0:6280:3f0::a6b3] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGr2I-003N22-Ph; Thu, 28 Jul 2022 00:05:56 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Philipp Zabel , Peter Rosin Subject: [PATCH] mux: mmio: depends on REGMAP Date: Wed, 27 Jul 2022 17:05:50 -0700 Message-Id: <20220728000550.10495-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix build error when CONFIG_REGMAP is not set/enabled: ../drivers/mux/mmio.c: In function =E2=80=98mux_mmio_probe=E2=80=99: ../drivers/mux/mmio.c:76:34: error: storage size of =E2=80=98field=E2=80=99= isn=E2=80=99t known 76 | struct reg_field field; ../drivers/mux/mmio.c:102:29: error: implicit declaration of function =E2= =80=98devm_regmap_field_alloc=E2=80=99 [-Werror=3Dimplicit-function-declara= tion] 102 | fields[i] =3D devm_regmap_field_alloc(dev, regmap, = field); ../drivers/mux/mmio.c:76:34: warning: unused variable =E2=80=98field=E2=80= =99 [-Wunused-variable] 76 | struct reg_field field; Most drivers that use REGMAP select it, but trying to use 'select' here causes a ton of recursive/circular dependency chains, so just use "depends on" to prevent the build errors. Reported-by: kernel test robot Fixes: 73726380a26f ("mux: mmio-based syscon mux controller") Signed-off-by: Randy Dunlap Cc: Philipp Zabel Cc: Peter Rosin --- drivers/mux/Kconfig | 1 + 1 file changed, 1 insertion(+) --- a/drivers/mux/Kconfig +++ b/drivers/mux/Kconfig @@ -48,6 +48,7 @@ config MUX_GPIO config MUX_MMIO tristate "MMIO/Regmap register bitfield-controlled Multiplexer" depends on OF || COMPILE_TEST + depends on REGMAP help MMIO/Regmap register bitfield-controlled Multiplexer controller. =20