From nobody Mon Feb 9 09:57:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 150ABC433EF for ; Mon, 25 Jul 2022 06:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233126AbiGYG4C (ORCPT ); Mon, 25 Jul 2022 02:56:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232476AbiGYGzJ (ORCPT ); Mon, 25 Jul 2022 02:55:09 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C631E12A81 for ; Sun, 24 Jul 2022 23:54:44 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id b11so18769668eju.10 for ; Sun, 24 Jul 2022 23:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WtIlfV0TRfMwcTJkeyhrUYfoxrMyuEr0LUCaeLfKOGs=; b=eMTP8obKLxAXQt5xnsDW4v+x9tBv4EwYSyNchPAH3P0UIyQvQFTNaXPhkutw6uB3Zk u9+cGI2Lm63FNRYheuipBTljqPAHvbJoaCua49D8YCxrSIy2aU8Et0ed98iF4uHvH3cY SUjfhRYUxAp8jBBlLAqk6ZnlbIk5X442/75cI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WtIlfV0TRfMwcTJkeyhrUYfoxrMyuEr0LUCaeLfKOGs=; b=vEe47kpHGziDqnBcgXc7pDzAHggto15a77HW1bcBUXF5x949Bs0fXLCChWVwRvbS2K aSo11sy420xJS/txBwiJzrsey56Vd52UAIDuCVCoyV3lACsutzfwF5H2OLxOeeF7ZOjw 5qM8gKI/ajQt/Hn0gOPZwwp8PDpv7PY+RFqq1QOV9Hl/IGUORwalwNR5G3vU8X0Ll0hq w2xanrf8nwjtmRm9yxwWBxi52ggfxD7mcdb2kGDMdnyw+b+i33kRHDvjZPYGhc7qraoX Zd+XzQ1Tz4eHKxYAJMoJQTGeVgkqzmj3xkCkcHdyp1FKHJAT6WZSoBB3rVmJSAgWPsau eSXw== X-Gm-Message-State: AJIora+gwW/z5OOKrQQ5w2Jq0VHO+L5quJjOteLwbwoHuQDGhVGJ2P74 0Z3yYCrS3hj9f6sJwNVwbTfs8dfSg4qDeA== X-Google-Smtp-Source: AGRyM1uCFwgwAlh/8Q2w7NsXL5N7D0o4L6UMaDO7HEEYdidMdgTZqg4vkPY8gcdBpB23KukOVh3JLQ== X-Received: by 2002:a17:907:7638:b0:72d:f11b:5ebb with SMTP id jy24-20020a170907763800b0072df11b5ebbmr8846038ejc.647.1658732069630; Sun, 24 Jul 2022 23:54:29 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-87-14-98-67.retail.telecomitalia.it. [87.14.98.67]) by smtp.gmail.com with ESMTPSA id r2-20020a1709060d4200b00722e57fa051sm4967711ejh.90.2022.07.24.23.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jul 2022 23:54:29 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: michael@amarulasolutions.com, Amarula patchwork , Jeroen Hofstee , Oliver Hartkopp , Dario Binacchi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Marc Kleine-Budde , Paolo Abeni , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 4/6] can: slcan: use the generic can_change_mtu() Date: Mon, 25 Jul 2022 08:54:17 +0200 Message-Id: <20220725065419.3005015-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220725065419.3005015-1-dario.binacchi@amarulasolutions.com> References: <20220725065419.3005015-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It is useless to define a custom function that does nothing but always return the same error code. Better to use the generic can_change_mtu() function. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/slcan/slcan-core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slc= an-core.c index 09d4abbbd9f4..919311890d2c 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -740,16 +740,11 @@ static int slcan_netdev_open(struct net_device *dev) return err; } =20 -static int slcan_netdev_change_mtu(struct net_device *dev, int new_mtu) -{ - return -EINVAL; -} - static const struct net_device_ops slcan_netdev_ops =3D { .ndo_open =3D slcan_netdev_open, .ndo_stop =3D slcan_netdev_close, .ndo_start_xmit =3D slcan_netdev_xmit, - .ndo_change_mtu =3D slcan_netdev_change_mtu, + .ndo_change_mtu =3D can_change_mtu, }; =20 /****************************************** --=20 2.32.0