From nobody Sat Apr 18 04:19:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35C41C433EF for ; Tue, 19 Jul 2022 07:00:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233784AbiGSHAr (ORCPT ); Tue, 19 Jul 2022 03:00:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231602AbiGSHAj (ORCPT ); Tue, 19 Jul 2022 03:00:39 -0400 Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64A27B1E3 for ; Tue, 19 Jul 2022 00:00:33 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VJqbCMx_1658214018; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VJqbCMx_1658214018) by smtp.aliyun-inc.com; Tue, 19 Jul 2022 15:00:30 +0800 From: Jiapeng Chong To: hch@lst.de Cc: sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] nvmet-auth: Fix unsigned comparison with less than zero Date: Tue, 19 Jul 2022 15:00:05 +0800 Message-Id: <20220719070005.39531-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The return from the call to nvmet_auth_challenge() and nvmet_setup_auth() is int, it can be a negative error code, however this is being assigned to an u16 variable 'status', so making 'status' an int, and change the position to keep the code format. This was found by coccicheck: ./drivers/nvme/target/fabrics-cmd-auth.c:488:6-12: WARNING: Unsigned expres= sion compared with zero: status < 0. ./drivers/nvme/target/fabrics-cmd-auth.c:251:8-14: WARNING: Unsigned expres= sion compared with zero: status < 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/nvme/target/fabrics-cmd-auth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/fabrics-cmd-auth.c b/drivers/nvme/target/f= abrics-cmd-auth.c index cc56e8c821ce..02d1931a8219 100644 --- a/drivers/nvme/target/fabrics-cmd-auth.c +++ b/drivers/nvme/target/fabrics-cmd-auth.c @@ -190,7 +190,7 @@ void nvmet_execute_auth_send(struct nvmet_req *req) struct nvmf_auth_dhchap_success2_data *data; void *d; u32 tl; - u16 status =3D 0; + int status =3D 0; =20 if (req->cmd->auth_send.secp !=3D NVME_AUTH_DHCHAP_PROTOCOL_IDENTIFIER) { status =3D NVME_SC_INVALID_FIELD | NVME_SC_DNR; @@ -443,7 +443,7 @@ void nvmet_execute_auth_receive(struct nvmet_req *req) struct nvmet_ctrl *ctrl =3D req->sq->ctrl; void *d; u32 al; - u16 status =3D 0; + int status =3D 0; =20 if (req->cmd->auth_receive.secp !=3D NVME_AUTH_DHCHAP_PROTOCOL_IDENTIFIER= ) { status =3D NVME_SC_INVALID_FIELD | NVME_SC_DNR; --=20 2.20.1.7.g153144c