From nobody Sat Apr 18 04:20:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC0AC43334 for ; Mon, 18 Jul 2022 06:17:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233436AbiGRGQa (ORCPT ); Mon, 18 Jul 2022 02:16:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233461AbiGRGQU (ORCPT ); Mon, 18 Jul 2022 02:16:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C2D7DFB3 for ; Sun, 17 Jul 2022 23:16:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2EC961260 for ; Mon, 18 Jul 2022 06:16:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 443D2C341C0; Mon, 18 Jul 2022 06:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658124978; bh=m6JrRBU83Orl/8FY1+qgd1rVEjWLTgGStSpPrHNLjPs=; h=From:To:Cc:Subject:Date:From; b=Gf3UxHIZ6sArrvyUTuUdYpRa8lHBbveWUTiKQnqQCRM775Ghnso11fqFv6VhzJn/f 9e2/pE0UEfTCRLUzAUsiBWrC/3sY1aTwR6TUj34kQ/2cALcqSFuqDfibwOCIrtP71z ev3kRvTkpZZOLp41MtA7ksI0oZyK1DY4v1slsg8zgBGEUC1U2CnJo5iooNV6Kdns0K pTilVV9eF7RAb/nkw18IvpoZVDi9zORuQb0n5uH9XGBKfxflExDeb6a4/3b6TTehBQ gTV0XeeugtnWt7M98hp5KP3Vsno2fCmFgrC+eMJveDf6GQ1kbjrvsjuqUX2AaSQ9SD FSFAg0VwFnhqg== From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: [PATCH] platform/chrome: cros_kbd_led_backlight: fix build warning Date: Mon, 18 Jul 2022 06:16:08 +0000 Message-Id: <20220718061608.2303425-1-tzungbi@kernel.org> X-Mailer: git-send-email 2.37.0.170.g444d1eabd0-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" drivers/platform/chrome/cros_kbd_led_backlight.c got a new build warning when using the randconfig in [1]: >>> warning: unused variable 'keyboard_led_drvdata_ec_pwm' The warning happens when CONFIG_CROS_EC is set but CONFIG_OF is not set. Reproduce: - mkdir build_dir - wget [1] -O build_dir/.config - COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D1 \ O=3Dbuild_dir ARCH=3Ds390 SHELL=3D/bin/bash drivers/platform/chrome/ Fix the warning by hardening the guard condition. Also use IS_ENABLED() because CROS_EC is a tristate. [1]: https://download.01.org/0day-ci/archive/20220717/202207170538.MR39dw8m= -lkp@intel.com/config Fixes: 40f58143745e ("platform/chrome: cros_kbd_led_backlight: support EC P= WM backend") Reported-by: kernel test robot Signed-off-by: Tzung-Bi Shih --- drivers/platform/chrome/cros_kbd_led_backlight.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/pla= tform/chrome/cros_kbd_led_backlight.c index 5ad41c10412d..4a0b2bd004d5 100644 --- a/drivers/platform/chrome/cros_kbd_led_backlight.c +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c @@ -119,7 +119,7 @@ static const struct keyboard_led_drvdata keyboard_led_d= rvdata_acpi =3D { =20 #endif /* CONFIG_ACPI */ =20 -#ifdef CONFIG_CROS_EC +#if IS_ENABLED(CONFIG_CROS_EC) && defined(CONFIG_OF) =20 static int keyboard_led_set_brightness_ec_pwm(struct led_classdev *cdev, @@ -187,11 +187,7 @@ static const struct keyboard_led_drvdata keyboard_led_= drvdata_ec_pwm =3D { .max_brightness =3D KEYBOARD_BACKLIGHT_MAX, }; =20 -#else /* CONFIG_CROS_EC */ - -static const struct keyboard_led_drvdata keyboard_led_drvdata_ec_pwm =3D {= }; - -#endif /* CONFIG_CROS_EC */ +#endif /* IS_ENABLED(CONFIG_CROS_EC) && defined(CONFIG_OF) */ =20 static int keyboard_led_probe(struct platform_device *pdev) { --=20 2.37.0.170.g444d1eabd0-goog